barcodevalidation 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 522d7b61575d8c85f1db57f9ccbefcfa07965ffa
-  data.tar.gz: cd612cf9d41691e9b44003fd581c60b80771d73e
+  metadata.gz: db8ad560ea3e5057b6cbaee32f7d3e4075a1e432
+  data.tar.gz: a0022217ccfac363462b8bdac2c4e9d4b314d6ab
 SHA512:
-  metadata.gz: 7b16df4b9a082951160a1c1e9a06f8947304ae3413224e9521fa57441fefa15184fc58586a2f0e6f63c7cbaa2b220725f13243b7a2aa9f80c25d05bd81440f77
-  data.tar.gz: 7e328aa855eaf1b4d52c61e91abc085747b90961ec1021a403f0affbb8699c5286aed4e70966631870561b8e90973bf7f66e40842a12f08cddf98fbb7b1f58f1
+  metadata.gz: 1130c129b9825032db6054694b393bf58be61f2ce855ed46b56c9b139f94a08498ff5e9f903331b93093af5905241f86190ec418ad53fc3d8413d9a0a7ab476d
+  data.tar.gz: 8d49c76a546b5b32d886f5fa32f03924c5a2de39c55047497a3e2d7c0f992f32b53a935e8c97b2a798a7c117dee62fc0254f87ebc168170da65e0ecabf8dbc4e

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in barcodevalidation.gemspec
 gemspec
+
+gem 'minitest'

data/barcodevalidation.gemspec

@@ -6,8 +6,8 @@ require 'barcodevalidation/version'
 Gem::Specification.new do |spec|
   spec.name          = "barcodevalidation"
   spec.version       = Barcodevalidation::VERSION
-  spec.authors       = ["Alan Harper"]
-  spec.email         = ["alan@aussiegeek.net"]
+  spec.authors       = ["Marketplacer"]
+  spec.email         = ["it@marketplacer.com"]
   spec.summary       = %q{Barcode validation library}
   spec.description   = %q{Simple barcode validator. Just verifies that barcode checksum is valid}
   spec.homepage      = ""
@@ -17,9 +17,4 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
-
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake"
-  spec.add_development_dependency "minitest"
-  spec.add_development_dependency "codeclimate-test-reporter"
 end

data/lib/barcodevalidation.rb

@@ -2,8 +2,11 @@ require "barcodevalidation/version"
 
 module Barcodevalidation
   def self.valid?(barcode)
-    barcode = barcode.to_s
-    return false unless [8, 10, 12, 13].include?(barcode.length)
+    barcode = barcode.to_s.strip
+    # only accept numeric codes
+    return false unless barcode =~ /^\d+$/
+    # accept lengths defined at gtin.info
+    return false unless [8, 12, 13, 14].include?(barcode.length)
 
     parts = barcode.rjust(18, '0').chars.map(&:to_i)
     checksum = parts.pop
@@ -19,8 +22,5 @@ module Barcodevalidation
 
     calculated_checksum = ((calculated_checksum.to_f / 10).ceil * 10) - calculated_checksum
     checksum == calculated_checksum
-
-  rescue ArgumentError
-    false #we only accept numeric barcodes
   end
 end

data/lib/barcodevalidation/version.rb

@@ -1,3 +1,3 @@
 module Barcodevalidation
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/test/minitest_helper.rb

@@ -1,6 +1,3 @@
-require "codeclimate-test-reporter"
-CodeClimate::TestReporter.start
-
 $LOAD_PATH.unshift File.expand_path('../../lib', __FILE__)
 require 'barcodevalidation'
 

data/test/test_barcodevalidation.rb

@@ -1,10 +1,6 @@
 require 'minitest_helper'
 
 class TestBarcodevalidation < MiniTest::Test
-  def test_that_it_has_a_version_number
-    refute_nil ::Barcodevalidation::VERSION
-  end
-
   def test_valid_barcodes
     [
       937179004167,
@@ -32,7 +28,8 @@ class TestBarcodevalidation < MiniTest::Test
       777777,
       99999999,
       12345678901,
-      123456789012345
+      123456789012345,
+      'BODGYBARCODE'
     ].each { |barcode| refute Barcodevalidation.valid?(barcode), barcode }
   end
 end

metadata

@@ -1,74 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: barcodevalidation
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
-- Alan Harper
+- Marketplacer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-17 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.6'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.6'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: codeclimate-test-reporter
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
+date: 2016-03-23 00:00:00.000000000 Z
+dependencies: []
 description: Simple barcode validator. Just verifies that barcode checksum is valid
 email:
-- alan@aussiegeek.net
+- it@marketplacer.com
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -104,7 +48,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Barcode validation library