barcodevalidation 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62d88d4ad5b5997e2318941173c5b21271306c9c
-  data.tar.gz: 195ab587c4db244d0648d4a3f1c80445ee0831e1
+  metadata.gz: dac677100702afe680ec1161c2ecbfa9426df4ba
+  data.tar.gz: c2d7360b4dacc32286a59ffa6f67dccc1f04ebb5
 SHA512:
-  metadata.gz: 3c89e3dfd4c8074e297f2c2d05274aa07019094911efc45ac08ef4fff71353d46ab47d8552861a74fea837e5d3d1342bea9bd856810be420b7b65bfee7016e6d
-  data.tar.gz: bad7d58ad27909f78d598a6ff9351544936bc063fc02a007b4fcce81bff05347f7409a231be964ac02bdd980e7ae4305c8b7a3e8b39482b48c6acbd6f06a99df
+  metadata.gz: 0c388ac3ad8bad464cc111c1a5f2e8fe6a4de37d978fb4fdc87f7dbf5439849acc0b218f213a222d820cce8f43bff37bdb7ef8ea42b94e072c3eaf19b4afc7f5
+  data.tar.gz: 98a5889fea125fff15c609b272a810d1b8b553ce0fc6b2a24e121478ffda6d5f86d2f624fb5e8a5328cc660304d543611b4cb833f4ae9a44bb7ea6ec876d776d

data/lib/barcodevalidation.rb

@@ -2,6 +2,8 @@ require "barcodevalidation/version"
 
 module Barcodevalidation
   def self.valid?(barcode)
+    Integer(barcode)
+
     parts = ('%018d' % barcode).to_s.chars.map(&:to_i)
     checksum = parts.pop
     parts
@@ -17,5 +19,8 @@ module Barcodevalidation
 
     calculated_checksum =  ((calculated_checksum.to_f / 10).ceil * 10) - calculated_checksum
     checksum == calculated_checksum
+
+  rescue ArgumentError
+    false #we only accept numeric barcodes
   end
 end

data/lib/barcodevalidation/version.rb

@@ -1,3 +1,3 @@
 module Barcodevalidation
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/test/test_barcodevalidation.rb

@@ -8,6 +8,7 @@ class TestBarcodevalidation < MiniTest::Test
   def test_valid_barcodes
     [
       937179004167,
+      '937179004167',
       9312631133233
     ].each { |barcode| assert Barcodevalidation.valid?(barcode), barcode }
   end
@@ -18,7 +19,18 @@ class TestBarcodevalidation < MiniTest::Test
       1234567890123, #invalid check digit
       50140424, #invalid check digit
       5420056646861,
-      10004336
+      10004336,
+      '48cm',
+      1, #make sure only valid length barcodes are accepted
+      22,
+      333,
+      4444,
+      55555,
+      666666,
+      777777,
+      99999999,
+      12345678901,
+      123456789012345
     ].each { |barcode| refute Barcodevalidation.valid?(barcode), barcode }
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: barcodevalidation
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Alan Harper