banter 1.2.2 → 1.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4502cffd372062c6f50d1c7ce6e083ec11ba9ce6
-  data.tar.gz: 950e44227d9ecc62262d5ea4a8e693e8bcf07b94
+  metadata.gz: b13b654e7432d2615637212aa89c5e2982132c4f
+  data.tar.gz: 7574a9284911946d6ea20f7dab4c5edb4f6cd132
 SHA512:
-  metadata.gz: 920ae2ac8d44e9f87fb3d9eb97c972e67cdca29bec2317575d1f048bc08f010ff5985026ccbe3a373d85a495bce0cd206d017407aa8bc9db1664fdc830a56b86
-  data.tar.gz: 54a4e211d6d99707f22bfba87553b901620509a3c19431b8740e9c32acf288451aeeffbb2057ef1958220a7dc9b1583eb0f3e733a8deff7ad898d7e6434dab43
+  metadata.gz: 9b0e607a13ddfc3f25f018dc99c756c37969ed1cbd2054a297811e9aa87ed9d2d8377d97fad4bcb7fec4947aece16969d19ec1f6bd8a62ee016e115cf459fb85
+  data.tar.gz: b22048fb8320d300d739b46ad5cfb4b77a06bba4e80384824924ba105a574a82ac1ad92c2d8ff5db2f72c9de56da2642eb1b03842c6886621cb4c2fb14dd35fb

data/lib/banter/server/rabbit_mq_subscriber.rb

@@ -30,6 +30,7 @@ module Banter
         begin
           @connection.start
         rescue => e
+          Banter::RabbitLogger.log(Logger::ERROR, "Cannot connect to rabbitmq")
           Airbrake.notify(e, params: { message: e.message, what_happened: "RabbitMQ unreachable!" }, environment_name: ENV['RAILS_ENV'])
           raise e
         end
@@ -49,10 +50,7 @@ module Banter
         # Parameters for subscribe that might be useful:
         # :block=>true - Used for long running consumer applications.  (backend servers?)
 
-        @consumer = @listener.subscribe(consumer_tag: @queue_name,  manual_ack: true, block: blocking)
-        # @consumer = @listener.subscribe(consumer_tag: @queue_name, block: blocking)
-
-        @consumer.on_delivery do |delivery_info, properties, contents|
+        @consumer = @listener.subscribe(consumer_tag: @queue_name,  manual_ack: true, block: blocking) do |delivery_info, properties, contents|
           Banter::RabbitLogger.log(Logger::DEBUG, "Message delivery with contents: #{contents}")
           if delivery_info[:redelivered]
             e = StandardError.new("PubSub Message redelivery")
@@ -67,12 +65,13 @@ module Banter
           @channel.ack(delivery_info.delivery_tag)
           true
         end
+        nil
       end
 
       def teardown
         begin
-          @connection.close if @connection.present?
           @consumer.cancel if @consumer.present?
+          @connection.close if @connection.present?
         rescue => e
           Airbrake.notify(e, params: { error: e.message }, environment_name: ENV['RAILS_ENV'], backtrace: caller)
         end

data/lib/banter/version.rb

@@ -1,3 +1,3 @@
 module Banter
-  VERSION = "1.2.2"
+  VERSION = "1.2.3"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banter
 version: !ruby/object:Gem::Version
-  version: 1.2.2
+  version: 1.2.3
 platform: ruby
 authors:
 - The Honest Company
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-22 00:00:00.000000000 Z
+date: 2014-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler