banter 0.5.0 → 0.7.0

data/spec/banter/rabbit_logger_spec.rb

@@ -12,8 +12,9 @@ describe Banter::RabbitLogger do
   before do
     allow(Banter.logger).to receive(:debug)
     allow(Banter.logger).to receive(:info)
-    allow(Banter.logger).to receive(:warning)
+    allow(Banter.logger).to receive(:warn)
     allow(Banter.logger).to receive(:error)
+    allow(Banter.logger).to receive(:log)
   end
 
   describe "#log_publish" do
@@ -24,7 +25,7 @@ describe Banter::RabbitLogger do
     end
 
     it "should write a row to the log" do
-      expect(Banter.logger).to have_received(:debug).with(anything)
+      expect(Banter.logger).to have_received(:warn).with(anything)
     end
 
   end
@@ -51,6 +52,30 @@ describe Banter::RabbitLogger do
       expect{ result }.not_to raise_error()
     end
 
+    it "should respect the log level of the file" do
+      expect(Banter.logger).to have_received(:warn).with(anything)
+    end
+  end
+
+  describe "#log_complete" do
+    let!(:result) { subject.log_complete(routing_key, message)}
+
+    it "should not fail" do
+      expect{ result }.not_to raise_error()
+    end
+
+    it "should respect the log level of the file" do
+      expect(Banter.logger).to have_received(:warn).with(anything)
+    end
+  end
+
+  describe "#log" do
+    let!(:result) { subject.log(::Logger::DEBUG, message)}
+
+    it "should not fail" do
+      expect{ result }.not_to raise_error()
+    end
+
     it "should respect the log level of the file" do
       expect(Banter.logger).to have_received(:debug).with(anything)
     end

data/spec/banter/server/client_queue_listener_spec.rb

@@ -3,13 +3,34 @@ require 'spec_helper'
 describe Banter::Server::ClientQueueListener do
   describe "#message_received" do
 
-    subject { -> { queue_listener.message_received( {}, {routing_key: routing_key}, {context: context, payload: payload}) } }
+    subject { -> { queue_listener.message_received({}, { routing_key: routing_key }, { context: context, payload: payload }) } }
     let(:queue_listener) { Banter::Server::ClientQueueListener.new(Klass, routing_key, 'queue') }
     let(:routing_key) { 'some.test.key' }
-    let(:context) { {} }
-    let(:payload) { {hello: 'moto'} }
-    let(:context_before){}
-    let(:validators){ [] }
+    let(:context) { { app: 'test' } }
+    let(:payload) { { hello: 'moto' } }
+    let(:context_before) { }
+    let(:validators) { [] }
+    let(:banter_worker) { FactoryGirl.create(:banter_worker, process_name: 'test') }
+    let(:enable_banter_web) {
+      Banter::Configuration.web_enabled = true
+      allow(BanterWorker).to receive(:current).and_return(banter_worker)
+    }
+    let(:banter_message) { BanterMessage.last }
+
+    after(:each) { Banter::Configuration.web_enabled = false }
+
+    def self.banter_message_fields_are_correct(status, error_message = nil)
+      it { expect(BanterMessage.count).to eq 1 }
+      it { expect(banter_message.subscriber_class).to eq('Klass') }
+      it { expect(banter_message.queue_name).to eq('banter_test_foo') }
+      it { expect(banter_message.subscribed_key).to eq('test.foo') }
+      it { expect(banter_message.payload).to eq({ "hello" => "moto" }) }
+      it { expect(banter_message.started_at.to_s).to eq(Time.now.to_s) }
+      it { expect(banter_message.done_at.to_s).to eq(Time.now.to_s) }
+      it { expect(banter_message.worker_id).to eq(BanterWorker.current.id) }
+      it { expect(banter_message.status).to eq(status) }
+      it { expect(banter_message.error_message).to eq(error_message) }
+    end
 
     before do
       context_before
@@ -17,6 +38,7 @@ describe Banter::Server::ClientQueueListener do
       validators.each do |validator|
         Klass.validates_payload_with validator
       end
+      Klass.subscribe_to "test.foo"
 
       klass_instance
 
@@ -29,47 +51,89 @@ describe Banter::Server::ClientQueueListener do
     end
 
     context "Normal execution" do
-      let!(:klass_instance){
-        instance = Klass.new({},{}, {})
+      let!(:klass_instance) {
+        instance = Klass.new({}, {}, {})
         allow(instance).to receive(:perform!)
         instance
       }
 
-      context "test exception" do
-        let(:no_call) { true }
-        it { should_not raise_exception }
+      context "banter web disabled" do
+        context "test exception" do
+          let(:no_call) { true }
+          it { should_not raise_exception }
+        end
+
+        context "call" do
+          it { expect(klass_instance).to have_received(:perform!).with(payload) }
+          it { expect(BanterMessage.count).to eq(0) }
+        end
       end
 
-      context "call" do
-        it { expect(klass_instance).to have_received(:perform!).with(payload) }
+      context "banter web enabled" do
+        let(:context_before) { enable_banter_web }
+
+        context "test exception" do
+          let(:no_call) { true }
+          it { should_not raise_exception }
+        end
+
+        context "call" do
+          banter_message_fields_are_correct(BanterMessage::STATUS_SUCCESS)
+        end
       end
+
     end
 
     context "Exception during execution" do
       let!(:klass_instance) {
-        instance = Klass.new({},{}, {})
-        allow(instance).to receive(:perform){
-          raise StandardError.new("test")
+        instance = Klass.new({}, {}, {})
+        allow(instance).to receive(:perform!) {
+          raise StandardError.new("test exception")
         }
         instance
       }
-      let(:no_call) { true }
 
-      it { should_not raise_exception }
+      context "web disabled" do
+        before do
+          allow(Banter::RabbitLogger).to receive(:log)
+        end
+        it { should_not raise_exception }
+        it { expect(BanterMessage.count).to eq(0) }
+      end
+
+      context "banter web enabled" do
+        let(:context_before) { enable_banter_web }
+
+        it { should_not raise_exception }
+        it { expect(klass_instance).to have_received(:perform!).with(payload) }
+        banter_message_fields_are_correct(BanterMessage::STATUS_ERROR, 'test exception')
+      end
     end
 
     context "Payload error" do
       let!(:klass_instance) {
-        instance = Klass.new({},{}, {})
-        allow(instance).to receive(:perform)
+        instance = Klass.new({}, {}, {})
+        allow(instance).to receive(:perform!).and_raise(Banter::PayloadValidationError.new("validation failed"))
         instance
       }
 
-      let!(:validators) { [lambda{ |payload| false }]  }
+      let!(:validators) { [lambda { |payload| false }] }
+      context "web disabled" do
+        let(:context_before) { allow(Airbrake).to receive(:notify) }
+        it { expect(Airbrake).to have_received(:notify) }
+      end
 
-      let(:context_before){ allow(Airbrake).to receive(:notify)}
+      context "web enabled" do
+        let(:context_before) do
+          allow(Airbrake).to receive(:notify)
+          enable_banter_web
+        end
 
-      it {expect(Airbrake).to have_received(:notify)}
+        it { expect(Airbrake).to have_received(:notify) }
+        it { should_not raise_exception }
+        it { expect(klass_instance).to have_received(:perform!).with(payload) }
+        banter_message_fields_are_correct(BanterMessage::STATUS_VALIDATION_FAILED, "validation failed")
+      end
     end
   end
 end

data/spec/banter/server/subscriber_server_spec.rb

@@ -0,0 +1,87 @@
+require 'spec_helper'
+
+# There isn't a good way to stub and mock methods in classes that include Celluloid
+# The only workaround I have right now, is to check other methods that get called
+
+describe Banter::Server::SubscriberServer do
+  subject { Banter::Server::SubscriberServer.instance }
+  describe '#set_workers' do
+    before {
+      allow(Banter::Server::ClientQueueListener).to receive(:new)
+      subject.set_workers([MyTestSubscriber1, MyTestSubscriber2])
+    }
+
+    it "creates queue listeners" do
+      expect(Banter::Server::ClientQueueListener).to have_received(:new).with(MyTestSubscriber1, "foo.bar.one", 'banter_foo_bar_one')
+      expect(Banter::Server::ClientQueueListener).to have_received(:new).with(MyTestSubscriber2, "foo.bar.two", 'banter_foo_bar_two')
+    end
+  end
+
+  describe '#set_information' do
+    before { subject.send(:set_information)}
+    it { expect(subject.process_name).not_to be_nil }
+    it { expect(subject.pid).not_to be_nil }
+    it { expect(subject.hostname).not_to be_nil }
+  end
+
+  describe '#register_workers' do
+
+    context "web not enabled" do
+      before { subject.send(:register_workers)}
+      it "doesn't create BanterWorker" do
+        expect(BanterWorker.count).to eq(0)
+      end
+    end
+
+    context "web enabled" do
+      before {
+        Banter::Configuration.web_enabled = true
+        subject.set_workers([MyTestSubscriber1, MyTestSubscriber2])
+        subject.instance_variable_set(:@pid, 123)
+        subject.instance_variable_set(:@hostname, 'mymachine')
+        subject.send(:register_workers)
+      }
+
+      after {
+        Banter::Configuration.web_enabled = false
+      }
+
+      let(:banter_worker) { BanterWorker.last }
+
+      it "creates banter worker" do
+        expect(BanterWorker.count).to eq(1)
+      end
+
+      it "sets up BanterWorker.current" do
+        expect(BanterWorker.current).to eq(banter_worker)
+      end
+
+      it { expect(banter_worker.pid).to eq(123)}
+      it { expect(banter_worker.hostname).to eq("mymachine")}
+      it { expect(banter_worker.started_at.to_s).to eq(Time.now.to_s)}
+      it { expect(banter_worker.worker_classes).to eq(["MyTestSubscriber1", "MyTestSubscriber2"])}
+    end
+  end
+
+  describe '#unregister_current_worker' do
+    context "web enabled" do
+
+      let(:banter_worker) { FactoryGirl.create(:banter_worker) }
+      before {
+        Banter::Configuration.web_enabled = true
+        BanterWorker.class_variable_set(:@@current, banter_worker)
+        subject.send(:unregister_current_worker)
+      }
+
+      after {
+        Banter::Configuration.web_enabled = false
+      }
+
+      it "sets stopped_at" do
+        expect(banter_worker.stopped_at.to_s).to eq(Time.now.to_s)
+      end
+    end
+
+  end
+
+end

data/spec/banter/web/application_spec.rb

@@ -0,0 +1,10 @@
+require 'spec_helper'
+
+describe Banter::Web::Application do
+  describe 'GET /' do
+    before { get '/' }
+    it 'returns 200' do
+      expect(last_response.status).to eq 200
+    end
+  end
+end

data/spec/factories/banter_workers.rb

@@ -0,0 +1,13 @@
+FactoryGirl.define do
+  factory :banter_worker do
+    process_name "yo whats up"
+    pid 123
+    worker_classes [ 'MyTestSubscriber1', 'MyTestSubscriber2']
+    hostname "example.com"
+    started_at { Time.now }
+
+    trait :stopped do
+      stopped_at { Time.now }
+    end
+  end
+end

data/spec/mongoid.yml

@@ -0,0 +1,7 @@
+test:
+  sessions:
+    default:
+      database: banter_development
+      hosts:
+        - localhost:27017
+      options:

data/spec/spec_helper.rb

@@ -5,32 +5,50 @@
 #
 # See http://rubydoc.info/gems/rspec-core/RSpec/Core/Configuration
 
+
 require 'awesome_print'
 require 'banter'
 require 'banter/server'
 ENV['RAILS_ENV'] ||= "test"
 ENV['RACK_ENV'] ||= "test"
+require 'rack/test'
+require 'banter/web'
+require 'timecop'
+require 'factory_girl'
+
+module RSpecMixin
+  include Rack::Test::Methods
+  def app() Banter::Web::Application end
+end
 
+# FactoryGirl.definition_file_paths = %w(../factories)
+FactoryGirl.find_definitions
 
 RSpec.configure do |config|
-  # config.treat_symbols_as_metadata_keys_with_true_values = true
   config.run_all_when_everything_filtered = true
-  # Don't want to filter on anything right now.
   config.filter_run :focus
-
-  # Run specs in random order to surface order dependencies. If you find an
-  # order dependency and want to debug it, you can fix the order by providing
-  # the seed, which is printed after each run.
-  #     --seed 1234
-  # For now, always in same order
   config.order = 'random'
+  config.include RSpecMixin
+  config.before(:each) {
+    BanterWorker.delete_all
+    BanterMessage.delete_all
+  }
+
+  config.before(:each) {
+    t = Time.new
+    allow(Time).to receive(:now).and_return(t)
+  }
+
 end
 
 Banter::Configuration.configure_with("test", File.expand_path("../config.yml", __FILE__))
 Banter::Configuration.logger = ActiveSupport::TaggedLogging.new(Logger.new(nil))
 
-# Some test subscriber classes to make testing easier
+Mongoid.load!(File.expand_path("../mongoid.yml", __FILE__))
+
+# Test subscriber classes to make testing easier
 class MyTestSubscriber1 < Banter::Subscriber
+  subscribe_to "foo.bar.one"
 
   def perform(payload)
 
@@ -38,6 +56,7 @@ class MyTestSubscriber1 < Banter::Subscriber
 end
 
 class MyTestSubscriber2 < Banter::Subscriber
+  subscribe_to "foo.bar.two"
   def perform(payload)
 
   end

data/web/assets/stylesheets/banter.css

@@ -0,0 +1,66 @@
+body {
+    font-family: 'Open Sans', sans-serif;
+}
+
+.bold {
+    font-weight: 700;
+}
+
+.extra-bold {
+    font-weight: 800;
+}
+
+.padding-large {
+    padding: 15px;
+}
+
+.font-size-md {
+    font-size: 20px;
+}
+
+.rounded-corners-md {
+    border-radius: 4px;
+}
+
+.spin{
+    -webkit-transform-origin: 50% 58%;
+    transform-origin:50% 58%;
+    -ms-transform-origin:50% 58%; /* IE 9 */
+    -webkit-animation: spin 2s infinite linear;
+    -moz-animation: spin 2s infinite linear;
+    -o-animation: spin 2s infinite linear;
+    animation: spin 2s infinite linear;
+}
+
+
+@-moz-keyframes spin {
+    from {
+        -moz-transform: rotate(0deg);
+    }
+    to {
+        -moz-transform: rotate(360deg);
+    }
+}
+
+@-webkit-keyframes spin {
+    from {
+        -webkit-transform: rotate(0deg);
+    }
+    to {
+        -webkit-transform: rotate(360deg);
+    }
+}
+
+@keyframes spin {
+    from {
+        transform: rotate(0deg);
+    }
+    to {
+        transform: rotate(360deg);
+    }
+}
+
+pre > kbd {
+    background-color: transparent;
+    box-shadow: none;
+}