banktools-se 3.3.2 → 3.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ccccc22d21f8267923982fc38deeb6a399e005f7447ce10c7cad333786cae07d
-  data.tar.gz: 9fb1a7b6cd47306bc55b206d73bd9e64a95f299d5123f957eff1894411820a58
+  metadata.gz: f88306b60a358141bee6be5459b368874cbacf93b902c49fa00bcb9301b5afd9
+  data.tar.gz: ef5e4b8daac88c910d062837481e78367eb59e58f26d3bcf90e86786c862e5bb
 SHA512:
-  metadata.gz: b33615c06ae45f94fc8a73cf1f0b5dffcf2558bb33aaeacf9537c33f52b9f13d6d86a538e77437d866aab720040df8bf5253080915eeabb54ee56b49fe05c2f0
-  data.tar.gz: ac5d291cc1008477b7580f372015e7a9bd1c9613f8887a21fced5ba2ac2a419396f698421f9c659f7aaf181013deb2c39cb670daa8fb3a832d32a2f455597cb5
+  metadata.gz: 3daa817d195a97aca47e6e96d4f1455c24f7673c8807f4299909297b3ce66718927fd4c8d2fe9b95aedd0402a74f6a014bc8e79553404f9b15d43616089b1a0b
+  data.tar.gz: 19e3092e3b94606ca94d8213c92bddca3e9a720cc50e90bbdc6104973593dd1ead85d19eb0be09c116b68005130bf975a5af95c549493fdb4fe0dd084a218693

data/.github/workflows/ci.yml

@@ -6,6 +6,9 @@ on:
   pull_request:
     branches: [ master ]
 
+permissions:
+  contents: read
+
 jobs:
   ruby-versions:
     uses: ruby/actions/.github/workflows/ruby_versions.yml@master
@@ -22,7 +25,7 @@ jobs:
         ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
 
     steps:
-      - uses: actions/checkout@v6
+      - uses: actions/checkout@v7
       - name: Set up Ruby ${{ matrix.ruby-version }}
         uses: ruby/setup-ruby@v1
         with:

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 3.4.0
+
+- Zerofill Handelsbanken serial numbers to 9 digits in `Account#serial_number` and `Account#normalize`. 8-digit serial numbers are still valid; 7 or fewer are still too short.
+- A Swedbank/Sparbanken account with no serial number digits at all (e.g. "8000-2") is now too short, rather than zerofilled to all zeroes.
+
 ## 3.3.2
 
 - Revert erroneous changes introduced in 3.3.1

data/lib/banktools-se/account/clearing_number.rb

@@ -18,10 +18,11 @@ module BankTools
           3782..3782 => { name: "Nordea", serial_number_length: 10, luhn_for_serial: true }, # Personkonto.
           3783..4999 => { name: "Nordea" },
           5000..5999 => { name: "SEB" },
-          6000..6999 => { name: "Handelsbanken", serial_number_length: 8..9 },
+          # Can be 8 or 9 chars but must be zero-filled to 9.
+          6000..6999 => { name: "Handelsbanken", serial_number_length: 8..9, zerofill: true },
           7000..7999 => { name: "Swedbank" },
-          # Can be fewer chars but must be zero-filled, so let's call it 10.
-          8000..8999 => { name: "Swedbank", serial_number_length: 10, checksum_for_clearing: true, zerofill: true },
+          # Can be fewer chars but must be zero-filled to 10.
+          8000..8999 => { name: "Swedbank", serial_number_length: 1..10, checksum_for_clearing: true, zerofill: true },
           9020..9029 => { name: "Länsförsäkringar Bank" },
           9040..9049 => { name: "Citibank" },
           9060..9069 => { name: "Länsförsäkringar Bank" },
@@ -38,13 +39,13 @@ module BankTools
           9260..9269 => { name: "Den Norske Bank" },
           9270..9279 => { name: "ICA Banken" },
           9280..9289 => { name: "Resurs Bank" },
-          9300..9349 => { name: "Sparbanken Öresund", serial_number_length: 10, zerofill: true },
+          9300..9349 => { name: "Sparbanken Öresund", serial_number_length: 1..10, zerofill: true },
           9400..9449 => { name: "Forex Bank" },
           9460..9469 => { name: "GE Money Bank" },
           9470..9479 => { name: "Fortis Bank" },
           9500..9549 => { name: "Nordea/Plusgirot", serial_number_length: 1..10 },
           9550..9569 => { name: "Avanza Bank" },
-          9570..9579 => { name: "Sparbanken Syd", serial_number_length: 10, zerofill: true },
+          9570..9579 => { name: "Sparbanken Syd", serial_number_length: 1..10, zerofill: true },
           9630..9639 => { name: "Lån og Spar Bank Sverige" },
           9640..9649 => { name: "Nordax Bank AB" },
           9650..9659 => { name: "MedMera Bank" },

data/lib/banktools-se/account.rb

@@ -23,8 +23,9 @@ module BankTools
       def errors
         errors = []
 
-        errors << Errors::TOO_SHORT if serial_number.length < min_length
-        errors << Errors::TOO_LONG if serial_number.length > max_length
+        # Validate the serial number as given, before any zero-filling.
+        errors << Errors::TOO_SHORT if raw_serial_number.length < min_length
+        errors << Errors::TOO_LONG if raw_serial_number.length > max_length
         errors << Errors::INVALID_CHARACTERS if number.to_s.match(/[^\d -]/)
 
         if luhn_for_serial?
@@ -63,17 +64,19 @@ module BankTools
       end
 
       def serial_number
-        number = digits.slice(clearing_number_length..-1) || ""
-
         if zerofill?
-          number.rjust(serial_number_length, "0")
+          raw_serial_number.rjust(Array(serial_number_length).last, "0")
         else
-          number
+          raw_serial_number
         end
       end
 
       private
 
+      def raw_serial_number
+        digits.slice(clearing_number_length..-1) || ""
+      end
+
       def clearing_number_length
         checksum_for_clearing? ? 5 : 4
       end

data/lib/banktools-se/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module SE
-    VERSION = "3.3.2"
+    VERSION = "3.4.0"
   end
 end

data/spec/account_spec.rb

@@ -81,6 +81,14 @@ RSpec.describe BankTools::SE::Account do
       expect(BankTools::SE::Account.new("9570-2-00000000").errors).not_to include(BankTools::SE::Errors::TOO_SHORT)
     end
 
+    it "should include :too_short for Handelsbanken numbers shorter than 8 digits, even though they are zerofilled" do
+      expect(BankTools::SE::Account.new("6000-1234567").errors).to include(BankTools::SE::Errors::TOO_SHORT)
+    end
+
+    it "should include :too_long for Handelsbanken numbers longer than 9 digits" do
+      expect(BankTools::SE::Account.new("6000-1234567890").errors).to include(BankTools::SE::Errors::TOO_LONG)
+    end
+
     it "should include :too_long for numbers longer than the bank allows" do
       expect(BankTools::SE::Account.new("1100000000007").errors).to include(BankTools::SE::Errors::TOO_LONG)
     end
@@ -139,6 +147,10 @@ RSpec.describe BankTools::SE::Account do
       expect(BankTools::SE::Account.new("8000-2-0000000000").serial_number).to eq("0000000000")
     end
 
+    it "should zerofill Handelsbanken serial numbers to 9 digits" do
+      expect(BankTools::SE::Account.new("6000-12345678").serial_number).to eq("012345678")
+    end
+
     it "should be the empty string if there aren't enough numbers" do
       expect(BankTools::SE::Account.new("12").serial_number).to eq("")
     end
@@ -154,6 +166,11 @@ RSpec.describe BankTools::SE::Account do
       expect(BankTools::SE::Account.new("8000-2-0000000000").normalize).to eq("8000-2-0000000000")
     end
 
+    it "should zerofill Handelsbanken serial numbers to 9 digits" do
+      expect(BankTools::SE::Account.new("6000-12345678").normalize).to eq("6000-012345678")
+      expect(BankTools::SE::Account.new("6000-123456789").normalize).to eq("6000-123456789")
+    end
+
     it "should not attempt to normalize invalid numbers" do
       expect(BankTools::SE::Account.new(" 1-2-3 ").normalize).to eq(" 1-2-3 ")
     end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banktools-se
 version: !ruby/object:Gem::Version
-  version: 3.3.2
+  version: 3.4.0
 platform: ruby
 authors:
 - Henrik Nyh
@@ -45,7 +45,7 @@ licenses: []
 metadata:
   rubygems_mfa_required: 'true'
   source_code_uri: https://github.com/barsoom/banktools-se
-  changelog_uri: https://github.com/barsoom/banktools-se/blob/v3.3.2/CHANGELOG.md
+  changelog_uri: https://github.com/barsoom/banktools-se/blob/v3.4.0/CHANGELOG.md
 rdoc_options: []
 require_paths:
 - lib
@@ -60,7 +60,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.8
+rubygems_version: 4.0.22
 specification_version: 4
 summary: Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.
 test_files: []