banktools-se 3.3.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f5d38b29a0e8e17173e684e2aa57595210cd8239a3faad83881e09a2155b47ec
-  data.tar.gz: 536681543fe7547f8c5589a09929c3c4273f3de5126f8b56ff88edebea2c02d5
+  metadata.gz: 600245bcaff1e259996286998821855e9e4193222d8d335b10adc46a26b16648
+  data.tar.gz: 8daa94ebc4db1d562b0b7b8546732ca4cd987a583245ad56dd0af738beb5349a
 SHA512:
-  metadata.gz: 24b822afa750fd939f09245cecdc18eaf04dbedf9a7a04e8f246c0d5c4d264906817b63f89a7f93b1a73b1dc4d867791c09bb27277546a8536ae055744cd1aed
-  data.tar.gz: 2c3c2217e150f37beb61215d64407af6b592bddca513204d520c06c07e5a6da8ae3ee40147d5d2ffeb6b34cea9a553f9239f4e5e51d2d8c05f3d337e9b4adc19
+  metadata.gz: 4794736dd16c9390a3f2536e59cdb3a988a0039dbcc4b641361db9955f0c787647f2a178e3e0e3289962ab0be42fcbcb0509dd284a6c2bd58cf357075c61dbaf
+  data.tar.gz: 6d5cb0c57e1fdce708b5b77761be6db8a1e6390baf730a347c8241dbf5d22378d282b8de8baf66c07463462dc8a7fc531e8c632858f3fe2f34715895c6c5f5c1

data/.github/workflows/ci.yml

@@ -10,7 +10,7 @@ jobs:
   ruby-versions:
     uses: ruby/actions/.github/workflows/ruby_versions.yml@master
     with:
-      min_version: 3.1
+      min_version: 3.2
       engine: cruby
 
   test:
@@ -22,7 +22,7 @@ jobs:
         ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
       - name: Set up Ruby ${{ matrix.ruby-version }}
         uses: ruby/setup-ruby@v1
         with:

data/banktools-se.gemspec

@@ -13,5 +13,9 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths = [ "lib" ]
-  s.metadata      = { "rubygems_mfa_required" => "true" }
+  s.metadata      = {
+    "rubygems_mfa_required" => "true",
+    "source_code_uri" => "https://github.com/barsoom/banktools-se",
+    "changelog_uri" => "https://github.com/barsoom/banktools-se/blob/v#{BankTools::SE::VERSION}/CHANGELOG.md",
+  }
 end

data/lib/banktools-se/plusgiro.rb

@@ -4,6 +4,9 @@ module BankTools
 
       # Could sadly not find anything more authoritative than
       #   http://pellesoft.se/communicate/forum/view.aspx?msgid=267449&forumid=63&sum=0
+      #   https://www.nordea.se/foretag/kundservice/fragor-och-svar-konton.html#faq=Kontouppgifter+432454
+      MAX_LENGTH = 10
+      MIN_LENGTH = 2
 
       attr_reader :number
 
@@ -18,8 +21,8 @@ module BankTools
       def errors
         errors = []
 
-        errors << Errors::TOO_SHORT if digits.length < 2
-        errors << Errors::TOO_LONG if digits.length > 8
+        errors << Errors::TOO_SHORT if digits.length < MIN_LENGTH
+        errors << Errors::TOO_LONG if digits.length > MAX_LENGTH
         errors << Errors::INVALID_CHARACTERS if number.to_s.match(/[^0-9 -]/)
         errors << Errors::BAD_CHECKSUM unless Utils.valid_luhn?(number)
 

data/lib/banktools-se/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module SE
-    VERSION = "3.3.0"
+    VERSION = "3.3.1"
   end
 end

data/spec/plusgiro_spec.rb

@@ -26,6 +26,7 @@ RSpec.describe BankTools::SE::Plusgiro do
     [
       "28 65 43-4",  # IKEA
       "410 54 68-5",  # IKEA
+      "421 880 87-25", # Göteborg Dödsbotjänster AB
       "4-2",  # Sveriges riksbank
     ].each do |number|
       it "should be empty for a valid number like #{number}" do
@@ -40,8 +41,8 @@ RSpec.describe BankTools::SE::Plusgiro do
       expect(BankTools::SE::Plusgiro.new("1---------").errors).to include(BankTools::SE::Errors::TOO_SHORT)
     end
 
-    it "should include :too_long for numbers longer than 8 digits" do
-      expect(BankTools::SE::Plusgiro.new("410 54 68-51").errors).to include(BankTools::SE::Errors::TOO_LONG)
+    it "should include :too_long for numbers longer than 10 digits" do
+      expect(BankTools::SE::Plusgiro.new("410 54 68-51 21").errors).to include(BankTools::SE::Errors::TOO_LONG)
     end
 
     it "should include :invalid_characters for numbers with other character than digits, spaces and dashes" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: banktools-se
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.3.1
 platform: ruby
 authors:
 - Henrik Nyh
@@ -44,6 +44,8 @@ homepage: ''
 licenses: []
 metadata:
   rubygems_mfa_required: 'true'
+  source_code_uri: https://github.com/barsoom/banktools-se
+  changelog_uri: https://github.com/barsoom/banktools-se/blob/v3.3.1/CHANGELOG.md
 rdoc_options: []
 require_paths:
 - lib
@@ -58,7 +60,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.8
+rubygems_version: 4.0.8
 specification_version: 4
 summary: Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.
 test_files: []