banktools-se 3.2.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2171141853a873652da69aa7ccd2c49212b060c34b8438798019178f86717a9e
-  data.tar.gz: 53ddab54a570de046d7149e26805670068be40b37549a21c121a62295e4dd15b
+  metadata.gz: 600245bcaff1e259996286998821855e9e4193222d8d335b10adc46a26b16648
+  data.tar.gz: 8daa94ebc4db1d562b0b7b8546732ca4cd987a583245ad56dd0af738beb5349a
 SHA512:
-  metadata.gz: 8bfd4a36644ed06f78b43b22484b8fa9a3c337c5731fb213f9c744138ad3ff5aaed4718765e6c35586feb38535111b6286c0651b9cf39e5a1d7f9e1e0712fb0f
-  data.tar.gz: 823a913eb6e0a644028679331af9bbff728adf86a4f81a3febd122979408a791ea46e244ebbee403ba649dc1f2157ccef6abee5709ce717551ab0ab0f90e8f30
+  metadata.gz: 4794736dd16c9390a3f2536e59cdb3a988a0039dbcc4b641361db9955f0c787647f2a178e3e0e3289962ab0be42fcbcb0509dd284a6c2bd58cf357075c61dbaf
+  data.tar.gz: 6d5cb0c57e1fdce708b5b77761be6db8a1e6390baf730a347c8241dbf5d22378d282b8de8baf66c07463462dc8a7fc531e8c632858f3fe2f34715895c6c5f5c1

data/.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

data/.github/workflows/ci.yml

@@ -7,19 +7,22 @@ on:
     branches: [ master ]
 
 jobs:
-  test:
+  ruby-versions:
+    uses: ruby/actions/.github/workflows/ruby_versions.yml@master
+    with:
+      min_version: 3.2
+      engine: cruby
 
+  test:
+    needs: ruby-versions
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        ruby-version:
-          - 3.1
-          - "3.0"
-          - 2.7
+        ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v6
       - name: Set up Ruby ${{ matrix.ruby-version }}
         uses: ruby/setup-ruby@v1
         with:

data/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Changelog
 
+## 3.3.0
+
+- Add Lunar Bank clearing number range. [#14](https://github.com/barsoom/banktools-se/pull/14). Thanks, @andyglim!
+
 ## 3.2.0
 
 - Add Account#normalize keyword arguments `digits_only`, `clearing_checksum`. [#11](https://github.com/barsoom/banktools-se/pull/11)

data/Gemfile

@@ -1,6 +1,5 @@
 source "https://rubygems.org"
 
-# Specify your gem's dependencies in bank-tools-se.gemspec
 gemspec
 
 group :development, :test do

data/banktools-se.gemspec

@@ -13,5 +13,9 @@ Gem::Specification.new do |s|
   s.files         = `git ls-files`.split("\n")
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths = [ "lib" ]
-  s.metadata      = { "rubygems_mfa_required" => "true" }
+  s.metadata      = {
+    "rubygems_mfa_required" => "true",
+    "source_code_uri" => "https://github.com/barsoom/banktools-se",
+    "changelog_uri" => "https://github.com/barsoom/banktools-se/blob/v#{BankTools::SE::VERSION}/CHANGELOG.md",
+  }
 end

data/lib/banktools-se/account/clearing_number.rb

@@ -53,6 +53,7 @@ module BankTools
           9680..9689 => { name: "Bluestep Finance" },
           9690..9699 => { name: "Folkia" },
           9700..9709 => { name: "Ekobanken" },
+          9710..9719 => { name: "Lunar Bank" },
           9720..9729 => { name: "Netfonds Bank (ub)" },
           9750..9759 => { name: "Northmill Bank" },
           9770..9779 => { name: "FTCS" },

data/lib/banktools-se/plusgiro.rb

@@ -4,6 +4,9 @@ module BankTools
 
       # Could sadly not find anything more authoritative than
       #   http://pellesoft.se/communicate/forum/view.aspx?msgid=267449&forumid=63&sum=0
+      #   https://www.nordea.se/foretag/kundservice/fragor-och-svar-konton.html#faq=Kontouppgifter+432454
+      MAX_LENGTH = 10
+      MIN_LENGTH = 2
 
       attr_reader :number
 
@@ -18,8 +21,8 @@ module BankTools
       def errors
         errors = []
 
-        errors << Errors::TOO_SHORT if digits.length < 2
-        errors << Errors::TOO_LONG if digits.length > 8
+        errors << Errors::TOO_SHORT if digits.length < MIN_LENGTH
+        errors << Errors::TOO_LONG if digits.length > MAX_LENGTH
         errors << Errors::INVALID_CHARACTERS if number.to_s.match(/[^0-9 -]/)
         errors << Errors::BAD_CHECKSUM unless Utils.valid_luhn?(number)
 
@@ -29,7 +32,7 @@ module BankTools
       def normalize
         if valid?
           pre, pairs, post = digits.split(/(\d{2}*)(\d)$/)
-          pairs = pairs.split(/(\d\d)/).reject { |x| x.empty? }
+          pairs = pairs.split(/(\d\d)/).reject(&:empty?)
           [ pre, pairs.join(" "), "-", post ].join
         else
           number

data/lib/banktools-se/utils.rb

@@ -4,22 +4,22 @@ module BankTools
 
       # Based on http://blog.internautdesign.com/2007/4/18/ruby-luhn-check-aka-mod-10-formula
       def self.valid_luhn?(number)
-        digits = number.to_s.scan(/\d/).reverse.map { |x| x.to_i }
+        digits = number.to_s.scan(/\d/).reverse.map(&:to_i)
         digits = digits.each_with_index.map { |d, i|
           d *= 2 if i.odd?
           d > 9 ? d - 9 : d
         }
-        sum = digits.inject(0) { |m, x| m + x }
+        sum = digits.reduce(0) { |m, x| m + x }
         sum % 10 == 0
       end
 
       def self.luhn_checksum(number)
-        digits = number.to_s.scan(/\d/).reverse.map { |x| x.to_i }
+        digits = number.to_s.scan(/\d/).reverse.map(&:to_i)
         digits = digits.each_with_index.map { |d, i|
           d *= 2 if i.even?
           d > 9 ? d - 9 : d
         }
-        sum = digits.inject(0) { |m, x| m + x }
+        sum = digits.reduce(0) { |m, x| m + x }
         mod = 10 - sum % 10
         mod == 10 ? 0 : mod
       end

data/lib/banktools-se/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module SE
-    VERSION = "3.2.0"
+    VERSION = "3.3.1"
   end
 end

data/spec/account_spec.rb

@@ -64,7 +64,7 @@ RSpec.describe BankTools::SE::Account do
       "9550-0000000",       # Avanza Bank.
       "9570-0000000000",    # Sparbanken Syd.
       "9960-00",            # Nordea/Plusgirot.
-
+      "9710-0000000",       # Lunar Bank.
     ].each do |number|
       it "should be empty for a valid number like #{number}" do
         expect(BankTools::SE::Account.new(number).errors).to eq([])
@@ -112,6 +112,7 @@ RSpec.describe BankTools::SE::Account do
       expect(BankTools::SE::Account.new("11550000001").bank).to eq("Nordea")
       expect(BankTools::SE::Account.new("11990000009").bank).to eq("Nordea")
       expect(BankTools::SE::Account.new("12000000005").bank).to eq("Danske Bank")
+      expect(BankTools::SE::Account.new("97100000000").bank).to eq("Lunar Bank")
     end
 
     it "should return nil for unknown clearing numbers" do
@@ -163,41 +164,20 @@ RSpec.describe BankTools::SE::Account do
     end
 
     context "using digits_only: true" do
-      it "normalizes to clearing number then serial number" do
+      it "normalizes without any non-digit separators" do
+        expect(BankTools::SE::Account.new("1100-0000007").normalize(digits_only: true)).to eq("11000000007")
         expect(BankTools::SE::Account.new("11000000007").normalize(digits_only: true)).to eq("11000000007")
       end
 
-      it "keeps any Swedbank/Sparbanker clearing checksum" do
-        expect(BankTools::SE::Account.new("8000-2-0000000000").normalize(digits_only: true)).to eq("800020000000000")
-      end
-
       it "does not attempt to normalize invalid numbers" do
         expect(BankTools::SE::Account.new(" 1-2-3 ").normalize(digits_only: true)).to eq(" 1-2-3 ")
       end
-
-      it "prepends zeroes to the serial number if necessary" do
-        expect(BankTools::SE::Account.new("8000-2-80000003").normalize(digits_only: true)).to   eq("800020080000003")
-        expect(BankTools::SE::Account.new("8000-2-8000000003").normalize(digits_only: true)).to eq("800028000000003")
-      end
     end
 
     context "using clearing_checksum: false" do
-      it "normalizes to clearing number then serial number" do
-        expect(BankTools::SE::Account.new("1100 0000007").normalize(clearing_checksum: false)).to eq("1100-0000007")
-      end
-
-      it "drops any Swedbank/Sparbanker clearing checksum" do
+      it "drops any Swedbank/Sparbanker clearing checksum (fifth digit and hyphen)" do
         expect(BankTools::SE::Account.new("8000-2-0000000000").normalize(clearing_checksum: false)).to eq("8000-0000000000")
       end
-
-      it "keeps any invalid numbers" do
-        expect(BankTools::SE::Account.new(" 1-2-3 ").normalize(clearing_checksum: false)).to eq(" 1-2-3 ")
-      end
-
-      it "prepends zeroes to the serial number if necessary" do
-        expect(BankTools::SE::Account.new("8000-2-80000003").normalize(clearing_checksum: false)).to   eq("8000-0080000003")
-        expect(BankTools::SE::Account.new("8000-2-8000000003").normalize(clearing_checksum: false)).to eq("8000-8000000003")
-      end
     end
   end
 end

data/spec/plusgiro_spec.rb

@@ -26,6 +26,7 @@ RSpec.describe BankTools::SE::Plusgiro do
     [
       "28 65 43-4",  # IKEA
       "410 54 68-5",  # IKEA
+      "421 880 87-25", # Göteborg Dödsbotjänster AB
       "4-2",  # Sveriges riksbank
     ].each do |number|
       it "should be empty for a valid number like #{number}" do
@@ -40,8 +41,8 @@ RSpec.describe BankTools::SE::Plusgiro do
       expect(BankTools::SE::Plusgiro.new("1---------").errors).to include(BankTools::SE::Errors::TOO_SHORT)
     end
 
-    it "should include :too_long for numbers longer than 8 digits" do
-      expect(BankTools::SE::Plusgiro.new("410 54 68-51").errors).to include(BankTools::SE::Errors::TOO_LONG)
+    it "should include :too_long for numbers longer than 10 digits" do
+      expect(BankTools::SE::Plusgiro.new("410 54 68-51 21").errors).to include(BankTools::SE::Errors::TOO_LONG)
     end
 
     it "should include :invalid_characters for numbers with other character than digits, spaces and dashes" do

metadata

@@ -1,22 +1,21 @@
 --- !ruby/object:Gem::Specification
 name: banktools-se
 version: !ruby/object:Gem::Version
-  version: 3.2.0
+  version: 3.3.1
 platform: ruby
 authors:
 - Henrik Nyh
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-06-14 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies: []
-description: 
 email:
 - henrik@barsoom.se
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
@@ -45,7 +44,8 @@ homepage: ''
 licenses: []
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message: 
+  source_code_uri: https://github.com/barsoom/banktools-se
+  changelog_uri: https://github.com/barsoom/banktools-se/blob/v3.3.1/CHANGELOG.md
 rdoc_options: []
 require_paths:
 - lib
@@ -60,8 +60,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.11
-signing_key: 
+rubygems_version: 4.0.8
 specification_version: 4
 summary: Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.
 test_files: []