banktools-se 3.1.1 → 3.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ae26d83c75f488a904bc1dcaffada866c129f7f923a4083ef4c2886c58c4d605
-  data.tar.gz: 1a52ea7948ea5d90c0df16501455015ff8c870f22f00b64ca7ccf64f050aba83
+  metadata.gz: f5d38b29a0e8e17173e684e2aa57595210cd8239a3faad83881e09a2155b47ec
+  data.tar.gz: 536681543fe7547f8c5589a09929c3c4273f3de5126f8b56ff88edebea2c02d5
 SHA512:
-  metadata.gz: 4ea749b95887d14fce1fa99b3f34537f497706ea1670050014cf94064830b6e23a1db8c3a71caeaab0282a559879562ea4305d9507608f1ad01f04c0ffa859fc
-  data.tar.gz: 3aef88169d2c7be49fcfa7d88148db48db4a2ff2d9f8822cc9898ee03f9fad0cc0b4e7f9197ce0410f1021c3459172b8159d99d49269f20a0f06c98b882f8eb7
+  metadata.gz: 24b822afa750fd939f09245cecdc18eaf04dbedf9a7a04e8f246c0d5c4d264906817b63f89a7f93b1a73b1dc4d867791c09bb27277546a8536ae055744cd1aed
+  data.tar.gz: 2c3c2217e150f37beb61215d64407af6b592bddca513204d520c06c07e5a6da8ae3ee40147d5d2ffeb6b34cea9a553f9239f4e5e51d2d8c05f3d337e9b4adc19

data/.github/dependabot.yml

@@ -0,0 +1,6 @@
+version: 2
+updates:
+  - package-ecosystem: "github-actions"
+    directory: "/"
+    schedule:
+      interval: "weekly"

data/.github/workflows/ci.yml

@@ -7,18 +7,24 @@ on:
     branches: [ master ]
 
 jobs:
-  test:
+  ruby-versions:
+    uses: ruby/actions/.github/workflows/ruby_versions.yml@master
+    with:
+      min_version: 3.1
+      engine: cruby
 
+  test:
+    needs: ruby-versions
     runs-on: ubuntu-latest
 
     strategy:
       matrix:
-        ruby-version: ["3.0", "2.7", "2.6", "2.5"]
+        ruby-version: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
 
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Set up Ruby ${{ matrix.ruby-version }}
-        uses: ruby/setup-ruby@ae9cb3b565e36682a2c6045e4f664388da4c73aa
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby-version }}
           bundler-cache: true # runs 'bundle install' and caches installed gems automatically

data/.rspec

@@ -0,0 +1 @@
+--require spec_helper

data/CHANGELOG.md

@@ -1,5 +1,17 @@
 # Changelog
 
+## 3.3.0
+
+- Add Lunar Bank clearing number range. [#14](https://github.com/barsoom/banktools-se/pull/14). Thanks, @andyglim!
+
+## 3.2.0
+
+- Add Account#normalize keyword arguments `digits_only`, `clearing_checksum`. [#11](https://github.com/barsoom/banktools-se/pull/11)
+
+## 3.1.1
+
+- Require MFA for privileged Rubygems actions.
+
 ## 3.1.0
 
 - Add more banks to the range in `BankTools::SE::Account::ClearingNumber`. See [#7]. Thanks, Milen Dimitrov!

data/Gemfile

@@ -1,9 +1,12 @@
 source "https://rubygems.org"
 
-# Specify your gem's dependencies in bank-tools-se.gemspec
 gemspec
 
-group :development do
-  gem "barsoom_utils", github: "barsoom/barsoom_utils"
+group :development, :test do
+  gem "barsoom_utils"
+  gem "guard"
+  gem "guard-rspec"
+  gem "rake"
+  gem "rspec"
   gem "rubocop"
 end

data/banktools-se.gemspec

@@ -14,9 +14,4 @@ Gem::Specification.new do |s|
   s.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   s.require_paths = [ "lib" ]
   s.metadata      = { "rubygems_mfa_required" => "true" }
-
-  s.add_development_dependency "rake"
-  s.add_development_dependency "rspec"
-  s.add_development_dependency "guard"
-  s.add_development_dependency "guard-rspec"
 end

data/lib/banktools-se/account/clearing_number.rb

@@ -53,6 +53,7 @@ module BankTools
           9680..9689 => { name: "Bluestep Finance" },
           9690..9699 => { name: "Folkia" },
           9700..9709 => { name: "Ekobanken" },
+          9710..9719 => { name: "Lunar Bank" },
           9720..9729 => { name: "Netfonds Bank (ub)" },
           9750..9759 => { name: "Northmill Bank" },
           9770..9779 => { name: "FTCS" },

data/lib/banktools-se/account.rb

@@ -36,9 +36,16 @@ module BankTools
         errors
       end
 
-      def normalize
+      def normalize(digits_only: false, clearing_checksum: true)
         if valid?
-          [ clearing_number, serial_number ].join("-")
+          clearing_number_part =
+            if clearing_checksum
+              clearing_number
+            else
+              digits[0, 4]
+            end
+          result = [ clearing_number_part, serial_number ].join("-")
+          digits_only ? result.gsub(/\D/, "") : result
         else
           number
         end

data/lib/banktools-se/plusgiro.rb

@@ -29,7 +29,7 @@ module BankTools
       def normalize
         if valid?
           pre, pairs, post = digits.split(/(\d{2}*)(\d)$/)
-          pairs = pairs.split(/(\d\d)/).reject { |x| x.empty? }
+          pairs = pairs.split(/(\d\d)/).reject(&:empty?)
           [ pre, pairs.join(" "), "-", post ].join
         else
           number

data/lib/banktools-se/utils.rb

@@ -4,22 +4,22 @@ module BankTools
 
       # Based on http://blog.internautdesign.com/2007/4/18/ruby-luhn-check-aka-mod-10-formula
       def self.valid_luhn?(number)
-        digits = number.to_s.scan(/\d/).reverse.map { |x| x.to_i }
+        digits = number.to_s.scan(/\d/).reverse.map(&:to_i)
         digits = digits.each_with_index.map { |d, i|
           d *= 2 if i.odd?
           d > 9 ? d - 9 : d
         }
-        sum = digits.inject(0) { |m, x| m + x }
+        sum = digits.reduce(0) { |m, x| m + x }
         sum % 10 == 0
       end
 
       def self.luhn_checksum(number)
-        digits = number.to_s.scan(/\d/).reverse.map { |x| x.to_i }
+        digits = number.to_s.scan(/\d/).reverse.map(&:to_i)
         digits = digits.each_with_index.map { |d, i|
           d *= 2 if i.even?
           d > 9 ? d - 9 : d
         }
-        sum = digits.inject(0) { |m, x| m + x }
+        sum = digits.reduce(0) { |m, x| m + x }
         mod = 10 - sum % 10
         mod == 10 ? 0 : mod
       end

data/lib/banktools-se/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module SE
-    VERSION = "3.1.1"
+    VERSION = "3.3.0"
   end
 end

data/spec/account_spec.rb

@@ -1,9 +1,8 @@
 # encoding: utf-8
 
-require "spec_helper"
 require "banktools-se"
 
-describe BankTools::SE::Account do
+RSpec.describe BankTools::SE::Account do
   it "should initialize" do
     expect(BankTools::SE::Account.new("foo")).to be_a(BankTools::SE::Account)
   end
@@ -65,7 +64,7 @@ describe BankTools::SE::Account do
       "9550-0000000",       # Avanza Bank.
       "9570-0000000000",    # Sparbanken Syd.
       "9960-00",            # Nordea/Plusgirot.
-
+      "9710-0000000",       # Lunar Bank.
     ].each do |number|
       it "should be empty for a valid number like #{number}" do
         expect(BankTools::SE::Account.new(number).errors).to eq([])
@@ -113,6 +112,7 @@ describe BankTools::SE::Account do
       expect(BankTools::SE::Account.new("11550000001").bank).to eq("Nordea")
       expect(BankTools::SE::Account.new("11990000009").bank).to eq("Nordea")
       expect(BankTools::SE::Account.new("12000000005").bank).to eq("Danske Bank")
+      expect(BankTools::SE::Account.new("97100000000").bank).to eq("Lunar Bank")
     end
 
     it "should return nil for unknown clearing numbers" do
@@ -147,7 +147,7 @@ describe BankTools::SE::Account do
 
   describe "#normalize" do
     it "should normalize to clearing number dash serial number" do
-      account = expect(BankTools::SE::Account.new("11000000007").normalize).to eq("1100-0000007")
+      expect(BankTools::SE::Account.new("11000000007").normalize).to eq("1100-0000007")
     end
 
     it "should keep any Swedbank/Sparbanker clearing checksum" do
@@ -155,12 +155,29 @@ describe BankTools::SE::Account do
     end
 
     it "should not attempt to normalize invalid numbers" do
-      account = expect(BankTools::SE::Account.new(" 1-2-3 ").normalize).to eq(" 1-2-3 ")
+      expect(BankTools::SE::Account.new(" 1-2-3 ").normalize).to eq(" 1-2-3 ")
     end
 
     it "should prepend zeroes to the serial number if necessary" do
       expect(BankTools::SE::Account.new("8000-2-80000003").normalize).to   eq("8000-2-0080000003")
       expect(BankTools::SE::Account.new("8000-2-8000000003").normalize).to eq("8000-2-8000000003")
     end
+
+    context "using digits_only: true" do
+      it "normalizes without any non-digit separators" do
+        expect(BankTools::SE::Account.new("1100-0000007").normalize(digits_only: true)).to eq("11000000007")
+        expect(BankTools::SE::Account.new("11000000007").normalize(digits_only: true)).to eq("11000000007")
+      end
+
+      it "does not attempt to normalize invalid numbers" do
+        expect(BankTools::SE::Account.new(" 1-2-3 ").normalize(digits_only: true)).to eq(" 1-2-3 ")
+      end
+    end
+
+    context "using clearing_checksum: false" do
+      it "drops any Swedbank/Sparbanker clearing checksum (fifth digit and hyphen)" do
+        expect(BankTools::SE::Account.new("8000-2-0000000000").normalize(clearing_checksum: false)).to eq("8000-0000000000")
+      end
+    end
   end
 end

data/spec/bankgiro_spec.rb

@@ -1,7 +1,6 @@
-require "spec_helper"
 require "banktools-se"
 
-describe BankTools::SE::Bankgiro do
+RSpec.describe BankTools::SE::Bankgiro do
   it "should initialize" do
     expect(BankTools::SE::Bankgiro.new("foo")).to be_a(BankTools::SE::Bankgiro)
   end

data/spec/ocr_spec.rb

@@ -1,7 +1,6 @@
-require "spec_helper"
 require "banktools-se"
 
-describe BankTools::SE::OCR do
+RSpec.describe BankTools::SE::OCR do
   # https://www.bankgirot.se/globalassets/dokument/anvandarmanualer/bankgiroinbetalningar_anvandarmanual_sv_31okt2016.pdf section 5.2
   describe ".from_number" do
     it "adds a mod-10 check digit" do

data/spec/plusgiro_spec.rb

@@ -1,7 +1,6 @@
-require "spec_helper"
 require "banktools-se"
 
-describe BankTools::SE::Plusgiro do
+RSpec.describe BankTools::SE::Plusgiro do
 
   it "should initialize" do
     expect(BankTools::SE::Plusgiro.new("foo")).to be_a(BankTools::SE::Plusgiro)

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 RSpec.configure do |config|
   config.filter_run focus: true
   config.run_all_when_everything_filtered = true
+  config.disable_monkey_patching!
 end

data/spec/utils_spec.rb

@@ -1,7 +1,6 @@
-require "spec_helper"
 require "banktools-se/utils"
 
-describe BankTools::SE::Utils, "valid_luhn?" do
+RSpec.describe BankTools::SE::Utils, "valid_luhn?" do
 
   [
     "00",

metadata

@@ -1,80 +1,24 @@
 --- !ruby/object:Gem::Specification
 name: banktools-se
 version: !ruby/object:Gem::Version
-  version: 3.1.1
+  version: 3.3.0
 platform: ruby
 authors:
 - Henrik Nyh
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-11-19 00:00:00.000000000 Z
-dependencies:
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: guard-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-description: 
+date: 1980-01-02 00:00:00.000000000 Z
+dependencies: []
 email:
 - henrik@barsoom.se
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/dependabot.yml"
 - ".github/workflows/ci.yml"
 - ".gitignore"
+- ".rspec"
 - ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
@@ -100,7 +44,6 @@ homepage: ''
 licenses: []
 metadata:
   rubygems_mfa_required: 'true'
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -115,8 +58,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.28
-signing_key: 
+rubygems_version: 3.6.8
 specification_version: 4
 summary: Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.
 test_files: []