banktools-se 2.6.3 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6df052c5e1e856bc395b39e9e9355817f5a0bcdb
-  data.tar.gz: 82f54243c1e5ed41b80c4689d3c6e0cd7656aa21
+  metadata.gz: 38e5cf121c7e7407651ad63a42019ea082955b08
+  data.tar.gz: ce68adf193356960407508086df268b5dbc1e270
 SHA512:
-  metadata.gz: 4cc99d6b3c4e554c68401414da3e8b679f552603654d42c4667e0a723ce730785f4b0c3ee7a0652e7bc30b610bec98681459df40f4cd5dc0548458cee03ce6dc
-  data.tar.gz: 49557f51445e632e2f6ac97717d1a13c98696fcae3a865cf2a62a4918d3733fdbca7948642984b0e7102e1d8717a3f16dd529505ac6bcacefb3dcdf473ebe374
+  metadata.gz: f6bdae6a9abf7e6dd2ea17ffacfee12752374e5ae83f58310bfac8c4a78125b849a9daa13f862e5623ce914da28601f84378de3f0bc2bb7cea0ca7187aea9bf2
+  data.tar.gz: 902b07121e7aaad2450f9171092b4356ba5d283f9622c24ed34678b352c20daceca0b111d26ec69ba5767c0d5ac52b3fa4889b424c79632629c62d33c06f6355

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+
+## 3.0.0
+
+- Change `BankTools::SE::OCR.find_all_in_string` default `max_length` from 19 to 18 to avoid out of range errors with Active Record.
+
+## 2.6.3 and earlier
+
+- Please see commit history.

data/README.markdown

@@ -117,9 +117,9 @@ Possible improvements to make:
 
 ## Also see
 
-* [BankTools::DE (German)](https://github.com/barsoom/banktools-de)
-* [iban-tools](https://github.com/iulianu/iban-tools)
 * [Bankgirocentral documentation](https://www.bankgirot.se/kundservice/handbocker/)
+* [Our other BankTools](https://github.com/barsoom?q=banktools)
+* [iban-tools](https://github.com/iulianu/iban-tools)
 
 
 ## Credits and license

data/lib/banktools-se/ocr.rb

@@ -64,8 +64,8 @@ module BankTools
         ocr[0...-digits_to_chop]
       end
 
-      # max_length is 19 because that's the longest allowed integer by default in a Postgres integer column with Ruby on Rails. So attempting some queries with longer OCRs may cause exceptions.
-      def self.find_all_in_string(string, length_digit: false, pad: "", min_length: 4, max_length: 19)
+      # max_length is 18, because the biggest allowed integer by default in a Postgres integer column ("bigint") is 19 digits long, as is the next (disallowed) number. Attempting some queries with longer OCRs may cause Ruby on Rails exceptions.
+      def self.find_all_in_string(string, length_digit: false, pad: "", min_length: 4, max_length: 18)
         # First, treat the input as one long string of digits.
         # E.g. "1234 and 5678" becomes "12345678".
 
@@ -88,7 +88,7 @@ module BankTools
 
         # Get rid of any duplicates.
 
-        candidates.uniq!
+        candidates = candidates.uniq
 
         # Finally, limit these substrings to ones that are actually valid OCRs.
 

data/lib/banktools-se/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module SE
-    VERSION = "2.6.3"
+    VERSION = "3.0.0"
   end
 end

data/spec/ocr_spec.rb

@@ -121,15 +121,17 @@ describe BankTools::SE::OCR do
     end
 
     it "lets you configure the accepted OCR max_length" do
-      ocr_length_19 = "1234567890123456785"
-      ocr_length_20 = "12345678901234567894"
-      string = "#{ocr_length_19} #{ocr_length_20}"
+      # Add a check digit to the input.
+      ocr_length_18 = BankTools::SE::OCR.from_number("12345678901234567")
+      ocr_length_19 = BankTools::SE::OCR.from_number("123456789012345678")
 
-      # Default max_length is 19.
-      expect(BankTools::SE::OCR.find_all_in_string(string)).to include ocr_length_19
-      expect(BankTools::SE::OCR.find_all_in_string(string)).not_to include ocr_length_20
+      string = "#{ocr_length_18} #{ocr_length_19}"
 
-      expect(BankTools::SE::OCR.find_all_in_string(string, max_length: 20)).to include ocr_length_19, ocr_length_20
+      # Default max_length is 18.
+      expect(BankTools::SE::OCR.find_all_in_string(string)).to include ocr_length_18
+      expect(BankTools::SE::OCR.find_all_in_string(string)).not_to include ocr_length_19
+
+      expect(BankTools::SE::OCR.find_all_in_string(string, max_length: 19)).to include ocr_length_18, ocr_length_19
     end
 
     it "excludes duplicates" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banktools-se
 version: !ruby/object:Gem::Version
-  version: 2.6.3
+  version: 3.0.0
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-30 00:00:00.000000000 Z
+date: 2018-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -75,6 +75,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - README.markdown
 - Rakefile
@@ -113,7 +114,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: banktools-se
-rubygems_version: 2.5.1
+rubygems_version: 2.6.11
 signing_key: 
 specification_version: 4
 summary: Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.