banktools-se 0.0.1 → 0.2.0

data/README.markdown

@@ -6,6 +6,8 @@ Ruby gem to validate, normalize/prettify and to some extent interpret
   * Swedish plusgiro numbers
   * Swedish bankgiro numbers
 
+This gem does what it can to weed out invalid numbers but errs on the side of allowing too much, in the absence of good specifications, so be advised that a "valid" number might still be incorrect.
+
 Inspired by [iulianu/iban-tools](https://github.com/iulianu/iban-tools). Please consider contributing gems for your country.
 
 
@@ -60,11 +62,13 @@ to install it.
 
     # Bank account
 
-    valid_account = BankTools::SE::Account.new("1100-0000000")
+    valid_account = BankTools::SE::Account.new("11000000000")
     valid_account.valid?  # => true
     valid_account.errors  # => []
+    valid_account.normalize  # => "1100-0000000"
     valid_account.bank  # => "Nordea"
-    valid_account.normalize  # => "11000000007"
+    valid_account.clearing_number  # => "1100"
+    valid_account.serial_number  # => "0000000"
 
     bad_account = BankTools::SE::Account.new(" 0000-0000000X ")
     bad_account.valid?  # => false
@@ -73,13 +77,21 @@ to install it.
     bad_account.normalize  # => " 0000-0000000X "
 
 
+    # Error codes
+
+    BankTools::SE::Errors::TOO_SHORT                # => :too_short
+    BankTools::SE::Errors::TOO_LONG                 # => :too_long
+    BankTools::SE::Errors::INVALID_CHARACTERS       # => :invalid_characters
+    BankTools::SE::Errors::BAD_CHECKSUM             # => :bad_checksum
+    BankTools::SE::Errors::UNKNOWN_CLEARING_NUMBER  # => :unknown_clearing_number
+
+
 ## TODO
 
 Possible improvements to make:
 
-  * Handle [Swedbank zerofill](http://www.danskebank.se/sv-se/eBanking-content/text-pages/Pages/Bankliste2.aspx).
   * Handle [Sparbanken zerofill](http://www.danskebank.se/sv-se/eBanking-content/text-pages/Pages/Bankliste2.aspx).
-  * Look into just what bank account numbers need Luhn validation of which part.
+  * Luhn validation based on [BGC docs](http://www.bgc.se/upload/Gemensamt/Trycksaker/Manualer/BG910.pdf).
 
 
 ## Credits and license
@@ -105,4 +117,3 @@ By [Henrik Nyh](http://henrik.nyh.se/) for [Barsoom](http://barsoom.se) under th
 >  LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 >  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 >  THE SOFTWARE.
-

data/lib/banktools-se/account.rb

@@ -4,13 +4,7 @@ module BankTools
   module SE
     class Account
 
-      # http://sv.wikipedia.org/wiki/Lista_%C3%B6ver_clearingnummer_till_svenska_banker
-      # Max lengths from
-      #   http://www.danskebank.se/sv-se/eBanking-content/text-pages/Pages/Bankliste2.aspx
-      # Min lengths are educated guesses based on the above and
-      #   http://sv.wikipedia.org/wiki/Bankkonto
-      # When it's uncertain, let's error on the side of allowing too much.
-      # 1..99 means we have no idea.
+      # http://www.bgc.se/upload/Gemensamt/Trycksaker/Manualer/BG910.pdf
 
       DEFAULT_SERIAL_NUMBER_LENGTH = 7
 
@@ -18,10 +12,8 @@ module BankTools
         1100..1199 => { :name => "Nordea" },
         1200..1399 => { :name => "Danske Bank" },
         1400..2099 => { :name => "Nordea" },
-        2300..2309 => { :name => "JP Nordiska", :serial_number_length => 1..99 },
-        2310..2310 => { :name => "Ålandsbanken" },
-        2311..2399 => { :name => "JP Nordiska", :serial_number_length => 1..99 },
-        2950..2950 => { :name => "Sambox", :serial_number_length => 1..99 },
+        2300..2399 => { :name => "Ålandsbanken" },
+        2400..2499 => { :name => "Danske Bank" },
         3000..3299 => { :name => "Nordea" },
         3300..3300 => { :name => "Nordea", :serial_number_length => 10, :luhn_for_serial => true },  # Personkonto.
         3301..3399 => { :name => "Nordea" },
@@ -31,39 +23,33 @@ module BankTools
         3783..4999 => { :name => "Nordea" },
         5000..5999 => { :name => "SEB" },
         6000..6999 => { :name => "Handelsbanken", :serial_number_length => 9 },
-        7000..7120 => { :name => "Swedbank" },
-        7121..7122 => { :name => "Sparbanken i Enköping", :serial_number_length => 7..10 },  # 7? 10? Who knows.
-        7123..7999 => { :name => "Swedbank" },
-        8000..8999 => { :name => "Swedbank och fristående Sparbanker", :serial_number_length => 10, :checksum_for_clearing => true },
+        7000..7999 => { :name => "Swedbank" },
+        # Can be fewer chars but must be zero-filled, so let's call it 10.
+        8000..8999 => { :name => "Swedbank", :serial_number_length => 10, :checksum_for_clearing => true },
         9020..9029 => { :name => "Länsförsäkringar Bank" },
         9040..9049 => { :name => "Citibank" },
-        9050..9059 => { :name => "HSB Bank", :serial_number_length => 1..99 },
         9060..9069 => { :name => "Länsförsäkringar Bank" },
-        9080..9080 => { :name => "Calyon Bank", :serial_number_length => 1..99 },
-        9090..9099 => { :name => "ABN AMRO", :serial_number_length => 1..99 },
-        9100..9100 => { :name => "Nordnet Bank" },
+        9090..9099 => { :name => "Royal Bank of Scotland" },
+        9100..9109 => { :name => "Nordnet Bank" },
         9120..9124 => { :name => "SEB" },
         9130..9149 => { :name => "SEB" },
         9150..9169 => { :name => "Skandiabanken" },
         9170..9179 => { :name => "Ikano Bank" },
-        9180..9189 => { :name => "Danske Bank" },
+        9180..9189 => { :name => "Danske Bank", :serial_number_length => 10 },
         9190..9199 => { :name => "Den Norske Bank" },
-        9200..9209 => { :name => "Stadshypotek Bank", :serial_number_length => 1..99 },
-        9230..9230 => { :name => "Bank2" },
-        9231..9239 => { :name => "SalusAnsvar Bank", :serial_number_length => 1..99 },
-        9260..9269 => { :name => "Gjensidige NOR Sparebank", :serial_number_length => 1..99 },
+        9230..9239 => { :name => "Marginalen Bank" },
+        9250..9259 => { :name => "SBAB" },
+        9260..9269 => { :name => "Den Norske Bank" },
         9270..9279 => { :name => "ICA Banken" },
         9280..9289 => { :name => "Resurs Bank" },
-        9290..9299 => { :name => "Coop Bank", :serial_number_length => 1..99 },
         9300..9349 => { :name => "Sparbanken Öresund", :serial_number_length => 10 },
-        9400..9400 => { :name => "Forex Bank" },
-        9460..9460 => { :name => "GE Money Bank" },
-        9469..9469 => { :name => "GE Money Bank" },
-        9500..9547 => { :name => "Plusgirot Bank", :serial_number_length => 10 },
-        9548..9548 => { :name => "Ekobanken", :serial_number_length => 1..99 },
-        9549..9549 => { :name => "JAK Medlemsbank", :serial_number_length => 1..99 },
-        9550..9550 => { :name => "Avanza Bank" },
-        9960..9969 => { :name => "Plusgirot Bank", :serial_number_length => 10 },
+        9400..9449 => { :name => "Forex Bank" },
+        9460..9469 => { :name => "GE Money Bank" },
+        9470..9479 => { :name => "Fortis Bank" },
+        9500..9549 => { :name => "Nordea/Plusgirot", :serial_number_length => 1..10 },
+        9550..9569 => { :name => "Avanza Bank" },
+        9570..9579 => { :name => "Sparbanken Syd", :serial_number_length => 10 },
+        9960..9969 => { :name => "Nordea/Plusgirot", :serial_number_length => 1..10 },
       }
 
       attr_reader :number
@@ -79,15 +65,15 @@ module BankTools
       def errors
         errors = []
 
-        errors << :too_short if serial_number.length < min_length
-        errors << :too_long if serial_number.length > max_length
-        errors << :invalid_characters if number.to_s.match(/[^0-9 -]/)
+        errors << Errors::TOO_SHORT if serial_number.length < min_length
+        errors << Errors::TOO_LONG if serial_number.length > max_length
+        errors << Errors::INVALID_CHARACTERS if number.to_s.match(/[^0-9 -]/)
 
         if luhn_for_serial?
-          errors << :bad_checksum unless BankTools::SE::Utils.valid_luhn?(serial_number)
+          errors << Errors::BAD_CHECKSUM unless BankTools::SE::Utils.valid_luhn?(serial_number)
         end
 
-        errors << :unknown_clearing_number unless bank
+        errors << Errors::UNKNOWN_CLEARING_NUMBER unless bank
 
         errors
       end
@@ -105,22 +91,24 @@ module BankTools
       end
 
       def clearing_number
-        digits[0,4]
+        [
+          digits[0,4],
+          checksum_for_clearing? ? digits[4,1] : nil
+        ].compact.join("-")
       end
 
       def serial_number
-        value = digits[4..-1] || ""
-        if checksum_for_clearing? && value.length == max_length
-          value[1..-1]
-        else
-          value
-        end
+        digits.slice(clearing_number_length..-1) || ""
       end
 
       private
 
+      def clearing_number_length
+        checksum_for_clearing? ? 5 : 4
+      end
+
       def bank_data
-        number = clearing_number.to_i
+        number = digits[0,4].to_i
         _, found_data = CLEARING_NUMBER_MAP.find do |interval, data|
           interval.include?(number)
         end

data/lib/banktools-se/bankgiro.rb

@@ -17,10 +17,10 @@ module BankTools
       def errors
         errors = []
 
-        errors << :too_short if digits.length < 7
-        errors << :too_long if digits.length > 8
-        errors << :invalid_characters if number.to_s.match(/[^0-9 -]/)
-        errors << :bad_checksum unless BankTools::SE::Utils.valid_luhn?(number)
+        errors << Errors::TOO_SHORT if digits.length < 7
+        errors << Errors::TOO_LONG if digits.length > 8
+        errors << Errors::INVALID_CHARACTERS if number.to_s.match(/[^0-9 -]/)
+        errors << Errors::BAD_CHECKSUM unless BankTools::SE::Utils.valid_luhn?(number)
 
         errors
       end

data/lib/banktools-se/errors.rb

@@ -0,0 +1,11 @@
+module BankTools
+  module SE
+    module Errors
+      TOO_SHORT               = :too_short
+      TOO_LONG                = :too_long
+      INVALID_CHARACTERS      = :invalid_characters
+      BAD_CHECKSUM            = :bad_checksum
+      UNKNOWN_CLEARING_NUMBER = :unknown_clearing_number
+    end
+  end
+end

data/lib/banktools-se/plusgiro.rb

@@ -18,10 +18,10 @@ module BankTools
       def errors
         errors = []
 
-        errors << :too_short if digits.length < 2
-        errors << :too_long if digits.length > 8
-        errors << :invalid_characters if number.to_s.match(/[^0-9 -]/)
-        errors << :bad_checksum unless BankTools::SE::Utils.valid_luhn?(number)
+        errors << Errors::TOO_SHORT if digits.length < 2
+        errors << Errors::TOO_LONG if digits.length > 8
+        errors << Errors::INVALID_CHARACTERS if number.to_s.match(/[^0-9 -]/)
+        errors << Errors::BAD_CHECKSUM unless BankTools::SE::Utils.valid_luhn?(number)
 
         errors
       end

data/lib/banktools-se/utils.rb

@@ -3,10 +3,9 @@ module BankTools
     module Utils
 
       # Based on http://blog.internautdesign.com/2007/4/18/ruby-luhn-check-aka-mod-10-formula
-      require "enumerator"
       def self.valid_luhn?(number)
         digits = number.to_s.scan(/\d/).reverse.map { |x| x.to_i }
-        digits = digits.enum_with_index.map { |d, i|
+        digits = digits.each_with_index.map { |d, i|
           d *= 2 if i.odd?
           d > 9 ? d - 9 : d
         }

data/lib/banktools-se/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module SE
-    VERSION = "0.0.1"
+    VERSION = "0.2.0"
   end
 end

data/lib/banktools-se.rb

@@ -1,4 +1,5 @@
 require "banktools-se/version"
+require "banktools-se/errors"
 require "banktools-se/utils"
 require "banktools-se/bankgiro"
 require "banktools-se/plusgiro"

data/spec/account_spec.rb

@@ -28,14 +28,10 @@ describe BankTools::SE::Account do
   describe "#errors" do
     [
       "1100-0000000",       # Nordea.
-      "1155-0000000",       # Nordea.
-      "1199-0000000",       # Nordea.
       "1200-0000000",       # Danske Bank.
       "1400-0000000",       # Nordea.
-      "2300-00",            # JP Nordiska.
-      "2310-0000000",       # Ålandsbanken.
-      "2311-00",            # JP Nordiska.
-      "2950-00",            # Sambox.
+      "2300-0000000",       # Ålandsbanken.
+      "2400-0000000",       # Danske Bank.
       "3000-0000000",       # Nordea.
       "3300-800928-6249",   # Nordea personkonto.
       "3301-0000000",       # Nordea.
@@ -46,39 +42,31 @@ describe BankTools::SE::Account do
       "5000-0000000",       # SEB.
       "6000-000000000",     # Handelsbanken.
       "7000-0000000",       # Swedbank.
-      "7121-0000000",       # Sparbanken i Enköping.
-      "7123-0000000",       # Swedbank.
-      "8000-0000000000",    # Swedbank/Sparbanker.
       "8000-2-0000000000",  # Swedbank/Sparbanker with clearing number checksum.
       "9020-0000000",       # Länsförsäkringar Bank.
       "9040-0000000",       # Citibank.
-      "9050-00",            # HSB Bank.
       "9060-0000000",       # Länsförsäkringar Bank.
-      "9080-00",            # Calyon Bank.
-      "9090-00",            # ABN AMBRO.
+      "9090-0000000",       # Royal Bank of Scotland.
       "9100-0000000",       # Nordnet Bank.
       "9120-0000000",       # SEB.
       "9130-0000000",       # SEB.
       "9150-0000000",       # Skandiabanken.
       "9170-0000000",       # Ikano Bank.
-      "9180-0000000",       # Danske Bank.
+      "9180-0000000000",    # Danske Bank.
       "9190-0000000",       # Den Norske Bank.
-      "9200-00",            # Stadshypotek Bank.
-      "9230-0000000",       # Bank2.
-      "9231-00",            # SalusAnsvar Bank.
-      "9260-00",            # Gjensidige NOR Sparebank.
+      "9230-0000000",       # Marginalen.
+      "9250-0000000",       # SBAB.
+      "9260-0000000",       # Den Norske Bank.
       "9270-0000000",       # ICA Banken.
       "9280-0000000",       # Resurs Bank.
-      "9290-00",            # Coop Bank.
       "9300-0000000000",    # Sparbanken Öresund.
       "9400-0000000",       # Forex Bank.
       "9460-0000000",       # GE Money Bank.
-      "9469-0000000",       # GE Money Bank.
-      "9500-0000000000",    # Plusgirot Bank.
-      "9548-00",            # Ekobanken.
-      "9549-00",            # JAK Medlemsbank.
+      "9470-0000000",       # Fortis Bank.
+      "9500-00",            # Nordea/Plusgirot.
       "9550-0000000",       # Avanza Bank.
-      "9960-0000000000",    # Plusgirot Bank.
+      "9570-0000000000",    # Sparbanken Syd.
+      "9960-00",            # Nordea/Plusgirot.
 
     ].each do |number|
       it "should be empty for a valid number like #{number}" do
@@ -87,31 +75,31 @@ describe BankTools::SE::Account do
     end
 
     it "should include :too_short for numbers shorter than the bank allows" do
-      BankTools::SE::Account.new("11007").errors.should include(:too_short)
+      BankTools::SE::Account.new("11007").errors.should include(BankTools::SE::Errors::TOO_SHORT)
     end
 
     it "should include :too_long for numbers longer than the bank allows" do
-      BankTools::SE::Account.new("1100000000007").errors.should include(:too_long)
+      BankTools::SE::Account.new("1100000000007").errors.should include(BankTools::SE::Errors::TOO_LONG)
     end
 
     it "should not include :too_long for Swedbank/Sparbanker numbers with clearing checksum" do
-      BankTools::SE::Account.new("8000-2-0000000000").errors.should_not include(:too_long)
+      BankTools::SE::Account.new("8000-2-0000000000").errors.should_not include(BankTools::SE::Errors::TOO_LONG)
     end
 
     it "should include :invalid_characters for numbers with other character than digits, spaces and dashes" do
-      BankTools::SE::Account.new("1 2-3X").errors.should include(:invalid_characters)
-      BankTools::SE::Account.new("1 2-3").errors.should_not include(:invalid_characters)
+      BankTools::SE::Account.new("1 2-3X").errors.should include(BankTools::SE::Errors::INVALID_CHARACTERS)
+      BankTools::SE::Account.new("1 2-3").errors.should_not include(BankTools::SE::Errors::INVALID_CHARACTERS)
     end
 
     it "should include :bad_checksum for Nordea personkonto if the serial Luhn/mod 10 checksum is incorrect" do
       BankTools::SE::Utils.valid_luhn?("800928-6249").should be_true
       BankTools::SE::Utils.valid_luhn?("3300-800928-6249").should be_false
-      BankTools::SE::Account.new("3300-800928-6249").errors.should_not include(:bad_checksum)
+      BankTools::SE::Account.new("3300-800928-6249").errors.should_not include(BankTools::SE::Errors::BAD_CHECKSUM)
     end
 
     it "should include :unknown_clearing_number if the clearing number is unknown" do
-      BankTools::SE::Account.new("10000000009").errors.should include(:unknown_clearing_number)
-      BankTools::SE::Account.new("11000000007").errors.should_not include(:unknown_clearing_number)
+      BankTools::SE::Account.new("10000000009").errors.should include(BankTools::SE::Errors::UNKNOWN_CLEARING_NUMBER)
+      BankTools::SE::Account.new("11000000007").errors.should_not include(BankTools::SE::Errors::UNKNOWN_CLEARING_NUMBER)
     end
 
   end
@@ -137,6 +125,10 @@ describe BankTools::SE::Account do
       BankTools::SE::Account.new("12345678").clearing_number.should == "1234"
     end
 
+    it "should be the first five digits if there is a clearing number checksum" do
+      BankTools::SE::Account.new("8000-2-0000000000").clearing_number.should == "8000-2"
+    end
+
   end
 
   describe "#serial_number" do
@@ -145,13 +137,12 @@ describe BankTools::SE::Account do
       BankTools::SE::Account.new("12345678").serial_number.should == "5678"
     end
 
-    it "should be the empty string if there aren't enough numbers" do
-      BankTools::SE::Account.new("12").serial_number.should == ""
+    it "should be the digits after the first five digits if there is a clearing number checksum" do
+      BankTools::SE::Account.new("8000-2-0000000000").serial_number.should == "0000000000"
     end
 
-    it "should exclude any Swedbank/Sparbanker clearing checksum" do
-      BankTools::SE::Account.new("8000-2-0000000000").serial_number.should == "0000000000"
-      BankTools::SE::Account.new("8000-0000000000").serial_number.should == "0000000000"
+    it "should be the empty string if there aren't enough numbers" do
+      BankTools::SE::Account.new("12").serial_number.should == ""
     end
 
   end
@@ -162,9 +153,8 @@ describe BankTools::SE::Account do
       account = BankTools::SE::Account.new("11000000007").normalize.should == "1100-0000007"
     end
 
-    it "should remove any Swedbank/Sparbanker clearing checksum" do
-      BankTools::SE::Account.new("8000-2-0000000000").normalize.should == "8000-0000000000"
-      BankTools::SE::Account.new("8000-0000000000").normalize.should == "8000-0000000000"
+    it "should keep any Swedbank/Sparbanker clearing checksum" do
+      BankTools::SE::Account.new("8000-2-0000000000").normalize.should == "8000-2-0000000000"
     end
 
     it "should not attempt to normalize invalid numbers" do

data/spec/bankgiro_spec.rb

@@ -36,23 +36,23 @@ describe BankTools::SE::Bankgiro do
     end
 
     it "should include :too_short for numbers shorter than 7 digits" do
-      BankTools::SE::Bankgiro.new(nil).errors.should include(:too_short)
-      BankTools::SE::Bankgiro.new("").errors.should include(:too_short)
-      BankTools::SE::Bankgiro.new("54-0296").errors.should include(:too_short)
-      BankTools::SE::Bankgiro.new("54---------0296").errors.should include(:too_short)
+      BankTools::SE::Bankgiro.new(nil).errors.should include(BankTools::SE::Errors::TOO_SHORT)
+      BankTools::SE::Bankgiro.new("").errors.should include(BankTools::SE::Errors::TOO_SHORT)
+      BankTools::SE::Bankgiro.new("54-0296").errors.should include(BankTools::SE::Errors::TOO_SHORT)
+      BankTools::SE::Bankgiro.new("54---------0296").errors.should include(BankTools::SE::Errors::TOO_SHORT)
     end
 
     it "should include :too_long for numbers longer than 8 digits" do
-      BankTools::SE::Bankgiro.new("5402-96810").errors.should include(:too_long)
+      BankTools::SE::Bankgiro.new("5402-96810").errors.should include(BankTools::SE::Errors::TOO_LONG)
     end
 
     it "should include :invalid_characters for numbers with other character than digits, spaces and dashes" do
-      BankTools::SE::Bankgiro.new("5402-9681X").errors.should include(:invalid_characters)
-      BankTools::SE::Bankgiro.new(" 5 4 0 2 - 9 6 8 1 ").errors.should_not include(:invalid_characters)
+      BankTools::SE::Bankgiro.new("5402-9681X").errors.should include(BankTools::SE::Errors::INVALID_CHARACTERS)
+      BankTools::SE::Bankgiro.new(" 5 4 0 2 - 9 6 8 1 ").errors.should_not include(BankTools::SE::Errors::INVALID_CHARACTERS)
     end
 
     it "should include :bad_checksum if the Luhn/mod 10 checksum is incorrect" do
-      BankTools::SE::Bankgiro.new("5402-9682").errors.should include(:bad_checksum)
+      BankTools::SE::Bankgiro.new("5402-9682").errors.should include(BankTools::SE::Errors::BAD_CHECKSUM)
     end
 
   end

data/spec/plusgiro_spec.rb

@@ -35,23 +35,23 @@ describe BankTools::SE::Plusgiro do
     end
 
     it "should include :too_short for numbers shorter than 2 digits" do
-      BankTools::SE::Plusgiro.new(nil).errors.should include(:too_short)
-      BankTools::SE::Plusgiro.new("").errors.should include(:too_short)
-      BankTools::SE::Plusgiro.new("1").errors.should include(:too_short)
-      BankTools::SE::Plusgiro.new("1---------").errors.should include(:too_short)
+      BankTools::SE::Plusgiro.new(nil).errors.should include(BankTools::SE::Errors::TOO_SHORT)
+      BankTools::SE::Plusgiro.new("").errors.should include(BankTools::SE::Errors::TOO_SHORT)
+      BankTools::SE::Plusgiro.new("1").errors.should include(BankTools::SE::Errors::TOO_SHORT)
+      BankTools::SE::Plusgiro.new("1---------").errors.should include(BankTools::SE::Errors::TOO_SHORT)
     end
 
     it "should include :too_long for numbers longer than 8 digits" do
-      BankTools::SE::Plusgiro.new("410 54 68-51").errors.should include(:too_long)
+      BankTools::SE::Plusgiro.new("410 54 68-51").errors.should include(BankTools::SE::Errors::TOO_LONG)
     end
 
     it "should include :invalid_characters for numbers with other character than digits, spaces and dashes" do
-      BankTools::SE::Plusgiro.new("410 54 68-5X").errors.should include(:invalid_characters)
-      BankTools::SE::Plusgiro.new("4 1 0 5 4 6 8 - 5 ").errors.should_not include(:invalid_characters)
+      BankTools::SE::Plusgiro.new("410 54 68-5X").errors.should include(BankTools::SE::Errors::INVALID_CHARACTERS)
+      BankTools::SE::Plusgiro.new("4 1 0 5 4 6 8 - 5 ").errors.should_not include(BankTools::SE::Errors::INVALID_CHARACTERS)
     end
 
     it "should include :bad_checksum if the Luhn/mod 10 checksum is incorrect" do
-      BankTools::SE::Plusgiro.new("410 54 68-6").errors.should include(:bad_checksum)
+      BankTools::SE::Plusgiro.new("410 54 68-6").errors.should include(BankTools::SE::Errors::BAD_CHECKSUM)
     end
 
   end

metadata

@@ -1,75 +1,56 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: banktools-se
-version: !ruby/object:Gem::Version 
-  hash: 29
+version: !ruby/object:Gem::Version
+  version: 0.2.0
   prerelease: 
-  segments: 
-  - 0
-  - 0
-  - 1
-  version: 0.0.1
 platform: ruby
-authors: 
+authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2011-10-12 00:00:00 +02:00
-default_executable: 
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2012-05-10 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rspec
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
+  requirement: &70242598104220 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: guard
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
+  version_requirements: *70242598104220
+- !ruby/object:Gem::Dependency
+  name: guard
+  requirement: &70242598103800 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
-  name: guard-rspec
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  version_requirements: *70242598103800
+- !ruby/object:Gem::Dependency
+  name: guard-rspec
+  requirement: &70242598103380 !ruby/object:Gem::Requirement
     none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 3
-        segments: 
-        - 0
-        version: "0"
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id003
+  prerelease: false
+  version_requirements: *70242598103380
 description: 
-email: 
+email:
 - henrik@barsoom.se
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
+files:
 - .gitignore
 - Gemfile
 - Guardfile
@@ -79,6 +60,7 @@ files:
 - lib/banktools-se.rb
 - lib/banktools-se/account.rb
 - lib/banktools-se/bankgiro.rb
+- lib/banktools-se/errors.rb
 - lib/banktools-se/plusgiro.rb
 - lib/banktools-se/utils.rb
 - lib/banktools-se/version.rb
@@ -87,41 +69,31 @@ files:
 - spec/plusgiro_spec.rb
 - spec/spec_helper.rb
 - spec/utils_spec.rb
-has_rdoc: true
-homepage: ""
+homepage: ''
 licenses: []
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
+required_ruby_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
-required_rubygems_version: !ruby/object:Gem::Requirement 
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
-  requirements: 
-  - - ">="
-    - !ruby/object:Gem::Version 
-      hash: 3
-      segments: 
-      - 0
-      version: "0"
+  requirements:
+  - - ! '>='
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: banktools-se
-rubygems_version: 1.5.3
+rubygems_version: 1.8.5
 signing_key: 
 specification_version: 3
 summary: Validate and normalize Swedish bank account numbers, plusgiro and bankgiro.
-test_files: 
+test_files:
 - spec/account_spec.rb
 - spec/bankgiro_spec.rb
 - spec/plusgiro_spec.rb