banktools-global 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 003d61bea3f19fb30ece532474b46e3fdf2f8bb69b44b58ad091d5bbab8438e7
-  data.tar.gz: f2063c18c11fd5b7bac3036156849cb9fe85bb15262b6458816abf71e2cc0dc5
+  metadata.gz: 2f967b8f0b0bdaf9d08b043b27263f0824ab6c8b51e9b32a7880a3e9a7c3127d
+  data.tar.gz: a684c3960db386810020bcffc58a435c06f9509e62dd9463abaacb18d5b95bf9
 SHA512:
-  metadata.gz: 81bff04af82a6647241e4a9b34c0af52645533aac48c1c891bff9e46ae60891729f7ed63bfcccf5861929c60d4be89da9a5167dd5955b31cb0ccc2175aa5624d
-  data.tar.gz: b3a0060d26cfdc78899ab7d5bc366e9574b725b50b6583adabe5cf17f01e5b5e097ba0ea2c5b9ae222e1b878b597a4c10d50b96e5247b914d11406698e1f2795
+  metadata.gz: 38343b5d0a7470536849a9cb59dea203d1352b535f7efffda9f9e63f06aab570875b03dc5c3835500b9fb0dc0ff257652ef895322cff18ed25ab84bad82850a1
+  data.tar.gz: 065fae49bcd7bdebed65a629b2580dc4c3c9becab6213466547c3b123859b0a85c16f2fd18caee65cc4dd25432a4cb54867f2d614de9c169161d3f75df1b069e

data/.github/workflows/main.yml

@@ -1,18 +1,21 @@
 name: Ruby
 
-on: [push,pull_request]
+on: [push, pull_request]
 
 jobs:
   build:
     runs-on: ubuntu-latest
+    
+    strategy:
+      matrix:
+        ruby-version: ["3.0", "2.7"]
+
     steps:
     - uses: actions/checkout@v2
-    - name: Set up Ruby
+    - name: Set up Ruby ${{ matrix.ruby-version }}
       uses: ruby/setup-ruby@v1
       with:
-        ruby-version: 2.7.2
-    - name: Run the default task
-      run: |
-        gem install bundler -v 2.2.14
-        bundle install
-        bundle exec rake
+        ruby-version: ${{ matrix.ruby-version }}
+        bundler-cache: true # runs 'bundle install' and caches installed gems automatically        
+    - name: Run tests
+      run: bundle exec rake

data/.rubocop.yml

@@ -0,0 +1,5 @@
+AllCops:
+  Exclude:
+    - "tmp/**/*"
+inherit_gem:
+  barsoom_utils: shared_rubocop.yml

data/CHANGELOG.md

@@ -1,5 +1,7 @@
 ## [Unreleased]
 
+- Safer YAML loading
+
 ## [1.0.1] - 2021-04-19
 
 - Bugfix: Allow spaces in IBAN.

data/Gemfile

@@ -8,3 +8,8 @@ gemspec
 gem "rake", "~> 13.0"
 
 gem "rspec", "~> 3.0"
+
+group :development, :test do
+  gem "barsoom_utils", github: "barsoom/barsoom_utils"
+  gem "rubocop"
+end

data/Gemfile.lock

@@ -1,13 +1,26 @@
+GIT
+  remote: https://github.com/barsoom/barsoom_utils.git
+  revision: d59121c10b4ba0e996d213ad23dc1545dcd27de0
+  specs:
+    barsoom_utils (0.1.0)
+
 PATH
   remote: .
   specs:
-    banktools-global (0.1.0)
+    banktools-global (1.0.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    ast (2.4.2)
     diff-lcs (1.4.4)
-    rake (13.0.3)
+    parallel (1.20.1)
+    parser (3.0.2.0)
+      ast (~> 2.4.1)
+    rainbow (3.0.0)
+    rake (13.0.6)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
     rspec (3.10.0)
       rspec-core (~> 3.10.0)
       rspec-expectations (~> 3.10.0)
@@ -21,14 +34,30 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.10.0)
     rspec-support (3.10.2)
+    rubocop (1.18.4)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.8.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.8.0)
+      parser (>= 3.0.1.1)
+    ruby-progressbar (1.11.0)
+    unicode-display_width (2.0.0)
 
 PLATFORMS
   x86_64-darwin-20
+  x86_64-linux
 
 DEPENDENCIES
   banktools-global!
+  barsoom_utils!
   rake (~> 13.0)
   rspec (~> 3.0)
+  rubocop
 
 BUNDLED WITH
-   2.2.14
+   2.2.25

data/banktools-global.gemspec

@@ -5,30 +5,21 @@ require_relative "lib/banktools/global/version"
 Gem::Specification.new do |spec|
   spec.name          = "banktools-global"
   spec.version       = BankTools::Global::VERSION
-  spec.authors       = ["Henrik Nyh"]
-  spec.email         = ["henrik@nyh.se"]
+  spec.authors       = [ "Henrik Nyh" ]
+  spec.email         = [ "henrik@nyh.se" ]
 
   spec.summary       = "Validate and normalize international bank account numbers like IBAN/BIC. Based on iban-tools."
   spec.homepage      = "https://github.com/barsoom/banktools-global"
   spec.license       = "MIT"
   spec.required_ruby_version = Gem::Requirement.new(">= 2.4.0")
+  spec.metadata      = { "rubygems_mfa_required" => "true" }
 
   spec.metadata["homepage_uri"] = spec.homepage
   spec.metadata["source_code_uri"] = spec.homepage
-  spec.metadata["changelog_uri"] = "https://github.com/barsoom/banktools-global/blob/master/README.md"
+  spec.metadata["changelog_uri"] = "https://github.com/barsoom/banktools-global/blob/main/README.md"
 
-  # Specify which files should be added to the gem when it is released.
-  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{\A(?:test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
-
-  # Uncomment to register a new dependency of your gem
-  # spec.add_dependency "example-gem", "~> 1.0"
-
-  # For more information and examples about making a new gem, checkout our
-  # guide at: https://bundler.io/guides/creating_gem.html
+  spec.require_paths = [ "lib" ]
 end

data/lib/banktools/global/iban.rb

@@ -7,7 +7,7 @@ class BankTools::Global::IBAN
   E = BankTools::Global::Errors
 
   def initialize(raw)
-    @pre_normalized = raw.to_s.gsub(/\s/, "").strip.upcase
+    @pre_normalized = raw.to_s.gsub(/\s/, "").upcase
   end
 
   def valid?
@@ -30,22 +30,22 @@ class BankTools::Global::IBAN
   end
 
   def normalize
-     @pre_normalized.gsub(/.{4}/, '\0 ').strip
+    @pre_normalized.gsub(/.{4}/, '\0 ').strip
   end
 
   private
 
   def good_checksum?
-    number_string =
+    number =
       (bban + country_code + check_digits).chars.map { |char|
         case char
         when "0".."9" then char
         when "A".."Z" then (char.ord - 55).to_s
         else raise "Unexpected byte '#{byte}' in IBAN '#{normalize}'!"
         end
-      }.join
+      }.join.to_i
 
-    number_string.to_i % 97 == 1
+    number % 97 == 1
   end
 
   def country_code
@@ -62,7 +62,7 @@ class BankTools::Global::IBAN
 
   def rules
     @@rules ||=
-      YAML.load(File.read(File.join(File.dirname(__FILE__), "iban_rules.yml")))
+      YAML.safe_load(File.read(File.join(File.dirname(__FILE__), "iban_rules.yml")))
         .transform_values { |h| h.merge("bban_pattern" => /\A#{h.fetch("bban_pattern")}\z/) }
   end
 end

data/lib/banktools/global/version.rb

@@ -2,6 +2,6 @@
 
 module BankTools
   module Global
-    VERSION = "1.0.1"
+    VERSION = "1.0.2"
   end
 end

metadata

@@ -1,16 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: banktools-global
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Henrik Nyh
-autorequire:
-bindir: exe
+autorequire: 
+bindir: bin
 cert_chain: []
-date: 2021-04-19 00:00:00.000000000 Z
+date: 2021-11-19 00:00:00.000000000 Z
 dependencies: []
-description:
+description: 
 email:
 - henrik@nyh.se
 executables: []
@@ -20,6 +20,7 @@ files:
 - ".github/workflows/main.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
 - Gemfile.lock
@@ -39,10 +40,11 @@ homepage: https://github.com/barsoom/banktools-global
 licenses:
 - MIT
 metadata:
+  rubygems_mfa_required: 'true'
   homepage_uri: https://github.com/barsoom/banktools-global
   source_code_uri: https://github.com/barsoom/banktools-global
-  changelog_uri: https://github.com/barsoom/banktools-global/blob/master/README.md
-post_install_message:
+  changelog_uri: https://github.com/barsoom/banktools-global/blob/main/README.md
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -57,8 +59,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key:
+rubygems_version: 3.2.28
+signing_key: 
 specification_version: 4
 summary: Validate and normalize international bank account numbers like IBAN/BIC.
   Based on iban-tools.