banktools-de 1.0.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7b5d271dd698d5bdf599eb7d41c0383dfc9a6c04
-  data.tar.gz: 91d990d3764a1a0b81db3330811ec8444b185795
+  metadata.gz: 4f644a79480002d1cd803cd2eae18a277cd12ea8
+  data.tar.gz: 7bb872deab831e3669c911c4540910a1a02ecf70
 SHA512:
-  metadata.gz: 9a558ba6598cf6a8797c8fdde343ca51481d6439de8af24702831bdb2986aee9c4df8c686db4dfa7868b3057f0024ef4e1f6d039925334733025576815eb1730
-  data.tar.gz: 68f6f60d16288f7d10d950d8e48381a77cc2fc2342a11b45d715614e07a4505aa989b71d70eb3c3dedde4c46155778ae6ecaa9db26f32a2104e502f6264873ea
+  metadata.gz: 3e5fa5cec11896056bb53e7046f636bd978e75c443e4fe9b1a39937f27fd7a870f041d0413b2179b70ec404527b530241267628edb3855328c9c7abc171cbdc5
+  data.tar.gz: 8f93fb72571d481d5aee6eeb4b50e0cabd08cbb1b7c1486be9d8d15e18f845df2115131d69c1fe69cd928c1d31b5e551e533e62ad6212671969d9618030543b9

data/README.md

@@ -38,7 +38,7 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
 
     # Convert BLZ and account number to IBAN/BIC
 
-    result = BankTools::DE::IbanBicConverter.run(blz: "37040044", account: "532013000")
+    result = BankTools::DE::IbanBicConverter.call(blz: "37040044", account: "532013000")
     result.iban  # => "DE89370400440532013000"
     result.bic   # => "COBADEFFXXX"
     # Or raises an exception.

data/banktools-de.gemspec

@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "attr_extras", ">= 2.2.3"
+  spec.add_dependency "attr_extras", ">= 4"
   spec.add_dependency "ibanomat"  # Convert BLZ to IBAN/BIC
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"

data/lib/banktools-de/account.rb

@@ -1,12 +1,14 @@
 # http://de.wikipedia.org/wiki/Bankleitzahl
 # http://translate.google.com/translate?hl=en&sl=de&tl=en&u=http%3A%2F%2Fde.wikipedia.org%2Fwiki%2FBankleitzahl
 
-require "attr_extras"
+require "attr_extras/explicit"
 require "banktools-de/errors"
 
 module BankTools
   module DE
     class Account
+      extend AttrExtras.mixin
+
       # Picked some reasonable values, erring on the side of allowing too much.
       # Seems to claim max 10: http://docs.oracle.com/cd/E18727_01/doc.121/e13483/T359831T498954.htm
       # Seems to claim 2 - 13: http://www.credit-card.be/BankAccount/ValidationRules.htm#DE_Validation

data/lib/banktools-de/blz.rb

@@ -4,12 +4,14 @@
 require "banktools-de"
 require "banktools-de/errors"
 
-require "attr_extras"
+require "attr_extras/explicit"
 require "yaml"
 
 module BankTools
   module DE
     class BLZ
+      extend AttrExtras.mixin
+
       LENGTH = 8
       BLZ_TO_BANK_NAME_PATH = File.join(BankTools::DE.data_dir, "blz_to_name.yml")
 

data/lib/banktools-de/blz_downloader.rb

@@ -1,4 +1,4 @@
-require "attr_extras"
+require "attr_extras/explicit"
 require "yaml"
 require "open-uri"
 
@@ -8,6 +8,8 @@ require "creek"
 module BankTools
   module DE
     class BLZDownloader
+      extend AttrExtras.mixin
+
       pattr_initialize :url
 
       def run

data/lib/banktools-de/iban_bic.rb

@@ -1,19 +1,21 @@
 require "ibanomat"
-require "attr_extras"
+require "attr_extras/explicit"
 
 class BankTools::DE::IbanBicConverter
+  extend AttrExtras.mixin
+
   class CouldNotConvertError < StandardError; end
   class ServiceUnavailable < StandardError; end
   class UnknownError < StandardError; end
 
   class IbanBic
+    extend AttrExtras.mixin
     vattr_initialize :iban, :bic
   end
 
-  method_object :run,
-    [ :blz!, :account! ]
+  method_object [ :blz!, :account! ]
 
-  def run
+  def call
     account_data = get_account_data
     build_result(account_data)
   end

data/lib/banktools-de/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module DE
-    VERSION = "1.0.0"
+    VERSION = "2.0.0"
   end
 end

data/spec/iban_bic_spec.rb

@@ -1,14 +1,14 @@
 require "spec_helper"
 require "banktools-de/iban_bic"
 
-describe BankTools::DE::IbanBicConverter, ".run" do
+describe BankTools::DE::IbanBicConverter, ".call" do
   let(:blz) { "abc" }
   let(:account) { "def" }
 
   it "returns the BIC and IBAN" do
     allow(Ibanomat).to receive(:find).and_return(iban: "some iban", bic: "some bic", return_code: "00")
 
-    actual = BankTools::DE::IbanBicConverter.run(blz: blz, account: account)
+    actual = BankTools::DE::IbanBicConverter.call(blz: blz, account: account)
 
     expect(actual.iban).to eq("some iban")
     expect(actual.bic).to eq("some bic")
@@ -18,7 +18,7 @@ describe BankTools::DE::IbanBicConverter, ".run" do
     allow(Ibanomat).to receive(:find).and_return(return_code: "1")
 
     expect {
-      BankTools::DE::IbanBicConverter.run(blz: blz, account: account)
+      BankTools::DE::IbanBicConverter.call(blz: blz, account: account)
     }.to raise_error(BankTools::DE::IbanBicConverter::CouldNotConvertError)
   end
 
@@ -26,7 +26,7 @@ describe BankTools::DE::IbanBicConverter, ".run" do
     allow(Ibanomat).to receive(:find).and_raise(RestClient::RequestTimeout)
 
     expect {
-      BankTools::DE::IbanBicConverter.run(blz: blz, account: account)
+      BankTools::DE::IbanBicConverter.call(blz: blz, account: account)
     }.to raise_error(BankTools::DE::IbanBicConverter::ServiceUnavailable)
   end
 
@@ -34,7 +34,7 @@ describe BankTools::DE::IbanBicConverter, ".run" do
     allow(Ibanomat).to receive(:find).and_raise("unknown error")
 
     expect {
-      BankTools::DE::IbanBicConverter.run(blz: blz, account: account)
+      BankTools::DE::IbanBicConverter.call(blz: blz, account: account)
     }.to raise_error(BankTools::DE::IbanBicConverter::UnknownError)
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banktools-de
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-25 00:00:00.000000000 Z
+date: 2015-05-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: attr_extras
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.3
+        version: '4'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 2.2.3
+        version: '4'
 - !ruby/object:Gem::Dependency
   name: ibanomat
   requirement: !ruby/object:Gem::Requirement