banktools-de 0.1.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ca4b1b8655d880bccbb522088b57d2ab6e9f7a9e
-  data.tar.gz: 96285492b404d41ee65f5dc88ea64e2c90558f22
+  metadata.gz: 59b514513c7f20f8507e5c1f7680f8f7b134e6c5
+  data.tar.gz: a45d5a67dd11410894a9ee0f41ace47af66a534c
 SHA512:
-  metadata.gz: 3378612a3861ac4de6f107b6d15dd94d6d01da6a84fde99edb38644e597b11ede90cc07ab7984ff1aa5b869c001abff518d11abea2a3c8e1a8d1cf4748eca07d
-  data.tar.gz: 047b4016b6ae95e62fe7abc5d123934ee4b7635586a691df432be34aa52a99da50dc08cf96522ea099987fcc806b45cfd6aaebd054a9436d13cfa6fcf1727ddf
+  metadata.gz: 4daaee0d8bacc9fb0db4cb6b002a77c3930a650c3e0146b48d20e310d8baf4ae1a095bbcae59eb295d44844c6b7b1d562ecf9c70cbdd49ffa2655ac8c7e70f24
+  data.tar.gz: cc6cae467328770ed2af664596920f91c4bf47830d48105a7ce40f0d4a2024514c13abef83528e2fb03e85dd4fb2aeed50bc35d485d3cf580b091439a2e12897

data/README.md

@@ -36,6 +36,12 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
     bad_account.valid?  # => false
     bad_account.errors  # => [:too_short]
 
+    # Convert BLZ and account number to IBAN/BIC
+
+    result = BankTools::DE::IbanBicConverter.run(blz: "37040044", account: "532013000")
+    result.iban  # => "DE89370400440532013000"
+    result.bic   # => "COBADEFFXXX"
+    # Or raises an exception.
 
 ## Tests
 
@@ -92,9 +98,15 @@ Or install it yourself as:
 * [Konto API online service](https://www.kontoapi.de)
 
 
-## Credits and license
+## Credits
+
+* [Henrik Nyh](http://henrik.nyh.se)
+* Tomas Skogberg
+* Victor Arias
+
+## License
 
-By [Henrik Nyh](http://henrik.nyh.se) for [Barsoom](http://barsoom.se) under the MIT license:
+MIT license:
 
 Copyright (c) 2014 Barsoom AB
 

data/banktools-de.gemspec

@@ -6,9 +6,9 @@ require 'banktools-de/version'
 Gem::Specification.new do |spec|
   spec.name          = "banktools-de"
   spec.version       = BankTools::DE::VERSION
-  spec.authors       = ["Henrik Nyh"]
-  spec.email         = ["henrik@nyh.se"]
-  spec.summary       = %q{Validate and normalize German Bankleitzahl (BLZ) and bank account numbers.}
+  spec.authors       = [ "Henrik Nyh" ]
+  spec.email         = [ "henrik@nyh.se" ]
+  spec.summary       = %q{Validate and normalize German Bankleitzahl (BLZ) and bank account numbers. Also it converts BLZ to IBAN/BIC.}
   spec.homepage      = ""
   spec.license       = "MIT"
 
@@ -17,7 +17,8 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency "attr_extras", "> 1.0"
+  spec.add_dependency "attr_extras", ">= 2.2.3"
+  spec.add_dependency "ibanomat"  # Convert BLZ to IBAN/BIC
   spec.add_development_dependency "bundler", "~> 1.5"
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec"

data/lib/banktools-de/iban_bic.rb

@@ -0,0 +1,40 @@
+require "ibanomat"
+require "attr_extras"
+
+class BankTools::DE::IbanBicConverter
+  class CouldNotConvertError < StandardError; end
+  class ServiceUnavailable < StandardError; end
+  class UnknownError < StandardError; end
+
+  class IbanBic
+    vattr_initialize :iban, :bic
+  end
+
+  method_object :run,
+    [ :blz!, :account! ]
+
+  def run
+    account_data = get_account_data
+    build_result(account_data)
+  end
+
+  private
+
+  def get_account_data
+    Ibanomat.find(bank_code: blz, bank_account_number: account)
+  rescue RestClient::RequestTimeout
+    raise ServiceUnavailable
+  rescue
+    raise UnknownError
+  end
+
+  def build_result(account_data)
+    # Non-"00" values represent an Ibanomat warning or error.
+    return_code = account_data.fetch(:return_code)
+    raise CouldNotConvertError unless return_code == "00"
+
+    iban = account_data.fetch(:iban)
+    bic  = account_data.fetch(:bic)
+    IbanBic.new(iban, bic)
+  end
+end

data/lib/banktools-de/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module DE
-    VERSION = "0.1.0"
+    VERSION = "0.3.0"
   end
 end

data/lib/banktools-de.rb

@@ -13,3 +13,4 @@ end
 require "banktools-de/version"
 require "banktools-de/blz"
 require "banktools-de/account"
+require "banktools-de/iban_bic"

data/spec/iban_bic_spec.rb

@@ -0,0 +1,40 @@
+require "spec_helper"
+require "banktools-de/iban_bic"
+
+describe BankTools::DE::IbanBicConverter, ".run" do
+  let(:blz) { "abc" }
+  let(:account) { "def" }
+
+  it "returns the BIC and IBAN" do
+    allow(Ibanomat).to receive(:find).and_return(iban: "some iban", bic: "some bic", return_code: "00")
+
+    actual = BankTools::DE::IbanBicConverter.run(blz: blz, account: account)
+
+    expect(actual.iban).to eq("some iban")
+    expect(actual.bic).to eq("some bic")
+  end
+
+  it "raises CouldNotConvertError on conversion errors" do
+    allow(Ibanomat).to receive(:find).and_return(return_code: "1")
+
+    expect {
+      BankTools::DE::IbanBicConverter.run(blz: blz, account: account)
+    }.to raise_error(BankTools::DE::IbanBicConverter::CouldNotConvertError)
+  end
+
+  it "raises ServiceUnavailable when the service is down" do
+    allow(Ibanomat).to receive(:find).and_raise(RestClient::RequestTimeout)
+
+    expect {
+      BankTools::DE::IbanBicConverter.run(blz: blz, account: account)
+    }.to raise_error(BankTools::DE::IbanBicConverter::ServiceUnavailable)
+  end
+
+  it "raises UnknownError on other errors" do
+    allow(Ibanomat).to receive(:find).and_raise("unknown error")
+
+    expect {
+      BankTools::DE::IbanBicConverter.run(blz: blz, account: account)
+    }.to raise_error(BankTools::DE::IbanBicConverter::UnknownError)
+  end
+end

metadata

@@ -1,83 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: banktools-de
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-22 00:00:00.000000000 Z
+date: 2014-04-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: attr_extras
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.2.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: 2.2.3
+- !ruby/object:Gem::Dependency
+  name: ibanomat
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.5'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: creek
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: 
@@ -87,7 +101,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - Gemfile
 - README.md
 - Rakefile
@@ -98,10 +112,12 @@ files:
 - lib/banktools-de/blz.rb
 - lib/banktools-de/blz_downloader.rb
 - lib/banktools-de/errors.rb
+- lib/banktools-de/iban_bic.rb
 - lib/banktools-de/version.rb
 - spec/account_spec.rb
 - spec/banktools_spec.rb
 - spec/blz_spec.rb
+- spec/iban_bic_spec.rb
 - spec/spec_helper.rb
 homepage: ''
 licenses:
@@ -113,22 +129,24 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.0
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Validate and normalize German Bankleitzahl (BLZ) and bank account numbers.
+  Also it converts BLZ to IBAN/BIC.
 test_files:
 - spec/account_spec.rb
 - spec/banktools_spec.rb
 - spec/blz_spec.rb
+- spec/iban_bic_spec.rb
 - spec/spec_helper.rb