banktools-de 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 980f50e63ec1df638d17eb3a714882f5bc8b726b
-  data.tar.gz: 50d8371a2e358e81803b62a69e8e4489c06b22e8
+  metadata.gz: 52950f7fe73d77a9ff04ebac2e51f0c796cc440d
+  data.tar.gz: 8a3cbb75535461c2b59d9ae73099d96c462ff23d
 SHA512:
-  metadata.gz: 9e24fbda49c753f995a5f1e31223e1661d7cd1818d53fdb1ce40b74cb4fef7b43cff13a9f2055dafb94e8853b4fdaabe0a73b2bc8f8d59c3970b2e4531ad3a4c
-  data.tar.gz: bdd45c2c83ca819a129fc4ea7817e14454196fa4b66da52e0dd0de4f2319aeb49283edbb0ddc1eacddd671628b0d78d732e41d43f5cf853631e3c8ba045c8cc6
+  metadata.gz: 873d235ac161487915dff8416ef6838323990bc9a2b510f3a295454dda7f8a5d8e0aac7a7558c8e7400ac50cc4ea15fb28c321c056e0de27dd955ffc1bd7ff1a
+  data.tar.gz: cd4f307835992c85d3e3b9e064ee754e656fda1bf6d5efc4f381408643b074b4540ba5a81c60519c55e212549ee9fd9901f5495d4765690dba5450cb0f7f854f

data/README.md

@@ -16,11 +16,12 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
     blz.valid?  # => true
     blz.errors  # => []
     blz.bank_name  # => "Deutsche Bank PGK Berlin"
+    BankTools::DE::BLZ.blz_to_bank_name  # => { "10070024" => "Deutsche Bank PGK Berlin", … }
 
     bad_blz = BankTools::DE::BLZ.new("1X")
     bad_blz.normalize  # => "1X"
     bad_blz.valid?  # => false
-    bad_blz.errors  # => [ :too_short, :invalid_characters ]
+    bad_blz.errors  # => [:too_short, :invalid_characters]
     blz.bank_name  # => nil
 
     # Account
@@ -33,14 +34,13 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
     bad_account = BankTools::DE::Account.new("1")
     bad_account.normalize  # => "1"
     bad_account.valid?  # => false
-    bad_account.errors  # => [ :too_short ]
+    bad_account.errors  # => [:too_short]
 
 
 ## Tests
 
     bundle
-    rspec
-    # or: rake
+    rspec  # or: rake
 
 
 ## Update BLZ data
@@ -58,7 +58,7 @@ providing a URL for the latest unpacked XLSX version of the data.
 
 You can provide a local path if you want.
 
-This will overwrite the local data file, which should ship with the gem.
+This will overwrite the data file in the code repository.
 
 Updates appear to ship for periods of 3 months, provided the month before a period starts. We've seen these periods:
 * 2013-09-09 - 2013-12-08
@@ -80,10 +80,16 @@ Or install it yourself as:
     $ gem install banktools-de
 
 
+## TODO
+
+* [Checksum validation](http://www.bundesbank.de/Navigation/DE/Kerngeschaeftsfelder/Unbarer_Zahlungsverkehr/Pruefzifferberechnung/pruefzifferberechnung.html)
+
+
 ## Also see
 
 * [BankTools::SE (Swedish)](https://github.com/barsoom/banktools-se)
 * [iban-tools](https://github.com/iulianu/iban-tools)
+* [Konto API online service](https://www.kontoapi.de)
 
 
 ## Credits and license

data/lib/bank_tools/de/blz.rb

@@ -10,11 +10,15 @@ require "yaml"
 module BankTools
   module DE
     class BLZ
-      MIN_LENGTH = MAX_LENGTH = 8
-      BLZ_TO_NAME_PATH = File.join(BankTools::DE.data_dir, "blz_to_name.yml")
+      LENGTH = 8
+      BLZ_TO_BANK_NAME_PATH = File.join(BankTools::DE.data_dir, "blz_to_name.yml")
 
       pattr_initialize :original_value
 
+      def self.blz_to_bank_name
+        @blz_to_bank_name ||= YAML.load_file(BLZ_TO_BANK_NAME_PATH).fetch(:data)
+      end
+
       def normalize
         if compacted_value.match(/\A(\d{3})(\d{3})(\d{2})\z/)
           "#$1 #$2 #$3"
@@ -29,20 +33,20 @@ module BankTools
 
       def errors
         errors = []
-        errors << Errors::TOO_SHORT if compacted_value.length < MIN_LENGTH
-        errors << Errors::TOO_LONG if compacted_value.length > MAX_LENGTH
+        errors << Errors::TOO_SHORT if compacted_value.length < LENGTH
+        errors << Errors::TOO_LONG if compacted_value.length > LENGTH
         errors << Errors::INVALID_CHARACTERS if compacted_value.match(/\D/)
         errors
       end
 
       def bank_name
-        blz_to_name.fetch(compacted_value, nil)
+        blz_to_bank_name.fetch(compacted_value, nil)
       end
 
       private
 
-      def blz_to_name
-        @blz_to_name ||= YAML.load_file(BLZ_TO_NAME_PATH).fetch(:data)
+      def blz_to_bank_name
+        self.class.blz_to_bank_name
       end
 
       def compacted_value

data/lib/bank_tools/de/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module DE
-    VERSION = "0.0.5"
+    VERSION = "0.0.6"
   end
 end

data/spec/blz_spec.rb

@@ -56,3 +56,11 @@ describe BankTools::DE::BLZ, "#bank_name" do
     expect(BankTools::DE::BLZ.new("X").bank_name).to be_nil
   end
 end
+
+describe BankTools::DE::BLZ, ".blz_to_bank_name" do
+  it "returns a hash mapping BLZs to bank names" do
+    actual = BankTools::DE::BLZ.blz_to_bank_name
+    expect(actual).to be_a(Hash)
+    expect(actual["10000000"]).to eq "BBk Berlin"
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banktools-de
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-16 00:00:00.000000000 Z
+date: 2014-01-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: attr_extras