banktools-de 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5453ad9542d81acd4a0653df094a95d8b2b3aeb0
-  data.tar.gz: 05623115c4c2e589c48878a538dcdbc81171dc0c
+  metadata.gz: 980f50e63ec1df638d17eb3a714882f5bc8b726b
+  data.tar.gz: 50d8371a2e358e81803b62a69e8e4489c06b22e8
 SHA512:
-  metadata.gz: 36a975456c36e233e0a3d5e42ccdab38ba9c88e0b17bd915e97b982fe0e5bd477f6795ca3c4af8c8b1ca4d7209410ad3e16ab38fac483a1ab7e1666017ec2f5c
-  data.tar.gz: c86193338004fc5df9262877e71608356064704ccbc0b0ca49d79d49bb5440768dbe2cf27a01f7f1fa500bdfeff8d83412d66739febea51e25d7816d643d2093
+  metadata.gz: 9e24fbda49c753f995a5f1e31223e1661d7cd1818d53fdb1ce40b74cb4fef7b43cff13a9f2055dafb94e8853b4fdaabe0a73b2bc8f8d59c3970b2e4531ad3a4c
+  data.tar.gz: bdd45c2c83ca819a129fc4ea7817e14454196fa4b66da52e0dd0de4f2319aeb49283edbb0ddc1eacddd671628b0d78d732e41d43f5cf853631e3c8ba045c8cc6

data/README.md

@@ -9,8 +9,6 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
 
 ## Usage
 
-(Very much in progress. Expect this list to change rapidly.)
-
     # BLZ
 
     blz = BankTools::DE::BLZ.new("10070024")
@@ -40,6 +38,7 @@ If we got anything wrong, please file an issue or contribute a fix yourself.
 
 ## Tests
 
+    bundle
     rspec
     # or: rake
 
@@ -52,6 +51,7 @@ Bundesbank provide a mapping from BLZ to bank name that appears to be updated re
 
 As a gem maintainer, run
 
+    bundle
     rake download URL="http://www.bundesbank.de/…/blz_2013_12_09_xls.xlsx?__blob=publicationFile"
 
 providing a URL for the latest unpacked XLSX version of the data.

data/data/blz_to_name.yml

@@ -1,6 +1,6 @@
 ---
-:generated_at: 2014-01-15 15:05:01.491807000 +01:00
-:generated_from_url: http://www.bundesbank.de/Redaktion/DE/Downloads/Kerngeschaeftsfelder/Unbarer_Zahlungsverkehr/Bankleitzahlen/2014_03_02/blz_2013_12_09_xls.xlsx?__blob=publicationFile#.xlsx
+:generated_at: 2014-01-15 15:21:26.199891000 +01:00
+:generated_from_url: http://www.bundesbank.de/Redaktion/DE/Downloads/Kerngeschaeftsfelder/Unbarer_Zahlungsverkehr/Bankleitzahlen/2014_03_02/blz_2013_12_09_xls.xlsx?__blob=publicationFile
 :data:
   '10000000': BBk Berlin
   '10010010': Postbank Berlin

data/lib/bank_tools/de/blz.rb

@@ -10,7 +10,7 @@ require "yaml"
 module BankTools
   module DE
     class BLZ
-      LENGTH = 8
+      MIN_LENGTH = MAX_LENGTH = 8
       BLZ_TO_NAME_PATH = File.join(BankTools::DE.data_dir, "blz_to_name.yml")
 
       pattr_initialize :original_value
@@ -29,8 +29,8 @@ module BankTools
 
       def errors
         errors = []
-        errors << Errors::TOO_SHORT if compacted_value.length < LENGTH
-        errors << Errors::TOO_LONG if compacted_value.length > LENGTH
+        errors << Errors::TOO_SHORT if compacted_value.length < MIN_LENGTH
+        errors << Errors::TOO_LONG if compacted_value.length > MAX_LENGTH
         errors << Errors::INVALID_CHARACTERS if compacted_value.match(/\D/)
         errors
       end
@@ -46,7 +46,7 @@ module BankTools
       end
 
       def compacted_value
-        original_value.to_s.gsub(/\s/, "")
+        original_value.to_s.gsub(/[\s-]/, "")
       end
     end
   end

data/lib/bank_tools/de/version.rb

@@ -1,5 +1,5 @@
 module BankTools
   module DE
-    VERSION = "0.0.4"
+    VERSION = "0.0.5"
   end
 end

data/spec/blz_spec.rb

@@ -30,8 +30,8 @@ end
 describe BankTools::DE::BLZ, "#errors" do
   Errors ||= BankTools::DE::Errors
 
-  it "is empty if there's 8 digits and possibly whitespace" do
-    expect(BankTools::DE::BLZ.new(" 123 456 78 ").errors).to be_empty
+  it "is empty when valid" do
+    expect(BankTools::DE::BLZ.new(" 123 456-78 ").errors).to be_empty
   end
 
   it "includes TOO_SHORT if below 8 characters" do
@@ -52,7 +52,7 @@ describe BankTools::DE::BLZ, "#bank_name" do
     expect(BankTools::DE::BLZ.new("10000000").bank_name).to eq "BBk Berlin"
   end
 
-  it "is provided if known" do
+  it "is nil if unknown" do
     expect(BankTools::DE::BLZ.new("X").bank_name).to be_nil
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banktools-de
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-15 00:00:00.000000000 Z
+date: 2014-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: attr_extras