bankster-client 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b719fbb94d277694b56663bab9c67c2622cef7da
-  data.tar.gz: e02d1bf64b21d4b4e40d973fb5b0a19c79b26a0c
+  metadata.gz: 64029ea6a27e2f54eff6adc40ead807eeb5cb2df
+  data.tar.gz: f30e871a722a0dc02100b5112a905249d5dd4ddf
 SHA512:
-  metadata.gz: dba22f2217678f053b8ee30c9a3e067e33de25e7bf2f28476315a245f5bcd63655ab41580a38dddd949e18a9eb6f9580419c50dbcc1658f515f937df5e7ba6e3
-  data.tar.gz: 7a803a95da9ab57b45e055b00b93082fe68b249f017901b1c8e48e04f4f45dc1c4de51d584873a20f3ec8e47dc8a0e75a372f0b6d2ffed5aa114d30ba4e4831d
+  metadata.gz: a5f465a79af34f299f641455ea00682bdf541a8e47dc503817c6e45425f1525128e7a91dae3aace145b1d9c03c120c416333ef1456dd0663bd4ab448889f0e8b
+  data.tar.gz: 26e47bad8d480207e095fb7ba176452b1bb21fd84515de8eac0868ecfedcccf5e36909aa6621ba74ca4f86ba56227aef9e3e4f2493462cb30881494495138812

data/.gitignore

@@ -8,3 +8,4 @@
 /spec/reports/
 /tmp/
 *.gem
+.byebug_history

data/.rubocop.yml

@@ -1,3 +1,6 @@
+AllCops:
+  TargetRubyVersion: 2.3
+
 Metrics/LineLength:
   Max: 200
 

data/Gemfile

@@ -1,9 +1,11 @@
+# frozen_string_literal: true
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in bankster-client.gemspec
 gemspec
 
 gem 'rubocop', require: false
+gem 'byebug'
 
 group :test do
   gem 'webmock'

data/README.md

@@ -6,9 +6,9 @@ A tiny http wrapper for bankster.io
 
 Add this line to your application's Gemfile:
 
-```ruby
-gem 'bankster-client'
-```
+  ```ruby
+  gem 'bankster-client'
+  ```
 
 And then execute:
 
@@ -20,26 +20,51 @@ Or install it yourself as:
 
 ## Usage
 
-```ruby
-bank_credentials = Bankster::BankCredentials::Hbci.new({
-  url:        'https://hbci11.fiducia.de/cgi-bin/hbciservlet',
-  bank_code:  '67290000',
-  user_id:    'my_hbci_user_id',
-  pin:        'my_hbci_pin'
-})
-api_key = '9daad1ea407b91745d99e78ec1602110'
+Bankster::Client can be configured globaly or on instance level. 
 
-bankster_client = Bankster::Client.new(bank_credentials, api_key)
+### Global Configuration:
 
-transactions = bankster_client.transactions('my_account_number', Date.new(2016,5,1), Date.new(2016,5,11))
-```
+  ```ruby
+  Bankster::Client.configure do
+    api_key = "my_api_key"
+    api_url = "http://bankster.io"
+    credentials = some_bankster_credentials
+  end
+  ```
 
-To override the hostname where the bankster-proxy resides, define 
+Afterwards, the Bankster::Client can be initialized:
 
-```ruby
-BANSTER_BASE_URI = 'http://localhost:9292'
-```
 
+  ```ruby
+  client = Bankster::Client.new
+  ```
+
+### Configure every instance:
+
+If configuration params are given to the initializer, they override an existing global configuration:
+
+  ```ruby
+  client = Bankster::Client.new(credentials: hbci_credentials, api_key: 'my_key', base_uri: 'http://some_host')
+  ```
+
+## Credentials
+
+Credentials are one of `Bankster::BankCredentials::Hbci` or `Bankster::BankCredentials::Ebics`, e.g.:
+
+  ```ruby
+  hbci_credentials = Bankster::BankCredentials::Hbci.new({
+    url:        'https://hbci11.fiducia.de/cgi-bin/hbciservlet',
+    bank_code:  '67290000',
+    user_id:    'my_hbci_user_id',
+    pin:        'my_hbci_pin'
+  })
+  ```
+
+## Receiving transactions
+
+  ```ruby
+  transactions = client.transactions('my_account_number', Date.new(2016,5,1), Date.new(2016,5,11))
+  ```
 
 ## Development
 

data/Rakefile

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 

data/bankster-client.gemspec

@@ -1,10 +1,11 @@
 # coding: utf-8
+# frozen_string_literal: true
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'bankster-client'
-  spec.version       = '0.0.5'
+  spec.version       = '0.0.6'
   spec.authors       = ['Roman Lehnert', 'Alexander Klaiber']
   spec.email         = ['mail@bankster.io']
 
@@ -25,9 +26,9 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_runtime_dependency 'httparty'
-  spec.add_runtime_dependency 'bankster-bank_credentials'
+  spec.add_runtime_dependency 'bankster-bank_credentials', '~> 0.1.5'
 
   spec.add_development_dependency 'bundler', '~> 1.12'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 11.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
 end

data/bin/console

@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'bankster/client'

data/lib/bankster/client.rb

@@ -0,0 +1,7 @@
+# frozen_string_literal: true
+require 'httparty'
+require 'bankster/bank_credentials'
+
+require_relative 'client/configuration'
+require_relative 'client/client'
+require_relative 'client/bank_account'

data/lib/{bankster_client → bankster/client}/bank_account.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module BanksterClient
   class BankAccount
     attr_reader :owner, :iban, :bic

data/lib/{bankster_client → bankster/client}/client.rb

@@ -1,13 +1,25 @@
-module BanksterClient
+# frozen_string_literal: true
+module Bankster
   class Client
     include HTTParty
 
-    def initialize
+    attr_reader :credentials
+
+    def self.configuration
+      Configuration.instance
+    end
+
+    def self.configure
+      yield Configuration.instance
+    end
+
+    def initialize(credentials)
+      @credentials = credentials
       @options = {
-        base_uri: BanksterClient.configuration.api,
+        base_uri: self.class.configuration.api_url,
         headers: {
-          'Api-Key' => BanksterClient.configuration.api_key,
-          'Bank-Credentials' => Base64.urlsafe_encode64(BanksterClient.configuration.credentials.to_json)
+          'Api-Key': self.class.configuration.api_key,
+          'Bank-Credentials': encoded_credentials
         }
       }
     end
@@ -32,7 +44,14 @@ module BanksterClient
         }
       )
       response = self.class.post('/transfers', attributes)
-      raise(response.body) unless response.ok?
+      raise(response.body) if !response.code.eql?(200) && !response.code.eql?(201)
+    end
+
+    private
+
+    def encoded_credentials
+      raise 'No credentials given' unless credentials
+      credentials.encode
     end
   end
 end

data/lib/bankster/client/configuration.rb

@@ -0,0 +1,17 @@
+# frozen_string_literal: true
+require 'singleton'
+
+module Bankster
+  class Client
+    class Configuration
+      include Singleton
+
+      attr_accessor :api_url
+      attr_accessor :api_key
+
+      def initialize
+        @api_url = 'http://bankster-proxy-prod.eu-central-1.elasticbeanstalk.com'
+      end
+    end
+  end
+end

data/samples/ebic_transactions.rb

@@ -0,0 +1,20 @@
+# frozen_string_literal: true
+require '../lib/bankster/client'
+
+Bankster::Client.configure do |config|
+  config.api_url = ''
+  config.api_key = ''
+end
+
+credentials = Bankster::BankCredentials::Ebics.new(
+  key: '',
+  user_id: '',
+  passphrase: '',
+  host_id: '',
+  partner_id: '',
+  url: ''
+)
+
+client = Bankster::Client.new(credentials)
+
+puts client.transactions('100490016', Date.new(2016, 7, 22), Date.new(2016, 7, 22))

data/samples/ebic_transfer.rb

@@ -0,0 +1,30 @@
+# frozen_string_literal: true
+require '../lib/bankster/client'
+
+Bankster::Client.configure do |config|
+  config.api_url = ''
+  config.api_key = ''
+end
+
+credentials = Bankster::BankCredentials::Ebics.new(
+  key: '',
+  user_id: '',
+  passphrase: '',
+  host_id: '',
+  partner_id: '',
+  url: ''
+)
+
+client = Bankster::Client.new(credentials)
+
+sending_account = BanksterClient::BankAccount.new('', '', '')
+receiving_account = BanksterClient::BankAccount.new('', '', '')
+
+puts client.transfer(
+  sending_account,
+  receiving_account,
+  1000,
+  'S UL 671891175',
+  '5791ffa538f8846d596accdb',
+  '5791ffa538f8846d596accdb'
+)

data/samples/hbci_transactions.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+require '../lib/bankster/client'
+
+Bankster::Client.configure do |config|
+  config.api_url = ''
+  config.api_key = ''
+end
+
+credentials = Bankster::BankCredentials::Hbci.new(
+  url: '',
+  bank_code: '',
+  user_id: '',
+  pin: ''
+)
+
+client = Bankster::Client.new(credentials)
+
+puts client.transactions('490016', Date.new(2016, 7, 22), Date.new(2016, 7, 22))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bankster-client
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Roman Lehnert
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-07-12 00:00:00.000000000 Z
+date: 2016-08-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -29,16 +29,16 @@ dependencies:
   name: bankster-bank_credentials
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.1.5
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 0.1.5
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -59,14 +59,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '11.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '11.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -101,11 +101,13 @@ files:
 - bankster-client.gemspec
 - bin/console
 - bin/setup
-- lib/bankster_client.rb
-- lib/bankster_client/bank_account.rb
-- lib/bankster_client/client.rb
-- lib/bankster_client/configuration.rb
-- lib/bankster_client/version.rb
+- lib/bankster/client.rb
+- lib/bankster/client/bank_account.rb
+- lib/bankster/client/client.rb
+- lib/bankster/client/configuration.rb
+- samples/ebic_transactions.rb
+- samples/ebic_transfer.rb
+- samples/hbci_transactions.rb
 homepage: http://bankster.io
 licenses:
 - MIT

data/lib/bankster_client.rb

@@ -1,16 +0,0 @@
-require 'httparty'
-require 'bankster/bank_credentials'
-
-require_relative 'bankster_client/configuration'
-require_relative 'bankster_client/client'
-require_relative 'bankster_client/bank_account'
-
-module BanksterClient
-  def self.configuration
-    Configuration.instance
-  end
-
-  def self.configure
-    yield Configuration.instance
-  end
-end

data/lib/bankster_client/configuration.rb

@@ -1,17 +0,0 @@
-require 'singleton'
-
-module BanksterClient
-  class Configuration
-    include Singleton
-
-    attr_accessor :api, :api_key
-
-    def credentials=(credentials)
-      @hbci_credentials = Bankster::BankCredentials::Hbci.new(credentials)
-    end
-
-    def credentials
-      @hbci_credentials
-    end
-  end
-end

data/lib/bankster_client/version.rb

@@ -1,3 +0,0 @@
-module BanksterClient
-  VERSION = '0.0.1'.freeze
-end