bankscrap 2.0.1 → 2.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: b5efc7e5d7389c86940e835e58f1e472a21c798e
-  data.tar.gz: fbe0edfb17bf2f8bd6a187a76b9dc526eb9fa493
+  metadata.gz: 13c569f9c25d7e6f84690e4c1bab9d8a2a00f5ed
+  data.tar.gz: e76f218f60aa54069fb20e3384bc4004f6f64d10
 SHA512:
-  metadata.gz: 1b157a5484ebc5246b58707278693d818b334da890460ad0cd9e4ae04a05bb524aecd215c005a3ea4ddaead74978294ce505ba51a641a9f59b6ea15135179058
-  data.tar.gz: 29ebadde8aaafd5f182f83649cefffdebb67002abd7dcbca896e35908e55fa3dfb2b756c51cc5de79f99d3e1f40a45189e5976cc0f9b8291edc7031a812f2e2d
+  metadata.gz: 8ecdb3929fde61194a69ff1fa5cfb503d94e7c00441d954cc84bc053173ae931a10fcda0a6d9df0292065b64b922bcb3913b11bdee03b09ac45a510d3acc02fb
+  data.tar.gz: 154449817ea77620bb04559bdb1f084f5aa798d547bf08ec60e400407dcd465fe041876961a018f1b4ea3e1d1c89b35da9339727bb94cfb756381d27be69faef

data/README.md

@@ -1,7 +1,8 @@
-# 💸 Bankscrap 💸 
+# 💸 Bankscrap 💸
 
 [![](http://188.166.39.57:3000/badge.svg)](http://188.166.39.57:3000)
-![build status](https://travis-ci.org/bankscrap/bankscrap.svg?branch=master)
+[![Gem Version](https://badge.fury.io/rb/bankscrap.svg)](https://badge.fury.io/rb/bankscrap)
+[![Build Status](https://travis-ci.org/bankscrap/bankscrap.svg?branch=master)](https://travis-ci.org/bankscrap/bankscrap)
 
 Ruby gem to extract account balance and transactions from banks. You can use it either as command line tool or as a library.
 
@@ -14,6 +15,8 @@ Feel free to contribute and add your bank if it isn't supported.
 * **ING Direct**: [bankscrap-ing](https://github.com/bankscrap/bankscrap-ing)
 * **Arquia Banca**: [bankscrap-arquia](https://github.com/bankscrap/bankscrap-arquia)
 * **Banc Sabadell** (WIP): [bankscrap-banc-sabadell](https://github.com/bankscrap/bankscrap-banc-sabadell)
+* **Santander** (WIP): [bankscrap-santander](https://github.com/bankscrap/bankscrap-santander)
+* **Openbank** (WIP): [bankscrap-openbank](https://github.com/bankscrap/bankscrap-openbank)
 
 Interested in any other bank? Open a new Issue and we'll try to help.
 
@@ -60,7 +63,7 @@ Note that you only need to install the gem for your selected bank – the main g
 
 ###### BBVA
 
-    $ bankscrap balance YourBank --credentials=user:YOUR_BANK_USER password:YOUR_BANK_PASSWORD
+    $ bankscrap balance BBVA --credentials=user:YOUR_BANK_USER password:YOUR_BANK_PASSWORD
 
 ###### ING Direct
 ING needs one more argument: your birthday.
@@ -76,7 +79,7 @@ Replace 01/01/1980 with your actual birthday.
 
 ###### ING Direct
 
-    $ bankscrap transactions ING --credentials=nif:YOUR_DNI password:YOUR_BANK_PASSWORD birthday:01/01/1980
+    $ bankscrap transactions ING --credentials=dni:YOUR_DNI password:YOUR_BANK_PASSWORD birthday:01/01/1980
 
 #### Transactions with date range
 
@@ -86,7 +89,7 @@ Replace 01/01/1980 with your actual birthday.
 
 By default it will use your first bank account, if you want to fetch transactions for a different account you can use this syntax:
 
-    $ bankscrap transactions YourBank --iban "your_iban" --credentials=user:YOUR_BANK_USER password:YOUR_BANK_PASSWORD 
+    $ bankscrap transactions YourBank --iban "your_iban" --credentials=user:YOUR_BANK_USER password:YOUR_BANK_PASSWORD
 
 If you don't want to pass your user and password everytime you can define them in your .bash_profile by adding:
 
@@ -94,7 +97,7 @@ If you don't want to pass your user and password everytime you can define them i
     export BANKSCRAP_[BANK_NAME]_PASSWORD=YOUR_BANK_USER
     export BANKSCRAP_[BANK_NAME]_ANY_OTHER_CREDENTIAL=ANY_OTHER_CREDENTIAL
 
-eg: 
+eg:
     export BANKSCRAP_BBVA_NET_CASH_USER=YOUR_BANK_USER
 
 
@@ -116,7 +119,7 @@ bbva = Bankscrap::BBVA::Bank.new(user: YOUR_BBVA_USER, password: YOUR_BBVA_PASSW
 
 # ING
 require 'bankscrap-ing'
-ing = Bankscrap::ING::Bank.new(nif: YOUR_NIF, password: YOUR_ING_PASSWORD, birthday: "dd/mm/yyyy")
+ing = Bankscrap::ING::Bank.new(dni: YOUR_DNI, password: YOUR_ING_PASSWORD, birthday: "dd/mm/yyyy")
 ```
 
 
@@ -129,6 +132,7 @@ bank.accounts
 ```
 
 And get its balance:
+
 ```ruby
 bank.accounts.first.balance
 ```
@@ -148,7 +152,20 @@ account.transactions = account.fetch_transactions(start_date: Date.today - 1.yea
 account.transactions
 ```
 
+### From Ruby code (with IRB, useful when developing)
+
+In the terminal:
+
+```
+irb -I lib/ -r 'bankscrap'
+```
 
+After that, you can use your bank adapter as usual:
+
+```ruby
+require 'bankscrap-ing'
+ing = Bankscrap::ING::Bank.new(dni: YOUR_DNI, password: YOUR_ING_PASSWORD, birthday: "dd/mm/yyyy")
+```
 
 ## Contributing
 

data/generators/adapter_generator.rb

@@ -5,21 +5,21 @@ module Bankscrap
     argument :bank_name
 
     def self.source_root
-       File.join(File.dirname(__FILE__), 'templates')
+      File.join(File.dirname(__FILE__), 'templates')
     end
 
     def generate
       self.destination_root = File.expand_path('.', gem_name)
       directory '.'
 
-      say ""
+      say ''
       say "Great! Now you can start implementing your bank's adapter for Bankscrap.", :yellow
-      say ""
-      say "To get started take a look to:", :yellow
+      say ''
+      say 'To get started take a look to:', :yellow
       say "#{destination_root}/lib/bankscrap/#{bank_name_dasherized}/bank.rb", :yellow
-      say ""
-      say "If you need help you can join our Slack chat room. Click the Slack badge on Github:", :yellow
-      say "https://github.com/bankscrap/bankscrap", :yellow
+      say ''
+      say 'If you need help you can join our Slack chat room. Click the Slack badge on Github:', :yellow
+      say 'https://github.com/bankscrap/bankscrap', :yellow
     end
 
     protected
@@ -27,6 +27,7 @@ module Bankscrap
     def bank_name_dasherized
       @bank_name_dasherized ||= bank_name.underscore.dasherize
     end
+
     def gem_name
       @gem_name ||= 'bankscrap-' + bank_name_dasherized
     end
@@ -35,4 +36,4 @@ module Bankscrap
       @module_name ||= bank_name
     end
   end
-end
+end

data/generators/templates/lib/bankscrap/%bank_name_dasherized%/bank.rb.tt

@@ -13,7 +13,7 @@ module Bankscrap
 
       # TODO: change this for the proper credentials required in your adapter.
       # It can be anything (user, birthday, ID, whatever you need).
-      REQUIRED_CREDENTIALS  = [:user, :password, :any_other_credential]
+      REQUIRED_CREDENTIALS  = %i(user password any_other_credential).freeze
 
       def initialize(credentials = {})
         super do
@@ -21,9 +21,7 @@ module Bankscrap
           # or add custom headers to the HTTP client
 
           # user_agent = SecureRandom.hex(32).upcase + ';Android;LGE;Nexus 5;1080x1776;Android;5.1.1;BMES;4.4;xxhd'
-          # add_headers(
-          #   'User-Agent' => user_agent
-          # )
+          # add_headers('User-Agent' => user_agent)
         end
       end
 
@@ -79,7 +77,7 @@ module Bankscrap
           amount: REPLACE_ME, # Should be a Money object
           description: REPLACE_ME,
           effective_date: REPLACE_ME,
-          currency: REPLACE_ME, 
+          currency: REPLACE_ME,
           balance: REPLACE_ME  # Should be a Money object
         )
       end

data/lib/bankscrap/account.rb

@@ -1,9 +1,9 @@
 module Bankscrap
   class Account
     include Utils::Inspectable
-    
-    attr_accessor :bank, :id, :name, :balance, 
-                  :available_balance, :description, 
+
+    attr_accessor :bank, :id, :name, :balance,
+                  :available_balance, :description,
                   :transactions, :iban, :bic
 
     def initialize(params = {})

data/lib/bankscrap/bank.rb

@@ -7,22 +7,18 @@ module Bankscrap
                      'like Gecko) Chrome/18.0.1025.166 Mobile Safari/535.19'.freeze
     attr_accessor :headers, :accounts, :investments
 
-    REQUIRED_CREDENTIALS = [:user, :password] 
+    REQUIRED_CREDENTIALS = %i(user password).freeze
 
     class MissingCredential < ArgumentError; end
 
     def initialize(credentials = {})
-      # Assign required credentials as env vars. 
+      # Assign required credentials as env vars.
       # If empty, use ENV vars as fallback:
       # BANKSCRAP_MY_BANK_USER, BANKSCRAP_MY_BANK_PASWORD, etc.
       self.class::REQUIRED_CREDENTIALS.each do |field|
         value = credentials.with_indifferent_access[field] || ENV["#{env_vars_prefix}_#{field.upcase}"]
-
-        if value.blank?
-          raise MissingCredential, "Missing credential: '#{field}'"
-        else
-          instance_variable_set("@#{field}", value)
-        end
+        raise MissingCredential, "Missing credential: '#{field}'" if value.blank?
+        instance_variable_set("@#{field}", value)
       end
 
       initialize_http_client
@@ -34,9 +30,7 @@ module Bankscrap
       @accounts = fetch_accounts
 
       # Not all the adapters have support for investments
-      if self.respond_to?(:fetch_investments)
-        @investments = fetch_investments
-      end
+      @investments = fetch_investments if respond_to?(:fetch_investments)
     end
 
     # Interface method placeholders
@@ -112,7 +106,7 @@ module Bankscrap
 
     # Prefix for env vars used to store credentials
     def env_vars_prefix
-      self.class.parent.name.underscore.upcase.gsub('/', '_')
+      self.class.parent.name.underscore.upcase.tr('/', '_')
     end
   end
 end

data/lib/bankscrap/cli.rb

@@ -1,10 +1,9 @@
 require 'thor'
 require 'active_support/core_ext/string'
-Dir[File.expand_path("../../..", __FILE__) + "/generators/*.rb"].each do |generator|
+Dir[File.expand_path('../../..', __FILE__) + '/generators/*.rb'].each do |generator|
   require generator
 end
 
-
 module Bankscrap
   class CLI < Thor
     def self.shared_options
@@ -59,12 +58,11 @@ module Bankscrap
 
       say "Transactions for: #{account.description} (#{account.iban})", :cyan
       print_transactions_header
-      transactions.each { |t|  print_transaction(t) }
+      transactions.each { |t| print_transaction(t) }
     end
 
-
-    register(Bankscrap::AdapterGenerator, "generate_adapter", "generate_adapter MyBankName", 
-      "generates a template for a new Bankscrap bank adapter")
+    register(Bankscrap::AdapterGenerator, 'generate_adapter', 'generate_adapter MyBankName',
+             'generates a template for a new Bankscrap bank adapter')
 
     private
 
@@ -113,18 +111,18 @@ module Bankscrap
 
     def print_transactions_header
       say "\n"
-      say "DATE".ljust(13)
-      say "DESCRIPTION".ljust(50) + "\s\s\s"
-      say "AMOUNT".rjust(15) + "\s\s\s"
-      say "BALANCE".rjust(15)
-      say "-" * 99 
+      say 'DATE'.ljust(13)
+      say 'DESCRIPTION'.ljust(50) + '   '
+      say 'AMOUNT'.rjust(15) + '   '
+      say 'BALANCE'.rjust(15)
+      say '-' * 99
     end
 
     def print_transaction(transaction)
       color = (transaction.amount > Money.new(0) ? :green : :red)
-      say transaction.effective_date.strftime('%d/%m/%Y') + "\s\s\s"
-      say transaction.description.squish.truncate(50).ljust(50) + "\s\s\s", color
-      say transaction.amount.format.rjust(15) + "\s\s\s", color
+      say transaction.effective_date.strftime('%d/%m/%Y') + '   '
+      say transaction.description.squish.truncate(50).ljust(50) + '   ', color
+      say transaction.amount.format.rjust(15) + '   ', color
       say transaction.balance.format.rjust(15)
     end
   end

data/lib/bankscrap/investment.rb

@@ -11,9 +11,7 @@ module Bankscrap
     private
 
     def inspect_attributes
-      [
-        :id, :name, :balance, :currency, :investment
-      ]
+      %i(id name balance currency investment)
     end
   end
 end

data/lib/bankscrap/transaction.rb

@@ -2,8 +2,7 @@ module Bankscrap
   class Transaction
     include Utils::Inspectable
 
-    attr_accessor :id, :amount, :description, :effective_date,
-                  :balance, :account
+    attr_accessor :id, :amount, :description, :effective_date, :balance, :account
 
     def initialize(params = {})
       raise NotMoneyObjectError.new(:amount) unless params[:amount].is_a?(Money)
@@ -26,7 +25,7 @@ module Bankscrap
     private
 
     def inspect_attributes
-      [ :id, :amount, :effective_date, :description, :balance ]
+      %i(id amount effective_date description balance)
     end
   end
 end

data/lib/bankscrap/utils/inspectable.rb

@@ -12,7 +12,7 @@ module Bankscrap
         end.map do |attribute|
           "#{attribute}: #{send(attribute).inspect}"
         end.join ' '
-        "#<#{self.class.name}:#{sprintf('0x%x', object_id)} #{attributes}>"
+        "#<#{self.class.name}:#{format('0x%x', object_id)} #{attributes}>"
       end
     end
   end

data/lib/bankscrap/version.rb

@@ -1,3 +1,3 @@
 module Bankscrap
-  VERSION = '2.0.1'.freeze
+  VERSION = '2.0.2'.freeze
 end

data/lib/bankscrap.rb

@@ -24,8 +24,7 @@ module Bankscrap
     end
   end
 
-
   self.log = false
   self.debug = false
-  # self.proxy = {host: 'localhost', port: 8888}
-end
+  # self.proxy = { host: 'localhost', port: 8888 }
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bankscrap
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.0.2
 platform: ruby
 authors:
 - Javier Cuevas
@@ -9,140 +9,106 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-16 00:00:00.000000000 Z
+date: 2017-02-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '10.0'
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.5.1
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '3.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.5.1
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.39.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.39.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 3.4.0
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.19'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: mechanize
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.7.4
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 2.7.4
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: money
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.5.0
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 6.5.0
+        version: '0'
 description: Command line tools to get bank account details from some banks.
 email:
 - javi@diacode.com
@@ -195,7 +161,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.8
 signing_key: 
 specification_version: 4
 summary: Get your bank account details.