bankocr 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0c718e8a72b9c3926e904bd07c21637270d96ccc
-  data.tar.gz: 78622c054b4183e0f6b022aedd5cdf492dd2b8e3
+  metadata.gz: 26e0d3a1fb2759af164b58e10b12692ba0d7b178
+  data.tar.gz: 85168f078496ca138a3b6392112a91de7192bd74
 SHA512:
-  metadata.gz: 0fd91b34998b1be1886fff104925b24ebcbe871848ad35f069da570d6f075def69336f6b96f412983f7d236b03c0f54fd9d00ae82778db30aa04fd9ce061fb4c
-  data.tar.gz: 77f43c26adb1c807c338d56ba8b38779e6bcb54a9657100394b9ab86ce373c093bf662bac25604f5e3bbfa6f41ff409264d6132515d45ba2006b6627f7bcb06e
+  metadata.gz: 5aa4456636276c3ddc3472c9e7818058cba091956b3ac9837a621e6b49100588fa76a6722d77d98ebeb13e05abac67462b860c5f7f23384d937501edbe529783
+  data.tar.gz: f1256f6172a86841528e25f2b197cf85794843e750725e30877141c372ad3e20625d3840c30587c5bad39c1ab97f64650b2006363a560863ab9587a728ac022f

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bankocr (0.0.4)
+    bankocr (0.0.5)
       thor (~> 0.19)
 
 GEM

data/bin/bankocr

@@ -5,8 +5,7 @@ require 'bankocr'
 
 module BankOCR
   class ProcessCommand < Thor
-    desc 'process input_path output_path',
-      'Generates a report for account numbers read from input'
+    desc 'process input_path output_path', 'Create report for account numbers'
 
     def process(input, output)
       BankOCR.process(input, output)

data/lib/account_number.rb

@@ -7,11 +7,11 @@ module BankOCR
     end
 
     def valid?
-      @valid ||= sum(@digits) % 11 == 0
+      @valid ||= sum(to_s) % 11 == 0
     end
 
     def to_s
-      @digits
+      @digits.map(&:value).join
     end
 
     private

data/lib/bankocr/version.rb

@@ -1,3 +1,3 @@
 module BankOCR
-  VERSION = '0.0.4'
+  VERSION = '0.0.5'
 end

data/lib/bankocr.rb

@@ -6,6 +6,7 @@ module BankOCR
   autoload :FileParser,      'file_parser'
   autoload :AccountNumber,   'account_number'
   autoload :ReportGenerator, 'report_generator'
+  autoload :Digit,           'digit'
 
   def self.process(input, output)
     account_numbers = BankOCR::FileParser.new(input).entries

data/lib/digit.rb

@@ -0,0 +1,43 @@
+module BankOCR
+  class Digit
+    attr_reader :value, :shape
+
+    def initialize(shape)
+      @shape = shape
+      @value = CONVERSIONS[shape] || '?'
+    end
+
+    CONVERSIONS = {
+      ' _ ' /
+      '| |' /
+      '|_|' => '0',
+      '   ' /
+      '  |' /
+      '  |' => '1',
+      ' _ ' /
+      ' _|' /
+      '|_ ' => '2',
+      ' _ ' /
+      ' _|' /
+      ' _|' => '3',
+      '   ' /
+      '|_|' /
+      '  |' => '4',
+      ' _ ' /
+      '|_ ' /
+      ' _|' => '5',
+      ' _ ' /
+      '|_ ' /
+      '|_|' => '6',
+      ' _ ' /
+      '  |' /
+      '  |' => '7',
+      ' _ ' /
+      '|_|' /
+      '|_|' => '8',
+      ' _ ' /
+      '|_|' /
+      ' _|' => '9'
+    }
+  end
+end

data/lib/file_parser.rb

@@ -6,15 +6,15 @@ module BankOCR
     end
 
     def entries
-      @entries || read_entries
+      @digits || read_entries
     end
 
     def read_entries
-      @entries = []
+      @digits = []
       file     = File.open(@input_path)
-      @entries << parse_entry(file) until file.eof?
+      @digits << parse_entry(file) until file.eof?
 
-      @entries.map{|e| BankOCR::AccountNumber.new(e) }
+      @digits.map { |d| BankOCR::AccountNumber.new(d) }
     rescue
       p 'Error reading input file, please validate'
       []
@@ -30,30 +30,17 @@ module BankOCR
       bottom = file.readline
       _blank = file.readline
 
-      entry_to_digits(top, middle, bottom)
+      build_digit(top, middle, bottom)
     end
 
-    def entry_to_digits(top, middle, bottom)
+    def build_digit(top, middle, bottom)
       (0..8).map do |i|
         low   = (i * 3)
         high  = ((i + 1) * 3) - 1
         shape = top[low..high] + middle[low..high] + bottom[low..high]
 
-        conversions[shape] || '?'
-      end.join
-    end
-
-    def conversions
-      { ' _ | ||_|' => '0',
-        '     |  |' => '1',
-        ' _  _||_ ' => '2',
-        ' _  _| _|' => '3',
-        '   |_|  |' => '4',
-        ' _ |_  _|' => '5',
-        ' _ |_ |_|' => '6',
-        ' _   |  |' => '7',
-        ' _ |_||_|' => '8',
-        ' _ |_| _|' => '9' }
+        BankOCR::Digit.new(shape)
+      end
     end
   end
 end

data/lib/report_generator.rb

@@ -25,6 +25,5 @@ module BankOCR
         ' ERR'
       end
     end
-
   end
 end

data/spec/lib/account_number_spec.rb

@@ -2,15 +2,21 @@ require 'bankocr'
 
 describe BankOCR::AccountNumber do
 
+  def digits(string)
+    string.split('').map do |c|
+      shape = BankOCR::Digit::CONVERSIONS.keys[c.to_i]
+      BankOCR::Digit.new(shape)
+    end
+  end
+
   context 'when validating account numbers' do
 
     let(:valid_numbers)   { %w(711111111b 123456789 490867715) }
     let(:invalid_numbers) { %w(888888888 490067715 012345678) }
-    let(:wrong_numbers)   { %w(86110?356) }
 
     it 'validates valid account numbers' do
       valid_numbers.each do |n|
-        account = described_class.new(n)
+        account = described_class.new(digits(n))
 
         expect(account.valid?).to eq(true)
       end
@@ -18,15 +24,7 @@ describe BankOCR::AccountNumber do
 
     it 'validates invalid account numbers' do
       invalid_numbers.each do |n|
-        account = described_class.new(n)
-
-        expect(account.valid?).to eq(false)
-      end
-    end
-
-    it 'validates wrong account numbers' do
-      wrong_numbers.each do |n|
-        account = described_class.new(n)
+        account = described_class.new(digits(n))
 
         expect(account.valid?).to eq(false)
       end

data/spec/lib/report_generator_spec.rb

@@ -4,9 +4,9 @@ describe BankOCR::ReportGenerator do
 
   let(:accounts) do
     [
-      BankOCR::AccountNumber.new('457508000'),
-      BankOCR::AccountNumber.new('664371495'),
-      BankOCR::AccountNumber.new('86110??36')
+      double('account', :to_s => '457508000', :valid? => true),
+      double('account', :to_s => '664371495', :valid? => false),
+      double('account', :to_s => '86110??36', :valid? => false)
     ]
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bankocr
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Javier Cervantes
@@ -72,6 +72,7 @@ files:
 - lib/account_number.rb
 - lib/bankocr.rb
 - lib/bankocr/version.rb
+- lib/digit.rb
 - lib/file_parser.rb
 - lib/report_generator.rb
 - spec/bin/bankocr_spec.rb