bankocr 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 88a16391bafc7e1f8c59f0d1490d5ec75ddadb1a
-  data.tar.gz: 9cd73c8055978b7732ca36a0700077536ab03424
+  metadata.gz: 0c718e8a72b9c3926e904bd07c21637270d96ccc
+  data.tar.gz: 78622c054b4183e0f6b022aedd5cdf492dd2b8e3
 SHA512:
-  metadata.gz: ed392b2fce5cf57bea88fc1a57348d6743f793523685e7faabd6e7976fb1d5efc036c9c14bad397e07a80d1f367323cf860fcd2821914d2a33bbb4b7496a2e98
-  data.tar.gz: 41b514e56b802f7192291033b577e58a00697f57008ed44f16fe1777c23b28e7f1c9547e27713ec4fb0479a353916381d03f71305802d40bb3548bddaae4af75
+  metadata.gz: 0fd91b34998b1be1886fff104925b24ebcbe871848ad35f069da570d6f075def69336f6b96f412983f7d236b03c0f54fd9d00ae82778db30aa04fd9ce061fb4c
+  data.tar.gz: 77f43c26adb1c807c338d56ba8b38779e6bcb54a9657100394b9ab86ce373c093bf662bac25604f5e3bbfa6f41ff409264d6132515d45ba2006b6627f7bcb06e

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bankocr (0.0.3)
+    bankocr (0.0.4)
       thor (~> 0.19)
 
 GEM

data/README.md

@@ -9,17 +9,20 @@ This repository provides a solution for BankOCR kata.
 * Description of the problem can be found here: http://code.joejag.com/coding-dojo-bank-ocr/
 * Current implementation covers the first 3 use cases.
 
-## How to run?
-
-Use the following commands:
+## How to install
 
 ```
 gem install backocr
-bankocr process ./bin/input.in ./bin/output
 ```
 
-* It will generate a file under /bin directory with results
-* If you want to modify input edit file /bin/input.in
+## How to run?
+
+* You can download a sample input file from here: https://github.com/solojavier/BankOCR/raw/master/bin/input.in
+* To process input file and generate a report use the following command:
+
+```
+bankocr process input_path output_path
+```
 
 ## Tests
 

data/bin/bankocr

@@ -9,12 +9,7 @@ module BankOCR
       'Generates a report for account numbers read from input'
 
     def process(input, output)
-      begin
-        BankOCR.process(input, output)
-        p 'OCR accounts report generated succesfully'
-      rescue Exception => ex
-        p ex.message
-      end
+      BankOCR.process(input, output)
     end
   end
 end

data/lib/account_number.rb

@@ -1,24 +1,17 @@
 module BankOCR
   # Object representing an account number
   class AccountNumber
-    attr_reader :error_message, :digits
 
     def initialize(digits)
       @digits = digits
-      @valid  = false
-
-      validate!
     end
 
     def valid?
-      @valid
+      @valid ||= sum(@digits) % 11 == 0
     end
 
-    def validate!
-      @error_message =   'ILL' if @digits.include?('?')
-      @error_message ||= 'ERR' if sum(@digits) % 11 != 0
-
-      @valid = true unless @error_message
+    def to_s
+      @digits
     end
 
     private

data/lib/bankocr.rb

@@ -8,8 +8,7 @@ module BankOCR
   autoload :ReportGenerator, 'report_generator'
 
   def self.process(input, output)
-    digit_strings   = BankOCR::FileParser.new(input).entries
-    account_numbers = digit_strings.map { |d| BankOCR::AccountNumber.new(d) }
+    account_numbers = BankOCR::FileParser.new(input).entries
 
     BankOCR::ReportGenerator.new(output, account_numbers).save!
   end

data/lib/bankocr/version.rb

@@ -1,3 +1,3 @@
 module BankOCR
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/lib/file_parser.rb

@@ -14,9 +14,10 @@ module BankOCR
       file     = File.open(@input_path)
       @entries << parse_entry(file) until file.eof?
 
-      @entries
+      @entries.map{|e| BankOCR::AccountNumber.new(e) }
     rescue
-      raise 'Error reading input file, please validate'
+      p 'Error reading input file, please validate'
+      []
     ensure
       file.close if file
     end

data/lib/report_generator.rb

@@ -10,12 +10,21 @@ module BankOCR
       file = File.open(@output_path, 'w+')
 
       @account_numbers.each do |account|
-        file.write account.digits
-        file.write " #{account.error_message}" unless account.valid?
-        file.write "\n"
+        file.write "#{account}#{error(account)}\n"
       end
 
       file.close
     end
+
+    private
+
+    def error(account)
+      if account.to_s.include?('?')
+        ' ILL'
+      elsif !account.valid?
+        ' ERR'
+      end
+    end
+
   end
 end

data/spec/lib/account_number_spec.rb

@@ -13,7 +13,6 @@ describe BankOCR::AccountNumber do
         account = described_class.new(n)
 
         expect(account.valid?).to eq(true)
-        expect(account.error_message).to eq(nil)
       end
     end
 
@@ -22,7 +21,6 @@ describe BankOCR::AccountNumber do
         account = described_class.new(n)
 
         expect(account.valid?).to eq(false)
-        expect(account.error_message).to eq('ERR')
       end
     end
 
@@ -31,7 +29,6 @@ describe BankOCR::AccountNumber do
         account = described_class.new(n)
 
         expect(account.valid?).to eq(false)
-        expect(account.error_message).to eq('ILL')
       end
     end
 

data/spec/lib/file_parser_spec.rb

@@ -14,13 +14,13 @@ describe BankOCR::FileParser do
     it 'returns an array with account numbers' do
       parser = described_class.new(input_path)
 
-      expect(parser.entries).to eq(account_numbers)
+      expect(parser.entries.map(&:to_s)).to eq(account_numbers)
     end
 
     it 'returns empty account_numbers if error reading file' do
       parser = described_class.new('invalid_path')
 
-      expect{parser.entries}.to raise_error('Error reading input file, please validate')
+      expect(parser.entries).to eq([])
     end
 
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bankocr
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Javier Cervantes
@@ -74,7 +74,6 @@ files:
 - lib/bankocr/version.rb
 - lib/file_parser.rb
 - lib/report_generator.rb
-- lib/utils.rb
 - spec/bin/bankocr_spec.rb
 - spec/bin/input.in
 - spec/lib/account_number_spec.rb

data/lib/utils.rb

@@ -1,84 +0,0 @@
-# Module for BankOCR Application
-module BankOCR
-  # Utility functions to perform data conversions
-  module Utils
-    # Parses an OCR machine input file and returns an array of account numbers
-    def parse_file(input_path)
-      file    = File.open(input_path)
-      numbers = []
-
-      numbers << next_entry_to_digits(file) until file.eof?
-      numbers
-    rescue
-      []
-    ensure
-      file.close if file
-    end
-
-    # Receives a list of account numbers and returns validation information
-    def validate_accounts(account_numbers)
-      account_numbers.map do |number|
-        valid, message = validate(number.to_s)
-
-        { account_number: number, valid: valid, message: message }
-      end
-    end
-
-    # Creates a file report in ouput path with accounts received
-    def generate_report(output_path, accounts)
-      file = File.open(output_path, 'w+')
-
-      accounts.select { |a| a[:account_number] }.each do |acc|
-        file.write acc[:account_number]
-        file.write " #{acc[:message]}" if !acc[:valid] && acc[:message]
-        file.write "\n"
-      end
-
-      file.close
-    end
-
-    private
-
-    def next_entry_to_digits(file)
-      top    = file.readline
-      middle = file.readline
-      bottom = file.readline
-      _blank = file.readline
-
-      (0..8).map do |i|
-        low   = (i * 3)
-        high  = ((i + 1) * 3) - 1
-        shape = top[low..high] + middle[low..high] + bottom[low..high]
-
-        conversions[shape] || '?'
-      end.join
-    end
-
-    def conversions
-      { ' _ | ||_|' => '0',
-        '     |  |' => '1',
-        ' _  _||_ ' => '2',
-        ' _  _| _|' => '3',
-        '   |_|  |' => '4',
-        ' _ |_  _|' => '5',
-        ' _ |_ |_|' => '6',
-        ' _   |  |' => '7',
-        ' _ |_||_|' => '8',
-        ' _ |_| _|' => '9' }
-    end
-
-    def sum(account_number)
-      (0..8).map { |i| account_number[i].to_i * (i + 2) }.reduce(:+)
-    end
-
-    def validate(number)
-      if number.include?('?')
-        [false, 'ILL']
-      elsif sum(number) % 11 != 0
-        [false, 'ERR']
-      else
-        [true, 'OK']
-      end
-    end
-  end
-end