bankline_csv_import_file 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5873525845d592185e8e2588efb4ae4780f891e5
-  data.tar.gz: 23c0e7b3fde8695b4e1bdcf31258ff37b4f64b68
+SHA256:
+  metadata.gz: a291c34665a288d576f2b5aa20c621ad58dec49b2b4c61e240f33c33e21e15fd
+  data.tar.gz: 0abd8a2e5d0b851954b641faa7cfb3d044cc0f56f8f4d18edb62cc61dbea5c6b
 SHA512:
-  metadata.gz: c114810c6d7a56388a2e8c9f6bec660719bb1344c8e5c40711892bd316c0095f2f21f43f93ec02fe41e9f08e6be3286d5b27f365ddc0c6e327584285e7be71e1
-  data.tar.gz: 85cb877a0b3506166048addfaeb236605c6c18e2452a760ddbf73829248f6da365f42894844bb43f349c68a685f284a82c3ef7b2be5e35cac347cdee4023060e
+  metadata.gz: 6de7bfb93252c6a1a99bfdcdf7467a0886f4ce8b1ced41f03562b3b782c1ad643317ebbb02e187c91a9ecfd3bf24c6c9405aa42c109dc98f6308341d9cbb1e8c
+  data.tar.gz: 1353404252535a7def4ddaf8e4d67e2837ff849bf2f876ad6acbbfe54a7504abdebd3a596f928800d14282c31f31ddeb6212d955a49e78bdf339bffe1d82fa57

data/.github/workflows/ci.yml

@@ -0,0 +1,26 @@
+name: Ruby CI
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    strategy:
+      matrix:
+        ruby-version: ["3.0", "2.7", "2.6", "2.5"]
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up Ruby ${{ matrix.ruby-version }}
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby-version }}
+          bundler-cache: true # runs 'bundle install' and caches installed gems automatically
+      - name: Run tests
+        run: bundle exec rake

data/.rubocop.yml

@@ -0,0 +1,5 @@
+AllCops:
+  Exclude:
+    - "tmp/**/*"
+inherit_gem:
+  barsoom_utils: shared_rubocop.yml

data/Gemfile

@@ -1,6 +1,11 @@
 source "https://rubygems.org"
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in bankline_csv_import_file.gemspec
 gemspec
+
+group :development do
+  gem "barsoom_utils", github: "barsoom/barsoom_utils"
+  gem "rubocop"
+end

data/Gemfile.lock

@@ -1,3 +1,9 @@
+GIT
+  remote: https://github.com/barsoom/barsoom_utils
+  revision: d59121c10b4ba0e996d213ad23dc1545dcd27de0
+  specs:
+    barsoom_utils (0.1.0)
+
 PATH
   remote: .
   specs:
@@ -6,30 +12,52 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    diff-lcs (1.3)
-    rake (10.5.0)
-    rspec (3.7.0)
-      rspec-core (~> 3.7.0)
-      rspec-expectations (~> 3.7.0)
-      rspec-mocks (~> 3.7.0)
-    rspec-core (3.7.1)
-      rspec-support (~> 3.7.0)
-    rspec-expectations (3.7.0)
+    ast (2.4.2)
+    diff-lcs (1.4.4)
+    parallel (1.20.1)
+    parser (3.0.2.0)
+      ast (~> 2.4.1)
+    rainbow (3.0.0)
+    rake (13.0.1)
+    regexp_parser (2.1.1)
+    rexml (3.2.5)
+    rspec (3.9.0)
+      rspec-core (~> 3.9.0)
+      rspec-expectations (~> 3.9.0)
+      rspec-mocks (~> 3.9.0)
+    rspec-core (3.9.2)
+      rspec-support (~> 3.9.3)
+    rspec-expectations (3.9.2)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-mocks (3.7.0)
+      rspec-support (~> 3.9.0)
+    rspec-mocks (3.9.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.7.0)
-    rspec-support (3.7.1)
+      rspec-support (~> 3.9.0)
+    rspec-support (3.9.3)
+    rubocop (1.18.4)
+      parallel (~> 1.10)
+      parser (>= 3.0.0.0)
+      rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
+      rexml
+      rubocop-ast (>= 1.8.0, < 2.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.8.0)
+      parser (>= 3.0.1.1)
+    ruby-progressbar (1.11.0)
+    unicode-display_width (2.0.0)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   bankline_csv_import_file!
+  barsoom_utils!
   bundler
   rake
   rspec
+  rubocop
 
 BUNDLED WITH
-   1.16.0
+   2.2.25

data/README.md

@@ -1,11 +1,11 @@
 # Bankline CSV import file
 
+[![Ruby CI](https://github.com/barsoom/bankline_csv_import_file/actions/workflows/ci.yml/badge.svg)](https://github.com/barsoom/bankline_csv_import_file/actions/workflows/ci.yml)
+
 Generate Bankline CSV import files per <https://www.business.rbs.co.uk/content/dam/rbs_co_uk/Business_and_Content/PDFs/Bankline/Bankline-import-file-guide-CSV-RBS.pdf>, used e.g. by NatWest.
 
 Not intended to be a complete implementation. We have implemented what we need; feel free to make PRs for further behaviour.
 
-USER BEWARE: At the time of writing, we have not yet verified that the produced file works.
-
 
 ## Usage
 
@@ -21,6 +21,8 @@ file.add_international_payment(…)
 file.generate  # => "foo,bar,…"
 ```
 
+At least with NatWest, it seems that the uploaded file must have a `.txt` extension, despite containing CSV.
+
 ### Domestic payment
 
 All these arguments are required unless stated otherwise.
@@ -32,11 +34,11 @@ file.add_domestic_payment(
   payer_sort_code: "151000",
   payer_account_number: "31806542",
   amount: "123.45",                        # Strings and BigDecimal are allowed. (Floats are not advisable for money.) Rounded to 2 decimals.
+  payment_date: Date.new(2018, 1, 1),      # See note below.
   beneficiary_sort_code: "151000",
   beneficiary_account_number: "44298801",
   beneficiary_name: "John Doe",            # Truncated to a max length of 35.
   beneficiary_reference: "Invoice 123",    # Truncated to a max length of 18.
-  payment_date: Date.new(2018, 1, 1),      # See note below.
 )
 
 file.generate  # => "foo,bar,…"
@@ -63,18 +65,17 @@ All these arguments are required unless stated otherwise.
 file = BanklineCsvImportFile.new
 
 file.add_international_payment(
-  payer_sort_code: "151000",             # Any non-digits will be stripped automatically.
-  payer_account_number: "31806542",      # Any non-digits will be stripped automatically.
+  payer_sort_code: "151000",
+  payer_account_number: "31806542",
   amount: "123.45",                      # Strings and BigDecimal are allowed. (Floats are not advisable for money.)
   payment_date: Date.new(2018, 1, 1),    # See note below.
   beneficiary_bic: "SPKHDE2H",
   beneficiary_iban: "DE53250501800039370089",
   beneficiary_name: "John Doe",
+  beneficiary_reference: "Invoice 123",  # Optional. Truncated to 35 chars per line and max 4 lines.
 
   # Optional but recommended, see below. Truncated to 35 chars per line and max 3 lines.
   beneficiary_address: "10 Foo Street\nBartown, Baz County\nABC 123"
-
-  beneficiary_reference: "Invoice 123",  # Optional. Truncated to 35 chars per line and max 4 lines.
 )
 
 file.generate  # => "foo,bar,…"

data/Rakefile

@@ -5,7 +5,7 @@ begin
 
   RSpec::Core::RakeTask.new(:spec)
 
-  task :default => :spec
+  task default: :spec
 rescue LoadError
   # no RSpec available
 end

data/bankline_csv_import_file.gemspec

@@ -7,19 +7,18 @@ require "bankline_csv_import_file/version"
 Gem::Specification.new do |spec|
   spec.name          = "bankline_csv_import_file"
   spec.version       = BanklineCsvImportFile::VERSION
-  spec.authors       = ["Henrik Nyh"]
-  spec.email         = ["henrik@nyh.se"]
+  spec.authors       = [ "Henrik Nyh" ]
+  spec.email         = [ "henrik@nyh.se" ]
 
   spec.summary       = %q{Generate Bankline CSV import files.}
   spec.homepage      = "https://github.com/barsoom/bankline_csv_import_file"
   spec.license       = "MIT"
+  spec.metadata      = { "rubygems_mfa_required" => "true" }
 
   spec.files         = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = "exe"
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = [ "lib" ]
 
   spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake"

data/lib/bankline_csv_import_file/record.rb

@@ -1,7 +1,7 @@
 class BanklineCsvImportFile
   class Record
     def initialize
-      # H001..H003, T001..T082.
+      # 85 columns, namely H001..H003 and T001..T082 per https://www.business.rbs.co.uk/content/dam/rbs_co_uk/Business_and_Content/PDFs/Bankline/Bankline-import-file-guide-CSV-RBS.pdf (section 3).
       @array = Array.new(85)
     end
 
@@ -13,6 +13,7 @@ class BanklineCsvImportFile
       when /\AT(\d\d\d)\z/
         i = $1.to_i
         raise "Out of range!" unless (1..82).cover?(i)
+
         @array[i + 2] = value
       else
         raise "Unknown field: #{key.inspect}"

data/lib/bankline_csv_import_file/version.rb

@@ -1,3 +1,3 @@
 class BanklineCsvImportFile
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bankline_csv_import_file
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Henrik Nyh
 autorequire: 
-bindir: exe
+bindir: bin
 cert_chain: []
-date: 2018-07-06 00:00:00.000000000 Z
+date: 2021-11-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -59,9 +59,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
+- ".rubocop.yml"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -76,7 +77,8 @@ files:
 homepage: https://github.com/barsoom/bankline_csv_import_file
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -92,8 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.2.28
 signing_key: 
 specification_version: 4
 summary: Generate Bankline CSV import files.

data/.travis.yml

@@ -1,5 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 1.9.3
-before_install: gem install bundler -v 1.16.0