banking_data 0.9.4 → 0.9.5

data/lib/banking_data/austrian_bank.rb

@@ -35,7 +35,7 @@ class BankingData::AustrianBank < BankingData::Bank
 
       def file
         File.dirname(__FILE__) +
-          '/../../data/SEPA-ZV-VZ_gesamt_de_1615904610976.csv'
+          '/../../data/SEPA-ZV-VZ_gesamt_de_1642675944518_alte_Version.csv'
       end
 
       def opts

data/lib/banking_data/dutch_bank.rb

@@ -23,9 +23,9 @@ class BankingData::DutchBank < BankingData::Bank
     def get_all
       banks = []
       SmarterCSV.process(file, opts).each do |line|
-        bank_id = line[:bank_identifier].to_s
+        bank_id = line[:identifier].to_s
         bic = line[:bic]
-        name = line[:naam_bank].to_s
+        name = line[:naam_betaaldienstverlener].to_s
         if bank_id && bic && name
           banks << new(name: name, bank_id: bank_id, bic: bic)
         end

data/lib/banking_data/german_bank.rb

@@ -31,7 +31,7 @@ class BankingData::GermanBank < BankingData::Bank
       end
 
       def file
-        File.dirname(__FILE__) + '/../../data/blz_2021_03_16.txt'
+        File.dirname(__FILE__) + '/../../data/blz_2021_12_06.txt'
       end
   end
 end

data/lib/banking_data/version.rb

@@ -1,4 +1,4 @@
 module BankingData
   # banking_data version
-  VERSION = '0.9.4'
+  VERSION = '0.9.5'
 end

data/spec/banking_data/austrian_bank_spec.rb

@@ -3,7 +3,7 @@ require 'spec_helper'
 module BankingData
   describe AustrianBank do
     describe 'end-to-end test' do
-      ['RCNOATW1XXX', 'FFBKDEFFAUT'].each do |bic|
+      ['RCNOATW1XXX', 'EUAAATWWXXX'].each do |bic|
         it "includes #{bic}" do
           expect(AustrianBank.only(:bic).map(&:first)).to include(bic)
           expect(Bank.where(locale: :at).only(:bic).map(&:first))
@@ -21,6 +21,21 @@ module BankingData
             .to eq([blz])
         end
       end
+
+      it 'all bics are blank or look like bics' do
+        bics = AustrianBank.only(:bic).map(&:first)
+        # regular expression: the bic should have 11 characters, that are either
+        # all white space or consist of capital letters and digits
+        expect(bics.select{ |bic| !( bic =~  /\A(\s|([A-Z]|\d)){11}\z/ ) }).
+          to eq([])
+      end
+
+      it 'all blz except two exceptions consist of 5 digits' do
+        exceptions = ['1000', '100']
+        blzs = AustrianBank.only(:blz).map(&:first) - exceptions
+        expect(blzs.select{ |blz| !( blz =~  /\A\d{5}\z/ ) }).
+          to eq([])
+      end
     end
   end
 end

data/spec/banking_data/dutch_bank_spec.rb

@@ -11,5 +11,30 @@ module BankingData
         end
       end
     end
+
+    it 'all but one bics are blank or look like bics' do
+      exceptions = ['BOFSNL21002']
+      bics = DutchBank.only(:bic).map(&:first) - exceptions
+      # regular expression: the bic should have 8 characters, that are either
+      # all white space or consist of capital letters and digits
+      expect(bics.select{ |bic| !( bic =~  /\A(\s|([A-Z]|\d)){8}\z/ ) }).
+        to eq([])
+    end
+
+    it 'all bank identifiers consist of 4 capital letters' do
+      bank_ids = DutchBank.only(:bank_id).map(&:first)
+      # regular expression: the bic should have 8 characters, that are either
+      # all white space or consist of capital letters and digits
+      expect(bank_ids.select{ |bank_id| !( bank_id =~  /\A[A-Z]{4}\z/ ) }).
+        to eq([])
+    end
+
+    it 'all bank names have at least one letter' do
+      names = DutchBank.only(:name).map(&:first)
+      # regular expression: the bic should have 8 characters, that are either
+      # all white space or consist of capital letters and digits
+      expect(names.select{ |name| !( name =~  /\A.*[a-zA-Z]+.*\z/ ) }).
+        to eq([])
+    end
   end
 end

data/spec/banking_data/german_bank_spec.rb

@@ -22,6 +22,20 @@ module BankingData
             .to eq([blz])
         end
       end
+
+      it 'all bics are blank or look like bics' do
+        bics = GermanBank.only(:bic).map(&:first)
+        # regular expression: the bic should have 11 characters, that are either
+        # all white space or consist of capital letters and digits
+        expect(bics.select{ |bic| !( bic =~  /\A(\s|([A-Z]|\d)){11}\z/ ) }).
+          to eq([])
+      end
+
+      it 'all blz consist of 8 digits' do
+        blzs = GermanBank.only(:blz).map(&:first)
+        expect(blzs.select{ |blz| !( blz =~  /\A\d{8}\z/ ) }).
+          to eq([])
+      end
     end
   end
 end

data/spec/banking_data/swiss_bank_spec.rb

@@ -3,13 +3,21 @@ require 'spec_helper'
 module BankingData
   describe SwissBank do
     describe 'end-to-end test' do
-      ['SNBZCHZZXXX', 'UBSWCHZH31A'].each do |bic|
+      ['SNBZCHZZXXX', 'UBSWCHZH31A', 'VBBECH22XXX'].each do |bic|
         it "includes #{bic}" do
           expect(SwissBank.only(:bic).map(&:first)).to include(bic)
           expect(Bank.where(locale: :ch).only(:bic).map(&:first))
             .to include(bic)
         end
       end
+
+      it 'all bics are blank or look like bics' do
+        bics = SwissBank.only(:bic).map(&:first)
+        # regular expression: the bic should have 11 characters, that are either
+        # all white space or consist of capital letters and digits
+        expect(bics.select{ |bic| !( bic =~  /\A(\s|([A-Z]|\d)){11}\z/ ) }).
+          to eq([])
+      end
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banking_data
 version: !ruby/object:Gem::Version
-  version: 0.9.4
+  version: 0.9.5
 platform: ruby
 authors:
 - Frank C. Eckert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-03-17 00:00:00.000000000 Z
+date: 2022-04-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -42,16 +42,16 @@ dependencies:
   name: smarter_csv
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 1.2.9
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 1.1.0
+        version: 1.2.9
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -137,7 +137,8 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 description: This gem exposes the official banking data of the respective national
-  banks of Germany, Austria and Switzerland, including bank codes and SWIFT-codes/BICs.
+  banks of Germany, Austria, Netherlands and Switzerland, including bank codes and
+  SWIFT-codes/BICs.
 email: frank.eckert@boost-project.com
 executables: []
 extensions: []
@@ -156,9 +157,9 @@ files:
 - banking_data.gemspec
 - data/BIC-lijst-NL.csv
 - data/README.md
-- data/SEPA-ZV-VZ_gesamt_de_1615904610976.csv
+- data/SEPA-ZV-VZ_gesamt_de_1642675944518_alte_Version.csv
 - data/bcbankenstamm.txt
-- data/blz_2021_03_16.txt
+- data/blz_2021_12_06.txt
 - gemfiles/rails_3.0.gemfile
 - gemfiles/rails_4.0.gemfile
 - gemfiles/rails_4.2.gemfile
@@ -190,19 +191,19 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - "<"
+  - - ">="
     - !ruby/object:Gem::Version
-      version: '3'
+      version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
-summary: Banking data for German, Austrian and Swiss banks
+summary: Banking data for German, Austrian, Dutch and Swiss banks
 test_files:
 - spec/banking_data/austrian_bank_spec.rb
 - spec/banking_data/bank_spec.rb