banking_data 0.7.2 → 0.9.3

data/lib/banking_data.rb

@@ -6,6 +6,7 @@ require 'banking_data/bank'
 require 'banking_data/german_bank'
 require 'banking_data/austrian_bank'
 require 'banking_data/swiss_bank'
+require 'banking_data/dutch_bank'
 
 module BankingData
 

data/lib/banking_data/austrian_bank.rb

@@ -35,7 +35,7 @@ class BankingData::AustrianBank < BankingData::Bank
 
       def file
         File.dirname(__FILE__) +
-          '/../../data/SEPA-ZV-VZ_gesamt_de_1502983225066.csv'
+          '/../../data/SEPA-ZV-VZ_gesamt_de_1592217062909.csv'
       end
 
       def opts

data/lib/banking_data/dutch_bank.rb

@@ -0,0 +1,50 @@
+require 'active_support/core_ext/object/blank'
+
+class BankingData::DutchBank < BankingData::Bank
+  extend ActiveModel::Naming
+  include ActiveModel::Conversion
+  include ActiveModel::AttributeMethods
+
+  LOCALE = :nl
+
+  attr_accessor :bank_id, :bic, :name
+
+  class << self
+
+    delegate :where, :only, to: :query
+    delegate :map, :each, to: :all
+
+    def all
+      @@all ||= get_all
+    end
+
+    private
+
+    def get_all
+      banks = []
+      SmarterCSV.process(file, opts).each do |line|
+        bank_id = line[:bank_identifier].to_s
+        bic = line[:bic]
+        name = line[:naam_bank].to_s
+        if bank_id && bic && name
+          banks << new(name: name, bank_id: bank_id, bic: bic)
+        end
+      end
+      banks.uniq
+    end
+
+    private
+
+    def file
+      File.dirname(__FILE__) +
+        '/../../data/BIC-lijst-NL.csv'
+    end
+
+    def opts
+      {
+        col_sep: ',',
+        skip_lines: 1
+      }
+    end
+  end
+end

data/lib/banking_data/german_bank.rb

@@ -31,7 +31,7 @@ class BankingData::GermanBank < BankingData::Bank
       end
 
       def file
-        File.dirname(__FILE__) + '/../../data/blz_2017_09_04_txt'
+        File.dirname(__FILE__) + '/../../data/blz_2020_08_06_txt'
       end
   end
 end

data/lib/banking_data/query.rb

@@ -27,6 +27,8 @@ module BankingData
     end
 
     def to_a
+      return [] if bank.nil?
+
       data = bank.all
         .select { |bank| @options.map { |k, v| bank.send(k) == v }.all? }
       if @attributes

data/lib/banking_data/version.rb

@@ -1,4 +1,4 @@
 module BankingData
   # banking_data version
-  VERSION = '0.7.2'
+  VERSION = '0.9.3'
 end

data/spec/banking_data/dutch_bank_spec.rb

@@ -0,0 +1,15 @@
+require 'spec_helper'
+
+module BankingData
+  describe DutchBank do
+    describe 'end-to-end test' do
+      ['ABNANL2A', 'INGBNL2A', 'RABONL2U'].each do |bic|
+        it "includes #{bic}" do
+          expect(DutchBank.only(:bic).map(&:first)).to include(bic)
+          expect(Bank.where(locale: :nl).only(:bic).map(&:first))
+            .to include(bic)
+        end
+      end
+    end
+  end
+end

data/spec/query_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+require 'banking_data'
+
+describe BankingData::Query do
+  describe '#to_a' do
+    it 'returns [] for unknown banks' do
+      locale = :li
+
+      bank = BankingData::Bank.subclasses.find do |bank_class|
+        bank_class::LOCALE == locale
+      end
+
+      expect(bank).to be_nil
+
+      query = BankingData::Query.new(
+        locale: :li,
+        blz: '8800'
+      )
+
+      expect(query.to_a).to be_empty
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banking_data
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.9.3
 platform: ruby
 authors:
 - Frank C. Eckert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-08-21 00:00:00.000000000 Z
+date: 2020-06-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -154,10 +154,11 @@ files:
 - README.md
 - Rakefile
 - banking_data.gemspec
+- data/BIC-lijst-NL.csv
 - data/README.md
-- data/SEPA-ZV-VZ_gesamt_de_1502983225066.csv
+- data/SEPA-ZV-VZ_gesamt_de_1592217062909.csv
 - data/bcbankenstamm.txt
-- data/blz_2017_09_04_txt
+- data/blz_2020_08_06_txt
 - gemfiles/rails_3.0.gemfile
 - gemfiles/rails_4.0.gemfile
 - gemfiles/rails_4.2.gemfile
@@ -165,6 +166,7 @@ files:
 - lib/banking_data.rb
 - lib/banking_data/austrian_bank.rb
 - lib/banking_data/bank.rb
+- lib/banking_data/dutch_bank.rb
 - lib/banking_data/german_bank.rb
 - lib/banking_data/query.rb
 - lib/banking_data/swiss_bank.rb
@@ -172,9 +174,11 @@ files:
 - rubocop-todo.yml
 - spec/banking_data/austrian_bank_spec.rb
 - spec/banking_data/bank_spec.rb
+- spec/banking_data/dutch_bank_spec.rb
 - spec/banking_data/german_bank_spec.rb
 - spec/banking_data/swiss_bank_spec.rb
 - spec/banking_data_spec.rb
+- spec/query_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/opahk/banking_data
 licenses:
@@ -195,15 +199,16 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Banking data for German, Austrian and Swiss banks
 test_files:
 - spec/banking_data/austrian_bank_spec.rb
 - spec/banking_data/bank_spec.rb
+- spec/banking_data/dutch_bank_spec.rb
 - spec/banking_data/german_bank_spec.rb
 - spec/banking_data/swiss_bank_spec.rb
 - spec/banking_data_spec.rb
+- spec/query_spec.rb
 - spec/spec_helper.rb