bank_statement_parser 0.1.11 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ebc742c8d24a74d3b38904096e66548289bde353
-  data.tar.gz: 2f16e836465583bcb9b4e3b3a248ec7f6e591f7e
+  metadata.gz: 745a9c41a2a718421bbeff54a6cab8db47767c95
+  data.tar.gz: 839a9e0a2e2c02844001bdac55e11f8aac5642ae
 SHA512:
-  metadata.gz: 3540762354c19f63abba8c77ce309186c7c7f7f03549fac25517ea3a0057f52e08534820edf3cf4007e7d999bd7d4af2a4ce172c0ecd86c0458c89120c8bc07a
-  data.tar.gz: df3519d1e91dacfddfd85677d58634daf5289791e32013aef7a7732e6fb9d514d5bd5b29f80d0df1c3a314ba98d9408d2fb6f05a3a2028ba66d785ba27a06e8e
+  metadata.gz: 15bcbe26137f90c85536d0b87b18b18712e579bdd7f88b8dc8c4b24f258eaac30457b96014adf3b929a9f8eee4ab2c345adc5fa4aff5a9c47b23e496ad112d62
+  data.tar.gz: 4e60bf99feb68775bb5098eb0b872c8d3c7b3ae585975627e2fdc7eb46a651244ccbc20d549e7099e604d266c89dabf5fa0172a0048a51afdbdf500b21cd65a6

data/bin/bank_statement_to_yaml.rb

@@ -23,9 +23,10 @@ require 'yaml'
 
 require 'bank_statement_parser'
 
-parser = BankStatementParser::HSBC.new
+#bank_symbol = :hsbc
+bank_symbol = :santander
 
 # Attempt to parse the specified file
-parser.parse ARGV[0]
+bank_statement = BankStatementParser.parse ARGV[0], bank_symbol
 
-puts YAML.dump(parser.bank_statement)
+puts YAML.dump(bank_statement)

data/lib/bank_statement_parser/base.rb

@@ -50,7 +50,11 @@ module BankStatementParser
                   when String
                     # Is the path a URI?
                     if path =~ URI::regexp(%w(ftp http https))
-                      open(path).read
+                      begin
+                        open(path).read
+                      rescue OpenURI::HTTPError => e
+                        raise "Failed to read URI #{path}: #{e}"
+                      end
                     else
                       raise "Expected a text file path" unless
                         path =~ /\.txt\z/
@@ -75,6 +79,9 @@ module BankStatementParser
       raise "Failed to find sort code" if sort_code.nil?
       raise "Failed to find account number" if account_number.nil?
       raise "Failed to find statement date" if statement_date.nil?
+      raise "Failed to find account name" if name.nil?
+      raise "Failed to find opening balance" if opening_balance.nil?
+      raise "Failed to find closing balance" if closing_balance.nil?
     end
 
     protected

data/lib/bank_statement_parser.rb

@@ -17,6 +17,7 @@
 
 require 'logger'
 require 'bank_statement_parser/hsbc'
+require 'bank_statement_parser/santander'
 module BankStatementParser
 
   @@logger = Logger.new(STDERR)
@@ -27,10 +28,17 @@ module BankStatementParser
     @@logger = logger
   end
 
-  # Parse the specified statement file, for the specified (by name) bank
+  # Parse the specified statement file, for the specified (by symbol) bank
   #
   # Returns an instance of BankStatement
-  def self.parse path, bank = 'HSBC'
+  def self.parse path, bank_symbol = :hsbc
+    # Known banks should all be tabulated here
+    banks = {
+      hsbc: 'HSBC',
+      santander: 'Santander',
+    }
+    bank = banks[bank_symbol] or raise "Unknown bank #{bank_symbol}"
+
     parser_class = Kernel.const_get(self.name + '::' + bank)
     raise "No parser for #{bank} statements" unless Class == parser_class.class
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bank_statement_parser
 version: !ruby/object:Gem::Version
-  version: 0.1.11
+  version: 1.0.0
 platform: ruby
 authors:
 - Simon Dawson