bank_scrap 0.0.13 → 0.0.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 72a10733f8205d87884e40ba46e1d783317c0670
-  data.tar.gz: 03caab3dceaf26a5101bf18f1078b19c0382f6ef
+  metadata.gz: 032037fabd4f7fdb19e19a15c284f1f4d81ebd98
+  data.tar.gz: 0084c4701ff1ceb0e498c173e63819ce4a8d9404
 SHA512:
-  metadata.gz: a0b2753998bdd9c2d523c0bf058080afd56b595d4fcb24a0199c8fcfed5d2b805b94b211b3d465359ed7a887e6c5bfa5f35eea8e3b78f954883be3198e4a3c87
-  data.tar.gz: 0a50ff4c20b0f2423f358dd7114f53960c1034629ed29b3b042bcfcb223564e8c526be6c38d1200d4bce6c0c746c4122fe780d429982fd26cfa5a3dc6c89cbc1
+  metadata.gz: 30a368317e1cc336e7d179ce2119d4937ef666eef1ef3603e159b9a273414c49e57734d100f7ac2882ade92520d294358162b9745497342b3936a99f9af5f30c
+  data.tar.gz: a73e6cf9b6cc440d37c3bee5edb9e54418eed33b668ff96cf3d44f7b28717ab4b99cec78dbc36a513190061e43b41dc1f160fe006c822c60097e39450e39393b

data/lib/bank_scrap/banks/bbva.rb

@@ -57,7 +57,6 @@ module BankScrap
     # Returns an array of BankScrap::Transaction objects
     def fetch_transactions_for(account, start_date: Date.today - 1.month, end_date: Date.today)
       from_date = start_date.strftime('%Y-%m-%d')
-      to_date   = end_date.strftime('%Y-%m-%d')
 
       # Misteriously we need a specific content-type here
       funny_headers = {
@@ -65,24 +64,36 @@ module BankScrap
         'BBVA-Method' => 'GET'
       }
 
+      # The API accepts a toDate param that we could pass the end_date argument,
+      # however when we pass the toDate param, the API stops returning the account balance.
+      # Therefore we need to take a workaround: only filter with fromDate and loop 
+      # over all the available pages, filtering out the movements that doesn't match
+      # the end_date argument.
       url = BASE_ENDPOINT +
             ACCOUNT_ENDPOINT +
             account.id +
-            "/movements/v1?fromDate=#{from_date}&toDate=#{to_date}"
+            "/movements/v1?fromDate=#{from_date}"
+            
       offset = nil
+      pagination_balance = nil
       transactions = []
 
       with_headers(funny_headers) do
         # Loop over pagination
         loop do
           new_url = offset ? (url + "&offset=#{offset}") : url
+          new_url = pagination_balance ? (new_url + "&paginationBalance=#{pagination_balance}") : new_url
           json = JSON.parse(post(new_url, {}))
 
           unless json['movements'].blank?
-            transactions += json['movements'].map do |data|
+            # As explained before, we have to discard records newer than end_date. 
+            filtered_movements = json['movements'].select { |m| Date.parse(m['operationDate']) <= end_date }
+            
+            transactions += filtered_movements.map do |data|
               build_transaction(data, account)
             end
             offset = json['offset']
+            pagination_balance = json['paginationBalance']
           end
 
           break unless json['thereAreMoreMovements'] == true

data/lib/bank_scrap/version.rb

@@ -1,3 +1,3 @@
 module BankScrap
-  VERSION = '0.0.13'
+  VERSION = '0.0.14'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bank_scrap
 version: !ruby/object:Gem::Version
-  version: 0.0.13
+  version: 0.0.14
 platform: ruby
 authors:
 - Ismael Sánchez
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-12 00:00:00.000000000 Z
+date: 2015-06-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler