bank_lookup 0.2.0 → 0.2.1

data/lib/bank_lookup.rb

@@ -32,8 +32,17 @@ module BankLookup
   end
 
   class API < Sinatra::Base
+    before do
+      content_type :json
+    end
+
     # GET /bank_name?number=23413421
     get '/bank_name' do
+      if params['number'].nil?
+        halt 400, MultiJson.encode(:error => '"number" param is required')
+      end
+      params['number'].strip!
+
       number = params['number']
       if name = DB[number]
         MultiJson.encode({:name => name, :pretty_name => name.titleize})

data/lib/bank_lookup/version.rb

@@ -1,3 +1,3 @@
 module BankLookup
-  VERSION = '0.2.0'
+  VERSION = '0.2.1'
 end

data/spec/api_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe BankLookup::API, 'GET /bank_name' do 
+  def app
+    BankLookup::API.new
+  end
+
+  def get(url)
+    Rack::MockRequest.new(app).get(url)
+  end
+
+  describe "when passed a number that exists in the db" do 
+    it 'responds with 200' do 
+      get("/bank_name?number=011000015").status.should == 200
+    end
+
+    it 'responds with json content type' do 
+      get("/bank_name?number=011000015").content_type.should =~ /json/
+    end
+
+    it 'responds with name and pretty name keys' do
+      data = MultiJson.decode(get("/bank_name?number=011000015").body)
+      data.should have_key 'name'
+      data.should have_key 'pretty_name'
+    end
+
+    it 'strips whitespace from the front' do
+      get("/bank_name?number=%20011000015").status.should == 200
+    end
+
+    it 'strips whitespace from the end' do
+      get("/bank_name?number=011000015%20").status.should == 200
+    end
+  end
+
+  describe 'when passed a number that does not exist' do
+    it 'responds with 404' do
+      get('/bank_name?number=234').status.should == 404
+    end
+
+    it 'responds with json' do
+      get('/bank_name?number=234').content_type.should =~ /json/
+    end
+  end
+
+  describe 'when not passed a number param' do
+    it 'responds with 400' do
+      get('/bank_name').status.should == 400
+    end
+
+    it 'responds with an error message' do
+      MultiJson.decode(get('/bank_name').body).should == {'error' => '"number" param is required'}
+    end
+
+    it 'responds with a text content type' do
+      get('/bank_name').content_type.should =~ /json/
+    end
+  end
+end

data/spec/bank_lookup_spec.rb

@@ -0,0 +1,11 @@
+require 'spec_helper'
+
+describe BankLookup::DB do
+  it 'allows looking up a number with a string number' do
+    BankLookup::DB['011000015'].should == 'FEDERAL RESERVE BANK'
+  end
+
+  it 'does not allow looking up a number with an int number' do
+    BankLookup::DB[011000015].should be_nil
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,17 @@
+require 'rubygems'
+require 'bundler/setup'
+
+ENV['RACK_ENV'] ||= 'test'
+
+$:.push File.dirname(File.expand_path(__FILE__))
+$:.push(File.join(File.dirname(File.expand_path(__FILE__)), '..', 'lib'))
+
+require 'bank_lookup'
+
+Bundler.setup :default, :test
+Bundler.require :default, :test
+
+BankLookup::Parser.parse
+
+RSpec.configure do |c|
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bank_lookup
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.1
   prerelease: 
 platform: ruby
 authors:
@@ -10,11 +10,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-10-08 00:00:00.000000000 Z
+date: 2013-03-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
-  requirement: &70147441679220 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -22,10 +22,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70147441679220
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: sinatra
-  requirement: &70147441678720 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +38,15 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70147441678720
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: &70147441678160 !ruby/object:Gem::Requirement
+  requirement: !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,7 +54,12 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *70147441678160
+  version_requirements: !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Lookup bank names by routing number.
 email:
 - ajsharp@gmail.com
@@ -54,6 +69,7 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- .gitignore
 - Gemfile
 - README.md
 - bank_lookup.gemspec
@@ -62,6 +78,9 @@ files:
 - examples/config.ru
 - lib/bank_lookup.rb
 - lib/bank_lookup/version.rb
+- spec/api_spec.rb
+- spec/bank_lookup_spec.rb
+- spec/spec_helper.rb
 homepage: https://github.com/zaarly/bank_lookup
 licenses: []
 post_install_message: 
@@ -82,8 +101,12 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: bank_lookup
-rubygems_version: 1.8.15
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: Lookup bank names by routing number.
-test_files: []
+test_files:
+- spec/api_spec.rb
+- spec/bank_lookup_spec.rb
+- spec/spec_helper.rb
+has_rdoc: