bank_credentials 0.1.7 → 0.2.0

data/spec/bank_credentials/hbci_spec.rb

@@ -16,9 +16,27 @@ describe BankCredentials::Hbci do
     end
   end
 
+  describe '#url' do
+    let(:credential_hash) do
+      {
+        bank_code: '10020890',
+        user_id: 'user_id',
+        pin: 'pin'
+      }
+    end
+
+    subject { described_class.new(credential_hash) }
+
+    context 'with valid bank list' do
+      it 'returns endpoint url' do
+        expect(subject.url).to eql('https://hbci-01.hypovereinsbank.de/bank/hbci')
+      end
+    end
+  end
+
   describe '#valid?' do
     it 'returns false when one of the keys is missing' do
-      %i[url bank_code user_id pin].each do |key|
+      %i[bank_code user_id pin].each do |key|
         expect(described_class.new(credential_hash.merge!(key => nil))).to_not be_valid
       end
     end
@@ -30,7 +48,7 @@ describe BankCredentials::Hbci do
 
   describe 'validate!' do
     it 'raises an error when one of the keys is missing' do
-      %i[url bank_code user_id pin].each do |key|
+      %i[bank_code user_id pin].each do |key|
         subject = described_class.new(credential_hash.merge!(key => nil), validate: false)
         expect { subject.validate! }.to raise_error(BankCredentials::Hbci::Errors::Invalid)
       end

data/spec/spec_helper.rb

@@ -4,3 +4,4 @@ $LOAD_PATH.unshift File.expand_path('../lib', __dir__)
 require 'bank_credentials'
 require 'byebug'
 require 'support/credentials'
+require 'webmock/rspec'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bank_credentials
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.2.0
 platform: ruby
 authors:
 - Roman Lehnert
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-06-29 00:00:00.000000000 Z
+date: 2018-07-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -30,28 +30,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '10'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '5'
+        version: '10'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '12.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '3.4'
 description: Encapsulates and validates the completeness of banking credentials for
   ebics and hbci.
 email:
@@ -94,6 +108,7 @@ files:
 - lib/bank_credentials/factory.rb
 - lib/bank_credentials/hbci.rb
 - lib/bank_credentials/version.rb
+- lib/bank_list.json
 - spec/bank_credentials/base_spec.rb
 - spec/bank_credentials/ebics_spec.rb
 - spec/bank_credentials/errors_spec.rb