bank-validator 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4e50ae23a715911b48b2719007826a9cade6f052
-  data.tar.gz: ff4026eb0d5ade84c6d5d60e48f68d7589e6b0e2
+  metadata.gz: a12a8cb39e85cd7d3095f4531e93280815e1c6ad
+  data.tar.gz: 696ef669eda1a6b45c321d8370ed271f40604ad5
 SHA512:
-  metadata.gz: fe563fd57de306b2a158ea02fc43e22e573b863ea9174f89d79df90ce534290d9d2b82b63e6b7f8343d37c11ef7c06101c282089c94571c069386b6c73e7fd38
-  data.tar.gz: 4846d208591cde4ec4168882b0cc2a76e668d295fbc8cbbab55a2835299e13ef601ffbcc27c6024c0edf431984bf01823dd6e31975631f16e27565d8b10bb73b
+  metadata.gz: 4bf523388656b2848daf70438f5be12aae3255a29f8ac84351545097408af1c03960f71cf83d2b01b7b24252d143b4153737b5ad88136d956f24dfc08b5d2965
+  data.tar.gz: 6ec35e9c6495af57215244c1c00d7924ad1cd5ae2bf7a0e944ac3bb388cc651db54803fbbf2c0df56bc508e233a128f1e15568d6516913de147abdff4d7eb6fc

data/VERSION

@@ -1 +1 @@
-0.2.2
+0.2.3

data/bank-validator.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: bank-validator 0.2.2 ruby lib
+# stub: bank-validator 0.2.3 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "bank-validator"
-  s.version = "0.2.2"
+  s.version = "0.2.3"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Adam Bahlke"]
-  s.date = "2015-03-31"
+  s.date = "2015-04-01"
   s.description = "Validates IBAN and BIC account numbers. Still a work in progress"
   s.email = "adam.bahlke@hitfoxgroup.com"
   s.extra_rdoc_files = [
@@ -89,6 +89,9 @@ Gem::Specification.new do |s|
     "test/dummy/spec/spec_helper.rb",
     "test/dummy/vendor/assets/javascripts/.keep",
     "test/dummy/vendor/assets/stylesheets/.keep",
+    "test/dummy_classes.rb",
+    "test/dummy_classes/dummy_user.rb",
+    "test/dummy_classes/dummy_user2.rb",
     "test/helper.rb",
     "test/test_bank-validator.rb"
   ]

data/lib/active_model/bic_validator.rb

@@ -9,7 +9,7 @@ class BicValidator < ActiveModel::EachValidator
   private
   
   def record_error(record, attribute, value)
-    record.errors.add(attribute, (:invalid_bic || options[:message]))
+    record.errors.add(attribute, (options[:message] || :invalid_bic))
   end
 
   def regexp

data/lib/active_model/iban_validator.rb

@@ -9,7 +9,7 @@ class IbanValidator < ActiveModel::EachValidator
   private
   
   def record_error(record, attribute, value)
-    record.errors.add(attribute, (:invalid_iban || options[:message]))
+    record.errors.add(attribute, (options[:message] || :invalid_iban))# || options[:message]))
   end
   
   def regexp

data/lib/active_model/routing_number_validator.rb

@@ -9,7 +9,7 @@ class RoutingNumberValidator < ActiveModel::EachValidator
   private
   
   def record_error(record, attribute, value)
-    record.errors.add(attribute, (:invalid_routing_number || options[:message]))
+    record.errors.add(attribute, (options[:message] || :invalid_routing_number))
   end
   
   def regexp

data/test/dummy/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ~/Workspace/bank-validator
   specs:
-    bank-validator (0.2.1)
+    bank-validator (0.2.2)
       activemodel (>= 3.0)
       activerecord (>= 3.0)
       activesupport (>= 3.0)

data/test/dummy_classes.rb

@@ -0,0 +1,3 @@
+require 'helper'
+require 'dummy_classes/dummy_user'
+require 'dummy_classes/dummy_user2'

data/test/dummy_classes/dummy_user.rb

@@ -0,0 +1,38 @@
+class DummyUser
+  include ActiveModel::Validations
+  validates :iban, iban: true
+  validates :bic, bic: true
+  validates :routing_number, routing_number: true
+
+  attr_accessor :iban
+
+  def initialize(attributes = {})
+    @iban = attributes[:iban]
+    @bic = attributes[:bic]
+    @routing_number = attributes[:routing_number]
+  end
+
+  def save
+    if valid?
+      return true
+    else
+      return false
+    end
+  end
+
+  def self.create(attributes = {})
+    new(attributes).save
+  end
+
+  def iban
+    @iban
+  end
+
+  def bic
+    @bic
+  end
+
+  def routing_number
+    @routing_number
+  end
+end

data/test/dummy_classes/dummy_user2.rb

@@ -0,0 +1,38 @@
+class DummyUser2
+  include ActiveModel::Validations
+  validates :iban, iban: {:message => 'custom iban error message'}
+  validates :bic, bic: {:message => 'custom bic error message'}
+  validates :routing_number, routing_number: {:message => 'custom routing number error message'}
+
+  attr_accessor :iban
+
+  def initialize(attributes = {})
+    @iban = attributes[:iban]
+    @bic = attributes[:bic]
+    @routing_number = attributes[:routing_number]
+  end
+
+  def save
+    if valid?
+      return true
+    else
+      return false
+    end
+  end
+
+  def self.create(attributes = {})
+    new(attributes).save
+  end
+
+  def iban
+    @iban
+  end
+
+  def bic
+    @bic
+  end
+
+  def routing_number
+    @routing_number
+  end
+end

data/test/test_bank-validator.rb

@@ -1,95 +1,75 @@
-require 'helper'
-
+require 'dummy_classes'
 class TestBankValidator < MiniTest::Test
 
-  class TestUser
-    include ActiveModel::Validations
-    validates :iban, iban: true
-    validates :bic, bic: true
-    validates :routing_number, routing_number: true
-
-    attr_accessor :iban
-
-    def initialize(attributes = {})
-      @iban = attributes[:iban]
-      @bic = attributes[:bic]
-      @routing_number = attributes[:routing_number]
-    end
-
-    def save
-      if valid?
-        return true
-      else
-        return false
-      end
-    end
-
-    def self.create(attributes = {})
-      new(attributes).save
-    end
-
-    def iban
-      @iban
+  context "test custom messages" do
+    should "display custom iban error message" do
+      user = DummyUser2.new(iban: "GB82WEST", bic: "DEUTDEBR", routing_number: "026009593")
+      user.valid?
+      assert_equal ['custom iban error message'], user.errors[:iban]
     end
 
-    def bic
-      @bic
+    should "display custom bic error message" do
+      user = DummyUser2.new(iban: "GB82WEST12345698765432", bic: "DEUTDE", routing_number: "026009593")
+      user.valid?
+      assert_equal ['custom bic error message'], user.errors[:bic]
     end
 
-    def routing_number
-      @routing_number
+    should "display custom routing number error message" do
+      user = DummyUser2.new(iban: "GB82WEST12345698765432", bic: "DEUTDEBR", routing_number: "02600959")
+      user.valid?
+      assert_equal ['custom routing number error message'], user.errors[:routing_number]
     end
   end
 
   context "iban validator" do
     should "not save if the iban is too short" do
-      assert_equal false, TestUser.create(iban: "GB82WEST", bic: "DEUTDEBR", routing_number: "026009593")
+      assert_equal false, DummyUser.create(iban: "GB82WEST", bic: "DEUTDEBR", routing_number: "026009593")
     end
 
     should "save if the iban is at least 16 characters" do
-      assert_equal true, TestUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR", routing_number: "026009593")
+      assert_equal true, DummyUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR", routing_number: "026009593")
     end
 
     should "returns false if the iban does not leave a remainder of 1 when divided by 97" do
-      assert_equal false, TestUser.create(iban: "GB82WEST123456987654Df", bic: "DEUTDEBR", routing_number: "026009593")
+      assert_equal false, DummyUser.create(iban: "GB82WEST123456987654Df", bic: "DEUTDEBR", routing_number: "026009593")
     end
 
     should "returns true if the iban returns a remainder of 1 when divided by 97" do
-      assert_equal true, TestUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR", routing_number: "026009593")
+      assert_equal true, DummyUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR", routing_number: "026009593")
     end
 
     should "work for different IBAN formats" do
       #Belgium
-      assert_equal true, TestUser.create(iban: "BE62510007547061", bic: "DEUTDEBR", routing_number: "026009593")
+      assert_equal true, DummyUser.create(iban: "BE62510007547061", bic: "DEUTDEBR", routing_number: "026009593")
 
       #Bulgaria
-      assert_equal true, TestUser.create(iban: "BG80BNBG96611020345678", bic: "DEUTDEBR", routing_number: "026009593")
+      assert_equal true, DummyUser.create(iban: "BG80BNBG96611020345678", bic: "DEUTDEBR", routing_number: "026009593")
 
       #Germany
-      assert_equal true, TestUser.create(iban: "DE89370400440532013000", bic: "DEUTDEBR", routing_number: "026009593")
+      assert_equal true, DummyUser.create(iban: "DE89370400440532013000", bic: "DEUTDEBR", routing_number: "026009593")
     end
   end
 
   context "bic validator" do
     should "be between 8 and 11 characters" do
-      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
-      assert_equal true, TestUser.create(bic: "DEUTDEBR123", iban: "BE62510007547061", routing_number: "026009593")
+      assert_equal true, DummyUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
+      assert_equal true, DummyUser.create(bic: "DEUTDEBR123", iban: "BE62510007547061", routing_number: "026009593")
     end
 
     should "start with 6 letters" do
-      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
-      assert_equal false, TestUser.create(bic: "DEUT22BR", iban: "BE62510007547061", routing_number: "026009593")
+      assert_equal true, DummyUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
+      assert_equal false, DummyUser.create(bic: "DEUT22BR", iban: "BE62510007547061", routing_number: "026009593")
     end
   end
 
   context "routing number" do
     should "be 9 digits long" do
-      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
+      assert_equal true, DummyUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
     end
 
     should "return false if not 9 digits long" do
-      assert_equal false, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "02600959")
-      assert_equal false, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "0260095933")
+      assert_equal false, DummyUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "02600959")
+      assert_equal false, DummyUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "0260095933")
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bank-validator
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Adam Bahlke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-31 00:00:00.000000000 Z
+date: 2015-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -214,6 +214,9 @@ files:
 - test/dummy/spec/spec_helper.rb
 - test/dummy/vendor/assets/javascripts/.keep
 - test/dummy/vendor/assets/stylesheets/.keep
+- test/dummy_classes.rb
+- test/dummy_classes/dummy_user.rb
+- test/dummy_classes/dummy_user2.rb
 - test/helper.rb
 - test/test_bank-validator.rb
 homepage: http://github.com/declarus/bank-validator