bank-validator 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ddd75b09500230fa5fccc407ffdf8bb27033bbb8
-  data.tar.gz: 93a3fb9f4af678aa20ef7e93d48a58918dd7f1e2
+  metadata.gz: ce72710f7f5b48fe94d61e369c631410fd437571
+  data.tar.gz: c70fa8f2e6775e95b94b6df61d28013eb9c064a1
 SHA512:
-  metadata.gz: eb2e939049927446444d8981164e4b4cc988f504160e3cb975548f29bb58e14c6539306b4b860b4ccff0430de22e8bf0ee02f04c424b08c6346f30479c6379b2
-  data.tar.gz: f3e57ca5df536bc694afb2a7186bd5aecf2ff1d05bddbb385cb566d36964e06914fab13a9a7f323174cfb3c0cb6013665394d84a9489088bb4e04db8a374b5b0
+  metadata.gz: 9b2818360426dde18ed7da0613ef33b993e789c94a5e537d5991226d69973359802a5abebb207bcecbde8db64235ed4f5e3946c07663d7e1d9c656c2a0bd998b
+  data.tar.gz: 9160b86ea2a11feb65ffcbfe40e0f048fdf3d30d8c73111e813367661ed93e2970c4ff5b6957d694563374fa63afdef61a200f6b0fe6040cb98454043e0c01ae

data/VERSION

@@ -1 +1 @@
-0.1.0
+0.2.0

data/bank-validator.gemspec

@@ -2,16 +2,16 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: bank-validator 0.1.0 ruby lib
+# stub: bank-validator 0.2.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "bank-validator"
-  s.version = "0.1.0"
+  s.version = "0.2.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
   s.authors = ["Adam Bahlke"]
-  s.date = "2015-03-30"
+  s.date = "2015-03-31"
   s.description = "Validates IBAN and BIC account numbers. Still a work in progress"
   s.email = "adam.bahlke@hitfoxgroup.com"
   s.extra_rdoc_files = [
@@ -29,6 +29,7 @@ Gem::Specification.new do |s|
     "bank-validator.gemspec",
     "lib/active_model/bic_validator.rb",
     "lib/active_model/iban_validator.rb",
+    "lib/active_model/routing_number_validator.rb",
     "lib/bank-validator.rb",
     "test/dummy/.gitignore",
     "test/dummy/.rspec",
@@ -72,6 +73,7 @@ Gem::Specification.new do |s|
     "test/dummy/config/routes.rb",
     "test/dummy/config/secrets.yml",
     "test/dummy/db/migrate/20150330083818_create_users.rb",
+    "test/dummy/db/migrate/20150331083155_add_routing_number_to_users.rb",
     "test/dummy/db/schema.rb",
     "test/dummy/db/seeds.rb",
     "test/dummy/lib/assets/.keep",

data/lib/active_model/routing_number_validator.rb

@@ -0,0 +1,24 @@
+require 'active_model'
+
+class RoutingNumberValidator < ActiveModel::EachValidator
+
+  def validate_each(record, attribute, value)
+    record_error(record, attribute, value) unless value =~ regexp && valid_routing_number?(value)
+  end
+  
+  private
+  
+  def record_error(record, attribute, value)
+    record.errors.add(attribute, :invalid_iban)
+  end
+  
+  def regexp
+    /^[0-9]{9}$/
+  end
+
+  def valid_routing_number?(route_number)
+    d = route_number.split(//)
+
+    ((3 * (d[0].to_i + d[3].to_i + d[6].to_i)) + (7 * (d[1].to_i + d[4].to_i + d[7].to_i)) + (d[2].to_i + d[5].to_i + d[8].to_i)) % 10 == 0
+  end
+end

data/lib/bank-validator.rb

@@ -1,7 +1,9 @@
 require_relative './active_model/iban_validator'
 require_relative './active_model/bic_validator'
+require_relative './active_model/routing_number_validator'
 
 module ActiveModel
   autoload :IbanValidator, './active_model/iban_validator'
   autoload :BicValidator, './active_model/bic_validator'
+  autoload :RoutingNumberValidator, './active_model/routing_number_validator'
 end

data/test/dummy/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ~/Workspace/bank-validator
   specs:
-    bank-validator (0.0.6)
+    bank-validator (0.1.0)
       activemodel (>= 3.0)
       activerecord (>= 3.0)
       activesupport (>= 3.0)

data/test/dummy/app/models/user.rb

@@ -1,4 +1,5 @@
 class User < ActiveRecord::Base
   validates :iban, iban: true
   validates :bic, bic: true
+  validates :routing_number, routing_number: true
 end

data/test/dummy/db/migrate/20150331083155_add_routing_number_to_users.rb

@@ -0,0 +1,5 @@
+class AddRoutingNumberToUsers < ActiveRecord::Migration
+  def change
+    add_column :users, :routing_number, :string
+  end
+end

data/test/dummy/db/schema.rb

@@ -11,14 +11,15 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20150330083818) do
+ActiveRecord::Schema.define(version: 20150331083155) do
 
   create_table "users", force: :cascade do |t|
     t.string   "name"
     t.string   "iban"
     t.string   "bic"
-    t.datetime "created_at", null: false
-    t.datetime "updated_at", null: false
+    t.datetime "created_at",     null: false
+    t.datetime "updated_at",     null: false
+    t.string   "routing_number"
   end
 
 end

data/test/dummy/spec/features/gem_testing_spec.rb

@@ -4,7 +4,7 @@ RSpec.describe 'testing the gem', type: :feature do
 
   context "validating iban" do
     before :each do
-      @user = User.create(name: 'Adam', iban: '', bic: 'DEUTDEFF500')
+      @user = User.create(name: 'Adam', iban: '', bic: 'DEUTDEFF500', routing_number: '226073523')
     end
 
     it 'validates a users iban' do
@@ -30,7 +30,7 @@ RSpec.describe 'testing the gem', type: :feature do
 
   context "validating bic" do
     before :each do
-      @user = User.create(name: 'Adam', iban: 'BE62510007547061', bic: '')
+      @user = User.create(name: 'Adam', iban: 'BE62510007547061', bic: '', routing_number: '226073523')
     end
 
     it 'validates a users bic' do
@@ -59,4 +59,26 @@ RSpec.describe 'testing the gem', type: :feature do
       expect(user.bic).to eq('DEUTDEFF500')
     end
   end
+
+  context "validating routing number" do
+    before :each do
+      @user = User.create(name: 'Adam', iban: 'BE62510007547061', bic: 'DEUTDEFF500', routing_number: '')
+    end
+
+    it 'validates a users routing number' do
+      @user.routing_number = '226073523'
+      expect(@user.save).to be(true)
+    end
+
+    it 'returns false for an invalid routing number' do
+      @user.routing_number = '22607352'
+      expect(@user.save).to be(false)
+
+      @user.routing_number = '2260735233'
+      expect(@user.save).to be(false)
+
+      @user.routing_number = '2260-7352-3'
+      expect(@user.save).to be(false)
+    end
+  end
 end

data/test/test_bank-validator.rb

@@ -6,12 +6,14 @@ class TestBankValidator < MiniTest::Test
     include ActiveModel::Validations
     validates :iban, iban: true
     validates :bic, bic: true
+    validates :routing_number, routing_number: true
 
     attr_accessor :iban
 
     def initialize(attributes = {})
       @iban = attributes[:iban]
       @bic = attributes[:bic]
+      @routing_number = attributes[:routing_number]
     end
 
     def save
@@ -33,47 +35,61 @@ class TestBankValidator < MiniTest::Test
     def bic
       @bic
     end
+
+    def routing_number
+      @routing_number
+    end
   end
 
   context "iban validator" do
     should "not save if the iban is too short" do
-      assert_equal false, TestUser.create(iban: "GB82WEST", bic: "DEUTDEBR")
+      assert_equal false, TestUser.create(iban: "GB82WEST", bic: "DEUTDEBR", routing_number: "026009593")
     end
 
     should "save if the iban is at least 16 characters" do
-      assert_equal true, TestUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR")
+      assert_equal true, TestUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR", routing_number: "026009593")
     end
 
     should "returns false if the iban does not leave a remainder of 1 when divided by 97" do
-      assert_equal false, TestUser.create(iban: "GB82WEST123456987654Df", bic: "DEUTDEBR")
+      assert_equal false, TestUser.create(iban: "GB82WEST123456987654Df", bic: "DEUTDEBR", routing_number: "026009593")
     end
 
     should "returns true if the iban returns a remainder of 1 when divided by 97" do
-      assert_equal true, TestUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR")
+      assert_equal true, TestUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR", routing_number: "026009593")
     end
 
     should "work for different IBAN formats" do
       #Belgium
-      assert_equal true, TestUser.create(iban: "BE62510007547061", bic: "DEUTDEBR")
+      assert_equal true, TestUser.create(iban: "BE62510007547061", bic: "DEUTDEBR", routing_number: "026009593")
 
       #Bulgaria
-      assert_equal true, TestUser.create(iban: "BG80BNBG96611020345678", bic: "DEUTDEBR")
+      assert_equal true, TestUser.create(iban: "BG80BNBG96611020345678", bic: "DEUTDEBR", routing_number: "026009593")
 
       #Germany
-      assert_equal true, TestUser.create(iban: "DE89370400440532013000", bic: "DEUTDEBR")
+      assert_equal true, TestUser.create(iban: "DE89370400440532013000", bic: "DEUTDEBR", routing_number: "026009593")
     end
   end
 
   context "bic validator" do
     should "be between 8 and 11 characters" do
-      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061")
-      assert_equal true, TestUser.create(bic: "DEUTDEBR123", iban: "BE62510007547061")
+      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
+      assert_equal true, TestUser.create(bic: "DEUTDEBR123", iban: "BE62510007547061", routing_number: "026009593")
     end
 
     should "start with 6 letters" do
-      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061")
-      assert_equal false, TestUser.create(bic: "DEUT22BR", iban: "BE62510007547061")
+      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
+      assert_equal false, TestUser.create(bic: "DEUT22BR", iban: "BE62510007547061", routing_number: "026009593")
+    end
+  end
+
+  context "routing number" do
+    should "be 9 digits long" do
+      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "026009593")
     end
 
+    should "return false if not 9 digits long" do
+      assert_equal false, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "02600959")
+      assert_equal false, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061", routing_number: "0260095933")
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bank-validator
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Adam Bahlke
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-30 00:00:00.000000000 Z
+date: 2015-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -154,6 +154,7 @@ files:
 - bank-validator.gemspec
 - lib/active_model/bic_validator.rb
 - lib/active_model/iban_validator.rb
+- lib/active_model/routing_number_validator.rb
 - lib/bank-validator.rb
 - test/dummy/.gitignore
 - test/dummy/.rspec
@@ -197,6 +198,7 @@ files:
 - test/dummy/config/routes.rb
 - test/dummy/config/secrets.yml
 - test/dummy/db/migrate/20150330083818_create_users.rb
+- test/dummy/db/migrate/20150331083155_add_routing_number_to_users.rb
 - test/dummy/db/schema.rb
 - test/dummy/db/seeds.rb
 - test/dummy/lib/assets/.keep