bank-validator 0.0.6 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 73aa72dcb3b94f3f1c58f0c996406c7931eecbcd
-  data.tar.gz: f1ec617013e30ffe8e8be14aa09ae97c163dc63e
+  metadata.gz: ddd75b09500230fa5fccc407ffdf8bb27033bbb8
+  data.tar.gz: 93a3fb9f4af678aa20ef7e93d48a58918dd7f1e2
 SHA512:
-  metadata.gz: 6c12eb467855a4f70b83ef4c43ed3e5fd4ac2955a16041dc8ac82f729821621b1e2da68ed753af965481848c98e642e2a7a5226368d22ca372ec7ea2a98451bb
-  data.tar.gz: 38018cdf9bc96940426dc25c18cd2dfe6a3eb5aec3538be8e710ffa985691043415011e1246ffd2388fd9a4ccadac7d9a468eac42febbe1f603f27722a9e465b
+  metadata.gz: eb2e939049927446444d8981164e4b4cc988f504160e3cb975548f29bb58e14c6539306b4b860b4ccff0430de22e8bf0ee02f04c424b08c6346f30479c6379b2
+  data.tar.gz: f3e57ca5df536bc694afb2a7186bd5aecf2ff1d05bddbb385cb566d36964e06914fab13a9a7f323174cfb3c0cb6013665394d84a9489088bb4e04db8a374b5b0

data/VERSION

@@ -1 +1 @@
-0.0.6
+0.1.0

data/bank-validator.gemspec

@@ -2,11 +2,11 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: bank-validator 0.0.6 ruby lib
+# stub: bank-validator 0.1.0 ruby lib
 
 Gem::Specification.new do |s|
   s.name = "bank-validator"
-  s.version = "0.0.6"
+  s.version = "0.1.0"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.require_paths = ["lib"]
@@ -27,6 +27,7 @@ Gem::Specification.new do |s|
     "Rakefile",
     "VERSION",
     "bank-validator.gemspec",
+    "lib/active_model/bic_validator.rb",
     "lib/active_model/iban_validator.rb",
     "lib/bank-validator.rb",
     "test/dummy/.gitignore",

data/lib/active_model/bic_validator.rb

@@ -0,0 +1,18 @@
+require 'active_model'
+
+class BicValidator < ActiveModel::EachValidator
+
+  def validate_each(record, attribute, value)
+    record_error(record, attribute, value) unless value =~ regexp
+  end
+  
+  private
+  
+  def record_error(record, attribute, value)
+    record.errors.add(attribute, :invalid_bic)
+  end
+
+  def regexp
+    /[A-Z]{6}[A-Z0-9]{2,}/
+  end
+end

data/lib/bank-validator.rb

@@ -1,5 +1,7 @@
 require_relative './active_model/iban_validator'
+require_relative './active_model/bic_validator'
 
 module ActiveModel
   autoload :IbanValidator, './active_model/iban_validator'
+  autoload :BicValidator, './active_model/bic_validator'
 end

data/test/dummy/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: ~/Workspace/bank-validator
   specs:
-    bank-validator (0.0.5)
+    bank-validator (0.0.6)
       activemodel (>= 3.0)
       activerecord (>= 3.0)
       activesupport (>= 3.0)

data/test/dummy/app/models/user.rb

@@ -1,3 +1,4 @@
 class User < ActiveRecord::Base
   validates :iban, iban: true
+  validates :bic, bic: true
 end

data/test/dummy/spec/features/gem_testing_spec.rb

@@ -1,27 +1,62 @@
 require 'rails_helper'
 
 RSpec.describe 'testing the gem', type: :feature do
-  before :each do
-    @user = User.create(name: 'Adam', iban: '', bic: '')
-  end
 
-  it 'validates a users iban' do
-    @user.iban = 'GB82WEST12345698765432'
-    expect(@user.save).to be(true)
-  end
+  context "validating iban" do
+    before :each do
+      @user = User.create(name: 'Adam', iban: '', bic: 'DEUTDEFF500')
+    end
 
-  it 'returns false for an invalid iban' do
-    @user.iban = 'YOLO'
-    expect(@user.save).to be(false)
-  end
+    it 'validates a users iban' do
+      @user.iban = 'GB82WEST12345698765432'
+      expect(@user.save).to be(true)
+    end
 
-  it 'validates a belgian users iban' do
-    @user.iban = 'BE62510007547061'
-    expect(@user.save).to be(true)
+    it 'returns false for an invalid iban' do
+      @user.iban = 'YOLO'
+      expect(@user.save).to be(false)
+    end
+
+    it 'validates a belgian users iban' do
+      @user.iban = 'BE62510007547061'
+      expect(@user.save).to be(true)
+    end
+
+    it 'creates a user with full iban' do
+      user = User.create(name: 'Adam', iban: 'BE62510007547061')
+      expect(user.iban).to eq('BE62510007547061')
+    end
   end
 
-  it 'creates a user with full iban' do
-    user = User.create(name: 'Adam', iban: 'BE62510007547061')
-    expect(user.iban).to eq('BE62510007547061')
+  context "validating bic" do
+    before :each do
+      @user = User.create(name: 'Adam', iban: 'BE62510007547061', bic: '')
+    end
+
+    it 'validates a users bic' do
+      @user.bic = 'DEUTDEBR'
+      expect(@user.save).to be(true)
+    end
+
+    it 'returns false for an invalid bic' do
+      @user.bic = 'YOLO'
+      expect(@user.save).to be(false)
+
+      @user.bic = 'D3UTDEBR'
+      expect(@user.save).to be(false)
+    end
+
+    it 'validates a different bic types' do
+      @user.bic = 'DEUTDEDBBER'
+      expect(@user.save).to be(true)
+
+      @user.bic = 'DEUTDEFF500'
+      expect(@user.save).to be(true)
+    end
+
+    it 'saves the bic' do
+      user = User.create(name: 'Adam', iban: 'BE62510007547061', bic: 'DEUTDEFF500')
+      expect(user.bic).to eq('DEUTDEFF500')
+    end
   end
 end

data/test/test_bank-validator.rb

@@ -5,11 +5,13 @@ class TestBankValidator < MiniTest::Test
   class TestUser
     include ActiveModel::Validations
     validates :iban, iban: true
+    validates :bic, bic: true
 
     attr_accessor :iban
 
     def initialize(attributes = {})
       @iban = attributes[:iban]
+      @bic = attributes[:bic]
     end
 
     def save
@@ -27,32 +29,51 @@ class TestBankValidator < MiniTest::Test
     def iban
       @iban
     end
-  end
 
-  should "not save if the iban is too short" do
-    assert_equal false, TestUser.create(iban: "GB82WEST")
+    def bic
+      @bic
+    end
   end
 
-  should "save if the iban is at least 16 characters" do
-    assert_equal true, TestUser.create(iban: "GB82WEST12345698765432")
-  end
+  context "iban validator" do
+    should "not save if the iban is too short" do
+      assert_equal false, TestUser.create(iban: "GB82WEST", bic: "DEUTDEBR")
+    end
 
-  should "returns false if the iban does not leave a remainder of 1 when divided by 97" do
-    assert_equal false, TestUser.create(iban: "GB82WEST123456987654Df")
-  end
+    should "save if the iban is at least 16 characters" do
+      assert_equal true, TestUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR")
+    end
+
+    should "returns false if the iban does not leave a remainder of 1 when divided by 97" do
+      assert_equal false, TestUser.create(iban: "GB82WEST123456987654Df", bic: "DEUTDEBR")
+    end
 
-  should "returns true if the iban returns a remainder of 1 when divided by 97" do
-    assert_equal true, TestUser.create(iban: "GB82WEST12345698765432")
+    should "returns true if the iban returns a remainder of 1 when divided by 97" do
+      assert_equal true, TestUser.create(iban: "GB82WEST12345698765432", bic: "DEUTDEBR")
+    end
+
+    should "work for different IBAN formats" do
+      #Belgium
+      assert_equal true, TestUser.create(iban: "BE62510007547061", bic: "DEUTDEBR")
+
+      #Bulgaria
+      assert_equal true, TestUser.create(iban: "BG80BNBG96611020345678", bic: "DEUTDEBR")
+
+      #Germany
+      assert_equal true, TestUser.create(iban: "DE89370400440532013000", bic: "DEUTDEBR")
+    end
   end
 
-  should "work for different IBAN formats" do
-    #Belgium
-    assert_equal true, TestUser.create(iban: "BE62510007547061")
+  context "bic validator" do
+    should "be between 8 and 11 characters" do
+      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061")
+      assert_equal true, TestUser.create(bic: "DEUTDEBR123", iban: "BE62510007547061")
+    end
 
-    #Bulgaria
-    assert_equal true, TestUser.create(iban: "BG80BNBG96611020345678")
+    should "start with 6 letters" do
+      assert_equal true, TestUser.create(bic: "DEUTDEBR", iban: "BE62510007547061")
+      assert_equal false, TestUser.create(bic: "DEUT22BR", iban: "BE62510007547061")
+    end
 
-    #Germany
-    assert_equal true, TestUser.create(iban: "DE89370400440532013000")
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bank-validator
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.1.0
 platform: ruby
 authors:
 - Adam Bahlke
@@ -152,6 +152,7 @@ files:
 - Rakefile
 - VERSION
 - bank-validator.gemspec
+- lib/active_model/bic_validator.rb
 - lib/active_model/iban_validator.rb
 - lib/bank-validator.rb
 - test/dummy/.gitignore