bank-contact 0.0.3 → 0.0.4

data/lib/bank.rb

@@ -1,9 +1,9 @@
-require "bank/version"
-require "pathname"
-require "yaml"
+require 'bank/version'
+require 'pathname'
+require 'yaml'
 
 module Bank
   def self.load_specifications(name)
-    YAML.load_file Pathname.new(__FILE__).dirname.parent + "data" + "#{name}.yml"
+    YAML.load_file Pathname.new(__FILE__).dirname.parent + 'data' + "#{name}.yml"
   end
 end

data/lib/bank/bban.rb

@@ -5,36 +5,36 @@ module Bank
     def initialize(country_code, code)
       @country_code, @code = country_code, code
     end
-    
+
     def to_s
       @code
     end
-    
+
     def valid?
       valid_length? && !data.nil?
     end
-    
+
     # the bban is the iban minus the first 4 characters (country_code, check_digits)
     def valid_length?
       specification && specification['length'] - 4  == @code.length
     end
-    
+
     [:account_number, :bank_identifier, :branch_identifier].each do |m|
       define_method(m) { data && data[m] }
     end
-    
+
     private
-    
+
     def data
-      @code.match(/^#{specification['regexp']}$/) if specification
+      @code.match(/^#{specification['regexp']}$/x) if specification
     end
-    
+
     def specification
       @specification ||= self.class.specifications[@country_code.downcase]
     end
-    
+
     def self.specifications
       @@specs ||= Bank.load_specifications(:iban)
     end
   end
-end
+end

data/lib/bank/bic.rb

@@ -1,40 +1,39 @@
-require "bank/validators/bic_validator" if defined? ActiveModel
+require 'bank/validators/bic_validator' if defined? ActiveModel
 
 module Bank
   class BIC
-    
     def self.valid?(code)
       new(code).valid?
     end
-    
+
     def initialize(code)
       @code = code.to_s.strip.gsub(/\s+/, '').upcase
     end
-    
+
     def bank_code
       @code[0..3]
     end
-    
+
     def country_code
       @code[4..5]
     end
-  
+
     def location_code
       @code[6..7]
     end
-    
+
     def branch_code
       @code[8..10]
     end
-    
+
     def to_s(formatted=false)
       formatted ? "#{bank_code} #{country_code} #{location_code} #{branch_code}".strip : @code
     end
-    
+
     def test?
       location_code[1] == '0'
     end
-    
+
     def passive?
       location_code[1] == '1'
     end
@@ -42,19 +41,19 @@ module Bank
     def reverse_billing?
       location_code[1] == '2'
     end
-    
+
     def valid?
       valid_length? && valid_format? && valid_location_code? && valid_branch_code?
     end
-    
+
     def valid_length?
       @code.length == 8 || @code.length == 11
     end
-    
+
     def valid_format?
-      @code =~ /^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$/
+      !!(@code =~ /^[A-Z]{4}[A-Z]{2}[A-Z0-9]{2}([A-Z0-9]{3})?$/)
     end
-    
+
     def valid_location_code?
       location_code[0] != '0' && location_code[0] != '1' && location_code[1] != 'O'
     end

data/lib/bank/contact.rb

@@ -4,30 +4,30 @@ require 'bank/bic'
 module Bank
   class Contact
     attr_reader :iban, :bic
-    
+
     def initialize(iban, bic)
       self.iban = iban
       self.bic  = bic
     end
-    
+
     def iban=(value)
       @iban = IBAN.new(value)
     end
-    
+
     def bic=(value)
       @bic = BIC.new(value)
     end
-    
+
     def valid?
       iban.valid? && bic.valid?
     end
-    
+
     def to_h
       { iban: iban.to_s, bic: bic.to_s }
     end
-    
+
     def to_a
       to_h.values
     end
   end
-end
+end

data/lib/bank/iban.rb

@@ -1,46 +1,46 @@
-require "forwardable"
-require "bank/bban"
-require "bank/validators/iban_validator" if defined? ActiveModel
+require 'forwardable'
+require 'bank/bban'
+require 'bank/validators/iban_validator' if defined? ActiveModel
 
 module Bank
   class IBAN # International Bank Account Number
     extend Forwardable
     def_delegators :bban, :account_number, :bank_identifier, :branch_identifier
-    
+
     def self.valid?(code)
       new(code).valid?
     end
-    
+
     def initialize(code)
       @code = code.to_s.strip.gsub(/\s+/, '').upcase
     end
-    
+
     def country_code
       @code[0..1]
     end
-    
+
     def check_digits
       @code[2..3]
     end
-    
+
     def bban
       @bban ||= BBAN.new(country_code, @code[4..-1])
     end
-    
+
     def valid?
       valid_check_digits? && bban.valid?
     end
-    
+
     def valid_check_digits?
       to_i % 97 == 1
     end
-    
+
     def to_i
       "#{bban}#{country_code}#{check_digits}".each_char.map { |chr| chr.to_i(36) }.join.to_i
     end
-    
+
     def to_s(formatted=false)
       formatted ? @code.gsub(/(.{4})/, '\1 ').strip : @code
     end
   end
-end
+end

data/lib/bank/validators/iban_validator.rb

@@ -4,4 +4,4 @@ class IbanValidator < ActiveModel::EachValidator
   def validate_each(record, attribute, value)
     record.errors.add(attribute, :invalid) unless Bank::IBAN.valid?(value)
   end
-end
+end

data/lib/bank/version.rb

@@ -1,3 +1,3 @@
 module Bank
-  VERSION = "0.0.3"
+  VERSION = '0.0.4'
 end

data/spec/activemodel_spec.rb

@@ -21,32 +21,31 @@ class Person
     false
   end
 end
-  
 
 describe IbanValidator do
   before {
     @model = Company.new
   }
-  
-  it "should be valid" do
+
+  it 'should be valid' do
     @model.iban = 'FR1420041010050500013M02606'
     @model.valid?.must_equal true
   end
-  
-  it "should not be valid" do
+
+  it 'should not be valid' do
     @model.iban = 'FR1420041010050500013'
     @model.valid?.must_equal false
-    @model.errors[:iban].must_include "is invalid"
+    @model.errors[:iban].must_include 'is invalid'
   end
-  
-  it "should not validate with nil value" do
+
+  it 'should not validate with nil value' do
     @model.iban.must_equal nil
     @model.valid?.must_equal false
   end
-  
-  it "should not use the validator with option allow_nil: true" do
+
+  it 'should not use the validator with option allow_nil: true' do
     @person = Person.new
     @person.iban.must_equal nil
     @person.valid?.must_equal true
   end
-end
+end

data/spec/bic_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+describe Bank::BIC do
+  before do
+    @bic = Bank::BIC.new('ABNACHZ8XXX')
+  end
+
+  it 'returns the right bank code' do
+    @bic.bank_code.must_equal 'ABNA'
+  end
+
+  it 'returns the right country code' do
+    @bic.country_code.must_equal 'CH'
+  end
+
+  it 'returns the right location code' do
+    @bic.location_code.must_equal 'Z8'
+  end
+
+  it 'returns the right branch code' do
+    @bic.branch_code.must_equal 'XXX'
+  end
+
+  [8, 11].each do |len|
+    describe 'x' * len do
+      it 'has a valid length' do
+        Bank::BIC.new('x' * len).valid_length?.must_equal true
+      end
+    end
+  end
+
+  1.upto(20) do |len|
+    if len != 8 && len != 11
+      describe 'x' * len do
+        it 'has a valid length' do
+          Bank::BIC.new('x' * len).valid_length?.must_equal false
+        end
+      end
+    end
+  end
+
+  [
+    'UCJAES2MXXX',
+    'ABAGATWWXXX',
+    'UCJAES2MXXX'
+  ].each do |code|
+    describe code do
+      it 'has a valid format' do
+        Bank::BIC.new(code).valid_format?.must_equal true
+      end
+    end
+  end
+
+  [
+    '12341234'
+  ].each do |code|
+    describe code do
+      it 'has an invalid format' do
+        Bank::BIC.new(code).valid_format?.must_equal false
+      end
+    end
+  end
+
+end

data/spec/contact_spec.rb

@@ -8,22 +8,23 @@ describe Bank::Contact do
     @bic  = Bank::BIC.new('BYLADEM1203')
     @contact = Bank::Contact.new(@iban, @bic)
   end
-  
-  it "should validate" do
+
+  it 'should validate' do
     @contact.valid?.must_equal true
   end
-  
-  it "should have the right types" do
+
+  it 'should have the right types' do
     @contact.iban.must_be_kind_of Bank::IBAN
     @contact.bic.must_be_kind_of Bank::BIC
   end
-  
-  it "should export to_h" do
-    @contact.to_h.must_equal({iban: "FR1420041010050500013M02606", bic: "BYLADEM1203"})
-  end
-  
-  it "should export to_a" do
-    @contact.to_a.must_equal(["FR1420041010050500013M02606", "BYLADEM1203"])
+
+  it 'should export to_h' do
+    @contact.to_h.must_equal(
+      iban: 'FR1420041010050500013M02606',
+      bic: 'BYLADEM1203')
   end
 
-end
+  it 'should export to_a' do
+    @contact.to_a.must_equal(['FR1420041010050500013M02606', 'BYLADEM1203'])
+  end
+end

data/spec/iban_spec.rb

@@ -1,150 +1,149 @@
 require 'spec_helper'
 
-
 describe Bank::IBAN do
   before do
     @iban = Bank::IBAN.new('FR14 2004 1010 0505 0001 3M026 06')
   end
-  
-  it "should valid from class method" do
+
+  it 'should valid from class method' do
     Bank::IBAN.valid?('FR14 2004 1010 0505 0001 3M026 06').must_equal true
   end
-  
-  it "should load the validation rules" do
+
+  it 'should load the validation rules' do
     Bank.load_specifications(:iban).wont_be :empty?
     Bank.load_specifications(:iban).must_be_kind_of Hash
   end
 
-  it "should return the county code" do
-    @iban.country_code.must_equal "FR"
+  it 'should return the county code' do
+    @iban.country_code.must_equal 'FR'
   end
- 
-  it "should return the check digits" do
-    @iban.check_digits.must_equal "14"
+
+  it 'should return the check digits' do
+    @iban.check_digits.must_equal '14'
   end
- 
-  it "should return the BBAN" do
-    @iban.bban.must_be_kind_of Bank::BBAN 
-    @iban.bban.to_s.must_equal "20041010050500013M02606"
+
+  it 'should return the BBAN' do
+    @iban.bban.must_be_kind_of Bank::BBAN
+    @iban.bban.to_s.must_equal '20041010050500013M02606'
   end
- 
-  it "should convert to integer value" do
+
+  it 'should convert to integer value' do
     @iban.to_i.must_equal 200410100505000132202606152714
   end
- 
-  it "should convert to string" do
+
+  it 'should convert to string' do
     @iban.to_s.must_equal 'FR1420041010050500013M02606'
   end
-  
-  it "should convert to formatted string" do
+
+  it 'should convert to formatted string' do
     @iban.to_s(true).must_equal 'FR14 2004 1010 0505 0001 3M02 606'
   end
 
-  it "should respond_to? account_number" do
+  it 'should respond_to? account_number' do
     @iban.respond_to?(:account_number).must_equal true
   end
 
-  it "should return account_number" do
-    @iban.account_number.must_equal "0500013M026"
+  it 'should return account_number' do
+    @iban.account_number.must_equal '0500013M026'
   end
-  
-  it "should return bank_identifier" do
-    @iban.bank_identifier.must_equal "20041"
+
+  it 'should return bank_identifier' do
+    @iban.bank_identifier.must_equal '20041'
   end
-  
-  it "should return branch_identifier" do
-    @iban.branch_identifier.must_equal "01005"
+
+  it 'should return branch_identifier' do
+    @iban.branch_identifier.must_equal '01005'
   end
-  
+
   [
-    "AL47212110090000000235698741",
-    "AD12 00012030200359100100",
-    "AT611904300234573201",
-    "BE68539007547034",
-    "BA391290079401028494",
-    "BG80BNBG96611020345678",
-    "HR1210010051863000160",
-    "CY17002001280000001200527600",
-    "CZ6508000000192000145399",
-    "DK5000400440116243",
-    "EE382200221020145685",
-    "FO1464600009692713",
-    "FI2112345600000785",
-    "FR1420041010050500013M02606",
-    "GE29NB0000000101904917",
-    "DE89370400440532013000",
-    "GI75NWBK000000007099453",
-    "GR1601101250000000012300695",
-    "GL8964710001000206",
-    "HU42117730161111101800000000",
-    "IS140159260076545510730339",
-    "IE29AIBK93115212345678",
-    "IT60X0542811101000000123456",
-    "LV80BANK0000435195001",
-    "LI21088100002324013AA",
-    "LT121000011101001000",
-    "LU280019400644750000",
-    "MK07300000000042425",
-    "MT84MALT011000012345MTLCAST001S",
-    "MD24AG000225100013104168",
-    "MC5813488000010051108001292",
-    "ME25505000012345678951",
-    "NL91ABNA0417164300",
-    "NO9386011117947",
-    "PL27114020040000300201355387",
-    "PT50000201231234567890154",
-    "RO49AAAA1B31007593840000",
-    "SM86U0322509800000000270100",
-    "RS35260005601001611379",
-    "SK3112000000198742637541",
-    "SI56191000000123438",
-    "ES9121000418450200051332",
-    "SE3550000000054910000003",
-    "CH9300762011623852957",
-    #"UA573543470006762462054925026",
-    "GB29NWBK60161331926819",
-    #"DZ4000400174401001050486",
-    "AO06000600000100037131174",
-    "AZ21NABZ00000000137010001944",
-    "BH29BMAG1299123456BH00",
-    "BJ11B00610100400271101192591",
-    "BR9700360305000010009795493P1",
-    "VG96VPVG0000012345678901",
-    "BF1030134020015400945000643",
-    "BI43201011067444",
-    "CM2110003001000500000605306",
-    "CV64000300004547069110176",
-    "FR7630007000110009970004942",
-    #"CG5230011000202151234567890",
-    "CR0515202001026284066",
-    "DO28BAGR00000001212453611324",
-    #"EG1100006001880800100014553",
-    #"GA2140002000055602673300064",
-    "GT82TRAJ01020000001210029690",
-    "IR580540105180021273113007",
-    "IL620108000000099999999",
-    "CI05A00060174100178530011852",
-    "KZ176010251000042993",
-    "KW74NBOK0000000000001000372151",
-    "LB30099900000001001925579115",
-    "MG4600005030010101914016056",
-    "ML03D00890170001002120000447",
-    "MR1300012000010000002037372",
-    "MU17BOMM0101101030300200000MUR",
-    "MZ59000100000011834194157",
-    "PK24SCBL0000001171495101",
-    "PS92PALS000000000400123456702",
-    "PT50000200000163099310355",
-    "SA0380000000608010167519",
-    "SN12K00100152000025690007542",
-    "TN5914207207100707129648",
-    "TR330006100519786457841326",
-    "AE260211000000230064016"
+    'AL47212110090000000235698741',
+    'AD12 00012030200359100100',
+    'AT611904300234573201',
+    'BE68539007547034',
+    'BA391290079401028494',
+    'BG80BNBG96611020345678',
+    'HR1210010051863000160',
+    'CY17002001280000001200527600',
+    'CZ6508000000192000145399',
+    'DK5000400440116243',
+    'EE382200221020145685',
+    'FO1464600009692713',
+    'FI2112345600000785',
+    'FR1420041010050500013M02606',
+    'GE29NB0000000101904917',
+    'DE89370400440532013000',
+    'GI75NWBK000000007099453',
+    'GR1601101250000000012300695',
+    'GL8964710001000206',
+    'HU42117730161111101800000000',
+    'IS140159260076545510730339',
+    'IE29AIBK93115212345678',
+    'IT60X0542811101000000123456',
+    'LV80BANK0000435195001',
+    'LI21088100002324013AA',
+    'LT121000011101001000',
+    'LU280019400644750000',
+    'MK07300000000042425',
+    'MT84MALT011000012345MTLCAST001S',
+    'MD24AG000225100013104168',
+    'MC5813488000010051108001292',
+    'ME25505000012345678951',
+    'NL91ABNA0417164300',
+    'NO9386011117947',
+    'PL27114020040000300201355387',
+    'PT50000201231234567890154',
+    'RO49AAAA1B31007593840000',
+    'SM86U0322509800000000270100',
+    'RS35260005601001611379',
+    'SK3112000000198742637541',
+    'SI56191000000123438',
+    'ES9121000418450200051332',
+    'SE3550000000054910000003',
+    'CH9300762011623852957',
+    'UA573543470006762462054925026',
+    'GB29NWBK60161331926819',
+    # 'DZ4000400174401001050486',
+    'AO06000600000100037131174',
+    'AZ21NABZ00000000137010001944',
+    'BH29BMAG1299123456BH00',
+    'BJ11B00610100400271101192591',
+    'BR9700360305000010009795493P1',
+    'VG96VPVG0000012345678901',
+    'BF1030134020015400945000643',
+    'BI43201011067444',
+    'CM2110003001000500000605306',
+    'CV64000300004547069110176',
+    'FR7630007000110009970004942',
+    # 'CG5230011000202151234567890',
+    'CR0515202001026284066',
+    'DO28BAGR00000001212453611324',
+    # 'EG1100006001880800100014553',
+    # 'GA2140002000055602673300064',
+    'GT82TRAJ01020000001210029690',
+    'IR580540105180021273113007',
+    'IL620108000000099999999',
+    'CI05A00060174100178530011852',
+    'KZ176010251000042993',
+    'KW74NBOK0000000000001000372151',
+    'LB30099900000001001925579115',
+    'MG4600005030010101914016056',
+    'ML03D00890170001002120000447',
+    'MR1300012000010000002037372',
+    'MU17BOMM0101101030300200000MUR',
+    'MZ59000100000011834194157',
+    'PK24SCBL0000001171495101',
+    'PS92PALS000000000400123456702',
+    'PT50000200000163099310355',
+    'SA0380000000608010167519',
+    'SN12K00100152000025690007542',
+    'TN5914207207100707129648',
+    'TR330006100519786457841326',
+    'AE260211000000230064016'
   ].each do |code|
     describe code do
-      it "should be valid" do
+      it 'should be valid' do
         Bank::IBAN.new(code).valid?.must_equal true
       end
     end
   end
-end
+end