banco 1.0.2 → 1.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c230ed99ba0f6d76fa738cc6ff8a3ea55173c6051765bff9971591b669df8fc
-  data.tar.gz: 12a1a50bd2fed725e4b339b212e2ba71342a240ef4a98639faa69894e60fa1c1
+  metadata.gz: ce7ba84a2102c4036382a535b0da7a40ea8d0e5230ecb5bed701f63ae823febd
+  data.tar.gz: 03fd4cd2808134359200dd681f9b1c6905f0aa86c9c0c3e96a5407ab7aaa8839
 SHA512:
-  metadata.gz: ee6561fc735f9ecbda6673c264c48d9ef71bfb8a1f2483e6a9feee865469c0a7f2d36c1d239e9220ff1ab71350575b2af5b000447035e20ce95ec0f47eba8be0
-  data.tar.gz: ef5106aad369fd69f76c0425127db3fb0287281914075417a863ce501f902baa5d81d6b2ee365edda16e3b34f66dfa06bad7c8ee1e10317dac1ceec3a44ebacd
+  metadata.gz: d0155da256d6bd565971b345a5c0ee55cf6af5f141edd348869698f58c75f781260952ae59663b84896b65c584484abdd4cc855c2bfdca681b17620a80ebd70c
+  data.tar.gz: e22296a81318c9b612de090e568991e80967ff834ae51255a0541ddf175910468b87333e2fc93643b6feb9c9c42fdea1caac910727a7a3850a143c8e47e4487e

data/bin/banco

@@ -6,45 +6,48 @@ require_relative '../lib/banco/reader'
 require_relative '../lib/banco/reporter'
 
 module Banco
+  def self.starter
+    Viewable::prompt
+    begin
+      file = GetFile.new
+      reader = Reader.new(file.csv_file_name, file.summary_name)
+      reader.read_in_csv_data
+      Reporter.new(reader.csv_file_name, reader.report_name, reader.all_from_csv)
+    rescue
+      puts "try again or 'q' to exit".center(54)
+      retry
+    end
+  end
 
-	def self.starter
-		Viewable::prompt
-		file = GetFile.new
-		reader = Reader.new(file.csv_file_name, file.summary_name)
-		reader.read_in_csv_data
-		Reporter.new(reader.csv_file_name, reader.report_name, reader.all_from_csv)
-	end
-
-	Viewable::hello
-	report = starter
-	loop do
-		report.menu
-		answer = gets.chomp.downcase
-		case answer
-		when 'a'
-			print report.transactions_all
-		when 'o'
-			print report.transactions_out
-		when "i"
-			print report.transactions_in
-		when "m"
-			print report.money_out_summary
-		when "n"
-			print report.money_in_summary
-		when "b"
-			print report.bottom_line
-		when "l"
-			report = starter
-		when "s"
-			report.save_summary_to_file
-		when "t"
-			report.save_transactions_to_file
-		when "q"
-			break
-		else
-			report.menu
-		end
-	end
-	Viewable::farewell
+  Viewable::hello
+  report = starter
+  loop do
+    report.menu
+    answer = gets.chomp.downcase
+    case answer
+    when 'a'
+      print report.transactions_all
+    when 'o'
+      print report.transactions_out
+    when 'i'
+      print report.transactions_in
+    when 'm'
+      print report.money_out_summary
+    when 'n'
+      print report.money_in_summary
+    when 'b'
+      print report.bottom_line
+    when 'l'
+      report = starter
+    when 's'
+      report.save_summary_to_file
+    when 't'
+      report.save_transactions_to_file
+    when 'q'
+      break
+    else
+      report.menu
+    end
+  end
+  Viewable::farewell
 end
-

data/lib/banco/get_file.rb

@@ -1,41 +1,43 @@
+
 module Banco
-	class GetFile
-		attr_reader :name, :csv_file_name, :summary_name
+  class GetFile
+    attr_reader :name, :csv_file_name, :summary_name
 
-		def initialize
-			@csv_file_name = gets.chomp.downcase
-			if @csv_file_name == 'q'
-				Viewable::farewell
-				exit
-			else
-				file_checker_cleaner(@csv_file_name)
-				@name = @csv_file_name.split('.').first
-				@doctype = @csv_file_name.split('.').last
-				@summary_name = @name
-				@csv_file_name
-			end
-		end
+    def initialize
+      @csv_file_name = gets.chomp.downcase
+      if @csv_file_name == 'q'
+        Viewable::farewell
+        exit
+      else
+        file_checker_cleaner(@csv_file_name)
+        @name = @csv_file_name.split('.').first
+        make_name
+      end
+    end
 
-		def file_checker_cleaner(filename)
-			if filename =~/([^\s]+(\.csv)$)/
-				puts "\nloading #{filename}..."
-			else
-				puts "#{filename} won't work !".center(54)
-				puts "try again or 'q' to exit".center(54)
-				make_name
-			end
-		end
+    def make_name
+      @name = @csv_file_name.split('.').first
+      @doctype = @csv_file_name.split('.').last
+      @summary_name = @name
+      @csv_file_name
+    end
 
-	end
+    def file_checker_cleaner(filename)
+      if filename =~ /([^\s]+(\.csv)$)/
+        puts "\nloading #{filename}..."
+      else
+        puts "#{filename} isn't a valid file for Banco !".center(54)
+        throw
+      end
+    end
+  end
 end
 
-if __FILE__ == $0
-	file = Banco::GetFile.new()
-	file.make_name
-	puts "\n\n\n"
-	p file.valid_file
-	p file.name
-	p file.summary_name
+if $PROGRAM_NAME == __FILE__
+  file = Banco::GetFile.new
+  file.make_name
+  puts "\n\n\n"
+  p file.valid_file
+  p file.name
+  p file.summary_name
 end
-
-

data/lib/banco/reader.rb

@@ -1,67 +1,64 @@
+
 require_relative 'transaction'
 require_relative 'viewable'
 require 'csv'
 
 module Banco
-	class Reader
-		include Viewable
-
-		attr_reader :all_from_csv, :report_name, :csv_file_name
-
-		def initialize(csv_file_name, report_name)
-			@csv_file_name = csv_file_name
-			@report_name = report_name
-			@all_from_csv = []
-		end
+  class Reader
+    include Viewable
 
-		def read_in_csv_data
-			begin
-				@csv_row_count = 1
+    attr_reader :all_from_csv, :report_name, :csv_file_name
 
-				CSV.foreach(csv_file_name) do |row|
-					all_from_csv << Transaction.new(row[0],row[1],row[2],row[3],row[4],@csv_row_count)
-					@csv_row_count += 1
-				end
+    def initialize(csv_file_name, report_name)
+      @csv_file_name = csv_file_name
+      @report_name = report_name
+      @all_from_csv = []
+    end
 
-			rescue ArgumentError => e
-				non_numeric_in_csv(e, @csv_row_count)
-				puts "sorted ? ('y' to continue or 'q' to exit)".rjust(54)
-				input = gets.chomp.downcase
-				@all_from_csv = []
-				input == "y" ? retry : Viewable::farewell
+    def read_in_csv_data
+      @csv_row_count = 1
 
-			rescue Errno::ENOENT => e
-				puts "Can't find file #{@csv_file_name} - have another go or (q) quit\n\n"
-				loop do
-					input = gets.chomp.downcase
-					case input
-						when 'q'
-							Viewable::farewell
-							exit
-						when /([^\s]+(\.csv)$)/
-							@csv_file_name = input
-							break
-						else
-		    			puts "\ninvalid file - try again or 'q' to quit\n\n"
-	    			end
-    		end
-  		retry
-		end
-	end
-
-		def non_numeric_in_csv(exception, row_number)
-            reason = exception.message.split(':')
-            puts "Please check row #{row_number} of #{@csv_file_name},"
-            puts "#{reason.last} should be a numeric value".rjust(54)
+      CSV.foreach(csv_file_name) do |row|
+        all_from_csv << Transaction.new(row[0], row[1], row[2], row[3], row[4], @csv_row_count)
+        @csv_row_count += 1
+      end
+      rescue ArgumentError => e
+        non_numeric_in_csv(e, @csv_row_count)
+        puts "sorted ? ('y' to continue or 'q' to exit)".rjust(54)
+        input = gets.chomp.downcase
+        @all_from_csv = []
+        input == 'y' ? retry : Viewable.farewell
+      rescue Errno::ENOENT => e
+        puts "Can't find file #{@csv_file_name} - have another go or (q) quit\n\n"
+        loop do
+          input = gets.chomp.downcase
+          case input
+          when 'q'
+            Viewable.farewell
+            exit
+          when /([^\s]+(\.csv)$)/
+            @csv_file_name = input
+            break
+          else
+            puts "\ninvalid file - try again or 'q' to quit\n\n"
+          end
         end
-	end
+      retry
+    end
+
+    def non_numeric_in_csv(exception, row_number)
+      reason = exception.message.split(':')
+      puts "Please check row #{row_number} of #{@csv_file_name},"
+      puts "#{reason.last} should be a numeric value".rjust(54)
+    end
+  end
 end
 
-if __FILE__ == $0
-    reader = Banco::Reader.new("test.csv", "test")
-    reader.read_in_csv_data
-    puts reader.report_name
-    puts reader.csv_file_name
-    puts reader.all_from_csv
-    p reader
+if $PROGRAM_NAME == __FILE__
+  reader = Banco::Reader.new('test.csv', 'test')
+  reader.read_in_csv_data
+  puts reader.report_name
+  puts reader.csv_file_name
+  puts reader.all_from_csv
+  p reader
 end

data/lib/banco/reporter.rb

@@ -1,3 +1,4 @@
+
 require_relative 'transaction'
 require_relative 'reader'
 require_relative 'viewable'
@@ -5,72 +6,69 @@ require 'csv'
 
 module Banco
   class Reporter
-
     include Viewable
 
-		attr_reader :all_transactions,
-								:outgoing_trans,
-								:incoming_trans,
-								:outgoings,
-								:incomings,
-								:outgoing_total,
-								:incoming_total,
-								:name,
-								:csv_file_name
+    attr_reader :all_transactions,
+                :outgoing_trans,
+                :incoming_trans,
+                :outgoings,
+                :incomings,
+                :outgoing_total,
+                :incoming_total,
+                :name,
+                :csv_file_name
 
-		def initialize(csv_file_name, report_name, transactions)
-			@csv_file_name = csv_file_name
-			@name = report_name
-			@all_transactions = transactions
-			@outgoing_trans = []
-			@incoming_trans = []
-			@outgoings = Hash.new(0)
-			@incomings = Hash.new(0)
-			puts "formating data..."
-			remove_blank_lines
-			split_in_out
-			total_outgoing
-			total_incoming
-			puts "\n\n"
-		end
+    def initialize(csv_file_name, report_name, transactions)
+      @csv_file_name = csv_file_name
+      @name = report_name
+      @all_transactions = transactions
+      @outgoing_trans = []
+      @incoming_trans = []
+      @outgoings = Hash.new(0)
+      @incomings = Hash.new(0)
+      puts 'formating data...'
+      remove_blank_lines
+      split_in_out
+      total_outgoing
+      total_incoming
+      puts "\n\n"
+    end
 
+    def remove_blank_lines
+      @all_transactions.delete_if { |trans| trans.moneyin.zero? && trans.moneyout.zero? }
+    end
 
-		def remove_blank_lines
-			@all_transactions.delete_if{|trans| trans.moneyin == 0 && trans.moneyout == 0}
-		end
+    def split_in_out
+      @outgoing_trans, @incoming_trans = @all_transactions.partition { |trans| trans.moneyin.zero? && trans.moneyout.positive? }
+    end
 
-		def split_in_out
-			@outgoing_trans, @incoming_trans = @all_transactions.partition{|trans| trans.moneyin == 0 && trans.moneyout > 0}
-		end
+    def total_outgoing
+      @outgoing_trans.each { |trans| @outgoings[trans.description[0..8]] += trans.moneyout }
+      @outgoing_total = @outgoings.values.map.reduce(:+)
+    end
 
-		def total_outgoing
-			@outgoing_trans.each{|trans| @outgoings[trans.description[0..8]] += trans.moneyout}
-			@outgoing_total = @outgoings.values.map.reduce(:+)
-		end
-
-		def total_incoming
-			@incoming_trans.each{|trans| @incomings[trans.description[0..8]] += trans.moneyin}
-			@incoming_total = @incomings.values.map.reduce(:+)
-		end
-	end
+    def total_incoming
+      @incoming_trans.each { |trans| @incomings[trans.description[0..8]] += trans.moneyin }
+      @incoming_total = @incomings.values.map.reduce(:+)
+    end
+  end
 end
 
-
-if __FILE__ == $0
-    reader = Banco::Reader.new("test.csv", "test")
-    reader.read_in_csv_data
-    puts "\n\n\n#all csv data from reader object\n\n"
-    puts "#{reader.all_from_csv}\n\n"
-    report = Banco::Reporter.new(reader.csv_file_name, reader.report_name, reader.all_from_csv)
-    puts "#{report.name} is the Reporter object's name\nReporter object contents below, (3 arrays, 2 hashes):\n\n"
-    puts "\n\nall transactions array\n"
-    p report.all_transactions
-    puts "\n\noutgoings array\n"
-    p report.outgoing_trans
-    puts "\n\nincomings array\n"
-    p report.incoming_trans
-    puts "\n\nOutgoings hash\n"
-    p report.outgoings
-    puts "\n\nIncomings hash\n"
-    p report.incomings
+if $PROGRAM_NAME == __FILE__
+  reader = Banco::Reader.new('test.csv', 'test')
+  reader.read_in_csv_data
+  puts "\n\n\n#all csv data from reader object\n\n"
+  puts "#{reader.all_from_csv}\n\n"
+  report = Banco::Reporter.new(reader.csv_file_name, reader.report_name, reader.all_from_csv)
+  puts "#{report.name} is the Reporter object's name\nReporter object contents below, (3 arrays, 2 hashes):\n\n"
+  puts "\n\nall transactions array\n"
+  p report.all_transactions
+  puts "\n\noutgoings array\n"
+  p report.outgoing_trans
+  puts "\n\nincomings array\n"
+  p report.incoming_trans
+  puts "\n\nOutgoings hash\n"
+  p report.outgoings
+  puts "\n\nIncomings hash\n"
+  p report.incomings
 end

data/lib/banco/transaction.rb

@@ -1,31 +1,32 @@
+
 module Banco
-	class Transaction
-		require 'bigdecimal'
-		attr_reader :date, :description, :type, :moneyin, :moneyout, :csv_row_count
+  class Transaction
+    require 'bigdecimal'
+    attr_reader :date, :description, :type, :moneyin, :moneyout, :csv_row_count
 
-		def initialize(date_string, description, type, moneyin, moneyout, csv_row_count)
-			@csv_row_count = csv_row_count
-			@moneyin = convert(moneyin)
-			@moneyout = convert(moneyout)
-			@date = date_string
-			@description = '%-22.22s' % "#{description.upcase}"
-			@type = '%-8.8s' % "#{type.upcase}"
-		end
+    def initialize(date_string, description, type, moneyin, moneyout, csv_row_count)
+      @csv_row_count = csv_row_count
+      @moneyin = convert(moneyin)
+      @moneyout = convert(moneyout)
+      @date = date_string
+      @description = format('%-22.22s', description.upcase.to_s)
+      @type = format('%-8.8s', type.upcase.to_s)
+    end
 
-		def convert(money)
-			money.nil? ?  BigDecimal('0') : BigDecimal(money)
-	  end
+    def convert(money)
+      money.nil? ? BigDecimal('0') : BigDecimal(money)
+    end
 
-		def to_s
-			"#{date} #{type} #{description}"
-		end
-	end
+    def to_s
+      "#{date} #{type} #{description}"
+    end
+  end
 end
 
-if __FILE__ == $0
-	trans = Banco::Transaction.new("01/01/17", "Supermarket","Purchase", "72.90", "0","1")
-	p trans
-	t = Banco::Transaction.new
-	t.send(:initialize, "02/02/18", "new way", "credit", "0", '111.11','2')
-	p t
+if $PROGRAM_NAME == __FILE__
+  trans = Banco::Transaction.new('01/01/17', 'Supermarket', 'Purchase', '72.90', '0', '1')
+  p trans
+  t = Banco::Transaction.new
+  t.send(:initialize, '02/02/18', 'new way', 'credit', '0', '111.11', '2')
+  p t
 end

data/lib/banco/viewable.rb

@@ -1,3 +1,4 @@
+
 module Banco
   module Viewable
     def menu
@@ -15,16 +16,16 @@ module Banco
     end
 
     def to_pounds(money)
-      format = sprintf("%10.2f", money.truncate(2))
+      format = format('%10.2f', money.truncate(2))
       "£#{format}"
     end
 
     def dashes
-      "---".center(55,"-")
+      '---'.center(55, '-')
     end
 
     def date_range
-      "(#{self.all_transactions.last.date} - #{self.all_transactions.first.date})"
+      "(#{all_transactions.last.date} - #{all_transactions.first.date})"
     end
 
     def facts(transactions)
@@ -32,59 +33,59 @@ module Banco
     end
 
     def money_out_summary
-      print_summary("Outgoings", self.outgoings, self.outgoing_total)
+      print_summary('Outgoings', outgoings, outgoing_total)
     end
 
     def money_in_summary
-      print_summary("Incomings", self.incomings, self.incoming_total)
+      print_summary('Incomings', incomings, incoming_total)
     end
 
     def transactions_all
-      output = ""
+      output = ''
       output << dashes
       output << "\n"
       output << "All transactions:\n"
-      output << "#{facts(self.all_transactions)}\n\n"
-      self.all_transactions.each do |trans|
-        if trans.moneyout == 0
-          output << "#{trans} + #{to_pounds(trans.moneyin)}\n"
-        else
-          output << "#{trans} - #{to_pounds(trans.moneyout)}\n"
-        end
+      output << "#{facts(all_transactions)}\n\n"
+      all_transactions.each do |trans|
+        output << if trans.moneyout == 0
+                    "#{trans} + #{to_pounds(trans.moneyin)}\n"
+                  else
+                    "#{trans} - #{to_pounds(trans.moneyout)}\n"
+                  end
       end
       output << dashes
       output << "\n\n"
     end
 
     def transactions_out
-      output = ""
+      output = ''
       output << dashes
       output << "\n"
       output << "Outgoing Transactions:\n"
-      output << "#{facts(self.outgoing_trans)}\n\n"
-      self.outgoing_trans.each{|trans| output << "#{trans} - #{to_pounds(trans.moneyout)}\n"}
+      output << "#{facts(outgoing_trans)}\n\n"
+      outgoing_trans.each { |trans| output << "#{trans} - #{to_pounds(trans.moneyout)}\n" }
       output << dashes
       output << "\n\n"
     end
 
     def transactions_in
-      output = ""
+      output = ''
       output << dashes
       output << "\n"
       output << "Incoming Transactions :\n"
-      output << "#{facts(self.incoming_trans)}\n\n"
-      self.incoming_trans.each{|trans| output << "#{trans} + #{to_pounds(trans.moneyin)}\n"}
+      output << "#{facts(incoming_trans)}\n\n"
+      incoming_trans.each { |trans| output << "#{trans} + #{to_pounds(trans.moneyin)}\n" }
       output << dashes
       output << "\n\n"
     end
 
     def print_summary(kind, hash, total)
-      output = ""
+      output = ''
       output << dashes
       output << "\n"
       output << "#{kind} Summary, totals from #{hash.size} different sources :\n"
       output << "#{date_range}\n"
-      hash.sort_by{|_k,v| v}.reverse.each{|k,v| output << "#{k} #{to_pounds(v)}\n".rjust(54)}
+      hash.sort_by { |_k, v| v }.reverse.each { |k, v| output << "#{k} #{to_pounds(v)}\n".rjust(54) }
       output << "\n"
       output << "Total #{kind}: #{to_pounds(total)}\n".rjust(54)
       output << dashes
@@ -92,21 +93,21 @@ module Banco
     end
 
     def bottom_line
-      output = ""
+      output = ''
       output << dashes
       output << "\n"
-      output << "#{facts(self.all_transactions)}".rjust(54)
+      output << facts(all_transactions).to_s.rjust(54)
       output << "\n\n"
-      output << "Money In  : #{to_pounds(self.incoming_total)}".rjust(54)
+      output << "Money In  : #{to_pounds(incoming_total)}".rjust(54)
       output << "\n"
-      output << "Money Out : #{to_pounds(self.outgoing_total)}".rjust(54)
+      output << "Money Out : #{to_pounds(outgoing_total)}".rjust(54)
       output << "\n\n"
-      diff = self.incoming_total - self.outgoing_total
-        if self.outgoing_total > self.incoming_total
-          output << "Outgoings exceed Incomings, DEFICIT of #{to_pounds(diff)}".rjust(54)
-        else
-          output << "Incomings exceed Outgoings, SURPLUS of #{to_pounds(diff)}".rjust(54)
-        end
+      diff = incoming_total - outgoing_total
+      output << if outgoing_total > incoming_total
+                  "Outgoings exceed Incomings, DEFICIT of #{to_pounds(diff)}".rjust(54)
+                else
+                  "Incomings exceed Outgoings, SURPLUS of #{to_pounds(diff)}".rjust(54)
+                end
       output << "\n"
       output << dashes
       output << "\n\n"
@@ -114,67 +115,67 @@ module Banco
 
     def self.farewell
       puts "\n\n"
-      puts "*".center(55,'*')
-      puts "  Banco  ".center(55,'*')
-      puts "  hope your numbers were positive  ".center(55,'*')
-      puts "   code@s33d.co   ".center(55,'*')
-      puts "*".center(55,'*')
+      puts '*'.center(55, '*')
+      puts '  Banco  '.center(55, '*')
+      puts '  hope your numbers were positive  '.center(55, '*')
+      puts '  ♥️  code@s33d.co   '.center(56, '*')
+      puts '*'.center(55, '*')
       puts "\n\n\n"
       exit
     end
 
     def self.hello
       puts "\n\n"
-      puts "Banco will summarize your bank statements.".center(55)
-      puts "import a .csv file for review".center(55)
+      puts 'Banco will summarize your bank statements.'.center(55)
+      puts 'import a .csv file for review'.center(55)
       puts "\n\n"
-      puts "the .csv file should have :".center(55)
-      puts "NO headers".center(55)
-      puts "with columns ordered (left to right)".center(55)
-      puts "date - description - type - money in - money out".center(55)
-      puts "all additional columns will be ignored".center(55)
+      puts 'the .csv file should have :'.center(55)
+      puts 'NO headers'.center(55)
+      puts 'with columns ordered (left to right)'.center(55)
+      puts 'date - description - type - money in - money out'.center(55)
+      puts 'all additional columns will be ignored'.center(55)
     end
 
     def self.prompt
       puts "\n\n"
-      puts "Enter the name of you .csv file to review".center(54)
+      puts 'Enter the name of you .csv file to review'.center(54)
       puts "(use 'test.csv' for the test file)".center(54)
       puts "or 'q' to quit...".center(55)
       puts "\n\n"
     end
 
-    def save_summary_to_file(to_file="#{self.name}_summary.txt")
-      File.open(to_file, "w") do |file|
+    def save_summary_to_file(to_file = "#{name}_summary.txt")
+      File.open(to_file, 'w') do |file|
+        t = Time.now
+        file.puts t.strftime("\n\nprinted : %d %b %y at %I:%M%P")
+        file.puts "summarized by Banco from #{csv_file_name}"
+        file.puts "\n"
+        file.puts money_out_summary
+        file.puts "\n"
+        file.puts money_in_summary
+        file.puts "\n"
+        file.puts bottom_line
+        file.puts "\n"
+        file.puts '♥️ code@s33d.co'.rjust(54)
+      end
+      puts "\n\nfile saved as #{name}_summary.txt\n\n"
+    end
+
+    def save_transactions_to_file(to_file = "#{name}_transactions.txt")
+      File.open(to_file, 'w') do |file|
         t = Time.now
         file.puts t.strftime("\n\nprinted : %d %b %y at %I:%M%P")
-        file.puts "summarized by Banco from #{self.csv_file_name}"
+        file.puts "summarized by Banco from #{csv_file_name}"
         file.puts "\n"
-        file.puts self.money_out_summary
+        file.puts transactions_out
         file.puts "\n"
-        file.puts self.money_in_summary
+        file.puts transactions_in
         file.puts "\n"
-        file.puts self.bottom_line
+        file.puts bottom_line
         file.puts "\n"
-        file.puts "code@s33d.co".rjust(54)
+        file.puts '♥️ code@s33d.co'.rjust(54)
       end
-      puts "\n\nfile saved as #{self.name}_summary.txt\n\n"
-    end
-
-    def save_transactions_to_file(to_file="#{self.name}_transactions.txt")
-        File.open(to_file, "w") do |file|
-          t = Time.now
-          file.puts t.strftime("\n\nprinted : %d %b %y at %I:%M%P")
-          file.puts "summarized by Banco from #{self.csv_file_name}"
-          file.puts "\n"
-          file.puts self.transactions_out
-          file.puts "\n"
-          file.puts self.transactions_in
-          file.puts "\n"
-          file.puts self.bottom_line
-          file.puts "\n"
-          file.puts "code@s33d.co".rjust(54)
-        end
-        puts "\n\nfile saved as #{self.name}_transactions.txt\n\n"
+      puts "\n\nfile saved as #{name}_transactions.txt\n\n"
     end
   end
 end

data/spec/banco/reader_spec.rb

@@ -1,14 +1,16 @@
+# frozen_string_literal: true
+
 require 'banco/reader'
 module Banco
-	describe Reader do 
-		before do
-			csv_file_name = "test.csv"
-			report_name = "test"
-			@testreader = Banco::Reader.new(csv_file_name, report_name)
-			@testreader.read_in_csv_data
-		end
-		it "should produce an array for all rows on csv file" do
-			expect(@testreader.all_from_csv.length).to eq(10)
-		end
-	end
+  describe Reader do
+    before do
+      csv_file_name = 'test.csv'
+      report_name = 'test'
+      @testreader = Banco::Reader.new(csv_file_name, report_name)
+      @testreader.read_in_csv_data
+    end
+    it 'should produce an array for all rows on csv file' do
+      expect(@testreader.all_from_csv.length).to eq(10)
+    end
+  end
 end

data/spec/banco/reporter_spec.rb

@@ -1,54 +1,55 @@
+# frozen_string_literal: true
+
 require 'banco/reporter'
 require 'banco/reader'
 module Banco
-	describe Reporter do 
-		before do
-			csv_file_name = "test.csv"
-			report_name = "test"
-			@testreader = Banco::Reader.new(csv_file_name, report_name)
-			@testreader.read_in_csv_data
-			@tester = Banco::Reporter.new('test.csv', 'test', @testreader.all_from_csv)
-			@tester.remove_blank_lines
-            @tester.split_in_out
-            @tester.total_outgoing
-            @tester.total_incoming
-		end
-
-		it "should remove transactions with zero values (moneyin / moneyout)" do
-			expect(@tester.all_transactions.size).to eq(8)
-		end
-		
-
-		it "should produce an array of incoming transactions" do
-		    expect(@tester.incoming_trans.size).to eq(4)
-		end
-
-		it "should produce an array of outgoing transactions" do
-			expect(@tester.outgoing_trans.size).to eq(4)
-		end
-
-		it "should produce a hash of outgoing transactions" do
-			expect(@tester.outgoings.size).to eq(2)
-		end
-
-		it "should produce a hash of incoming transactions" do
-			expect(@tester.incomings.size).to eq(2)
-		end
-
-		it "should sum incoming transactions by matching description string" do
-			expect(@tester.incomings['INCOMING2']).to eq(183.34)
-		end
-
-		it "should sum outgoing transactions by matching description string" do
-			expect(@tester.outgoings['OUTGOING2']).to eq(182.68)
-		end
-
-		it "should sum total incoming transactions" do
-			expect(@tester.incoming_total).to eq(321.58)
-		end
-
-		it "should sum total outgoing transactions" do
-			expect(@tester.outgoing_total).to eq(320.92)
-		end
-	end
-end
+  describe Reporter do
+    before do
+      csv_file_name = 'test.csv'
+      report_name = 'test'
+      @testreader = Banco::Reader.new(csv_file_name, report_name)
+      @testreader.read_in_csv_data
+      @tester = Banco::Reporter.new('test.csv', 'test', @testreader.all_from_csv)
+      @tester.remove_blank_lines
+      @tester.split_in_out
+      @tester.total_outgoing
+      @tester.total_incoming
+    end
+
+    it 'should remove transactions with zero values (moneyin / moneyout)' do
+      expect(@tester.all_transactions.size).to eq(8)
+    end
+
+    it 'should produce an array of incoming transactions' do
+      expect(@tester.incoming_trans.size).to eq(4)
+    end
+
+    it 'should produce an array of outgoing transactions' do
+      expect(@tester.outgoing_trans.size).to eq(4)
+    end
+
+    it 'should produce a hash of outgoing transactions' do
+      expect(@tester.outgoings.size).to eq(2)
+    end
+
+    it 'should produce a hash of incoming transactions' do
+      expect(@tester.incomings.size).to eq(2)
+    end
+
+    it 'should sum incoming transactions by matching description string' do
+      expect(@tester.incomings['INCOMING2']).to eq(183.34)
+    end
+
+    it 'should sum outgoing transactions by matching description string' do
+      expect(@tester.outgoings['OUTGOING2']).to eq(182.68)
+    end
+
+    it 'should sum total incoming transactions' do
+      expect(@tester.incoming_total).to eq(321.58)
+    end
+
+    it 'should sum total outgoing transactions' do
+      expect(@tester.outgoing_total).to eq(320.92)
+    end
+  end
+end

data/spec/banco/transaction_spec.rb

@@ -1,47 +1,49 @@
+# frozen_string_literal: true
+
 require 'banco/transaction'
 
 module Banco
-	describe Transaction do
-		before do
-			@trans1 = Transaction.new("12/01/17","some transaction", "credit", "57.91", "0.00", "1")
-			@trans2 = Transaction.new("13/01/17","some other transaction", "debit", "0.00", "57.91",'2')
-		end
-
-		# it "Should convert money in values to pence" do
-		#  	expect(@trans1.moneyin).to eq(5791)
-		# end
-
-		# it "Should convert money out values to pence" do
-		# 	expect(@trans2.moneyout).to eq(5791)
-		# end
-
-		it "Should have a description string of 22 characters (upcase)" do
-			expect(@trans2.description).to eq("SOME OTHER TRANSACTION")
-			expect(@trans1.description).to eq("SOME TRANSACTION      ")
-		end
-
-		it "Should have a type string upcased and 8 characters long" do
-			expect(@trans2.type).to eq("DEBIT   ")
-		end
-
-		it "Should have a date string" do
-			expect(@trans1.date).to eq("12/01/17")
-		end
-
-		it "Should have a row number" do
-			expect(@trans2.csv_row_count).to eq("2")
-		end
-
-		it "should have a to_s of all date description type" do
-			expect(@trans1.to_s).to eq("12/01/17 CREDIT   SOME TRANSACTION      ")
-		end
-
-		it "convert empty strings in money columns to integers" do
-			expect(@trans1.moneyout).to eq(0)
-		end
-
-		it "convert empty strings in money columns to integers" do
-			expect(@trans2.moneyin).to eq(0)
-		end
-	end
+  describe Transaction do
+    before do
+      @trans1 = Transaction.new('12/01/17', 'some transaction', 'credit', '57.91', '0.00', '1')
+      @trans2 = Transaction.new('13/01/17', 'some other transaction', 'debit', '0.00', '57.91', '2')
+    end
+
+    # it "Should convert money in values to pence" do
+    #    expect(@trans1.moneyin).to eq(5791)
+    # end
+
+    # it "Should convert money out values to pence" do
+    #   expect(@trans2.moneyout).to eq(5791)
+    # end
+
+    it 'Should have a description string of 22 characters (upcase)' do
+      expect(@trans2.description).to eq('SOME OTHER TRANSACTION')
+      expect(@trans1.description).to eq('SOME TRANSACTION      ')
+    end
+
+    it 'Should have a type string upcased and 8 characters long' do
+      expect(@trans2.type).to eq('DEBIT   ')
+    end
+
+    it 'Should have a date string' do
+      expect(@trans1.date).to eq('12/01/17')
+    end
+
+    it 'Should have a row number' do
+      expect(@trans2.csv_row_count).to eq('2')
+    end
+
+    it 'should have a to_s of all date description type' do
+      expect(@trans1.to_s).to eq('12/01/17 CREDIT   SOME TRANSACTION      ')
+    end
+
+    it 'convert empty strings in money columns to integers' do
+      expect(@trans1.moneyout).to eq(0)
+    end
+
+    it 'convert empty strings in money columns to integers' do
+      expect(@trans2.moneyin).to eq(0)
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: banco
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.0.3
 platform: ruby
 authors:
 - s33d
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-14 00:00:00.000000000 Z
+date: 2019-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec