bambora-client 0.1.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60f0ed5088f0e4f5b63e9335431dffc7562d2239d237a08ac45cbc116f118fce
-  data.tar.gz: 59bd1a213dde32eb67be6802e5621cf527c64e9b50a835fe754ecb663588a8fd
+  metadata.gz: c558cd0eb1fa8548cbe1f789247e8212eef01751816352f16a5de1d481c8d976
+  data.tar.gz: 41c21bf3ff0c31642177d5f7cd170a9cf955903a8f451d4f4c6f0a8a281366b9
 SHA512:
-  metadata.gz: 4bdbdf83b22c92b96bb6c04f71cfbfaaa2f5679e94cb2b00b431398cf09624f34e334201bcbe1e4efd2b4bd4bfb4a17c87058dfec438bff0c913075060a04411
-  data.tar.gz: 194b507146db394ceee4d59848a2126422224752d68f391fd8f866db5a9d0fc5785e4b22b2de4b94d9710d7bf0a58e0687d8e69053bb7819d1be7254ea1ca853
+  metadata.gz: 53e587d5ae1e54ce4042d80f1e5a9869cad0a11d47a733322ceeca1f4a727fdbc86a70b9e029a358413d2044a7dc3209c6988230c25bc46f08ef62a60dcf6640
+  data.tar.gz: 467774ca8f4ea52e0fc23e91a41182d67a162bcc7554083c6824437800bb9f8f9909bfca9ec8752b224aebf75f2b8cad281f5cc0a20959f8e668524c7743d95a

data/.github/workflows/gempush.yml

@@ -0,0 +1,31 @@
+name: Ruby Gem
+
+on:
+  push:
+    tags:
+      - v* # Only run when we carve a new tag
+
+jobs:
+  build:
+    name: Build + Publish
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - name: Set up Ruby 2.6
+      uses: actions/setup-ruby@v1
+      with:
+        ruby-version: 2.6.x
+
+    - name: Publish to RubyGems
+      run: |
+        mkdir -p $HOME/.gem
+        touch $HOME/.gem/credentials
+        chmod 0600 $HOME/.gem/credentials
+        printf -- "---\n:rubygems_api_key: ${GEM_HOST_API_KEY}\n" > $HOME/.gem/credentials
+        gem build *.gemspec
+        gem push *.gem
+      env:
+        GEM_HOST_API_KEY: ${{secrets.RUBYGEMS_AUTH_TOKEN}}
+
+

data/.gitignore

@@ -9,3 +9,7 @@
 
 # rspec failure tracking
 .rspec_status
+bambora-client-*.gem
+
+# Ruby-specific files
+Gemfile.lock

data/CHANGELOG.md

@@ -0,0 +1,24 @@
+## 0.3.0 (2020-05-27)
+
+- Add `Bambora::V1::ProfileResource#update` method
+
+## 0.2.0 (2020-05-11)
+
+- Add `Bambora::V1::ProfileResource#get` method
+
+## 0.1.3 (2020-04-30)
+
+- Ensure Batch Report returns empty array `:record` in response at the very least
+
+## 0.1.2 (2020-04-14)
+
+- Fix nil record with Bank Batch Report returns
+
+## 0.1.1 (2020-03-04)
+
+- Upgrade `rake` to `13.0.1`
+- Update README to notify Bambora dev support when functionality changes
+
+## 0.1.0 (2020-02-03)
+
+- First major release

data/README.md

@@ -92,6 +92,31 @@ profiles.delete(customer_code: '02355E2e58Bf488EAB4EaFAD7083dB6A')
 #    }
 ```
 
+### Update a Profile
+
+```ruby
+profiles.update(
+  customer_code: '02355E2e58Bf488EAB4EaFAD7083dB6A',
+  payment_profile_data: {
+    language: 'en',
+    comments: 'hello',
+    card: {
+      name: 'Hup Podling',
+      number: '4030000010001234',
+      expiry_month: '12',
+      expiry_year: '23',
+      cvd: '123',
+    },
+  },
+)
+
+# => {
+#      :code => 1,
+#      :message => "Operation Successful",
+#      :customer_code => "02355E2e58Bf488EAB4EaFAD7083dB6A",
+#    }
+```
+
 ### Payments
 
 *Summary*: Process payments using Credit Card, Payment Profile, Legato Token, Cash, Cheque, Interac, Apple Pay, or
@@ -188,6 +213,10 @@ Bug reports and pull requests are welcome on GitHub at
 intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the
 [Contributor Covenant](http://contributor-covenant.org) code of conduct.
 
+Your contributions are important. For larger changes to the behaviour of this client, or when adding new pieces of
+functionality, please inform Bambora. You can get in touch with their
+[developer support](https://dev.na.bambora.com/docs/support/) for advice.
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).

data/bambora-client.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
   if spec.respond_to?(:metadata)
-    spec.metadata['allowed_push_host'] = "https://rubygems.org"
+    spec.metadata['allowed_push_host'] = 'https://rubygems.org'
 
     spec.metadata['homepage_uri'] = spec.homepage
     spec.metadata['source_code_uri'] = 'https://github.com/HiMamaInc/bambora-client'
@@ -47,7 +47,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'bundler', '~> 2'
   spec.add_development_dependency 'pry', '~> 0.12.0'
   spec.add_development_dependency 'pry-byebug', '~> 3.7'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'rspec_junit_formatter', '~> 0.4.1'
   spec.add_development_dependency 'rubocop', '~> 0.74.0'

data/lib/bambora/bank/batch_report_resource.rb

@@ -53,17 +53,28 @@ module Bambora
       #
       #  @params profile_data [Hash] with values as noted in the example.
       def show(report_data)
-        add_messages_to_response(
-          client.post(path: sub_path, body: batch_report_body(report_data)),
-        )
+        response = client.post(path: sub_path, body: batch_report_body(report_data))
+
+        response = ensure_record_key_exists(response)
+        response = add_messages_to_response(response)
+
+        response
       end
 
       private
 
+      def ensure_record_key_exists(response)
+        # bambora can return null or empty record results, fill it in for consistency
+        response.dig(:response)[:record] = [] if response.dig(:response, :record).nil?
+
+        response
+      end
+
       def add_messages_to_response(response)
         response.dig(:response, :record).map! do |record|
           record.merge!(messages: record[:messageId].split(',').map { |id| MESSAGES[id] })
         end
+
         response
       end
 

data/lib/bambora/client/version.rb

@@ -2,6 +2,6 @@
 
 module Bambora
   class Client
-    VERSION = '0.1.0'
+    VERSION = '0.3.0'
   end
 end

data/lib/bambora/rest/client.rb

@@ -38,6 +38,10 @@ module Bambora
         end
       end
 
+      def put(path:, body:, headers:)
+        connection.put(path, body, headers)
+      end
+
       def connection
         @connection ||= Faraday.new(url: base_url) do |faraday|
           faraday.request :multipart

data/lib/bambora/rest/json_client.rb

@@ -99,6 +99,55 @@ module Bambora
         ).to_h
       end
 
+      # Make a PUT Request.
+      #
+      # @example
+      #
+      #   client = Bambora::Rest::JSONClient(base_url: '...', merchant_id: '...')
+      #
+      #   data = {
+      #     billing: {
+      #        name: "joh doe",
+      #        address_line1: "123 main st",
+      #        address_line2: "111",
+      #        city: "victoria",
+      #        province: "bc",
+      #        country: "ca",
+      #        postal_code: "V8T4M3",
+      #        phone_number: "25012312345",
+      #        email_address: "bill@smith.com"
+      #     },
+      #     card: {
+      #       name: 'Hup Podling',
+      #       number: '4030000010001234',
+      #       expiry_month: '12',
+      #       expiry_year: '23',
+      #       cvd: '123',
+      #     },
+      #   }
+      #
+      #   client.put(
+      #     path: 'v1/profiles',
+      #     body: data,
+      #     api_key: '...'
+      #   )
+      #   # => {
+      #   #      :code => 1,
+      #   #      :message => "Operation Successful",
+      #   #      :customer_code => "02355E2e58Bf488EAB4EaFAD7083dB6A",
+      #   #    }
+      #
+      # @param path [String] Indicating request path.
+      # @param body [Hash] Data to be sent in the body of the request.
+      # @param api_key [String] Indicating the API Key to be used with the request.
+      #
+      # @return [Hash] Indicating success or failure of the operation.
+      def put(path:, body:, api_key:)
+        parse_response_body(
+          super(path: path, body: body.to_json.to_s, headers: build_headers(api_key: api_key)),
+        ).to_h
+      end
+
       private
 
       def build_headers(api_key:)

data/lib/bambora/v1/profile_resource.rb

@@ -54,8 +54,94 @@ module Bambora
       # @see https://dev.na.bambora.com/docs/guides/payment_profiles
       #
       # @return [Hash] Indicating success or failure of the operation.
-      def create(card_data)
-        client.post(path: sub_path, body: card_data, api_key: api_key)
+      def create(payment_profile_data)
+        client.post(path: sub_path, body: payment_profile_data, api_key: api_key)
+      end
+
+      ##
+      # Get a Bambora payment profile given a customer code.
+      #
+      # @example
+      #
+      #   client = Bambora::Rest::JSONClient(base_url: '...', api_key: '...', merchant_id: '...')
+      #   profiles = Bambora::V1::ProfileResource(client: client)
+      #   customer_code = '02355E2e58Bf488EAB4EaFAD7083dB6A'
+      #
+      #   profiles.get(customer_code: customer_code)
+      #   # => {
+      #   #      :code => 1,
+      #   #      :message => "Operation Successful",
+      #   #      :customer_code => "02355E2e58Bf488EAB4EaFAD7083dB6A",
+      #   #      :status => "A",
+      #   #      :last_transaction => "1900-01-01T00:00:00",
+      #   #      :modified_date => "1900-01-01T00:00:00",
+      #   #      :card => { :name => "", :number => "", :card_type => "" },
+      #   #      :language => "en",
+      #   #      :velocity_group => "",
+      #   #      :profile_group => "",
+      #   #      :account_ref => "",
+      #   #      :billing =>
+      #   #        {
+      #   #          :name => "Harry Lewis",
+      #   #          :address_line1 => "",
+      #   #          :address_line2 => "",
+      #   #          :city => "",
+      #   #          :province => "",
+      #   #          :country => "",
+      #   #          :postal_code => "",
+      #   #          :phone_number => "",
+      #   #          :email_address => ""},
+      #   #      :custom => { :ref1 => "", :ref2 => "", :ref3 => "", :ref4 => "", :ref5 => "" }}
+      #
+      # @param customer_code [String] A unique identifier for the associated payment profile.
+      #
+      # @return [Hash] Payment profile details.
+      def get(customer_code:)
+        client.get(path: "#{sub_path}/#{customer_code}", api_key: api_key)
+      end
+
+      # Make a PUT Request.
+      #
+      # @example
+      #
+      #   client = Bambora::Rest::JSONClient(base_url: '...', api_key: '...', merchant_id: '...')
+      #   profiles = Bambora::V1::ProfileResource(client: client)
+      #   customer_code = '02355E2e58Bf488EAB4EaFAD7083dB6A'
+      #
+      #   data = {
+      #     billing: {
+      #        name: "joh doe",
+      #        address_line1: "123 main st",
+      #        address_line2: "111",
+      #        city: "victoria",
+      #        province: "bc",
+      #        country: "ca",
+      #        postal_code: "V8T4M3",
+      #        phone_number: "25012312345",
+      #        email_address: "bill@smith.com"
+      #     },
+      #     card: {
+      #       name: 'Hup Podling',
+      #       number: '4030000010001234',
+      #       expiry_month: '12',
+      #       expiry_year: '23',
+      #       cvd: '123',
+      #     },
+      #   }
+      #
+      #   profiles.update(customer_code: customer_code, payment_profile_data: data)
+      #   # => {
+      #   #      :code => 1,
+      #   #      :message => "Operation Successful",
+      #   #      :customer_code => "02355E2e58Bf488EAB4EaFAD7083dB6A",
+      #   #    }
+      #
+      # @param customer_code [String] A unique identifier for the associated payment profile.
+      # @param data [Hash] Payment profile data to be sent in the body of the request.
+      #
+      # @return [Hash] Indicating success or failure of the operation.
+      def update(customer_code:, payment_profile_data:)
+        client.put(path: "#{@sub_path}/#{customer_code}", body: payment_profile_data, api_key: api_key)
       end
 
       ##

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bambora-client
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Cassidy K
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-02-03 00:00:00.000000000 Z
+date: 2020-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: excon
@@ -114,14 +114,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -187,15 +187,16 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/gempush.yml"
 - ".github/workflows/linter.yml"
 - ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".ruby-version"
+- CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
-- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -249,7 +250,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubyforge_project: 
+rubygems_version: 2.7.6.2
 signing_key: 
 specification_version: 4
 summary: A thread-safe client for the Bambora/Beanstream API.

data/Gemfile.lock

@@ -1,93 +0,0 @@
-PATH
-  remote: .
-  specs:
-    bambora-client (0.1.0)
-      excon (< 1.0)
-      faraday (< 1.0)
-      gyoku (~> 1.0)
-      multiparty (~> 0)
-
-GEM
-  remote: https://rubygems.org/
-  specs:
-    addressable (2.7.0)
-      public_suffix (>= 2.0.2, < 5.0)
-    ast (2.4.0)
-    builder (3.2.4)
-    byebug (11.0.1)
-    coderay (1.1.2)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.3)
-    excon (0.71.0)
-    faraday (0.17.1)
-      multipart-post (>= 1.2, < 3)
-    gyoku (1.3.1)
-      builder (>= 2.1.2)
-    hashdiff (1.0.0)
-    jaro_winkler (1.5.3)
-    method_source (0.9.2)
-    mime-types (3.3)
-      mime-types-data (~> 3.2015)
-    mime-types-data (3.2019.1009)
-    multipart-post (2.1.1)
-    multiparty (0.2.0)
-      mime-types
-    parallel (1.18.0)
-    parser (2.6.5.0)
-      ast (~> 2.4.0)
-    pry (0.12.2)
-      coderay (~> 1.1.0)
-      method_source (~> 0.9.0)
-    pry-byebug (3.7.0)
-      byebug (~> 11.0)
-      pry (~> 0.10)
-    public_suffix (4.0.1)
-    rainbow (3.0.0)
-    rake (10.5.0)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.0)
-      rspec-support (~> 3.9.0)
-    rspec-expectations (3.9.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.0)
-      diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.0)
-    rspec_junit_formatter (0.4.1)
-      rspec-core (>= 2, < 4, != 2.12.0)
-    rubocop (0.74.0)
-      jaro_winkler (~> 1.5.1)
-      parallel (~> 1.10)
-      parser (>= 2.6)
-      rainbow (>= 2.2.2, < 4.0)
-      ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 1.7)
-    ruby-progressbar (1.10.1)
-    safe_yaml (1.0.5)
-    unicode-display_width (1.6.0)
-    webmock (3.7.6)
-      addressable (>= 2.3.6)
-      crack (>= 0.3.2)
-      hashdiff (>= 0.4.0, < 2.0.0)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  bambora-client!
-  bundler (~> 2)
-  pry (~> 0.12.0)
-  pry-byebug (~> 3.7)
-  rake (~> 10.0)
-  rspec (~> 3.0)
-  rspec_junit_formatter (~> 0.4.1)
-  rubocop (~> 0.74.0)
-  webmock (~> 3.7)
-
-BUNDLED WITH
-   2.1.0