bambora-batch_upload 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: acb069dcdbfe02b49c8349cb4d01467e025cbcfc
-  data.tar.gz: e10a43dca939849439d38ccb9cabd1285a43970b
+  metadata.gz: 5df6239fae3d7858fa64bbb6036702411fe78272
+  data.tar.gz: 9a65c41b2139546a702425319b1d655a7e13e5b9
 SHA512:
-  metadata.gz: bd175d85e4b2029b272901e657fb0cdd7a00b55a8d1f5510f661990dc112cb3c978f9b8f416d1f2a86d9e7d96bcc2c0f7c8377adcb343a821f6ca12aca442d91
-  data.tar.gz: 99048ba19f2e18b55ae3b5b1dda97ada5c43d6eb1f21a1f5e636b9b1c9a619fc2f1b0e998310ba29f0f87fa1a85db23c3ae1bc11bcfb5f4a2120b4c6d446dcee
+  metadata.gz: 0de1d46a82f52e230e0a025413c05fc18336a010ce2901e6a08989148ab312b14f62438f6f7524f1d26c52d158f2c77dc58e42a307d052c5ac6cd688e496bbe7
+  data.tar.gz: b4e450f72aedaabd5d3493f7e3b0f8d9200aec5665bb5650bb2929593fdcca601fef947f4b053bfda9237a700d9819895a4a4ab5a523d2ad93116c41a4d610b0

data/.rvmrc

@@ -0,0 +1,60 @@
+#!/usr/bin/env bash
+
+# This is an RVM Project .rvmrc file, used to automatically load the ruby
+# development environment upon cd'ing into the directory
+
+# First we specify our desired <ruby>[@<gemset>], the @gemset name is optional,
+# Only full ruby name is supported here, for short names use:
+#     echo "rvm use 2.3.3@bambora" > .rvmrc
+environment_id="ruby-2.3.3@bambora-batch_upload"
+
+# Uncomment the following lines if you want to verify rvm version per project
+# rvmrc_rvm_version="1.29.2 (master)" # 1.10.1 seems like a safe start
+# eval "$(echo ${rvm_version}.${rvmrc_rvm_version} | __rvm_awk -F. '{print "[[ "$1*65536+$2*256+$3" -ge "$4*65536+$5*256+$6" ]]"}' )" || {
+#   echo "This .rvmrc file requires at least RVM ${rvmrc_rvm_version}, aborting loading."
+#   return 1
+# }
+
+# First we attempt to load the desired environment directly from the environment
+# file. This is very fast and efficient compared to running through the entire
+# CLI and selector. If you want feedback on which environment was used then
+# insert the word 'use' after --create as this triggers verbose mode.
+if [[ -d "${rvm_path:-$HOME/.rvm}/environments"
+  && -s "${rvm_path:-$HOME/.rvm}/environments/$environment_id" ]]
+then
+  \. "${rvm_path:-$HOME/.rvm}/environments/$environment_id"
+  for __hook in "${rvm_path:-$HOME/.rvm}/hooks/after_use"*
+  do
+    if [[ -f "${__hook}" && -x "${__hook}" && -s "${__hook}" ]]
+    then \. "${__hook}" || true
+    fi
+  done
+  unset __hook
+  if (( ${rvm_use_flag:=1} >= 1 )) # display automatically
+  then
+    if [[ $- == *i* ]] # check for interactive shells
+    then printf "%b" "Using: $(tput setaf 2 2>/dev/null)$GEM_HOME$(tput sgr0 2>/dev/null)\n" # show the user the ruby and gemset they are using in green
+    else printf "%b" "Using: $GEM_HOME\n" # don't use colors in non-interactive shells
+    fi
+  fi
+else
+  # If the environment file has not yet been created, use the RVM CLI to select.
+  rvm --create use  "$environment_id" || {
+    echo "Failed to create RVM environment '${environment_id}'."
+    return 1
+  }
+fi
+
+# If you use bundler, this might be useful to you:
+# if [[ -s Gemfile ]] && {
+#   ! builtin command -v bundle >/dev/null ||
+#   builtin command -v bundle | GREP_OPTIONS="" \command \grep $rvm_path/bin/bundle >/dev/null
+# }
+# then
+#   printf "%b" "The rubygem 'bundler' is not installed. Installing it now.\n"
+#   gem install bundler
+# fi
+# if [[ -s Gemfile ]] && builtin command -v bundle >/dev/null
+# then
+#   bundle install | GREP_OPTIONS="" \command \grep -vE '^Using|Your bundle is complete'
+# fi

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bambora-batch_upload (0.1.0)
+    bambora-batch_upload (0.1.1)
       curb (= 0.9.3)
       holidays
 

data/README.md

@@ -40,8 +40,20 @@ To create a batch file and then upload:
 ```ruby
   #payment type has to be D (debit) or C (credit)
   #amount must be specified in pennies
+  #if reference is not specified, it will be set to 0
+  #recipient and dynamic descriptor are optional
   Bambora::BatchUpload.create_file do |reader|
-    reader.push_into_file(payment_type: "D", amount: 100, reference: 33, customer_code: "XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX") 
+    reader.push_into_file(payment_type: "D", amount: 100, reference: 34, 
+                          customer_code: "C6777B381C16434B82d40A8d23a19a68",
+                          dynamic_descriptor: "Wesam Corp") 
+    reader.push_into_file(payment_type: "D",
+                          institution_number: "123",
+                          transit_number: "12345",
+                          account_number: "123458",
+                          amount: 200,
+                          reference: 667,
+                          recipient: "Haddad"
+                          )
     ##more lines
     #reader.push_into_file(...)
   end

data/lib/bambora/batch_upload.rb

@@ -56,13 +56,14 @@ module Bambora
       def push_into_file(params)
         validate_args params
         array << OpenStruct.new(txn_type:      params[:payment_type],
-                                transit:       params[:transit_number].to_s,
                                 institution:   params[:institution_number].to_s,
+                                transit:       params[:transit_number].to_s,
                                 account:       params[:account_number].to_s,
                                 amount:        params[:amount],
-                                ref:           params[:reference].to_s,
+                                ref:           (params[:reference] || 0 ).to_s,
                                 recipient:     params[:recipient].to_s,
-                                customer_code: params[:customer_code].to_s
+                                customer_code: params[:customer_code].to_s,
+                                descriptor:    params[:dynamic_descriptor].to_s
                                )
       end
       private
@@ -73,9 +74,9 @@ module Bambora
         unless params[:payment_type] == "D" || params[:payment_type] == "C"
           raise ArgumentError, "Must provide payment type: C (credit) or D (debit)" 
         end
-        if params[:customer_code].nil? && (params[:transit_number] || 
-                                           params[:institution_number] ||
-                                           params[:account_number])
+        if params[:customer_code].nil? && (params[:transit_number].nil? || 
+                                           params[:institution_number].nil? ||
+                                           params[:account_number].nil?)
           raise ArgumentError, "Must either provide customer code or transit, institution, and account #s"
         end
       end

data/lib/bambora/batch_upload/create_batch_file.rb

@@ -39,13 +39,14 @@ module Bambora::BatchUpload
       txn_array.each do |txn|
         string << "E,"
         string << "#{txn.txn_type}," #C for Credit, D for Debit
-        string << "#{txn.transit},"
         string << "#{txn.institution},"
+        string << "#{txn.transit},"
         string << "#{txn.account},"
         string << "#{txn.amount},"
         string << "#{txn.ref},"
         string << "#{txn.recipient},"
-        string << "#{txn.customer_code}"
+        string << "#{txn.customer_code},"
+        string << "#{txn.descriptor}"
         string << "\r\n"
       end
       string

data/lib/bambora/batch_upload/version.rb

@@ -1,5 +1,5 @@
 module Bambora
   module BatchUpload
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/lib/extensions/date.rb

@@ -24,7 +24,7 @@ class Date
   end
 
   def sub_day? 
-    self.wday == self.class.monday && ( (self-1.day).holiday?(:ca_bc) || (self-2.day).holiday?(:ca_bc) )
+    self.wday == self.class.monday && ( (self-1).holiday?(:ca_bc) || (self-2).holiday?(:ca_bc) )
   end
 
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bambora-batch_upload
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - alwesam
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-11-24 00:00:00.000000000 Z
+date: 2017-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: curb
@@ -89,6 +89,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rvmrc"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile