ballou_sms_gateway 1.0.0 → 2.0.0

data/Readme.md

@@ -52,8 +52,8 @@ The `send!` method returns a request object with the following methods.
 - **request_id** (String) Request ID defined by you using the `request_id` method, or an auto-generated UUID string.
 - **sms_id** (String) ID defined by you using the `id` method, or an auto-generated UUID string.
 - **to** (String) Receiver specified by you using the `to` method.
-- **send?** (Boolean) Was the SMS send?
-- **valid?** (Boolean) Alias for `send?`.
+- **sent?** (Boolean) Was the SMS sent?
+- **valid?** (Boolean) Alias for `sent?`.
 - **error** (Fixnum) Error code. `0` if everything went okay.
 - **status** (Fixnum) Status code. `-1` means that the SMS was added to Ballou's queue.
 - **message** (String) A message from Ballou. This is set when a request goes wrong.

data/ballou_sms_gateway.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |gem|
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   gem.name          = "ballou_sms_gateway"
   gem.require_paths = ["lib"]
-  gem.version       = "1.0.0"
+  gem.version       = "2.0.0"
   
   gem.add_dependency("rest-client", "~> 1.6.7")
   gem.add_dependency("uuid", "~> 2.3.4")

data/lib/ballou_sms_gateway/request.rb

@@ -7,7 +7,7 @@ module BallouSmsGatewayModule
     #
     # @return Boolean Did everything went okay?
     #
-    def send?
+    def sent?
       error == 0
     end
     
@@ -19,6 +19,6 @@ module BallouSmsGatewayModule
       @error.to_i
     end
     
-    alias_method :valid?, :send?
+    alias_method :valid?, :sent?
   end
 end

data/lib/ballou_sms_gateway.rb

@@ -92,14 +92,14 @@ class BallouSmsGateway
   #
   # @to A list of phonenumbers. Can contain 0-9 and the "+" sign.
   # @return BallouSmsGateway
-  def to(*to)
-    to.flatten.each do |number|
+  def to(*receivers)
+    receivers.flatten.each do |number|
       unless number.to_s.match(/^\+?[0-9]{4,}$/)
         raise "Invalid receiver."
       end
     end
     
-    @to = to.flatten.map { |number| number }.join(",")
+    @to = receivers.flatten.join(",")
     return self
   end
   
@@ -107,21 +107,21 @@ class BallouSmsGateway
   # @from String Sender. Max length when only numbers are submitet; 15, otherwise; 10
   # @return BallouSmsGateway
   #
-  def from(from)
-    if from.to_s.length.zero?
+  def from(sender)
+    if sender.to_s.length.zero?
       raise "Sender is invalid, to short."
     end
     
     # Max length 15 for integers and 10 for chars 
-    if from.match(/^[0-9]+$/)
-      if  from.length > 15
+    if sender.match(/^[0-9]+$/)
+      if  sender.length > 15
         raise "Sender is invalid, to long."
       end
-    elsif from.length > 10
+    elsif sender.length > 10
       raise "Sender is invalid, to long."
     end
     
-    @from = from
+    @from = sender
     return self
   end
   

data/spec/ballou_sms_gateway_spec.rb

@@ -145,7 +145,7 @@ describe BallouSmsGateway do
       request.status.should eq(-1)
       request.error.should eq(0)
       request.message.should be_empty
-      request.should be_send
+      request.should be_sent
     end
     
     it "should send message to invalid receiver" do
@@ -164,7 +164,7 @@ describe BallouSmsGateway do
       request.sms_id.should eq(id)
       request.request_id.should eq(request_id)
       request.error.should eq(3)
-      request.should_not be_send
+      request.should_not be_sent
     end
     
     it "should be able to handle request errors" do
@@ -184,7 +184,7 @@ describe BallouSmsGateway do
       request.sms_id.should eq(id)
       request.request_id.should eq(request_id)
       request.error.should eq(7)
-      request.should_not be_send
+      request.should_not be_sent
       request.message.should eq("404 Resource Not Found")
     end
   end
@@ -204,7 +204,7 @@ describe BallouSmsGateway do
         send!
         
       request.should_not be_valid
-      request.should_not be_send
+      request.should_not be_sent
       request.error.should eq(2)
       request.status.should eq(-2)
       request.message.should eq("Authentication failed or IP rejected")

metadata

@@ -2,7 +2,7 @@
 name: ballou_sms_gateway
 version: !ruby/object:Gem::Version 
   prerelease: 
-  version: 1.0.0
+  version: 2.0.0
 platform: ruby
 authors: 
 - Linus Oleander