ballonizer 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 52d2c968649c91a1265268bba794bbdc898070d7
-  data.tar.gz: bbce6945bdceae4d0f52424f484f8be85059ec4c
+  metadata.gz: 967c8a0ccad88064316e33f61b350e0be330d66c
+  data.tar.gz: 0b417a9f8ec71ffe3be883245f68f4d71f9cf578
 SHA512:
-  metadata.gz: 22b110740fb92fa3f0676bae93a4d1a64e807c8f68a9ff8856fa6f3410c2bd91e10edc72822b877224b162b30f18af69b10434a79956a07f5491689d649ee3b8
-  data.tar.gz: 21a67f66b77c393dce3e026fc864c59de831653f70fffdf64ac7632a01f2c7713f5cb13856e665607924d9e4103a2c92e822964471930da1e10eeed1318c4d98
+  metadata.gz: 4c59c4dabec9977df98437ad2e594d8310cc41e776b4e32a7ffa6e3908f31c17271464e4db24b93c1667735e39486eeecafdc8d9e2d12e546a467137c008662e
+  data.tar.gz: 8c549d6bfb363b8cd3558de6f5de7a8b25b5ee038215c91ff1ea15780f523ab5b9d30ce05594dfcd118976522c4903f20154f28cc1b77e60271507b1044c25b6

data/lib/assets/javascripts/ballonizer.js

@@ -455,6 +455,24 @@
                 this.editionNode = editionBallon;
                 imageForm.prepend(this.editionNode);
 
+                // Some webcomics allows the reader to navigate using the
+                // arrow keys. This can be very annoying when editing a
+                // balloon ("edition mode"/textarea) because you normally
+                // use the arrows to edit the ballon you are writing. The
+                // result is you losing all your work every time you make
+                // the mistake of pressing an arrow key. This guarantee that
+                // any other scripts on the page that trigger by key events
+                // will not trigger while the user is typing a balloon text.
+                this.editionNode.keydown($.proxy(function (event) {
+                    event.stopPropagation();
+                }, this));
+                this.editionNode.keyup($.proxy(function (event) {
+                    event.stopPropagation();
+                }, this));
+                this.editionNode.keypress($.proxy(function (event) {
+                    event.stopPropagation();
+                }, this));
+
                 this.node.click($.proxy(function (event) {
                     this.click(event);
                 }, this));

data/lib/ballonizer.rb

@@ -55,7 +55,18 @@ require 'sprockets'
 # ballonized_image_ballons.
 #
 # Changelog:
-#  v0.6.1
+#  v0.7.3
+#   * Solve the annoying arrow key problem. Stop the propagation of
+#     the key events while editing a balloon. This is meant to solve
+#     the problem with some sites that use the arrow keys to navigate
+#     between pages. If you used one of these keys while editing a
+#     ballon you would lose all work.
+#  v0.7.2
+#   * Little CSS fix (normalize line-height for ballons)
+#  v0.7.1
+#   * Fix the big submit button problem and the hidden behind other
+#     element submit button problem.
+#  v0.7.0
 #   * Add the jquery_no_conflict option. If this option is true the
 #     js_load_snippet will restore any previous loaded version of
 #     jQuery after the ballonizer javascript client code already

data/spec/javascripts/ballonizer_spec.js

@@ -524,6 +524,47 @@ describe("Ballonizer", function () {
                         ]
                     });
                 });
+                // avoid the arrow keys to previous/next comic while typing problem
+                it("any key{press,down,up} triggers on the page don't trigger", function () {
+                    var firstBallon = getBallons()[0];
+
+                    $('body').keydown(function (event) {
+                        /* jshint unused: false */
+                        console.log("this body.keydown wasn't meant to execute");
+                    });
+                    $('body').keyup(function (event) {
+                        /* jshint unused: false */
+                        console.log("this body.keyup wasn't meant to execute");
+                    });
+                    $('body').keypress(function (event) {
+                        /* jshint unused: false */
+                        console.log("this body.keypress wasn't meant to execute");
+                    });
+
+                    var spyDown = spyOnEvent("body", "keydown");
+                    var spyUp = spyOnEvent("body", "keyup");
+                    var spyPress = spyOnEvent("body", "keypress");
+
+                    // alternate to the edition mode
+                    realWorldEvent("dblclick", firstBallon.getNormalNode());
+                    
+                    // trigger all three events while the textarea has focus
+                    var textarea = firstBallon.editionNode();
+                    textarea.trigger(jQuery.Event(
+                        'keydown', { which: $.ui.keyCode.LEFT }
+                    ));
+                    textarea.trigger(jQuery.Event(
+                        'keyup', { which: $.ui.keyCode.LEFT }
+                    ));
+                    textarea.trigger(jQuery.Event(
+                        'keypress', { which: $.ui.keyCode.LEFT }
+                    ));
+
+                    // verify if the body events have been triggered
+                    expect(spyDown).not.toHaveBeenTriggered();
+                    expect(spyUp).not.toHaveBeenTriggered();
+                    expect(spyPress).not.toHaveBeenTriggered();
+                });
             });
         });
         describe("when a ballon is added", function () {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ballonizer
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Henrique Becker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-09 00:00:00.000000000 Z
+date: 2013-09-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri