balihoo_lpc_client 0.5.2 → 0.6.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a419f5a1be223fef3953c4d503c46ca1efc38f7e
-  data.tar.gz: 0b8cdec43c0f6c5548824557760e3d4f0b212c54
+  metadata.gz: 591af8860b95e6f9fba8075f1a24049457aa1e74
+  data.tar.gz: 6b933abb027d4439683b06fc7239844bcf3fc265
 SHA512:
-  metadata.gz: 645048672a5b8baa72902b266866787ffe6db5822b478680d3563af2b924fb235426dac7f7bf3933ada5a5df7d36ad9130b6f3f1fcd1cdc1a791b518cd44d8e2
-  data.tar.gz: de75e508e3f92fd324d9625f16552aee8c73de5b92a3cf5dc98ccd2f78d7293957a6accc3e71d9db91d0e73bc833fe72cc662c33a06ad41cfda2e554824d34b3
+  metadata.gz: f934bee38ddb572e0dc06d012a56d0313bfbc0f9b52dd0c8f32dbd9ab01bdd0852173cf80fd28451cb94a4e35bf57bb358f14f69f0ad71da25b2c1a738f986c4
+  data.tar.gz: 722fccbfed104e79bcf88459dde8f0d6f56bba88dd993362d007217bcc31385c94556a49eab522cfeb672b38dc791b1919547107b0cc467db3af28c0ed6aea31

data/lib/balihoo_lpc_client/request/authentication.rb

@@ -2,9 +2,9 @@ module BalihooLpcClient
   module Request
     class Authentication < Base
       def authenticate!
-        response = self.class.post('/genClientAPIKey', opts)
+        response = self.class.post('/genClientAPIKey', opts).parsed_response
         handle_errors_with(klass: AuthenticationError, response: response)
-        handle_success(response.parsed_response)
+        handle_success(response: response)
       end
 
       private
@@ -21,8 +21,8 @@ module BalihooLpcClient
         }
       end
 
-      def handle_success(data)
-        auth = Response::Authentication.new(data)
+      def handle_success(response:)
+        auth = Response::Authentication.new(response)
         config.client_id = auth.client_id
         config.client_api_key = auth.client_api_key
         auth

data/lib/balihoo_lpc_client/request/base.rb

@@ -17,8 +17,12 @@ module BalihooLpcClient
       end
 
       def handle_errors_with(klass:, response:)
-        unless response.parsed_response.is_a?(Hash)
-          raise klass, response.parsed_response
+        if response.is_a?(String)
+          if response =~ /session has expired/
+            raise ApiSessionExpiredError, response
+          else
+            raise klass, response
+          end
         end
       end
     end

data/lib/balihoo_lpc_client/request/campaigns.rb

@@ -3,6 +3,7 @@ module BalihooLpcClient
     class Campaigns < ApiBase
       def fetch
         response = self.class.get('/campaigns', opts).parsed_response
+        handle_errors_with(klass: ApiResponseError, response: response)
         handle_response(response: response, klass: Response::Campaign)
       end
     end

data/lib/balihoo_lpc_client/request/campaigns_with_tactics.rb

@@ -3,6 +3,7 @@ module BalihooLpcClient
     class CampaignsWithTactics < ApiBase
       def fetch
         response = self.class.get('/campaignswithtactics', opts).parsed_response
+        handle_errors_with(klass: ApiResponseError, response: response)
         handle_response(response: response, klass: Response::Campaign)
       end
     end

data/lib/balihoo_lpc_client/request/metrics.rb

@@ -10,6 +10,7 @@ module BalihooLpcClient
 
       def fetch
         response = self.class.get("/tactic/#{tactic_id}/metrics", opts).parsed_response
+        handle_errors_with(klass: ApiResponseError, response: response)
         handle_response(response: response, klass: Response::Metric, mappable: false)
       end
     end

data/lib/balihoo_lpc_client/request/tactics.rb

@@ -10,11 +10,17 @@ module BalihooLpcClient
 
       def fetch
         response = self.class.get("/campaign/#{campaign_id}/tactics", opts).parsed_response
+        handle_errors_with(klass: ApiResponseError, response: response)
+        handle_response(response: response, klass: Response::Tactic)
+      end
+
+      private
 
+      def handle_response(response:, klass:, mappable: true)
         if multiple_locations?
-          multiple_locations(response: response, klass: Response::Tactic, mappable: true)
+          multiple_locations(response: response, klass: klass, mappable: mappable)
         else
-          single_location(response: response['tactics'], klass: Response::Tactic, mappable: true)
+          single_location(response: response['tactics'], klass: klass, mappable: mappable)
         end
       end
     end

data/lib/balihoo_lpc_client/request/website_metrics.rb

@@ -3,6 +3,7 @@ module BalihooLpcClient
     class WebsiteMetrics < ApiBase
       def fetch
         response = self.class.get("/websitemetrics", opts).parsed_response
+        handle_errors_with(klass: ApiResponseError, response: response)
         handle_response(response: response, klass: Response::WebsiteMetric, mappable: false)
       end
     end

data/lib/balihoo_lpc_client/version.rb

@@ -1,3 +1,3 @@
 module BalihooLpcClient
-  VERSION = "0.5.2"
+  VERSION = "0.6.0"
 end

data/lib/balihoo_lpc_client.rb

@@ -25,4 +25,6 @@ module BalihooLpcClient
   class AuthenticationError < BalihooLpcError; end
   class ApiOptionError < BalihooLpcError; end
   class NotAuthenticatedError < BalihooLpcError; end
+  class ApiSessionExpiredError < BalihooLpcError; end
+  class ApiResponseError < BalihooLpcError; end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: balihoo_lpc_client
 version: !ruby/object:Gem::Version
-  version: 0.5.2
+  version: 0.6.0
 platform: ruby
 authors:
 - JD Guzman