baldur 0.1.7 → 0.2.3

data/test/confirmation_modal_helper_test.rb

@@ -0,0 +1,241 @@
+require_relative 'test_helper'
+require 'action_controller'
+require_relative '../lib/generators/baldur/install/install_generator'
+
+class BaldurConfirmationModalHelperTest < Minitest::Test
+  class TestController < ActionController::Base
+    append_view_path File.expand_path('../app/views', __dir__)
+    helper Baldur::UiHelper
+    helper Baldur::RenderHelper
+  end
+
+  def test_ui_modal_host_renders_host_wrapper
+    html = TestController.render(
+      inline: <<~ERB,
+        <%= ui_modal_host(id: "test-modal") do %>
+          <p>Modal content</p>
+        <% end %>
+      ERB
+      formats: [:html]
+    )
+
+    assert_includes html, 'id="test-modal"'
+    assert_includes html, 'data-controller="modal"'
+    assert_includes html, 'data-modal-selector-value="#test-modal"'
+    assert_includes html, 'data-modal="true"'
+    assert_includes html, 'aria-hidden="true"'
+    assert_includes html, 'Modal content'
+    assert_includes html, 'class="fixed inset-0 z-50'
+  end
+
+  def test_ui_modal_host_with_custom_classes
+    html = TestController.render(
+      inline: <<~ERB,
+        <%= ui_modal_host(id: "custom-modal", classes: "my-extra-class") do %>
+          <p>Custom</p>
+        <% end %>
+      ERB
+      formats: [:html]
+    )
+
+    assert_includes html, 'my-extra-class'
+    assert_includes html, 'Custom'
+  end
+
+  def test_ui_confirmation_modal_renders_basic_structure
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "delete-modal",
+          dialog_id: "delete-dialog",
+          title: "Delete item?"
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'id="delete-modal"'
+    assert_includes html, 'id="delete-dialog"'
+    assert_includes html, 'data-controller="modal"'
+    assert_includes html, 'Delete item?'
+    assert_includes html, 'Confirm'
+    assert_includes html, 'Cancel'
+    assert_includes html, 'data-modal-close="true"'
+  end
+
+  def test_ui_confirmation_modal_with_danger_tone_shows_icon
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "danger-modal",
+          dialog_id: "danger-dialog",
+          title: "Discard collection?",
+          tone: :danger
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'color-error'
+    assert_includes html, 'Discard collection?'
+  end
+
+  def test_ui_confirmation_modal_default_tone_no_icon
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "default-modal",
+          dialog_id: "default-dialog",
+          title: "Proceed?"
+        )
+      %>',
+      formats: [:html]
+    )
+
+    refute_includes html, 'color-error'
+    assert_includes html, 'Proceed?'
+  end
+
+  def test_ui_confirmation_modal_danger_tone_sets_danger_button_variant
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "danger-btn-modal",
+          dialog_id: "danger-btn-dialog",
+          title: "Discard?",
+          tone: :danger
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'button--error'
+  end
+
+  def test_ui_confirmation_modal_default_tone_sets_primary_button_variant
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "primary-btn-modal",
+          dialog_id: "primary-btn-dialog",
+          title: "Proceed?"
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'button--filled'
+    refute_includes html, 'button--error'
+  end
+
+  def test_ui_confirmation_modal_with_type_to_confirm
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "flush-modal",
+          dialog_id: "flush-dialog",
+          title: "Flush All Data",
+          description: "This cannot be undone.",
+          tone: :danger,
+          confirm_label: "Confirm",
+          type_to_confirm: {
+            expected_text: "confirm",
+            label: "Type confirm to continue",
+            placeholder: "confirm",
+            hint: "This permanently removes all data."
+          }
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'modal confirmation'
+    assert_includes html, 'confirmation-case-sensitive-value'
+    assert_includes html, 'data-confirmation-target="input"'
+    assert_includes html, 'data-confirmation-target="submit"'
+    assert_includes html, 'confirmation#validate'
+    assert_includes html, 'Type confirm to continue'
+    assert_includes html, 'This permanently removes all data.'
+    assert_includes html, 'Flush All Data'
+    assert_includes html, 'Confirm'
+  end
+
+  def test_ui_confirmation_modal_type_to_confirm_disables_submit
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "disabled-modal",
+          dialog_id: "disabled-dialog",
+          title: "Delete?",
+          type_to_confirm: {
+            expected_text: "DELETE",
+            label: "Type DELETE"
+          }
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'disabled'
+    assert_includes html, 'Type DELETE'
+  end
+
+  def test_ui_confirmation_modal_type_to_confirm_case_insensitive
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "ci-modal",
+          dialog_id: "ci-dialog",
+          title: "Delete?",
+          type_to_confirm: {
+            expected_text: "delete",
+            case_sensitive: false
+          }
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'confirmation-case-sensitive-value'
+    refute_includes html, 'case-sensitive-value="true"'
+    assert_includes html, 'case-sensitive-value=&quot;false&quot;'
+  end
+
+  def test_ui_confirmation_modal_without_type_to_confirm_has_no_confirmation_controller
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "simple-modal",
+          dialog_id: "simple-dialog",
+          title: "Are you sure?"
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'data-controller="modal"'
+    refute_includes html, 'confirmation'
+  end
+
+  def test_ui_confirmation_modal_custom_labels
+    html = TestController.render(
+      inline: '<%=
+        ui_confirmation_modal(
+          host_id: "custom-modal",
+          dialog_id: "custom-dialog",
+          title: "Discard?",
+          confirm_label: "Discard",
+          cancel_label: "Go back"
+        )
+      %>',
+      formats: [:html]
+    )
+
+    assert_includes html, 'Discard'
+    assert_includes html, 'Go back'
+  end
+
+  def test_install_generator_includes_confirmation_controller
+    assert_includes Baldur::Generators::InstallGenerator::CORE_CONTROLLERS, 'confirmation'
+  end
+end

data/test/csp_rendering_test.rb

@@ -1,22 +1,22 @@
-require_relative "test_helper"
+require_relative 'test_helper'
 
-require "action_controller"
+require 'action_controller'
 
 class BaldurCspRenderingTest < Minitest::Test
   class TestController < ActionController::Base
-    append_view_path File.expand_path("../app/views", __dir__)
+    append_view_path File.expand_path('../app/views', __dir__)
     helper Baldur::UiHelper
     helper Baldur::UiHelperForms
   end
 
   def test_tooltip_renders_without_inline_style_attribute
     html = TestController.render(
-      partial: "baldur/components/tooltip",
+      partial: 'baldur/components/tooltip',
       locals: {
-        text: "Info",
-        content: "Tooltip body",
+        text: 'Info',
+        content: 'Tooltip body',
         show_icon: true,
-        icon: "circle-help",
+        icon: 'circle-help',
         variant: :link,
         wrapper_class: nil,
         trigger_class: nil,
@@ -31,26 +31,26 @@ class BaldurCspRenderingTest < Minitest::Test
 
   def test_date_field_renders_hidden_native_input_class_without_inline_style
     html = TestController.render(
-      partial: "baldur/components/date_field",
+      partial: 'baldur/components/date_field',
       locals: {
-        wrapper_classes: "field date-field",
-        label: "Due date",
+        wrapper_classes: 'field date-field',
+        label: 'Due date',
         supporting_text: nil,
         display_input_options: {
-          id: "due-date-display",
-          class: "text-field__control date-field__display",
-          type: "text",
-          name: "due_date"
+          id: 'due-date-display',
+          class: 'text-field__control date-field__display',
+          type: 'text',
+          name: 'due_date'
         },
         native_input_options: {
-          id: "due-date-native",
-          class: "date-field__native date-field__native--hidden",
-          type: "date",
-          tabindex: "-1"
+          id: 'due-date-native',
+          class: 'date-field__native date-field__native--hidden',
+          type: 'date',
+          tabindex: '-1'
         },
-        toggle_label: "Open date picker",
-        icon_name: "calendar",
-        support_id: "due-date-support"
+        toggle_label: 'Open date picker',
+        icon_name: 'calendar',
+        support_id: 'due-date-support'
       }
     )
 

data/test/engine_css_test.rb

@@ -0,0 +1,36 @@
+require_relative 'test_helper'
+
+class EngineCssTest < Minitest::Test
+  def engine_css_path
+    Baldur::Engine.root.join('app/assets/tailwind/baldur/engine.css')
+  end
+
+  def test_engine_css_exists
+    assert engine_css_path.exist?, "engine.css missing at #{engine_css_path}"
+  end
+
+  def test_source_paths_resolve_to_app_helpers_and_views
+    skip('engine.css not found') unless engine_css_path.exist?
+
+    source = engine_css_path.read
+
+    %w[helpers views].each do |dir|
+      assert_includes source, "@source \"../../../#{dir}\"",
+                      "engine.css @source for #{dir} must resolve from app/assets/tailwind/baldur/ → app/#{dir}\n" \
+                      "Expected: @source \"../../../#{dir}\"\n" \
+                      "Got: check #{engine_css_path}"
+    end
+  end
+
+  def test_source_paths_do_not_use_shallow_relative
+    skip('engine.css not found') unless engine_css_path.exist?
+
+    source = engine_css_path.read
+
+    %w[helpers views].each do |dir|
+      refute_includes source, "@source \"../../#{dir}\"",
+                      "engine.css uses shallow @source \"../../#{dir}\" which resolves to app/assets/tailwind/#{dir} (nonexistent)\n" \
+                      "Must use \"../../../#{dir}\" to reach app/#{dir}"
+    end
+  end
+end

data/test/fixtures/shared/_brand_lockup.html.erb

@@ -0,0 +1 @@
+<div class="brand-lockup"><span>Brand</span></div>

data/test/gemspec_test.rb

@@ -1,11 +1,13 @@
-require_relative "test_helper"
+require_relative 'test_helper'
 
 class BaldurGemspecTest < Minitest::Test
   def test_gemspec_lists_only_files
-    spec = Gem::Specification.load(File.expand_path("../baldur.gemspec", __dir__))
+    spec = Gem::Specification.load(File.expand_path('../baldur.gemspec', __dir__))
 
-    assert spec.files.any?, "expected gemspec to include files"
-    assert spec.files.all? { |path| File.file?(File.expand_path("../#{path}", __dir__)) }, "expected spec.files to contain only files"
-    assert_includes spec.files, "app/assets/tailwind/baldur/engine.css"
+    assert spec.files.any?, 'expected gemspec to include files'
+    assert spec.files.all? { |path|
+      File.file?(File.expand_path("../#{path}", __dir__))
+    }, 'expected spec.files to contain only files'
+    assert_includes spec.files, 'app/assets/tailwind/baldur/engine.css'
   end
 end

data/test/install_generator_test.rb

@@ -1,37 +1,41 @@
-require_relative "test_helper"
-require_relative "../lib/generators/baldur/install/install_generator"
+require_relative 'test_helper'
+require_relative '../lib/generators/baldur/install/install_generator'
 
 class BaldurInstallGeneratorTest < Rails::Generators::TestCase
   tests Baldur::Generators::InstallGenerator
-  destination File.expand_path("tmp/install_generator", __dir__)
+  destination File.expand_path('tmp/install_generator', __dir__)
   setup :prepare_destination
 
   setup do
-    FileUtils.mkdir_p File.join(destination_root, "app/assets/tailwind")
-    File.write(File.join(destination_root, "app/assets/tailwind/application.css"), "@import \"tailwindcss\";\n")
+    FileUtils.mkdir_p File.join(destination_root, 'app/assets/tailwind')
+    File.write(File.join(destination_root, 'app/assets/tailwind/application.css'), "@import \"tailwindcss\";\n")
   end
 
-  test "installs path agnostic tailwind integration and helper shims" do
+  test 'installs path agnostic tailwind integration and helper shims' do
     run_generator
 
-    tailwind_entrypoint = File.join(destination_root, "app/assets/tailwind/application.css")
+    tailwind_entrypoint = File.join(destination_root, 'app/assets/tailwind/application.css')
     tailwind_source = File.read(tailwind_entrypoint)
 
-    assert_includes tailwind_source, "@import \"../stylesheets/fonts.css\";"
-    assert_includes tailwind_source, "@import \"../builds/tailwind/baldur.css\";"
-    assert_includes tailwind_source, "@import \"../stylesheets/theme.css\";"
-    refute_includes tailwind_source, "gems/baldur"
+    assert_includes tailwind_source, '@import "../stylesheets/fonts.css";'
+    assert_includes tailwind_source, '@import "../builds/tailwind/baldur.css";'
+    assert_includes tailwind_source, '@import "../stylesheets/theme.css";'
+    refute_includes tailwind_source, 'gems/baldur'
 
-    assert_operator tailwind_source.index("@import \"../stylesheets/fonts.css\";"), :<, tailwind_source.index("@import \"tailwindcss\";")
-    assert_operator tailwind_source.index("@import \"../builds/tailwind/baldur.css\";"), :<, tailwind_source.index("@import \"../stylesheets/theme.css\";")
+    assert_operator tailwind_source.index('@import "../stylesheets/fonts.css";'), :<,
+                    tailwind_source.index('@import "tailwindcss";')
+    assert_operator tailwind_source.index('@import "../builds/tailwind/baldur.css";'), :<,
+                    tailwind_source.index('@import "../stylesheets/theme.css";')
 
-    assert_file "app/helpers/ui_helper.rb"
-    assert_file "app/helpers/ui_helper.rb", /include Baldur::Optional::AuthPageHelper/
-    assert_file "config/initializers/baldur.rb"
-    assert_file "app/assets/stylesheets/fonts.css"
-    assert_file "app/assets/stylesheets/theme.css"
-    assert_file "app/javascript/controllers/mobile_sidebar_controller.js", /export \{ default \} from "baldur\/controllers\/mobile_sidebar_controller"/
-    assert_file "app/javascript/controllers/sidebar_controller.js", /export \{ default \} from "baldur\/controllers\/sidebar_controller"/
-    assert_file "app/javascript/lib/snackbar.js", /export \* from "baldur\/lib\/snackbar"/
+    assert_file 'app/helpers/ui_helper.rb'
+    assert_file 'app/helpers/ui_helper.rb', /include Baldur::Optional::AuthPageHelper/
+    assert_file 'config/initializers/baldur.rb'
+    assert_file 'app/assets/stylesheets/fonts.css'
+    assert_file 'app/assets/stylesheets/theme.css'
+    assert_file 'app/javascript/controllers/mobile_sidebar_controller.js',
+                %r{export \{ default \} from "baldur/controllers/mobile_sidebar_controller"}
+    assert_file 'app/javascript/controllers/sidebar_controller.js',
+                %r{export \{ default \} from "baldur/controllers/sidebar_controller"}
+    assert_file 'app/javascript/lib/snackbar.js', %r{export \* from "baldur/lib/snackbar"}
   end
 end

data/test/install_panel_secondary_generator_test.rb

@@ -1,21 +1,24 @@
-require_relative "test_helper"
-require_relative "../lib/generators/baldur/install_panel_secondary/install_panel_secondary_generator"
+require_relative 'test_helper'
+require_relative '../lib/generators/baldur/install_panel_secondary/install_panel_secondary_generator'
 
 class BaldurInstallPanelSecondaryGeneratorTest < Rails::Generators::TestCase
   tests Baldur::Generators::InstallPanelSecondaryGenerator
-  destination File.expand_path("tmp/install_panel_secondary_generator", __dir__)
+  destination File.expand_path('tmp/install_panel_secondary_generator', __dir__)
   setup :prepare_destination
 
   setup do
-    FileUtils.mkdir_p File.join(destination_root, "app/assets/tailwind")
-    File.write(File.join(destination_root, "app/assets/tailwind/application.css"), "@import \"tailwindcss\";\n@import \"../builds/tailwind/baldur.css\";\n")
+    FileUtils.mkdir_p File.join(destination_root, 'app/assets/tailwind')
+    File.write(File.join(destination_root, 'app/assets/tailwind/application.css'),
+               "@import \"tailwindcss\";\n@import \"../builds/tailwind/baldur.css\";\n")
   end
 
-  test "adds helper and controller without touching the tailwind contract" do
+  test 'adds helper and controller without touching the tailwind contract' do
     run_generator
 
-    assert_file "app/helpers/panel_secondary_helper.rb", /include Baldur::Optional::PanelSecondaryHelper/
-    assert_file "app/javascript/controllers/panel_secondary_controller.js", /export \{ default \} from "baldur\/controllers\/panel_secondary_controller"/
-    assert_equal "@import \"tailwindcss\";\n@import \"../builds/tailwind/baldur.css\";\n", File.read(File.join(destination_root, "app/assets/tailwind/application.css"))
+    assert_file 'app/helpers/panel_secondary_helper.rb', /include Baldur::Optional::PanelSecondaryHelper/
+    assert_file 'app/javascript/controllers/panel_secondary_controller.js',
+                %r{export \{ default \} from "baldur/controllers/panel_secondary_controller"}
+    assert_equal "@import \"tailwindcss\";\n@import \"../builds/tailwind/baldur.css\";\n",
+                 File.read(File.join(destination_root, 'app/assets/tailwind/application.css'))
   end
 end

data/test/marketing_helper_test.rb

@@ -1,4 +1,4 @@
-require_relative "test_helper"
+require_relative 'test_helper'
 
 class BaldurMarketingHelperTest < Minitest::Test
   HelperHost = Struct.new(:config) do
@@ -15,17 +15,17 @@ class BaldurMarketingHelperTest < Minitest::Test
 
   def test_uses_configured_brand_without_host_helper_fallback
     Baldur.config.marketing_brand = {
-      name: "Standalone",
-      wordmark: "Standalone UI",
-      logo_src: "/standalone-logo.svg"
+      name: 'Standalone',
+      wordmark: 'Standalone UI',
+      logo_src: '/standalone-logo.svg'
     }
 
     helper = HelperHost.new(Baldur.config)
     resolved = helper.send(:ui_marketing_configured_brand)
 
-    assert_equal "Standalone", resolved[:name]
-    assert_equal "Standalone UI", resolved[:wordmark]
-    assert_equal "/standalone-logo.svg", resolved[:logo_src]
+    assert_equal 'Standalone', resolved[:name]
+    assert_equal 'Standalone UI', resolved[:wordmark]
+    assert_equal '/standalone-logo.svg', resolved[:logo_src]
   end
 
   def test_returns_empty_brand_hash_when_no_brand_is_configured

data/test/run_all.rb

@@ -1,3 +1,3 @@
-Dir[File.expand_path("*_test.rb", __dir__)].sort.each do |path|
+Dir[File.expand_path('*_test.rb', __dir__)].sort.each do |path|
   require path
 end

data/test/sidebar_helper_test.rb

@@ -1,10 +1,10 @@
-require_relative "test_helper"
+require_relative 'test_helper'
 
-require "action_controller"
+require 'action_controller'
 
 class BaldurSidebarHelperTest < Minitest::Test
   class TestController < ActionController::Base
-    append_view_path File.expand_path("../app/views", __dir__)
+    append_view_path File.expand_path('../app/views', __dir__)
     helper Baldur::UiHelper
     helper Baldur::UiHelperSidebar
   end
@@ -12,10 +12,10 @@ class BaldurSidebarHelperTest < Minitest::Test
   def setup
     @original_brand = Baldur.config.marketing_brand
     Baldur.config.marketing_brand = {
-      name: "Acme",
-      wordmark: "Acme Ops",
-      logo_src: "/acme.svg",
-      logo_alt: "Acme logo"
+      name: 'Acme',
+      wordmark: 'Acme Ops',
+      logo_src: '/acme.svg',
+      logo_alt: 'Acme logo'
     }
   end
 
@@ -33,16 +33,16 @@ class BaldurSidebarHelperTest < Minitest::Test
               secondary_label: "Admin"
             ) %>
       ERB
-      formats: [ :html ]
+      formats: [:html]
     )
 
     assert_includes html, 'data-controller="sidebar"'
     assert_includes html, 'data-controller="mobile-sidebar"'
-    assert_includes html, "Acme Ops"
+    assert_includes html, 'Acme Ops'
     assert_includes html, 'href="/dashboard"'
     assert_includes html, 'href="/settings"'
     assert_includes html, 'aria-current="page"'
-    assert_includes html, "Admin"
+    assert_includes html, 'Admin'
   end
 
   def test_sidebar_renders_slot_content_and_mobile_fallbacks
@@ -57,13 +57,13 @@ class BaldurSidebarHelperTest < Minitest::Test
           <% end %>
         <% end %>
       ERB
-      formats: [ :html ]
+      formats: [:html]
     )
 
-    assert_includes html, "Tenant Switcher"
-    assert_includes html, "user-menu"
-    assert_includes html, "Sign out"
-    assert_operator html.scan("Tenant Switcher").size, :>=, 2
-    assert_operator html.scan("Sign out").size, :>=, 2
+    assert_includes html, 'Tenant Switcher'
+    assert_includes html, 'user-menu'
+    assert_includes html, 'Sign out'
+    assert_operator html.scan('Tenant Switcher').size, :>=, 2
+    assert_operator html.scan('Sign out').size, :>=, 2
   end
 end

data/test/test_helper.rb

@@ -1,16 +1,16 @@
-ENV["MT_NO_PLUGINS"] = "1"
+ENV['MT_NO_PLUGINS'] = '1'
 
-require "bundler/setup"
-require "minitest/autorun"
-require "rails/generators/test_case"
-require "rails"
-require "lucide-rails"
+require 'bundler/setup'
+require 'minitest/autorun'
+require 'rails/generators/test_case'
+require 'rails'
+require 'lucide-rails'
 
-require_relative "../lib/baldur"
-require_relative "../app/helpers/baldur/render_helper"
-require_relative "../app/helpers/baldur/ui_helper_feedback"
-require_relative "../app/helpers/baldur/ui_helper_unavailable"
-require_relative "../app/helpers/baldur/ui_helper_forms"
-require_relative "../app/helpers/baldur/marketing_helper"
-require_relative "../app/helpers/baldur/ui_helper_sidebar"
-require_relative "../app/helpers/baldur/ui_helper"
+require_relative '../lib/baldur'
+require_relative '../app/helpers/baldur/render_helper'
+require_relative '../app/helpers/baldur/ui_helper_feedback'
+require_relative '../app/helpers/baldur/ui_helper_unavailable'
+require_relative '../app/helpers/baldur/ui_helper_forms'
+require_relative '../app/helpers/baldur/marketing_helper'
+require_relative '../app/helpers/baldur/ui_helper_sidebar'
+require_relative '../app/helpers/baldur/ui_helper'