baidu_translate 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 9d27fad7d037927ae84ba2f2832b82392ec5e467
-  data.tar.gz: 3b31c3f25953fbfb6391cbdf46a52b175dc547d2
+  metadata.gz: 0e247d8f671aa5de5ba22bff4983a709089ac676
+  data.tar.gz: b411301de1f800723f85758062ebf0bbb7e91a83
 SHA512:
-  metadata.gz: a595156cf238c01dae2e95a9fcebd97aa01c2e3d9a4b17481c793a562e7dfaed80b25d7e70a6d55730d4ca7b418c840876fd0fb06b96933ef7c14cc1085e913a
-  data.tar.gz: 4d655c241f521430d8e8ad91b2c61a48110617c1e96c5afe3036dbe2a3adecab51d5fc992aae8ff93fdca6c99ec2f047707826c32ad95ef5b2b4c2126480a478
+  metadata.gz: 2bff4e97af6b4e69b74d026a36e99802ac78262e3c61d1219ca49f019cdb741d5ae5f6821d16257bed0f57211b99e6e58776f60951201e46da46a51faa64d711
+  data.tar.gz: ac8025775c4e9c241ff2b441ab64829a0017bf259e87ddb8f601db7d4453a4b1274a01565269b73ac831cbd9290e09a75d9500804f835c7a3a69f51eadfdec55

data/.gitignore

@@ -7,3 +7,5 @@
 /pkg/
 /spec/reports/
 /tmp/
+*.gem
+.byebug_history

data/README.md

@@ -35,9 +35,11 @@ BaiduTranslate.translate('Apple', :en, :zh)
 # => "苹果"
 ```
 
+4. Check http://api.fanyi.baidu.com/api/trans/product/apidoc for the list of available languages and their codes and a list of possible errors.
+
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/baidu_translate. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [Contributor Covenant](http://contributor-covenant.org) code of conduct.
+Bug reports and pull requests are welcome!
 
 
 ## License

data/baidu_translate.gemspec

@@ -31,6 +31,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "minitest", "~> 5.0"
   spec.add_development_dependency "vcr"
+  spec.add_development_dependency "byebug"
   spec.add_development_dependency "webmock"
 
   spec.add_dependency "faraday"

data/lib/baidu_translate/translation.rb

@@ -5,40 +5,37 @@ require 'uri'
 API_URL = "http://api.fanyi.baidu.com/api/trans/vip/translate"
 
 module BaiduTranslate
-	module Translation
-
-		attr_accessor :app_id, :key
-
-		def setup(app_id, key)
-			@app_id = app_id
-			@key = key
-		end
-
-		def translate(text, from, to)
-
-			salt = rand(32768..65536)
-			api_params = Hash.new
-
-			api_params[:q] = text
-			api_params[:from] = from
-			api_params[:to] = to
-			
-			api_params[:appid] = @app_id
-			
-			api_params[:salt] = salt
-			api_params[:sign] = sign(text, salt)
-
-			response = Faraday.get(API_URL, api_params)
-      translation = JSON.parse(response.body)['trans_result'][0]['dst']
-      return translation
-		end
-
-		def sign(text, salt)
-			undigested_sign = @app_id.to_s + text + salt.to_s + @key
-			md5 = Digest::MD5.new
-			md5 << undigested_sign
-			md5.hexdigest
-		end
-
-	end
-end
+  module Translation
+
+    attr_accessor :app_id, :key
+
+    def setup(app_id, key)
+      @app_id = app_id
+      @key = key
+    end
+
+    def translate(text, from, to)
+      raise Exception.new("AppID and/or Key missing. Use BaiduTranslate.setup() to initialize.") unless @app_id && @key
+
+      salt = rand(32768..65536)
+      api_params = { q: text,
+                     from: from,
+                     to: to,
+                     appid: @app_id,
+                     salt: salt,
+                     sign: sign(text, salt) }
+
+      response = Faraday.get(API_URL, api_params).body
+      parsed_response = JSON.parse(response)
+      raise Exception.new(parsed_response.to_s) if parsed_response.key? "error_code"
+      parsed_response['trans_result'][0]['dst']
+    end
+
+    def sign(text, salt)
+      undigested_sign = @app_id.to_s + text + salt.to_s + @key
+      md5 = Digest::MD5.new
+      md5 << undigested_sign
+      md5.hexdigest
+    end
+  end
+end

data/lib/baidu_translate/version.rb

@@ -1,3 +1,3 @@
 module BaiduTranslate
-  VERSION = "0.1.0"
+  VERSION = "0.1.1"
 end

data/lib/baidu_translate.rb

@@ -2,10 +2,10 @@ require "baidu_translate/version"
 require "baidu_translate/translation"
 
 module BaiduTranslate
-  
+
   extend Translation
 
-	class << self
-	end
+  class << self
+  end
 
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: baidu_translate
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Simon Nizov
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-09-20 00:00:00.000000000 Z
+date: 2016-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement