bagit 0.4.3 → 0.4.4

data/spec/manifest_spec.rb

@@ -1,5 +1,6 @@
-# coding: utf-8
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "spec_helper"
 
 describe BagIt::Bag do
   describe "BagIt Manifests" do
@@ -7,13 +8,14 @@ describe BagIt::Bag do
       @sandbox = Sandbox.new
 
       # make the bag
-      @bag_path = File.join @sandbox.to_s, 'the_bag'
+      @bag_path = File.join @sandbox.to_s, "the_bag"
       @bag = described_class.new @bag_path
 
       # add some files
-      File.open('/dev/urandom') do |rio|
+      File.open("/dev/urandom") do |rio|
         10.times do |n|
-          @bag.add_file("file-#{n}-💩
+          @bag.add_file("file-#{n}-💩
+") { |io| io.write rio.read(16) }
           @bag.add_tag_file("tag-#{n}") { |io| io.write rio.read(16) }
         end
       end
@@ -25,13 +27,16 @@ describe BagIt::Bag do
 
     shared_examples_for "a manifest file" do
       before do
-        pattern = File.join @bag_path, '*manifest-*.txt'
+        pattern = File.join @bag_path, "*manifest-*.txt"
         @manifest_files = Dir.glob pattern
       end
 
       it "has a valid algorithm in the name (at least md5 or sha1)" do
-        algorithms = @manifest_files.map { |mf| mf =~ /manifest-(.*).txt$/; Regexp.last_match(1) }
-        algorithms.each { |a| expect(a).to be_in('md5', 'sha1') }
+        algorithms = @manifest_files.map { |mf|
+          mf =~ /manifest-(.*).txt$/
+          Regexp.last_match(1)
+        }
+        algorithms.each { |a| expect(a).to be_in("md5", "sha1") }
       end
 
       it "is not an empty file" do
@@ -47,7 +52,7 @@ describe BagIt::Bag do
       end
 
       it "validates after adding a file and remanifesting" do
-        @bag.add_file('newfile.txt') { |io| io.puts("new file to remanifest") }
+        @bag.add_file("newfile.txt") { |io| io.puts("new file to remanifest") }
         @bag.manifest!
         expect(@bag).to be_valid
       end

data/spec/spec_helper.rb

@@ -1,25 +1,27 @@
-require 'rubygems'
-require 'bundler'
-require 'coveralls'
+# frozen_string_literal: true
+
+require "rubygems"
+require "bundler"
+require "coveralls"
 
 Bundler.require(:default, :test)
 
 Coveralls.wear!
 
-require File.expand_path('./util/bagit_matchers', File.dirname(__FILE__))
+require File.expand_path("./util/bagit_matchers", File.dirname(__FILE__))
 
 RSpec.configure do |config|
   config.include(BagitMatchers)
 end
 
-$LOAD_PATH.unshift File.expand_path('../lib', File.dirname(__FILE__))
-require 'bagit'
+$LOAD_PATH.unshift File.expand_path("../lib", File.dirname(__FILE__))
+require "bagit"
 
-require 'tempfile'
+require "tempfile"
 
 class Sandbox
   def initialize
-    tf = Tempfile.open 'sandbox'
+    tf = Tempfile.open "sandbox"
     @path = tf.path
     tf.close!
     FileUtils.mkdir @path

data/spec/tag_info_spec.rb

@@ -1,5 +1,6 @@
-# coding: utf-8
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "spec_helper"
 
 describe BagIt::Bag do
   describe "Tag Info Files" do
@@ -7,11 +8,11 @@ describe BagIt::Bag do
       @sandbox = Sandbox.new
 
       # make the bag
-      @bag_path = File.join @sandbox.to_s, 'the_bag'
+      @bag_path = File.join @sandbox.to_s, "the_bag"
       @bag = described_class.new @bag_path
 
       # add some files
-      File.open('/dev/urandom') do |rio|
+      File.open("/dev/urandom") do |rio|
         10.times do |n|
           @bag.add_file("file-#{n}-💩
         end
@@ -24,12 +25,12 @@ describe BagIt::Bag do
 
     describe "bagit.txt" do
       before do
-        path = File.join @bag_path, 'bagit.txt'
+        path = File.join @bag_path, "bagit.txt"
         @lines = File.open(path, &:readlines)
       end
 
       it "creates a file bagit.txt on bag initialization" do
-        expect(File.join(@bag_path, 'bagit.txt')).to exist_on_fs
+        expect(File.join(@bag_path, "bagit.txt")).to exist_on_fs
       end
 
       it "has exactly two lines" do
@@ -49,7 +50,7 @@ describe BagIt::Bag do
 
     describe "bag-info.txt" do
       before do
-        path = File.join @bag_path, 'bag-info.txt'
+        path = File.join @bag_path, "bag-info.txt"
         @lines = File.open(path, &:readlines)
       end
 
@@ -62,20 +63,20 @@ describe BagIt::Bag do
       end
 
       it "is case insensitive with respect to LABELs" do
-        expect { @bag.write_bag_info 'foo' => 'lowercase', 'Foo' => 'capital' }.to raise_error(/Multiple labels/)
+        expect { @bag.write_bag_info "foo" => "lowercase", "Foo" => "capital" }.to raise_error(/Multiple labels/)
       end
 
       it "folds long VALUEs" do
-        longline = <<LOREM
-Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do
-  eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enimad
-  minim veniam, quis nostrud exercitation ullamco laboris nisi ut
-  aliquip ex ea commodo consequat. Duis aute irure dolor in
-  reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
-  pariatur. Excepteur sint occaecat cupidatat non proident, sunt in
-  culpa qui officia deserunt mollit anim id est laborum.
-LOREM
-        @bag.write_bag_info 'Lorem' => longline
+        longline = <<~LOREM
+          Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do
+            eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enimad
+            minim veniam, quis nostrud exercitation ullamco laboris nisi ut
+            aliquip ex ea commodo consequat. Duis aute irure dolor in
+            reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla
+            pariatur. Excepteur sint occaecat cupidatat non proident, sunt in
+            culpa qui officia deserunt mollit anim id est laborum.
+        LOREM
+        @bag.write_bag_info "Lorem" => longline
         expect(@bag.bag_info.keys.length).to eq(4) # this isn't a great test. Changed it from 1 to 4 because unrelated changes caused failure.
       end
 
@@ -92,10 +93,10 @@ LOREM
         expect(@bag.bag_info.keys).to include("Payload-Oxum")
       end
       it "does not override any previous values" do
-        path = File.join @bag_path, 'bag-info.txt'
-        @bag.write_bag_info 'Bag-Software-Agent' => 'Some Other Agent'
-        @bag.write_bag_info 'Source-Organization' => 'Awesome Inc.'
-        @bag.write_bag_info 'Bagging-Date' => '1901-01-01'
+        path = File.join @bag_path, "bag-info.txt"
+        @bag.write_bag_info "Bag-Software-Agent" => "Some Other Agent"
+        @bag.write_bag_info "Source-Organization" => "Awesome Inc."
+        @bag.write_bag_info "Bagging-Date" => "1901-01-01"
         @bag.write_bag_info
         contents = File.open(path).read
         expect(contents).to include "Some Other Agent"
@@ -103,19 +104,19 @@ LOREM
         expect(contents).to include "1901-01-01"
       end
       it "overrides previous tags when they collide with new ones" do
-        path = File.join @bag_path, 'bag-info.txt'
-        @bag.write_bag_info 'Source-Organization' => 'Awesome Inc.'
-        @bag.write_bag_info 'Source-Organization' => 'Awesome LLC.'
+        path = File.join @bag_path, "bag-info.txt"
+        @bag.write_bag_info "Source-Organization" => "Awesome Inc."
+        @bag.write_bag_info "Source-Organization" => "Awesome LLC."
         contents = File.open(path).read
         expect(contents).to include "Awesome LLC."
         expect(contents).not_to include "Awesome Inc."
       end
       it "contains values passed to bag" do
-        hash = { "Bag-Software-Agent" => "rspec",
-                 "Bagging-Date" => "2012-11-21",
-                 "Contact-Name" => "Willis Corto",
-                 "Some-Tag" => "Some Value" }
-        bag_with_info = described_class.new(@bag_path + '2', hash)
+        hash = {"Bag-Software-Agent" => "rspec",
+                "Bagging-Date" => "2012-11-21",
+                "Contact-Name" => "Willis Corto",
+                "Some-Tag" => "Some Value"}
+        bag_with_info = described_class.new(@bag_path + "2", hash)
         hash.each do |key, value|
           expect(bag_with_info.bag_info[key]).to eq(value)
         end

data/spec/tag_spec.rb

@@ -1,5 +1,6 @@
-# coding: utf-8
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "spec_helper"
 
 describe BagIt::Bag do
   describe "Tag Specs" do
@@ -7,11 +8,11 @@ describe BagIt::Bag do
       @sandbox = Sandbox.new
 
       # make the bag
-      @bag_path = File.join @sandbox.to_s, 'the_bag'
+      @bag_path = File.join @sandbox.to_s, "the_bag"
       @bag = described_class.new(@bag_path)
 
       # add some files
-      File.open('/dev/urandom') do |rio|
+      File.open("/dev/urandom") do |rio|
         10.times do |n|
           @bag.add_file("file-#{n}-💩
           @bag.add_tag_file("tag-#{n}") { |io| io.write rio.read(16) }
@@ -24,11 +25,11 @@ describe BagIt::Bag do
     end
     describe "#add_tag_file" do
       it "allows addition of tag files via io" do
-        @bag.add_tag_file("foo") { |io| io.puts 'all alone' }
+        @bag.add_tag_file("foo") { |io| io.puts "all alone" }
         expect(File.join(@bag_path, "foo")).to exist_on_fs
       end
       it "allows addition of bag files within directories using io" do
-        @bag.add_tag_file("fedora/foo") { |io| io.puts 'all alone' }
+        @bag.add_tag_file("fedora/foo") { |io| io.puts "all alone" }
         expect(File.join(@bag_path, "fedora", "foo")).to exist_on_fs
       end
       it "allows addition of deep tag files" do
@@ -36,12 +37,12 @@ describe BagIt::Bag do
         expect(File.join(@bag_path, "fedora", "foo", "newfoo", "deep")).to exist_on_fs
       end
       it "does not allow overwriting of tag files" do
-        expect { @bag.add_tag_file("tag-0") { |io| io.puts 'overwrite!' } }.to raise_error(RuntimeError)
+        expect { @bag.add_tag_file("tag-0") { |io| io.puts "overwrite!" } }.to raise_error(RuntimeError)
       end
       it "allows addition of tag files via copy" do
-        src_path = File.join @sandbox.to_s, 'somefile'
-        File.open(src_path, 'w') { |io| io.puts "something" }
-        @bag.add_tag_file("foo", src_path) { |io| io.puts 'all alone' }
+        src_path = File.join @sandbox.to_s, "somefile"
+        File.open(src_path, "w") { |io| io.puts "something" }
+        @bag.add_tag_file("foo", src_path) { |io| io.puts "all alone" }
         expect(File.join(@bag_path, "foo")).to exist_on_fs
       end
     end

data/spec/util/bagit_matchers.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module BagitMatchers
   class BeIn
     def initialize(*expected_collection)

data/spec/validation_spec.rb

@@ -1,5 +1,6 @@
-# coding: utf-8
-require 'spec_helper'
+# frozen_string_literal: true
+
+require "spec_helper"
 
 describe BagIt::Bag do
   describe "a valid bag" do
@@ -7,11 +8,11 @@ describe BagIt::Bag do
       @sandbox = Sandbox.new
 
       # make the bag
-      @bag_path = File.join @sandbox.to_s, 'the_bag'
+      @bag_path = File.join @sandbox.to_s, "the_bag"
       @bag = described_class.new @bag_path
 
       # add some files
-      File.open('/dev/urandom') do |rio|
+      File.open("/dev/urandom") do |rio|
         10.times do |n|
           @bag.add_file("file-#{n}-💩
 ") { |io| io.write rio.read(16) }
@@ -32,38 +33,38 @@ describe BagIt::Bag do
 
     it "is invalid if there is a file that's in the bag, but not in the manifest" do
       # add a file into the bag through the back door
-      File.open(File.join(@bag.data_dir, 'not-manifested'), 'w') do |io|
-        io.puts 'nothing to see here, move along'
+      File.open(File.join(@bag.data_dir, "not-manifested"), "w") do |io|
+        io.puts "nothing to see here, move along"
       end
 
-      @bag.validate_only('true_for/completeness')
+      @bag.validate_only("true_for/completeness")
       expect(@bag.errors.on(:completeness)).not_to be_empty
       expect(@bag).not_to be_valid
     end
 
     it "is invalid if there are files that are in the manifest but not in the bag" do
       # add a file and then remove it through the back door
-      @bag.add_file("file-k") { |io| io.puts 'time to go' }
+      @bag.add_file("file-k") { |io| io.puts "time to go" }
       @bag.manifest!
 
-      FileUtils.rm File.join(@bag.bag_dir, 'data', 'file-k')
+      FileUtils.rm File.join(@bag.bag_dir, "data", "file-k")
 
-      @bag.validate_only('true_for/completeness')
+      @bag.validate_only("true_for/completeness")
       expect(@bag.errors.on(:completeness)).not_to be_empty
       expect(@bag).not_to be_valid
     end
 
     it "is invalid if there is a fixity problem" do
       # tweak a file through the back door
-      File.open(@bag.bag_files[0], 'a') { |io| io.puts 'oops!' }
+      File.open(@bag.bag_files[0], "a") { |io| io.puts "oops!" }
 
-      @bag.validate_only('true_for/consistency')
+      @bag.validate_only("true_for/consistency")
       expect(@bag.errors.on(:consistency)).not_to be_empty
       expect(@bag).not_to be_valid
     end
 
     it "calculates sha1 correctly for a big file" do
-      @bag.add_file 'big-data-file' do |fh|
+      @bag.add_file "big-data-file" do |fh|
         count = 0
         while count < 1024 * 512
           fh.write "1" * 1024
@@ -71,14 +72,14 @@ describe BagIt::Bag do
         end
       end
       @bag.manifest!
-      sha1_manifest = File.join @bag_path, 'manifest-sha1.txt'
+      sha1_manifest = File.join @bag_path, "manifest-sha1.txt"
       checksums = {}
       File.open(sha1_manifest).each_line do |line|
-        fixity, path = line.split(' ')
+        fixity, path = line.split(" ")
         checksums[path] = fixity
       end
-      expected = checksums['data/big-data-file']
-      expect(expected).to eq('12be64c30968bb90136ee695dc58f4b2276968c6')
+      expected = checksums["data/big-data-file"]
+      expect(expected).to eq("12be64c30968bb90136ee695dc58f4b2276968c6")
     end
 
     it "validates by oxum when needed" do
@@ -87,7 +88,7 @@ describe BagIt::Bag do
 
     it "raises a sensible error when the manifest algorithm is unknown" do
       # add a manifest with an unsupported algorithm
-      File.open(File.join(@bag.bag_dir, 'manifest-sha999.txt'), 'w') do |io|
+      File.open(File.join(@bag.bag_dir, "manifest-sha999.txt"), "w") do |io|
         io.puts "digest-does-not-matter data/file-0\n"
       end
       expect { @bag.valid? }.to raise_error ArgumentError
@@ -95,13 +96,13 @@ describe BagIt::Bag do
 
     it "validates false by oxum when file count is incorrect" do
       # tweak oxum through backdoor
-      File.open(@bag.bag_info_txt_file, 'a') { |f| f.write "Payload-Oxum: " + @bag.bag_info["Payload-Oxum"].split('.')[0] + '.0' }
+      File.open(@bag.bag_info_txt_file, "a") { |f| f.write "Payload-Oxum: " + @bag.bag_info["Payload-Oxum"].split(".")[0] + ".0" }
       expect(@bag.valid_oxum?).to eq(false)
     end
 
     it "validates false by oxum when octetstream size is incorrect" do
       # tweak oxum through backdoor
-      File.open(@bag.bag_info_txt_file, 'a') { |f| f.write "Payload-Oxum: 1." + @bag.bag_info["Payload-Oxum"].split('.')[1] }
+      File.open(@bag.bag_info_txt_file, "a") { |f| f.write "Payload-Oxum: 1." + @bag.bag_info["Payload-Oxum"].split(".")[1] }
       expect(@bag.valid_oxum?).to eq(false)
     end
 
@@ -127,10 +128,10 @@ describe BagIt::Bag do
     describe "tag manifest validation" do
       it "is invalid if listed tag file does not exist" do
         # add a file and then remove it through the back door
-        @bag.add_tag_file("tag-k") { |io| io.puts 'time to go' }
+        @bag.add_tag_file("tag-k") { |io| io.puts "time to go" }
         @bag.tagmanifest!
 
-        FileUtils.rm File.join(@bag.bag_dir, 'tag-k')
+        FileUtils.rm File.join(@bag.bag_dir, "tag-k")
 
         # @bag.should_not be_valid
         expect(@bag).not_to be_valid

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bagit
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.4.4
 platform: ruby
 authors:
 - Tom Johnson, Francesco Lazzarino, Jamie Little
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-12-09 00:00:00.000000000 Z
+date: 2020-06-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: validatable
@@ -39,7 +39,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.5.0
 - !ruby/object:Gem::Dependency
-  name: bixby
+  name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -53,7 +53,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -67,7 +67,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: coveralls
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -81,7 +81,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -95,47 +95,47 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.4'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.4'
+        version: '3'
 - !ruby/object:Gem::Dependency
-  name: rspec
+  name: standard
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3'
+        version: '0'
 description: Ruby Library and Command Line tools for bagit
 email: jamie@jamielittle.org
 executables:
@@ -144,7 +144,6 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
-- ".rubocop.yml"
 - ".travis.yml"
 - Gemfile
 - LICENSE.txt
@@ -189,8 +188,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 3.0.8
 signing_key: 
 specification_version: 4
 summary: BagIt package generation and validation