bad_link_finder 0.2.2 → 0.2.3

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MWEzNmQ1MmQ4NzBkYTlkZmFlODhkNWQwNmJjZGRlMGIxNzkwOTI3Yg==
+    YTkzYzA3MDcwZjBkODJiN2VmZWM0OGRlODllMzFiZGJiMGQxNjc1Yg==
   data.tar.gz: !binary |-
-    MDA5MGMwNmIyNTE3NzgzZjUzMDEzYzQwMzljMGU4NTNmMjQ5ODhmMw==
+    ZDNmNDg2NjYwODNmN2IwNGQyNTllZGQ3Yjc2ZTY0MjU4Y2JkMTBkMA==
 SHA512:
   metadata.gz: !binary |-
-    ODliZjFkNTg2ZWVlZjNhYjcxODRlYzI3MDY5M2I2YmUyNjg1Y2NiNzkxMjQy
-    ZGM2ZDdmYmIxY2FjNDIyMDcxNDNiYjM3ZmFjMDAxODc0NDVhOWMxYjRkZDQ4
-    NjhhZWEzNzJjMjAxMmY5YjE3MjVhZmQ2ZDVjODYxNWQ0MWM2Y2Y=
+    NWI0NGU1MTBiMzIyZDE2MTU0YmUxNTM5MWQyZTE3YTUwZjMyZThiYTcxNzA3
+    MjEzYWYxOWE0NTBmZjg2ZGJiYmQxZmYwMWEzNzA1NWJjNjEwM2RhMGJmZmNi
+    MzQ2NGU3NGMxNWI0MmFlYjdlNjYxODY5N2ExZjQ3OGQ3YThiZDk=
   data.tar.gz: !binary |-
-    NDI0MTY2NzNjYTQ5ZjA4NWU0MWQ4MmUxNGExZjkyOTc3MWVjZmIwMjQ3OTZh
-    MGExOTY4YjNlZDAxNGFkNmE1ZTllODk4MGY1NzUxNmRkZTZkMmZkNGRlNTlk
-    YWFjYmYzY2JiNzBkMGQ1YmZlMDA1NmI4YzJiNWIzZGVkNTNiODQ=
+    NWEzMmE1NGRlNmUwOGVkNmY3ZDNmMTNkZjc3MzVkMTZlOTY1ZGRjY2M2YWM5
+    NDI0ZTYxNTg0MzVlYTcwZjUyNDMwNGE5OTcxYmFkMjJiMGUxOTUzZGIxODQ1
+    NmEzNjM5OTBhZWE1ZTk4OTgzZTBjYTU5ZmViM2Y5N2M3Y2ZlZDI=

data/lib/bad_link_finder/link.rb

@@ -9,6 +9,7 @@ module BadLinkFinder
       @link = link
       @url = get_url_from_link(link)
 
+      verify_url(@url)
       validate_with_request
 
     rescue URI::InvalidURIError => exception
@@ -60,6 +61,12 @@ module BadLinkFinder
       URI.join(@page_url, link).to_s
     end
 
+    def verify_url(url)
+      if url.start_with?('http')
+        raise URI::InvalidURIError.new("The URL #{url} should start with http:// or https://") unless url =~ %r{^https?://}
+      end
+    end
+
     def record_error(message, exception = nil)
       @error_message = message
       @exception = exception

data/lib/bad_link_finder/version.rb

@@ -1,3 +1,3 @@
 module BadLinkFinder
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/test/unit/link_test.rb

@@ -27,10 +27,17 @@ describe BadLinkFinder::Link do
     end
 
     it "reports malformed links without checking the internet" do
-      link = build_link('htt[]://{an-example-path}')
+      hrefs = [
+        'htt[]://{an-example-path}',
+        'http:www.example.com'
+      ]
 
-      refute link.valid?
-      assert_equal "This link is in a bad format", link.error_message
+      hrefs.each do |href|
+        link = build_link(href)
+
+        refute link.valid?
+        assert_equal "This link is in a bad format", link.error_message
+      end
     end
 
     it "reports links returning failure status codes" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bad_link_finder
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - Elliot Crosby-McCullough
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-12-03 00:00:00.000000000 Z
+date: 2013-12-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mechanize