backup 3.0.23 → 3.0.24

data/spec/compressor/gzip_spec.rb

@@ -3,81 +3,236 @@
 require File.expand_path('../../spec_helper.rb', __FILE__)
 
 describe Backup::Compressor::Gzip do
-  let(:compressor) { Backup::Compressor::Gzip.new }
+  before do
+    Backup::Compressor::Gzip.any_instance.stubs(:utility).returns('gzip')
+  end
 
-  describe 'setting configuration defaults' do
-    after { Backup::Configuration::Compressor::Gzip.clear_defaults! }
+  it 'should be a subclass of Compressor::Base' do
+    Backup::Compressor::Gzip.
+      superclass.should == Backup::Compressor::Base
+  end
 
-    it 'uses and overrides configuration defaults' do
-      Backup::Configuration::Compressor::Gzip.best.should be_false
-      Backup::Configuration::Compressor::Gzip.fast.should be_false
+  describe '#initialize' do
+    let(:compressor) { Backup::Compressor::Gzip.new }
 
-      compressor = Backup::Compressor::Gzip.new
-      compressor.best.should be_false
-      compressor.fast.should be_false
+    after { Backup::Compressor::Gzip.clear_defaults! }
 
-      Backup::Configuration::Compressor::Gzip.defaults do |c|
-        c.best = true
-        c.fast = true
+    it 'should load pre-configured defaults' do
+      Backup::Compressor::Gzip.any_instance.expects(:load_defaults!)
+      compressor
+    end
+
+    context 'when no pre-configured defaults have been set' do
+      it 'should use default values' do
+        compressor.level.should be_false
+
+        compressor.instance_variable_get(:@cmd).should == 'gzip'
+        compressor.instance_variable_get(:@ext).should == '.gz'
       end
-      Backup::Configuration::Compressor::Gzip.best.should be_true
-      Backup::Configuration::Compressor::Gzip.fast.should be_true
 
-      compressor = Backup::Compressor::Gzip.new
-      compressor.best.should be_true
-      compressor.fast.should be_true
+      it 'should use the values given' do
+        compressor = Backup::Compressor::Gzip.new do |c|
+          c.level = 5
+        end
+        compressor.level.should == 5
 
-      compressor = Backup::Compressor::Gzip.new do |c|
-        c.best = false
+        compressor.instance_variable_get(:@cmd).should == 'gzip -5'
+        compressor.instance_variable_get(:@ext).should == '.gz'
       end
-      compressor.best.should be_false
-      compressor.fast.should be_true
+    end # context 'when no pre-configured defaults have been set'
 
-      compressor = Backup::Compressor::Gzip.new do |c|
-        c.fast = false
+    context 'when pre-configured defaults have been set' do
+      before do
+        Backup::Compressor::Gzip.defaults do |c|
+          c.level = 7
+        end
       end
-      compressor.best.should be_true
-      compressor.fast.should be_false
-    end
-  end # describe 'setting configuration defaults'
 
-  describe '#compress_with' do
-    before do
-      compressor.expects(:log!)
-      compressor.expects(:utility).with(:gzip).returns('gzip')
-    end
+      it 'should use pre-configured defaults' do
+        compressor.level.should == 7
 
-    it 'should yield with the --best option' do
-      compressor.best = true
-      compressor.compress_with do |cmd, ext|
-        cmd.should == 'gzip --best'
-        ext.should == '.gz'
+        compressor.instance_variable_get(:@cmd).should == 'gzip -7'
+        compressor.instance_variable_get(:@ext).should == '.gz'
       end
-    end
 
-    it 'should yield with the --fast option' do
-      compressor.fast = true
-      compressor.compress_with do |cmd, ext|
-        cmd.should == 'gzip --fast'
-        ext.should == '.gz'
+      it 'should override pre-configured defaults' do
+        compressor = Backup::Compressor::Gzip.new do |c|
+          c.level = 6
+        end
+        compressor.level.should == 6
+
+        compressor.instance_variable_get(:@cmd).should == 'gzip -6'
+        compressor.instance_variable_get(:@ext).should == '.gz'
       end
-    end
+    end # context 'when pre-configured defaults have been set'
+  end # describe '#initialize'
+
+  describe 'deprecations' do
+    describe 'fast and best options' do
+      context 'when only the fast option is used' do
+        before do
+          Backup::Logger.expects(:warn).with(
+            instance_of(Backup::Errors::ConfigurationError)
+          )
+        end
 
-    it 'should yield with the --best and --fast options' do
-      compressor.best = true
-      compressor.fast = true
-      compressor.compress_with do |cmd, ext|
-        cmd.should == 'gzip --best --fast'
-        ext.should == '.gz'
+        context 'when set to true' do
+          it 'should log a warning and set `level` to 1' do
+            Backup::Logger.expects(:warn).with(
+              "Backup::Compressor::Gzip.level is being set to '1'"
+            )
+            compressor = Backup::Compressor::Gzip.new do |c|
+              c.fast = true
+            end
+            compressor.level.should be(1)
+          end
+        end
+
+        context 'when set to false' do
+          it 'should only log a warning' do
+            compressor = Backup::Compressor::Gzip.new do |c|
+              c.fast = false
+            end
+            compressor.level.should be_false
+          end
+        end
       end
-    end
 
-    it 'should yield with no options' do
-      compressor.compress_with do |cmd, ext|
-        cmd.should == 'gzip'
-        ext.should == '.gz'
+      context 'when only the best option is used' do
+        before do
+          Backup::Logger.expects(:warn).with(
+            instance_of(Backup::Errors::ConfigurationError)
+          )
+        end
+
+        context 'when set to true' do
+          it 'should log a warning and set `level` to 1' do
+            Backup::Logger.expects(:warn).with(
+              "Backup::Compressor::Gzip.level is being set to '9'"
+            )
+            compressor = Backup::Compressor::Gzip.new do |c|
+              c.best = true
+            end
+            compressor.level.should be(9)
+          end
+        end
+
+        context 'when set to false' do
+          it 'should only log a warning' do
+            compressor = Backup::Compressor::Gzip.new do |c|
+              c.best = false
+            end
+            compressor.level.should be_false
+          end
+        end
+
       end
-    end
-  end # describe '#compress_with'
 
+      context 'when both fast and best options are used' do
+        before do
+          Backup::Logger.expects(:warn).twice.with(
+            instance_of(Backup::Errors::ConfigurationError)
+          )
+        end
+
+        context 'when both are set true' do
+          context 'when fast is set first' do
+            it 'should cause the best option to be set' do
+              Backup::Logger.expects(:warn).with(
+                "Backup::Compressor::Gzip.level is being set to '1'"
+              )
+              Backup::Logger.expects(:warn).with(
+                "Backup::Compressor::Gzip.level is being set to '9'"
+              )
+              compressor = Backup::Compressor::Gzip.new do |c|
+                c.fast = true
+                c.best = true
+              end
+              compressor.level.should == 9
+            end
+          end
+
+          context 'when best is set first' do
+            it 'should cause the fast option to be set' do
+              Backup::Logger.expects(:warn).with(
+                "Backup::Compressor::Gzip.level is being set to '1'"
+              )
+              Backup::Logger.expects(:warn).with(
+                "Backup::Compressor::Gzip.level is being set to '9'"
+              )
+              compressor = Backup::Compressor::Gzip.new do |c|
+                c.best = true
+                c.fast = true
+              end
+              compressor.level.should == 1
+            end
+          end
+        end
+
+        context 'when only one is set true' do
+          context 'when fast is set true before best' do
+            it 'should cause the fast option to be set' do
+              Backup::Logger.expects(:warn).with(
+                "Backup::Compressor::Gzip.level is being set to '1'"
+              )
+              compressor = Backup::Compressor::Gzip.new do |c|
+                c.fast = true
+                c.best = false
+              end
+              compressor.level.should == 1
+            end
+          end
+
+          context 'when fast is set true after best' do
+            it 'should cause the fast option to be set' do
+              Backup::Logger.expects(:warn).with(
+                "Backup::Compressor::Gzip.level is being set to '1'"
+              )
+              compressor = Backup::Compressor::Gzip.new do |c|
+                c.best = false
+                c.fast = true
+              end
+              compressor.level.should == 1
+            end
+          end
+
+          context 'when best is set true before fast' do
+            it 'should cause the best option to be set' do
+              Backup::Logger.expects(:warn).with(
+                "Backup::Compressor::Gzip.level is being set to '9'"
+              )
+              compressor = Backup::Compressor::Gzip.new do |c|
+                c.best = true
+                c.fast = false
+              end
+              compressor.level.should == 9
+            end
+          end
+
+          context 'when best is set true after fast' do
+            it 'should cause the best option to be set' do
+              Backup::Logger.expects(:warn).with(
+                "Backup::Compressor::Gzip.level is being set to '9'"
+              )
+              compressor = Backup::Compressor::Gzip.new do |c|
+                c.fast = false
+                c.best = true
+              end
+              compressor.level.should == 9
+            end
+          end
+        end
+
+        context 'when both are set false' do
+          it 'should only issue the two warnings' do
+            compressor = Backup::Compressor::Gzip.new do |c|
+              c.fast = false
+              c.best = false
+            end
+            compressor.level.should be_false
+          end
+        end
+      end
+    end # describe 'fast and best options'
+  end # describe 'deprecations'
 end

data/spec/compressor/lzma_spec.rb

@@ -3,52 +3,83 @@
 require File.expand_path('../../spec_helper.rb', __FILE__)
 
 describe Backup::Compressor::Lzma do
-  let(:compressor) { Backup::Compressor::Lzma.new }
+  before do
+    Backup::Compressor::Lzma.any_instance.stubs(:utility).returns('lzma')
+  end
 
-  describe 'setting configuration defaults' do
-    after { Backup::Configuration::Compressor::Lzma.clear_defaults! }
+  it 'should be a subclass of Compressor::Base' do
+    Backup::Compressor::Lzma.
+      superclass.should == Backup::Compressor::Base
+  end
 
-    it 'uses and overrides configuration defaults' do
-      Backup::Configuration::Compressor::Lzma.best.should be_false
-      Backup::Configuration::Compressor::Lzma.fast.should be_false
+  describe '#initialize' do
+    let(:compressor) { Backup::Compressor::Lzma.new }
 
-      compressor = Backup::Compressor::Lzma.new
-      compressor.best.should be_false
-      compressor.fast.should be_false
+    after { Backup::Compressor::Lzma.clear_defaults! }
 
-      Backup::Configuration::Compressor::Lzma.defaults do |c|
-        c.best = true
-        c.fast = true
+    it 'should load pre-configured defaults' do
+      Backup::Compressor::Lzma.any_instance.expects(:load_defaults!)
+      compressor
+    end
+
+    context 'when no pre-configured defaults have been set' do
+      it 'should use default values' do
+        compressor.best.should be_false
+        compressor.fast.should be_false
       end
-      Backup::Configuration::Compressor::Lzma.best.should be_true
-      Backup::Configuration::Compressor::Lzma.fast.should be_true
 
-      compressor = Backup::Compressor::Lzma.new
-      compressor.best.should be_true
-      compressor.fast.should be_true
+      it 'should use the values given' do
+        compressor = Backup::Compressor::Lzma.new do |c|
+          c.best = true
+          c.fast = true
+        end
 
-      compressor = Backup::Compressor::Lzma.new do |c|
-        c.best = false
+        compressor.best.should be_true
+        compressor.fast.should be_true
       end
-      compressor.best.should be_false
-      compressor.fast.should be_true
+    end # context 'when no pre-configured defaults have been set'
 
-      compressor = Backup::Compressor::Lzma.new do |c|
-        c.fast = false
+    context 'when pre-configured defaults have been set' do
+      before do
+        Backup::Compressor::Lzma.defaults do |c|
+          c.best = true
+          c.fast = true
+        end
       end
-      compressor.best.should be_true
-      compressor.fast.should be_false
-    end
-  end # describe 'setting configuration defaults'
+
+      it 'should use pre-configured defaults' do
+        compressor.best.should be_true
+        compressor.fast.should be_true
+      end
+
+      it 'should override pre-configured defaults' do
+        compressor = Backup::Compressor::Lzma.new do |c|
+          c.best = false
+          c.fast = false
+        end
+
+        compressor.best.should be_false
+        compressor.fast.should be_false
+      end
+    end # context 'when pre-configured defaults have been set'
+  end # describe '#initialize'
 
   describe '#compress_with' do
     before do
-      compressor.expects(:log!)
-      compressor.expects(:utility).with(:lzma).returns('lzma')
+      Backup::Compressor::Lzma.any_instance.expects(:log!)
+
+      Backup::Logger.expects(:warn).with do |msg|
+        msg.should match(
+          /\[DEPRECATION WARNING\]\n  Compressor::Lzma is being deprecated/
+        )
+      end
     end
 
     it 'should yield with the --best option' do
-      compressor.best = true
+      compressor = Backup::Compressor::Lzma.new do |c|
+        c.best = true
+      end
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'lzma --best'
         ext.should == '.lzma'
@@ -56,28 +87,37 @@ describe Backup::Compressor::Lzma do
     end
 
     it 'should yield with the --fast option' do
-      compressor.fast = true
+      compressor = Backup::Compressor::Lzma.new do |c|
+        c.fast = true
+      end
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'lzma --fast'
         ext.should == '.lzma'
       end
     end
 
-    it 'should yield with the --best and --fast options' do
-      compressor.best = true
-      compressor.fast = true
+    it 'should prefer the --best option over --fast' do
+      compressor = Backup::Compressor::Lzma.new do |c|
+        c.best = true
+        c.fast = true
+      end
+
       compressor.compress_with do |cmd, ext|
-        cmd.should == 'lzma --best --fast'
+        cmd.should == 'lzma --best'
         ext.should == '.lzma'
       end
     end
 
     it 'should yield with no options' do
+      compressor = Backup::Compressor::Lzma.new
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'lzma'
         ext.should == '.lzma'
       end
     end
+
   end # describe '#compress_with'
 
 end

data/spec/compressor/pbzip2_spec.rb

@@ -3,66 +3,90 @@
 require File.expand_path('../../spec_helper.rb', __FILE__)
 
 describe Backup::Compressor::Pbzip2 do
-  let(:compressor) { Backup::Compressor::Pbzip2.new }
+  before do
+    Backup::Compressor::Pbzip2.any_instance.stubs(:utility).returns('pbzip2')
+  end
 
-  describe 'setting configuration defaults' do
-    after { Backup::Configuration::Compressor::Pbzip2.clear_defaults! }
+  it 'should be a subclass of Compressor::Base' do
+    Backup::Compressor::Pbzip2.
+      superclass.should == Backup::Compressor::Base
+  end
 
-    it 'uses and overrides configuration defaults' do
-      Backup::Configuration::Compressor::Pbzip2.best.should be_false
-      Backup::Configuration::Compressor::Pbzip2.fast.should be_false
-      Backup::Configuration::Compressor::Pbzip2.processors.should be_false
+  describe '#initialize' do
+    let(:compressor) { Backup::Compressor::Pbzip2.new }
 
-      compressor = Backup::Compressor::Pbzip2.new
-      compressor.best.should be_false
-      compressor.fast.should be_false
-      compressor.processors.should be_false
+    after { Backup::Compressor::Pbzip2.clear_defaults! }
 
-      Backup::Configuration::Compressor::Pbzip2.defaults do |c|
-        c.best = true
-        c.fast = true
-        c.processors = 2
+    it 'should load pre-configured defaults' do
+      Backup::Compressor::Pbzip2.any_instance.expects(:load_defaults!)
+      compressor
+    end
+
+    context 'when no pre-configured defaults have been set' do
+      it 'should use default values' do
+        compressor.best.should be_false
+        compressor.fast.should be_false
+        compressor.processors.should be_false
       end
-      Backup::Configuration::Compressor::Pbzip2.best.should be_true
-      Backup::Configuration::Compressor::Pbzip2.fast.should be_true
-      Backup::Configuration::Compressor::Pbzip2.processors.should == 2
 
-      compressor = Backup::Compressor::Pbzip2.new
-      compressor.best.should be_true
-      compressor.fast.should be_true
-      compressor.processors.should == 2
+      it 'should use the values given' do
+        compressor = Backup::Compressor::Pbzip2.new do |c|
+          c.best = true
+          c.fast = true
+          c.processors = 2
+        end
 
-      compressor = Backup::Compressor::Pbzip2.new do |c|
-        c.best = false
+        compressor.best.should be_true
+        compressor.fast.should be_true
+        compressor.processors.should == 2
+      end
+    end # context 'when no pre-configured defaults have been set'
+
+    context 'when pre-configured defaults have been set' do
+      before do
+        Backup::Compressor::Pbzip2.defaults do |c|
+          c.best = true
+          c.fast = true
+          c.processors = 2
+        end
       end
-      compressor.best.should be_false
-      compressor.fast.should be_true
-      compressor.processors.should == 2
 
-      compressor = Backup::Compressor::Pbzip2.new do |c|
-        c.fast = false
+      it 'should use pre-configured defaults' do
+        compressor.best.should be_true
+        compressor.fast.should be_true
+        compressor.processors.should == 2
       end
-      compressor.best.should be_true
-      compressor.fast.should be_false
-      compressor.processors.should == 2
 
-      compressor = Backup::Compressor::Pbzip2.new do |c|
-        c.processors = false
+      it 'should override pre-configured defaults' do
+        compressor = Backup::Compressor::Pbzip2.new do |c|
+          c.best = false
+          c.fast = false
+          c.processors = 4
+        end
+
+        compressor.best.should be_false
+        compressor.fast.should be_false
+        compressor.processors.should == 4
       end
-      compressor.best.should be_true
-      compressor.fast.should be_true
-      compressor.processors.should be_false
-    end
-  end # describe 'setting configuration defaults'
+    end # context 'when pre-configured defaults have been set'
+  end # describe '#initialize'
 
   describe '#compress_with' do
     before do
-      compressor.expects(:log!)
-      compressor.expects(:utility).with(:pbzip2).returns('pbzip2')
+      Backup::Compressor::Pbzip2.any_instance.expects(:log!)
+
+      Backup::Logger.expects(:warn).with do |msg|
+        msg.should match(
+          /\[DEPRECATION WARNING\]\n  Compressor::Pbzip2 is being deprecated/
+        )
+      end
     end
 
     it 'should yield with the --best option' do
-      compressor.best = true
+      compressor = Backup::Compressor::Pbzip2.new do |c|
+        c.best = true
+      end
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'pbzip2 --best'
         ext.should == '.bz2'
@@ -70,7 +94,10 @@ describe Backup::Compressor::Pbzip2 do
     end
 
     it 'should yield with the --fast option' do
-      compressor.fast = true
+      compressor = Backup::Compressor::Pbzip2.new do |c|
+        c.fast = true
+      end
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'pbzip2 --fast'
         ext.should == '.bz2'
@@ -78,25 +105,34 @@ describe Backup::Compressor::Pbzip2 do
     end
 
     it 'should yield with the -p option' do
-      compressor.processors = 2
+      compressor = Backup::Compressor::Pbzip2.new do |c|
+        c.processors = 2
+      end
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'pbzip2 -p2'
         ext.should == '.bz2'
       end
     end
 
-    it 'should yield with the --best and --fast options' do
-      compressor.best = true
-      compressor.fast = true
+    it 'should prefer the --best option over --fast' do
+      compressor = Backup::Compressor::Pbzip2.new do |c|
+        c.best = true
+        c.fast = true
+      end
+
       compressor.compress_with do |cmd, ext|
-        cmd.should == 'pbzip2 --best --fast'
+        cmd.should == 'pbzip2 --best'
         ext.should == '.bz2'
       end
     end
 
     it 'should yield with the --best and -p options' do
-      compressor.best = true
-      compressor.processors = 2
+      compressor = Backup::Compressor::Pbzip2.new do |c|
+        c.best = true
+        c.processors = 2
+      end
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'pbzip2 --best -p2'
         ext.should == '.bz2'
@@ -104,8 +140,11 @@ describe Backup::Compressor::Pbzip2 do
     end
 
     it 'should yield with the --fast and -p options' do
-      compressor.fast = true
-      compressor.processors = 2
+      compressor = Backup::Compressor::Pbzip2.new do |c|
+        c.fast = true
+        c.processors = 2
+      end
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'pbzip2 --fast -p2'
         ext.should == '.bz2'
@@ -113,6 +152,8 @@ describe Backup::Compressor::Pbzip2 do
     end
 
     it 'should yield with no options' do
+      compressor = Backup::Compressor::Pbzip2.new
+
       compressor.compress_with do |cmd, ext|
         cmd.should == 'pbzip2'
         ext.should == '.bz2'