backup 3.0.20 → 3.0.21

data/spec/notifier/prowl_spec.rb

@@ -3,147 +3,115 @@
 require File.expand_path('../../spec_helper.rb', __FILE__)
 
 describe Backup::Notifier::Prowl do
+  let(:model) { Backup::Model.new(:test_trigger, 'test label') }
   let(:notifier) do
-    Backup::Notifier::Prowl.new do |prowl|
+    Backup::Notifier::Prowl.new(model) do |prowl|
       prowl.application = 'application'
       prowl.api_key     = 'api_key'
     end
   end
 
   describe '#initialize' do
-    it 'sets the correct defaults' do
-      notifier.application = 'application'
-      notifier.api_key     = 'api_key'
+    it 'should sets the correct values' do
+      notifier.application.should == 'application'
+      notifier.api_key.should     == 'api_key'
 
       notifier.on_success.should == true
       notifier.on_warning.should == true
       notifier.on_failure.should == true
     end
 
-    it 'uses and overrides configuration defaults' do
-      Backup::Configuration::Notifier::Prowl.defaults do |notifier|
-        notifier.application  = 'my_default_application'
-        notifier.on_success   = false
-      end
-      prowl = Backup::Notifier::Prowl.new do |notifier|
-        notifier.api_key = 'my_own_api_key'
-      end
-
-      prowl.application.should == 'my_default_application'
-      prowl.api_key.should     == 'my_own_api_key'
-      prowl.on_success.should  == false
-      prowl.on_warning.should  == true
-      prowl.on_failure.should  == true
-    end
-
-    it 'creates a new Prowler::Application' do
-      notifier.prowl_client.should be_an_instance_of Prowler::Application
-      notifier.prowl_client.application.should == notifier.application
-      notifier.prowl_client.api_key.should == notifier.api_key
-    end
-  end
-
-  describe '#perform!' do
-    let(:model)     { Backup::Model.new('trigger', 'label') {} }
-    let(:message_a) { '[Backup::%s]' }
-    let(:message_b) { 'label (trigger)' }
-
-    before do
-      notifier.on_success = false
-      notifier.on_warning = false
-      notifier.on_failure = false
-    end
+    context 'when using configuration defaults' do
+      after { Backup::Configuration::Notifier::Prowl.clear_defaults! }
 
-    context 'success' do
+      it 'should use the configuration defaults' do
+        Backup::Configuration::Notifier::Prowl.defaults do |prowl|
+          prowl.application = 'default_app'
+          prowl.api_key     = 'default_api_key'
 
-      context 'when on_success is true' do
-        before { notifier.on_success = true }
-
-        it 'sends success message' do
-          notifier.expects(:log!)
-          notifier.prowl_client.expects(:notify).
-              with(message_a % 'Success', message_b)
-
-          notifier.perform!(model)
+          prowl.on_success = false
+          prowl.on_warning = false
+          prowl.on_failure = false
         end
-      end
+        notifier = Backup::Notifier::Prowl.new(model)
+        notifier.application.should == 'default_app'
+        notifier.api_key.should     == 'default_api_key'
 
-      context 'when on_success is false' do
-        it 'sends no message' do
-          notifier.expects(:log!).never
-          notifier.expects(:notify!).never
-          notifier.prowl_client.expects(:notify).never
-
-          notifier.perform!(model)
-        end
+        notifier.on_success.should == false
+        notifier.on_warning.should == false
+        notifier.on_failure.should == false
       end
 
-    end # context 'success'
+      it 'should override the configuration defaults' do
+        Backup::Configuration::Notifier::Prowl.defaults do |prowl|
+          prowl.application = 'old_app'
+          prowl.api_key     = 'old_api_key'
 
-    context 'warning' do
-      before { Backup::Logger.stubs(:has_warnings?).returns(true) }
-
-      context 'when on_success is true' do
-        before { notifier.on_success = true }
-
-        it 'sends warning message' do
-          notifier.expects(:log!)
-          notifier.prowl_client.expects(:notify).
-              with(message_a % 'Warning', message_b)
-
-          notifier.perform!(model)
+          prowl.on_success = true
+          prowl.on_warning = false
+          prowl.on_failure = false
         end
-      end
+        notifier = Backup::Notifier::Prowl.new(model) do |prowl|
+          prowl.application = 'new_app'
+          prowl.api_key     = 'new_api_key'
 
-      context 'when on_warning is true' do
-        before { notifier.on_warning = true }
-
-        it 'sends warning message' do
-          notifier.expects(:log!)
-          notifier.prowl_client.expects(:notify).
-              with(message_a % 'Warning', message_b)
-
-          notifier.perform!(model)
+          prowl.on_success = false
+          prowl.on_warning = true
+          prowl.on_failure = true
         end
-      end
 
-      context 'when on_success and on_warning are false' do
-        it 'sends no message' do
-          notifier.expects(:log!).never
-          notifier.expects(:notify!).never
-          notifier.prowl_client.expects(:notify).never
+        notifier.application.should == 'new_app'
+        notifier.api_key.should     == 'new_api_key'
 
-          notifier.perform!(model)
-        end
+        notifier.on_success.should == false
+        notifier.on_warning.should == true
+        notifier.on_failure.should == true
       end
+    end # context 'when using configuration defaults'
+  end
 
-    end # context 'warning'
-
-    context 'failure' do
-
-      context 'when on_failure is true' do
-        before { notifier.on_failure = true }
-
-        it 'sends failure message' do
-          notifier.expects(:log!)
-          notifier.prowl_client.expects(:notify).
-              with(message_a % 'Failure', message_b)
-
-          notifier.perform!(model, Exception.new)
-        end
+  describe '#notify!' do
+    context 'when status is :success' do
+      it 'should send Success message' do
+        notifier.expects(:send_message).with(
+          '[Backup::Success]'
+        )
+        notifier.send(:notify!, :success)
       end
+    end
 
-      context 'when on_failure is false' do
-        it 'sends no message' do
-          notifier.expects(:log!).never
-          notifier.expects(:notify!).never
-          notifier.prowl_client.expects(:notify).never
-
-          notifier.perform!(model, Exception.new)
-        end
+    context 'when status is :warning' do
+      it 'should send Warning message' do
+        notifier.expects(:send_message).with(
+          '[Backup::Warning]'
+        )
+        notifier.send(:notify!, :warning)
       end
+    end
 
-    end # context 'failure'
+    context 'when status is :failure' do
+      it 'should send Failure message' do
+        notifier.expects(:send_message).with(
+          '[Backup::Failure]'
+        )
+        notifier.send(:notify!, :failure)
+      end
+    end
+  end # describe '#notify!'
+
+  describe '#send_message' do
+    it 'should send the given message' do
+      client = mock
+      Prowler.expects(:new).with(
+        :application => 'application', :api_key => 'api_key'
+      ).returns(client)
+      client.expects(:notify).with(
+        'a message',
+        'test label (test_trigger)'
+      )
+
+      notifier.send(:send_message, 'a message')
+    end
+  end
 
-  end # describe '#perform!'
 end

data/spec/notifier/twitter_spec.rb

@@ -3,8 +3,9 @@
 require File.expand_path('../../spec_helper.rb', __FILE__)
 
 describe Backup::Notifier::Twitter do
+  let(:model) { Backup::Model.new(:test_trigger, 'test label') }
   let(:notifier) do
-    Backup::Notifier::Twitter.new do |twitter|
+    Backup::Notifier::Twitter.new(model) do |twitter|
       twitter.consumer_key       = 'consumer_key'
       twitter.consumer_secret    = 'consumer_secret'
       twitter.oauth_token        = 'oauth_token'
@@ -13,7 +14,7 @@ describe Backup::Notifier::Twitter do
   end
 
   describe '#initialize' do
-    it 'sets the correct defaults' do
+    it 'should sets the correct values' do
       notifier.consumer_key.should       == 'consumer_key'
       notifier.consumer_secret.should    == 'consumer_secret'
       notifier.oauth_token.should        == 'oauth_token'
@@ -24,128 +25,108 @@ describe Backup::Notifier::Twitter do
       notifier.on_failure.should == true
     end
 
-    it 'uses and overrides configuration defaults' do
-      Backup::Configuration::Notifier::Twitter.defaults do |twitter|
-        twitter.consumer_key = 'new_consumer_key'
-        twitter.on_success   = false
-      end
-      notifier = Backup::Notifier::Twitter.new do |twitter|
-        twitter.consumer_key = 'my_own_consumer_key'
-      end
-
-      notifier.consumer_key.should   == 'my_own_consumer_key'
-      notifier.on_success.should == false
-      notifier.on_warning.should == true
-      notifier.on_failure.should == true
-    end
+    context 'when using configuration defaults' do
+      after { Backup::Configuration::Notifier::Twitter.clear_defaults! }
 
-    it 'create a new Twitter::Client' do
-      notifier.twitter_client.should be_an_instance_of ::Twitter::Client
-      #notifier.twitter_client.credentials?.should be_true
-      options = ::Twitter.options # v1.7.1 API
-      options[:consumer_key].should       == notifier.consumer_key
-      options[:consumer_secret].should    == notifier.consumer_secret
-      options[:oauth_token].should        == notifier.oauth_token
-      options[:oauth_token_secret].should == notifier.oauth_token_secret
-    end
-  end
+      it 'should use the configuration defaults' do
+        Backup::Configuration::Notifier::Twitter.defaults do |twitter|
+          twitter.consumer_key       = 'some_consumer_key'
+          twitter.consumer_secret    = 'some_consumer_secret'
+          twitter.oauth_token        = 'some_oauth_token'
+          twitter.oauth_token_secret = 'some_oauth_token_secret'
 
-  describe '#perform!' do
-    let(:model)   { Backup::Model.new('trigger', 'label') {} }
-    let(:message) { '[Backup::%s] label (trigger)' }
-
-    before do
-      notifier.on_success = false
-      notifier.on_warning = false
-      notifier.on_failure = false
-    end
-
-    context 'success' do
-
-      context 'when on_success is true' do
-        before { notifier.on_success = true }
-
-        it 'sends success message' do
-          notifier.expects(:log!)
-          notifier.twitter_client.expects(:update).with(message % 'Success')
-
-          notifier.perform!(model)
+          twitter.on_success = false
+          twitter.on_warning = false
+          twitter.on_failure = false
         end
+        notifier = Backup::Notifier::Twitter.new(model)
+        notifier.consumer_key.should       == 'some_consumer_key'
+        notifier.consumer_secret.should    == 'some_consumer_secret'
+        notifier.oauth_token.should        == 'some_oauth_token'
+        notifier.oauth_token_secret.should == 'some_oauth_token_secret'
+
+        notifier.on_success.should == false
+        notifier.on_warning.should == false
+        notifier.on_failure.should == false
       end
 
-      context 'when on_success is false' do
-        it 'sends no message' do
-          notifier.expects(:log!).never
-          notifier.expects(:notify!).never
-          notifier.twitter_client.expects(:update).never
+      it 'should override the configuration defaults' do
+        Backup::Configuration::Notifier::Twitter.defaults do |twitter|
+          twitter.consumer_key       = 'old_consumer_key'
+          twitter.consumer_secret    = 'old_consumer_secret'
+          twitter.oauth_token        = 'old_oauth_token'
+          twitter.oauth_token_secret = 'old_oauth_token_secret'
 
-          notifier.perform!(model)
+          twitter.on_success = true
+          twitter.on_warning = false
+          twitter.on_failure = false
         end
-      end
-
-    end # context 'success'
-
-    context 'warning' do
-      before { Backup::Logger.stubs(:has_warnings?).returns(true) }
-
-      context 'when on_success is true' do
-        before { notifier.on_success = true }
-
-        it 'sends warning message' do
-          notifier.expects(:log!)
-          notifier.twitter_client.expects(:update).with(message % 'Warning')
-
-          notifier.perform!(model)
+        notifier = Backup::Notifier::Twitter.new(model) do |twitter|
+          twitter.consumer_key       = 'new_consumer_key'
+          twitter.consumer_secret    = 'new_consumer_secret'
+          twitter.oauth_token        = 'new_oauth_token'
+          twitter.oauth_token_secret = 'new_oauth_token_secret'
+
+          twitter.on_success = false
+          twitter.on_warning = true
+          twitter.on_failure = true
         end
-      end
-
-      context 'when on_warning is true' do
-        before { notifier.on_warning = true }
 
-        it 'sends warning message' do
-          notifier.expects(:log!)
-          notifier.twitter_client.expects(:update).with(message % 'Warning')
+        notifier.consumer_key.should       == 'new_consumer_key'
+        notifier.consumer_secret.should    == 'new_consumer_secret'
+        notifier.oauth_token.should        == 'new_oauth_token'
+        notifier.oauth_token_secret.should == 'new_oauth_token_secret'
 
-          notifier.perform!(model)
-        end
+        notifier.on_success.should == false
+        notifier.on_warning.should == true
+        notifier.on_failure.should == true
       end
+    end # context 'when using configuration defaults'
+  end
 
-      context 'when on_success and on_warning are false' do
-        it 'sends no message' do
-          notifier.expects(:log!).never
-          notifier.expects(:notify!).never
-          notifier.twitter_client.expects(:update).never
-
-          notifier.perform!(model)
-        end
+  describe '#notify!' do
+    context 'when status is :success' do
+      it 'should send Success message' do
+        notifier.expects(:send_message).with(
+          '[Backup::Success] test label (test_trigger)'
+        )
+        notifier.send(:notify!, :success)
       end
+    end
 
-    end # context 'warning'
-
-    context 'failure' do
-
-      context 'when on_failure is true' do
-        before { notifier.on_failure = true }
-
-        it 'sends failure message' do
-          notifier.expects(:log!)
-          notifier.twitter_client.expects(:update).with(message % 'Failure')
+    context 'when status is :warning' do
+      it 'should send Warning message' do
+        notifier.expects(:send_message).with(
+          '[Backup::Warning] test label (test_trigger)'
+        )
+        notifier.send(:notify!, :warning)
+      end
+    end
 
-          notifier.perform!(model, Exception.new)
-        end
+    context 'when status is :failure' do
+      it 'should send Failure message' do
+        notifier.expects(:send_message).with(
+          '[Backup::Failure] test label (test_trigger)'
+        )
+        notifier.send(:notify!, :failure)
       end
+    end
+  end # describe '#notify!'
 
-      context 'when on_failure is false' do
-        it 'sends no message' do
-          notifier.expects(:log!).never
-          notifier.expects(:notify!).never
-          notifier.twitter_client.expects(:update).never
+  describe '#send_message' do
+    it 'should send a message' do
+      client, config = mock, mock
 
-          notifier.perform!(model, Exception.new)
-        end
-      end
+      ::Twitter.expects(:configure).yields(config)
+      config.expects(:consumer_key=).with('consumer_key')
+      config.expects(:consumer_secret=).with('consumer_secret')
+      config.expects(:oauth_token=).with('oauth_token')
+      config.expects(:oauth_token_secret=).with('oauth_token_secret')
 
-    end # context 'failure'
+      ::Twitter::Client.expects(:new).returns(client)
+      client.expects(:update).with('a message')
 
-  end # describe '#perform!'
+      notifier.send(:send_message, 'a message')
+    end
+  end
 end