backlog 0.23.1 → 0.24.0

data/lang/en.yaml

@@ -40,6 +40,7 @@ friday: Friday
 grab_task: Grab task
 group: Group
 groups: Groups
+holidays_used: Holidays used
 home: Home
 hours: Hours
 invite: Invite
@@ -72,6 +73,7 @@ no_pending_tasks: There are no pending tasks in this sprint.
 no_pending_tasks_in_backlog: There are no pending tasks in this backlog.
 not_grabbed: Not grabbed by anyone
 notes: Notes
+ownership: Ownership
 paging: Paging
 password: Password
 period: Sprint
@@ -93,6 +95,7 @@ search: Search
 search_results_for: "Search results for '%s'"
 select: Select
 shortcuts: Shortcuts
+sick_days_used: Sick days
 signup: Sign Up
 specify: Specify
 spreadsheet: Spreadsheet
@@ -102,6 +105,7 @@ start_work: Start
 started_at: Started at
 started_tasks: Started tasks
 stop: Stop
+work_lock_subscriptions: Work Lock Subscriptions
 sunday: Sunday
 task: Task
 tasks: Tasks

data/lang/no.yaml

@@ -40,6 +40,7 @@ friday: Fredag
 grab_task: Grip oppgave
 group: Gruppe
 groups: Grupper
+holidays_used: Brukte feriedager
 home: Hjem
 hours: Timer
 invite: Invitèr
@@ -72,6 +73,7 @@ no_pending_tasks: Det er ingen ventende oppgaver i denne perioden.
 no_pending_tasks_in_backlog: Det er ingen ventende oppgaver i denne oppgavelisten.
 not_grabbed: Ikke tatt av noen
 notes: Notater
+ownership: Eierskap
 paging: Del opp i flere sider
 password: Passord
 period: Periode
@@ -93,6 +95,7 @@ search: Søk
 search_results_for: "Søkeresultater for '%s'"
 select: Velg
 shortcuts: Knapper
+sick_days_used: Sykedager
 signup: Innmelding
 specify: Spesifisèr
 spreadsheet: Regneark
@@ -101,6 +104,7 @@ start_on: Start på
 start_work: Start arbeid
 started_at: Start tid
 stop: Stopp
+work_lock_subscriptions: Abonenter på timelister
 sunday: Søndag
 task: Oppgave
 tasks: Oppgaver

data/lib/change_column_null_migration_fix.rb

@@ -7,6 +7,8 @@ class ActiveRecord::Migration
       execute("ALTER TABLE #{table_name} ALTER #{column_name} #{null ? 'DROP' : 'SET'} NOT NULL") 
     elsif ActiveRecord::Base.connection.adapter_name.downcase == "mysql"
       execute("ALTER TABLE #{table_name} MODIFY COLUMN #{column_name} #{column_type} #{null ? 'NULL' : 'NOT NULL'}")
+    else
+      raise "'change_column_null' is not supported for connection adapter #{ActiveRecord::Base.connection.adapter_name}."
     end
   end
   

data/test/fixtures/absences.yml

@@ -0,0 +1,11 @@
+# Read about fixtures at http://ar.rubyonrails.org/classes/Fixtures.html
+one:
+  id: 1
+  user_id: 1000001
+  "on": 2007-06-10
+  reason: HOLIDAY
+two:
+  id: 2
+  user_id: 1000001
+  "on": 2007-06-11
+  reason: SICK

data/test/fixtures/works.yml

@@ -2,19 +2,22 @@
 first:
   id: 1
   task_id: 1
-  started_at: 2007-06-12T13:35:00
+  started_on: 2007-06-12
+  start_time: !time 13:35:00
   completed_at: 2007-06-12T14:35:00
   hours: 30.0
   work_account_id: 1
 started:
   id: 2
   task_id: 4
-  started_at: 2007-06-12T13:35:00
+  started_on: 2007-06-12
+  start_time: !time 13:35:00
   work_account_id: 1
 personal:
   id: 3
   task_id: 1
-  started_at: 2007-06-12T13:35:00
+  started_on: 2007-06-12
+  start_time: !time 13:35:00
   completed_at: 2007-06-12T14:35:00
   user_id: 1000001
   hours: 40.0
@@ -22,13 +25,15 @@ personal:
 brother_of_started:
   id: 5
   task_id: 4
-  started_at: 2007-06-12T13:35:00
+  started_on: 2007-06-12
+  start_time: !time 13:35:00
   completed_at: 2007-06-12T14:35:00
   work_account_id: 1
 without_task:
   id: 6
   work_account_id: 1
-  started_at: 2007-06-13T13:35:00
+  started_on: 2007-06-13
+  start_time: !time 13:35:00
   completed_at: 2007-06-13T14:35:00
   hours: 8.0
   user_id: 1000001

data/test/functional/absences_controller_test.rb

@@ -0,0 +1,93 @@
+require File.dirname(__FILE__) + '/../test_helper'
+require 'absences_controller'
+
+# Re-raise errors caught by the controller.
+class AbsencesController; def rescue_action(e) raise e end; end
+
+class AbsencesControllerTest < Test::Unit::TestCase
+  fixtures :absences
+
+  def setup
+    @controller = AbsencesController.new
+    @request    = ActionController::TestRequest.new
+    @response   = ActionController::TestResponse.new
+    @request.session[:user_id] = 1000001
+
+    @first_id = absences(:one).id
+  end
+
+  def test_index
+    get :index
+    assert_response :success
+    assert_template 'list'
+  end
+
+  def test_list
+    get :list
+
+    assert_response :success
+    assert_template 'list'
+
+    assert_not_nil assigns(:absences)
+  end
+
+  def test_show
+    get :show, :id => @first_id
+
+    assert_response :success
+    assert_template 'show'
+
+    assert_not_nil assigns(:absence)
+    assert assigns(:absence).valid?
+  end
+
+  def test_new
+    get :new
+
+    assert_response :success
+    assert_template 'new'
+
+    assert_not_nil assigns(:absence)
+  end
+
+  def test_create
+    num_absences = Absence.count
+
+    post :create, :absence => {:on => '2007-06-09', :reason => 'HOLIDAY'}
+
+    assert_response :redirect
+    assert_redirected_to :action => 'list'
+
+    assert_equal num_absences + 1, Absence.count
+  end
+
+  def test_edit
+    get :edit, :id => @first_id
+
+    assert_response :success
+    assert_template 'edit'
+
+    assert_not_nil assigns(:absence)
+    assert assigns(:absence).valid?
+  end
+
+  def test_update
+    post :update, :id => @first_id
+    assert_response :redirect
+    assert_redirected_to :action => 'show', :id => @first_id
+  end
+
+  def test_destroy
+    assert_nothing_raised {
+      Absence.find(@first_id)
+    }
+
+    post :destroy, :id => @first_id
+    assert_response :redirect
+    assert_redirected_to :action => 'list'
+
+    assert_raise(ActiveRecord::RecordNotFound) {
+      Absence.find(@first_id)
+    }
+  end
+end

data/test/functional/tasks_controller_test.rb

@@ -177,13 +177,14 @@ class TasksControllerTest < Test::Unit::TestCase
     before = Task.find(1)
     assert_equal 70, before.total_done
     
-    post :end_work, :id => 1, :work => {:work_started_at_time => (Time.now - 3600).strftime('%H:%M')}
+    post :end_work, :id => 1, :work => {:work_start_time => (TimeOfDay.now - 3600).to_s}
     assert_response :redirect
     assert_redirected_to :controller => 'works', :action => :new, 
                           'work[hours]' => "0.25",
                           'work[task_id]' => 1,
+                          'work[started_on]' => Time.previous_quarter.to_date.to_s,
+                          'work[start_time]' => Time.previous_quarter.time_of_day.to_s,
                           'work[completed_at]' => Time.next_quarter.iso8601,
-                          'work[started_at]' => Time.previous_quarter.iso8601,
                           'estimate[todo]' => 1
     
     after = Task.find(1)

data/test/functional/works_controller_test.rb

@@ -8,6 +8,7 @@ class WorksControllerTest < Test::Unit::TestCase
   main_scenario
   
   def setup
+    #super
     @controller = WorksController.new
     @request    = ActionController::TestRequest.new
     @response   = ActionController::TestResponse.new
@@ -16,6 +17,7 @@ class WorksControllerTest < Test::Unit::TestCase
   end
   
   def teardown
+    super
     assert_sequences
   end
   
@@ -56,7 +58,18 @@ class WorksControllerTest < Test::Unit::TestCase
   def test_create
     num_works = Work.count
     
-    post :create, :work => {:task_id => 1, :started_at => Time.now.iso8601, :work_account_id => '1'}
+    post :create, :work => {:task_id => 1, :started_on => Date.today.to_s, :start_time => Time.now.time_of_day.to_s, :work_account_id => '1'}
+    
+    assert_response :redirect
+    assert_redirected_to :controller => 'periods', :action => 'show', :id => periods(:past).id, :task_id => 1
+    
+    assert_equal num_works + 1, Work.count
+  end
+  
+  def test_create_without_start_date
+    num_works = Work.count
+    
+    post :create, :work => {:task_id => 1, :start_time => Time.now.time_of_day.to_s, :work_account_id => '1'}
     
     assert_response :redirect
     assert_redirected_to :controller => 'periods', :action => 'show', :id => periods(:past).id, :task_id => 1
@@ -76,17 +89,31 @@ class WorksControllerTest < Test::Unit::TestCase
   
   def test_update
     post :update, :id => 1
+    assert_not_nil assigns(:work)
+    assert_equal([], assigns(:work).errors.full_messages, assigns(:work).inspect)
     assert_response :redirect
     assert_redirected_to :controller => 'periods', :action => 'show', :id => periods(:past).id
   end
   
   def test_update_time
     before = works(:first)
-    old_start_time = before.started_at
-    expected_time = Time.local(old_start_time.year , old_start_time.month, old_start_time.day, 8, 15)
-    post :update_time, :id => 1, :work => {"started_at_time"=>"8:15"}
+    old_start_date = before.started_on
+    expected_time = TimeOfDay.new(8, 15)
+    post :update_time, :id => 1, :work => {"start_time"=>"8:15"}
+    assert_response :success
+    assert_equal old_start_date, assigns(:work).started_on
+    assert_equal expected_time, assigns(:work).start_time
+  end
+  
+  def test_update_row_with_empty_start_time
+    before = works(:first)
+    old_start_date = before.started_on
+
+    post :update_time, :id => 1, :work => {"start_time"=>""}
+    
     assert_response :success
-    assert_equal expected_time.iso8601, assigns(:work).started_at.iso8601
+    assert_equal old_start_date, assigns(:work).started_on
+    assert_equal nil, assigns(:work).start_time
   end
   
   def test_destroy
@@ -107,7 +134,7 @@ class WorksControllerTest < Test::Unit::TestCase
     task = tasks(:started)
     work = works(:started)
     
-    post :update, "commit"=>"Lagre", "action"=>"update", "id"=>work.id.to_s, "controller"=>"works", "estimate"=>{"todo"=>"0"}, "work"=>{"completed_at"=>"2007-08-02 14:15", "task_id"=> task.id.to_s, "user_id"=>"1000001", "started_at"=>"2007-08-02 14:00"}
+    post :update, "commit"=>"Lagre", "action"=>"update", "id"=>work.id.to_s, "controller"=>"works", "estimate"=>{"todo"=>"0"}, "work"=>{"completed_at"=>"2007-08-02 14:15", "task_id"=> task.id.to_s, "user_id"=>"1000001", "started_on"=>"2007-08-02", "start_time"=>"14:00"}
     
     assert_response :redirect
     assert_redirected_to :controller => 'periods', :action => :show, :id => task.period, :task => nil

data/test/test_helper.rb

@@ -5,7 +5,8 @@ require 'user_notify'
 
 class Test::Unit::TestCase
   def self.main_scenario
-    fixtures :parties, :users, :groups, :groups_users, :work_accounts, :backlogs, :periods, :tasks, :task_files, :works, :estimates, :work_lock_subscriptions, :work_locks
+    fixtures :parties, :users, :groups, :groups_users, :work_accounts, :backlogs, :periods, :tasks,
+    :task_files, :works, :estimates, :work_lock_subscriptions, :work_locks, :absences
   end
   
   # Transactional fixtures accelerate your tests by wrapping each test method
@@ -60,7 +61,7 @@ class Test::Unit::TestCase
   def users(login)
     User.find_by_login(login.to_s)
   end  
-
+  
   def set_logged_in( user )
     @request.session[:user_id] = user.id
   end

data/test/unit/absence_test.rb

@@ -0,0 +1,31 @@
+require File.dirname(__FILE__) + '/../test_helper'
+
+class AbsenceTest < Test::Unit::TestCase
+  main_scenario
+
+  def teardown
+    Thread.current[:user] = nil
+  end
+  
+  def test_illegal_to_mark_date_as_absent_if_there_is_registered_work_on_same_date
+    Thread.current[:user] = users(:tesla)
+    assert_raise ActiveRecord::RecordInvalid do
+      Absence.create!({:on => '2007-06-12', :user_id => 1000001, :reason => 'lazy'})
+    end
+  end
+
+  def test_create_with_anonymous_not_allowed
+    assert_raise ActiveRecord::RecordInvalid do
+      Absence.create!({:on => '2007-06-12', :user_id => nil, :reason => 'lazy'})
+    end
+  end
+  
+  private
+
+  # TODO (uwe): This method should be removed
+  # It is here only because ClassTableInheritanceInRails broke reading fixtures by name
+  def users(login)
+    super(login)
+  end
+  
+end

data/test/unit/work_test.rb

@@ -61,6 +61,13 @@ class WorkTest < Test::Unit::TestCase
     assert_equal({work_accounts(:light_control) => [nil, BigDecimal('30'), nil, nil, nil, nil, nil]}, work_totals)
   end
 
+  def test_illegal_to_register_work_if_the_same_date_is_marked_as_absent
+    Thread.current[:user] = users(:tesla)
+    assert_raise ActiveRecord::RecordInvalid do
+      Work.create!({:started_on => '2007-06-10', :user_id => 1000001, :work_account => work_accounts(:light_control)})
+    end
+  end
+
   private
 
   # TODO (uwe): This method should be removed

data/vendor/plugins/rails_time/MIT-LICENSE

@@ -0,0 +1,20 @@
+Copyright (c) 2006 Jerrett Taylor
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/vendor/plugins/rails_time/README

@@ -0,0 +1,28 @@
+= Rails Time
+
+A handler for storing TimeOfDay objects in ActiveRecord objects as sql time values.
+
+
+== Installation
+
+./script/plugin install svn://rubyforge.org/var/svn/backlog/vendor/plugins/rails_time
+
+
+== Usage
+
+Create your tables with fields with type :time and you will be able to access them as
+TimeOfDay objects.
+
+  add_column :schedule, :start_time, :time
+ 
+  schedule = Schedule.find_first
+  schedule.start_time = TimeOfDay.parse('08:34')
+  schedule.price >> "08:34:00"
+
+
+Creating a Money can be done from a Fixnum (dollars) or a Float (dollars.cents). To create a money
+object from just cents, do Money.create_from_cents(100) 
+
+== Feedback
+
+Any suggestions, fixes, or improvements - lemme know, jerrett at gmail

data/vendor/plugins/rails_time/init.rb

@@ -0,0 +1,2 @@
+require 'time_of_day'
+require 'activerecord_time_extension'

data/vendor/plugins/rails_time/lib/activerecord_time_extension.rb

@@ -0,0 +1,28 @@
+module ActiveRecord
+  module ConnectionAdapters
+    class Column
+      def klass_with_time_of_day
+        return TimeOfDay if :time === type
+        klass_without_time_of_day
+      end
+      alias_method_chain :klass, :time_of_day
+      
+      def self.string_to_dummy_time(string)
+        return string if string.is_a? TimeOfDay
+        return nil if string.empty?
+        TimeOfDay.parse(string)
+      end
+    end
+    module Quoting
+      def quote_with_time_of_day(value, column = nil)
+        return "'#{quoted_time(value)}'" if TimeOfDay === value
+        quote_without_time_of_day(value, column)
+      end
+      alias_method_chain :quote, :time_of_day
+      
+      def quoted_time(value)
+        value.to_s
+      end
+    end
+  end
+end