backfiller 0.2.0 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 18b60be56e9153bca870e126330f666518c012c885c2e3d86d5c24625b395780
-  data.tar.gz: 06e10fa60228916766f7740231add1e1acc0c3f7dec1b9a1055785d908941a29
+  metadata.gz: 1c24e062cc5912339de434c17eabe729dcc48df6a361b891ba3c23985bc0bd92
+  data.tar.gz: d26a5b2bd63c94c1453ab0160463c446532c6fa8279b5bb0d049fe32d14f4785
 SHA512:
-  metadata.gz: 0315e6720c7ec5c15904696843caef797a5beceb2771934b01dcc61fddbbb4f65c28fb9b4a60ad94ea2c1d31161facc64f5016a8a236f506ea02f560b94e9262
-  data.tar.gz: 5a085ff3f03022926e6e188f1900f3697658ca78489e45273fce7fc6d6a78e93708c481c7bcfd09ddf049fe223c04f8ac6f625d7dc0fa103282070b1297d23f0
+  metadata.gz: 0650a73d5913a0a5a742adddcf07fc7c5c802f1b2d5e7a03f7e46c5d77872274af134ad20495e7cb7f9a56ba3bf9f7e189584135b2508280bac94756c6421340
+  data.tar.gz: ad1ffc87d70618cbd348633fceebcccad553d148677464791548e0725b491edf7a2fad8e6e2f3bb3b9f57e97ce2a181328746cb9a75d7e7a4f12752f5987c381

data/Changelog.md

@@ -1,13 +1,21 @@
 # Changelog
 
+## 0.2.2
+
+- Always release connections in runner (#5).
+
+## 0.2.1
+
+- `cursor_threshold` is nil by default.
+
 ## 0.2.0
 
-* Upgrade local gems
-* Add rubocop
-* Add specs
-* Configure travis
-* Add `cursor_threshold` feature
+- Upgrade local gems
+- Add rubocop
+- Add specs
+- Configure travis
+- Add `cursor_threshold` feature
 
 ## 0.1.1
 
-* Support Rails 6.0.0
+- Support Rails 6.0.0

data/README.md

@@ -168,6 +168,7 @@ For Rails application backfiller is initialized with next options
 * task_directory: `RAILS_ROOT/db/backfill`
 * task_namespace: `Backfill`
 * batch_size: `1_000`
+* cursor_threshold: `nil`
 * connection_pool: `ApplicationRecord.connection_pool`
 * logger: `ApplicationRecord.logger`
 
@@ -186,6 +187,10 @@ class Backfill::Foo
   def batch_size
     100
   end
+
+  def cursor_threshold
+    100_000
+  end
 end
 ```
 

data/backfiller.gemspec

@@ -5,7 +5,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name = 'backfiller'
-  spec.version = '0.2.0'
+  spec.version = '0.2.2'
   spec.authors = ['Andriy Yanko']
   spec.email = ['andriy.yanko@railsware.com']
 

data/lib/backfiller/railtie.rb

@@ -14,8 +14,6 @@ module Backfiller
 
         config.batch_size = 1_000
 
-        config.cursor_threshold = 100_000
-
         config.logger = defined?(ApplicationRecord) ? ApplicationRecord.logger : ActiveRecord::Base.logger
       end
     end

data/lib/backfiller/runner.rb

@@ -46,12 +46,14 @@ module Backfiller
       master_connection = acquire_connection
       worker_connection = acquire_connection
 
-      run_cursor_loop(master_connection) do |row|
-        process_method.call(worker_connection, row)
+      begin
+        run_cursor_loop(master_connection) do |row|
+          process_method.call(worker_connection, row)
+        end
+      ensure
+        release_connection(master_connection)
+        release_connection(worker_connection)
       end
-
-      release_connection(master_connection)
-      release_connection(worker_connection)
     end
 
     private
@@ -114,7 +116,7 @@ module Backfiller
 
         Backfiller.log "Processed #{count}"
 
-        return [false, count] if count > cursor_threshold
+        return [false, count] if cursor_threshold && count > cursor_threshold
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: backfiller
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.2.2
 platform: ruby
 authors:
 - Andriy Yanko
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-07-05 00:00:00.000000000 Z
+date: 2023-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -140,7 +140,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: Backfiller for null database columns