backbone-support 0.4.0 → 0.5.0

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: e9ffe52a5316ecd3a32212b66cfa6cdfb530ef8e
+  data.tar.gz: 4cc867fc3ece887b2f73fc3dc216c705e4e7b48c
+SHA512:
+  metadata.gz: af84d8073f5b27a768b341dce5852f9ac1d8799ac8ee3be0c4c30a7bbf41aca6e7905f20387ece1364c9784e461856f5bf41e058c8d5a91cf7f324b8d04eceb7
+  data.tar.gz: 65e5644b534351753aaf045c3ecd8edfcc330613d228bcf6f331dfa9bda5f96ee1afa1f0a6d483340634b842dd4134813aeead2935eac6148d9803717f83392f

data/.gitignore

@@ -1,2 +1,3 @@
 *.gem
 *.swp
+Gemfile.lock

data/.jshintrc

@@ -0,0 +1,38 @@
+{
+  "asi": false,
+  "bitwise": true,
+  "browser": true,
+  "camelcase": true,
+  "curly": true,
+  "forin": true,
+  "immed": true,
+  "latedef": "nofunc",
+  "maxlen": 80,
+  "newcap": true,
+  "noarg": true,
+  "noempty": true,
+  "nonew": true,
+  "predef": [
+    "$",
+    "jQuery",
+
+    "_",
+    "Backbone",
+    "Support",
+
+    "jasmine",
+    "beforeEach",
+    "afterEach",
+    "describe",
+    "expect",
+    "it",
+
+    "sinon",
+
+    "Helpers"
+  ],
+  "quotmark": true,
+  "trailing": true,
+  "undef": true,
+  "unused": true
+}

data/.travis.yml

@@ -1,7 +1,7 @@
+sudo: false
 language: ruby
 before_install:
   - 'export DISPLAY=:99.0'
   - 'sh -e /etc/init.d/xvfb start'
 rvm:
-  - '1.9.2'
-  - '1.9.3'
+  - 2.2.0

data/CHANGELOG

@@ -1,3 +1,12 @@
+0.5.0 (Feb 16, 2015)
+
+- Update Backbone to v1.1.2
+- Update Underscore to v1.7.0
+- Set `parent` before rendering in `CompositeView#renderChild()` so child view
+  has access to `parent` for easier event bindings.
+- Deprecate `Observer#bindTo()` and `Observer#unbindFromAll()` in favor of
+  Backbone's `Events#listenTo()` and `Events#stopListening()`.
+
 0.4.0 (May 10, 2013)
 
 - Update included Backbone to version 1.0
@@ -27,7 +36,7 @@ leave().
 0.2.0
 
 The version changes the order of when a view has render called on it when
-being swapped by a SwappingRouter. This fixes an issue in some browsers which 
+being swapped by a SwappingRouter. This fixes an issue in some browsers which
 would display a flash of unstyled content when performing certain actions in their
 render, like changing the body class. It introduces the requirement that all
 views return an instance of themselves when rendered (a fairly standard

data/README.md

@@ -1,5 +1,7 @@
 # Backbone Support [![Build Status](https://travis-ci.org/thoughtbot/backbone-support.png?branch=master)](https://travis-ci.org/thoughtbot/backbone-support) [![Gem Version](https://badge.fury.io/rb/backbone-support.png)](https://rubygems.org/gems/backbone-support)
 
+## Summary
+
 Backbone Support provides a collection of utility classes for use with
 [Backbone.js][]. There's no built-in garbage collection for Backbone’s event
 bindings, and forgetting to unbind can cause bugs and memory leaks. Backbone
@@ -30,34 +32,38 @@ Now, a `SwappingRouter` can take advantage of the `leave()` function, and
 clean up any existing views before swapping to a new one.  It swaps into a new
 view by rendering that view into its own `el`:
 
-    swap: function(newView) {
-      if (this.currentView && this.currentView.leave) {
-        this.currentView.leave();
-      }
-
-      this.currentView = newView;
-      $(this.el).empty().append(this.currentView.render().el);
-    }
+``` js
+swap: function(newView) {
+  if (this.currentView && this.currentView.leave) {
+    this.currentView.leave();
+  }
+
+  this.currentView = newView;
+  $(this.el).empty().append(this.currentView.render().el);
+}
+```
 
 An example SwappingRouter would look as follows:
 
-    Trajectory.Routers.Stories = Support.SwappingRouter.extend({
-      initialize: function(options) {
-        this.el = $("div.primary_content");
-      },
-      routes: {
-        "stories": "index",
-        "stories/new": "newStory"
-      }
-      index: function() {
-        var view = new Trajectory.Views.StoriesIndex();
-        this.swap(view);
-      },
-      newStory: function() {
-        var view = new Trajectory.Views.StoryNew({ model: new Story() });
-        this.swap(view);
-      }
-    }
+``` js
+Trajectory.Routers.Stories = Support.SwappingRouter.extend({
+  initialize: function(options) {
+    this.el = $("div.primary_content");
+  },
+  routes: {
+    "stories": "index",
+    "stories/new": "newStory"
+  }
+  index: function() {
+    var view = new Trajectory.Views.StoriesIndex();
+    this.swap(view);
+  },
+  newStory: function() {
+    var view = new Trajectory.Views.StoryNew({ model: new Story() });
+    this.swap(view);
+  }
+}
+```
 
 ### CompositeView
 
@@ -119,7 +125,9 @@ advantage of the asset pipeline.
 
 Add the gem to your Gemfile:
 
-    gem "backbone-support"
+``` ruby
+gem "backbone-support"
+```
 
 And then `bundle install`.
 
@@ -158,7 +166,6 @@ or:
 ### With Jammit
 
 First off:
-
     rails plugin install git@github.com:thoughtbot/backbone-support.git
 
 In your `config/application.rb`:

data/backbone-support.gemspec

@@ -16,7 +16,7 @@ Gem::Specification.new do |s|
   s.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
   s.require_paths = ["lib"]
 
-  s.add_development_dependency('jasmine', '1.3.0')
+  s.add_development_dependency('jasmine', '~> 2.0')
   s.add_development_dependency('rake')
   s.add_development_dependency('headless')
 end

data/bower.json

@@ -0,0 +1,38 @@
+{
+  "name": "backbone-support",
+  "version": "0.4.0",
+  "description": "SwappingController and CompositeView for Backbone.js",
+  "main": [
+    "vendor/assets/javascripts/underscore.js",
+    "vendor/assets/javascripts/backbone.js",
+    "lib/assets/javascripts/backbone-support/support.js",
+    "lib/assets/javascripts/backbone-support/observer.js",
+    "lib/assets/javascripts/backbone-support/composite_view.js",
+    "lib/assets/javascripts/backbone-support/swapping_router.js"
+  ],
+  "license": "MIT",
+  "ignore": [
+    "**/*.txt",
+    "**/.*",
+    ".jshintrc",
+    "CHANGELOG",
+    "Gemfile",
+    "Gemfile.lock",
+    "LICENSE",
+    "README.md",
+    "Rakefile",
+    "backbone-support.gemspec",
+    "spec"
+  ],
+  "homepage": "https://github.com/thoughtbot/backbone-support",
+  "authors": [
+    "thoughtbot (http://thoughtbot.com)"
+  ],
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/thoughtbot/backbone-support.git"
+  },
+  "keywords": [
+    "backbone"
+  ]
+}

data/lib/assets/javascripts/backbone-support/composite_view.js

@@ -14,31 +14,31 @@ _.extend(Support.CompositeView.prototype, Backbone.View.prototype, Support.Obser
   },
 
   renderChild: function(view) {
+    view.parent = this;
     view.render();
     this.children.push(view);
-    view.parent = this;
   },
-  
+
   renderChildInto: function(view, container) {
     this.renderChild(view);
-    this.$(container).empty().append(view.el);
+    this.$(container).html(view.el);
   },
 
   appendChild: function(view) {
     this.renderChild(view);
-    $(this.el).append(view.el);
+    this.$el.append(view.el);
   },
-  
+
   appendChildTo: function (view, container) {
     this.renderChild(view);
     this.$(container).append(view.el);
   },
-  
+
   prependChild: function(view) {
     this.renderChild(view);
-    $(this.el).prepend(view.el);
+    this.$el.prepend(view.el);
   },
-  
+
   prependChildTo: function (view, container) {
     this.renderChild(view);
     this.$(container).prepend(view.el);

data/lib/assets/javascripts/backbone-support/observer.js

@@ -1,16 +1,28 @@
-Support.Observer = function() {};
+(function() {
 
-_.extend(Support.Observer.prototype, {
-  bindTo: function(source, event, callback) {
-    source.bind(event, callback, this);
-    this.bindings = this.bindings || [];
-    this.bindings.push({ source: source, event: event, callback: callback });
-  },
+  Support.Observer = function() {};
 
-  unbindFromAll: function() {
-    _.each(this.bindings, function(binding) {
-      binding.source.unbind(binding.event, binding.callback);
-    });
-    this.bindings = []
+  // `console` is not defined when the Developer Tools are not open in older
+  // versions of Internet Explorer
+  function deprecate(message) {
+    /* global console */
+    if ( console && console.warn ) {
+      console.warn(message);
+    }
   }
-});
+
+  _.extend(Support.Observer.prototype, {
+    bindTo: function(source, event, callback) {
+      deprecate("Using #bindTo has been deprecated. Use #listenTo instead.");
+      this.listenTo(source, event, callback);
+    },
+
+    unbindFromAll: function() {
+      deprecate(
+        "Using #unbindFromAll has been deprecated. Use #stopListening instead."
+      );
+
+      this.stopListening();
+    }
+  });
+})();

data/lib/assets/javascripts/backbone-support/swapping_router.js

@@ -9,7 +9,7 @@ _.extend(Support.SwappingRouter.prototype, Backbone.Router.prototype, {
     }
 
     this.currentView = newView;
-    $(this.el).empty().append(this.currentView.render().el);
+    $(this.el).html(this.currentView.render().el);
 
     if (this.currentView && this.currentView.swapped) {
       this.currentView.swapped();

data/lib/backbone-support/version.rb

@@ -1,3 +1,3 @@
 module BackboneSupport
-  VERSION = '0.4.0'.freeze
+  VERSION = "0.5.0".freeze
 end

data/spec/javascripts/composite_view_spec.js

@@ -1,3 +1,4 @@
+/* global Helpers, Support */
 describe("Support.CompositeView", function() {
   var orangeView = Support.CompositeView.extend({
     render: function() {
@@ -37,8 +38,26 @@ describe("Support.CompositeView", function() {
       expect($("#test1").text()).toEqual("Orange!");
       expect($("#test2").text()).toEqual("Orange!");
     });
+
+    it("sets parent before rendering child view", function() {
+      var view = new blankView();
+      var spy = sinon.spy(view, 'on');
+      var viewWithParentBinding = Support.CompositeView.extend({
+        render: function() {
+          this.listenTo(this.parent, 'foo', this.foo);
+          return this;
+        },
+
+        foo: function() {
+        }
+      });
+
+      view.renderChild(new viewWithParentBinding({ el: "#test1" }));
+
+      expect(spy.called).toBeTruthy();
+    });
   });
-  
+
   describe("#renderChildInto", function() {
     it("renders child into the given element and replaces content there", function() {
       $("#test1").text("Replace this!");
@@ -57,7 +76,7 @@ describe("Support.CompositeView", function() {
       var view = new blankView({el: $('<div><div class="inside"></div></div>')});
       view.renderChildInto(new orangeView(), ".inside");
 
-     expect($(view.el).find('.inside').text()).toEqual("Orange!"); 
+      expect($(view.el).find('.inside').text()).toEqual("Orange!");
     });
   });
 
@@ -80,7 +99,7 @@ describe("Support.CompositeView", function() {
       view.appendChildTo(new orangeView(), "#test1");
 
       expect($("#test1").text()).toEqual("Append to this!Orange!");
-      
+
       $("#test1").remove();
       expect($("#test").text()).toEqual("");
     });
@@ -89,7 +108,7 @@ describe("Support.CompositeView", function() {
       var view = new blankView({el: $('<div><div class="inside">Append to this!</div></div>')});
       view.appendChildTo(new orangeView(), ".inside");
 
-      expect($(view.el).find('.inside').text()).toEqual("Append to this!Orange!"); 
+      expect($(view.el).find('.inside').text()).toEqual("Append to this!Orange!");
     });
 
     it("appends the element only to elements inside the view", function(){
@@ -101,27 +120,27 @@ describe("Support.CompositeView", function() {
       expect($("#outside").text()).toEqual("");
     });
   });
-  
+
   describe("#prependChild", function() {
     it("renders and prepends children views", function() {
       var view = new blankView({el: "#test"});
       view.prependChild(new orangeView());
       view.prependChild(new normalView());
-  
+
       expect($("#test").text()).toEqual("Normal!Orange!");
     });
   });
-  
+
   describe("#prependChildTo", function() {
     it("prepends child into the given element", function() {
       $("#test1").text("Prepend to this!");
-  
+
       var view = new blankView({el: "#test"});
       expect($("#test").text()).toEqual("");
 
       $("#test").append($("#test1"));
       view.prependChildTo(new orangeView(), "#test1");
-  
+
       expect($("#test1").text()).toEqual("Orange!Prepend to this!");
     });
 
@@ -131,7 +150,7 @@ describe("Support.CompositeView", function() {
 
       expect($(view.el).find('.inside').text()).toEqual("Orange!Prepend to this!");
     });
-    
+
     it("prepends the element only to elements inside the view", function(){
       var view = new blankView({el: $('<div><div class="main">Prepend to this!</div></div>')});
       var div = $("<div class='main' id='outside'></div>");
@@ -147,29 +166,15 @@ describe("Support.CompositeView", function() {
       var view = new orangeView();
       var spy = sinon.spy(view, "unbind");
 
-      runs(function() {
-        view.render();
-        $("#test").append(view.el);
-      });
-
-      Helpers.sleep();
-
-      runs(function() {
-        expect($("#test").text()).toEqual("Orange!");
-      });
-
-      Helpers.sleep();
+      view.render();
+      $("#test").append(view.el);
 
-      runs(function() {
-        view.leave();
-      });
+      expect($("#test").text()).toEqual("Orange!");
 
-      Helpers.sleep();
+      view.leave();
 
-      runs(function() {
-        expect($("#test").text()).toEqual("");
-        expect(spy.called).toBeTruthy();
-      });
+      expect($("#test").text()).toEqual("");
+      expect(spy.called).toBeTruthy();
     });
 
     it("removes children views on leave", function() {
@@ -197,7 +202,7 @@ describe("Support.CompositeView", function() {
     it("removes self from parent if invoked on a child view", function() {
       var view = new blankView();
       var childView = new orangeView({el: "#test1"});
-      view.renderChild(childView)
+      view.renderChild(childView);
       view.renderChild(new orangeView({el: "#test2"}));
 
       expect($("#test1").size()).toEqual(1);
@@ -248,9 +253,9 @@ describe("Support.CompositeView", function() {
 
   describe("#swapped", function() {
     it("fires 'swapped' event", function() {
-      var eventListener = sinon.spy()
-      var view = new Support.CompositeView
-      view.bind('swapped', eventListener)
+      var eventListener = sinon.spy();
+      var view = new Support.CompositeView;
+      view.bind('swapped', eventListener);
 
       view.swapped();
 
@@ -258,45 +263,20 @@ describe("Support.CompositeView", function() {
     });
   });
 
-  describe("#bindTo", function() {
-    var view = new orangeView();
-    var callback = sinon.spy();
-    var source = new Backbone.Model({
-        title: 'Model or Collection'
-    });
-
-    it("calls the unbindFromAll method when leaving the view", function() {
-      view.bindTo(source, 'foobar', callback);
-      expect(view.bindings.length).toEqual(1);
-    });
-  });
-
   describe("#unbindFromAll", function() {
-    var view = new orangeView();
-    var spy = sinon.spy(view, 'unbindFromAll');
-    var callback = sinon.spy();
-    var source = new Backbone.Model({
+    it("calls the unbindFromAll method when leaving the view", function() {
+      var view = new orangeView();
+      var spy = sinon.spy(view, 'unbindFromAll');
+      var callback = sinon.spy();
+      var source = new Backbone.Model({
         title: 'Model or Collection'
-    });
+      });
 
-    runs(function() {
       view.render();
       view.bindTo(source, 'foo', callback);
-      expect(view.bindings.length).toEqual(1);
-    });
-
-    Helpers.sleep();
-
-    runs(function() {
       view.leave();
-    });
-
-    Helpers.sleep();
 
-    it("calls the unbindFromAll method when leaving the view", function() {
-      runs(function() {
-        expect(spy.called).toBeTruthy();
-      });
+      expect(spy.called).toBeTruthy();
     });
   });
 });