backbone-filtered-collection 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 652f34d8646e018db86ec95f4722b8b115a0078f
-  data.tar.gz: bf1d2c926f9e1e0135984b78613d3ddc36a055e8
+  metadata.gz: ab93a979fe8e435f5d48597d79582f2a8019eee3
+  data.tar.gz: fc6f40626046d710f63f3200b4d91d4c974c8900
 SHA512:
-  metadata.gz: 69c6b95b7d3d05da2521ced7e1cb26fe970efb633869d9459cc52907f8a02105d982f5f500e07c9bd33f48b6ec9cc3ddb6982b3a574c67f16c8c6b353a1de4fc
-  data.tar.gz: f1c0fde67a77d7e28c15e4e7808d4d6c4ee4feb22a4d67cf520c5b119472845e89e08f05dafeb9700b7b23139e0d4109a0751f7d70e9bf3d5f08c8d787efdb88
+  metadata.gz: 6d2256530258f3d78fc40027317e11fdd90a332ec9e46fa4db651a0de2bcc6f9a7262dc0be40d6f7783b5f467fee4cb1e3337ed1805c3b6aac78ccb90ee8fce5
+  data.tar.gz: d5e5b4e1c5e4b5918ee460b3e97d2ad4787dc4b3686be1f9f93fc5f991961871a95cdbe8290b4ae9986f406f5ba744cb09f286ccd4ad0e76d0bb4f4f8f64e76e

data/.ruby-gemset

@@ -0,0 +1 @@
+filtered-collection

data/.ruby-version

@@ -0,0 +1 @@
+ruby-2.0.0-p353

data/backbone-filtered-collection.gemspec

@@ -20,5 +20,5 @@ Gem::Specification.new do |gem|
   gem.add_dependency "railties", ">= 3.0", "< 5.0"
 
   gem.add_development_dependency 'rake'
-  gem.add_development_dependency 'jasmine'
+  gem.add_development_dependency 'jasmine', '< 2.0'
 end

data/lib/backbone/filtered_collection/version.rb

@@ -1,5 +1,5 @@
 module Backbone
   module FilteredCollection
-    VERSION = "1.2.0"
+    VERSION = "1.2.1"
   end
 end

data/spec/javascripts/backbone-filtered-collection-spec.js

@@ -377,6 +377,37 @@ describe("Backbone.FilteredCollection", function() {
       expect(addSpy).toHaveBeenCalledWith(origModelZero, collection, jasmine.any(Object));
       expect(removeSpy).not.toHaveBeenCalled();
     });
+
+    it("property change events are fired on filtered collection", function() {
+      var collection         = new Backbone.Collection([ {id: 1, difficulty: 1}, {id: 2, difficulty: 2}, {id: 3, difficulty: 1}, {id: 4, difficulty: 3} ]);
+      var filteredCollection = new Backbone.FilteredCollection(null, {collection: collection});
+      filteredCollection.setFilter(function(d) { return (d.get('difficulty') === 1) });
+
+      var changeCount = 0;
+      var newModel = new Backbone.Model({id: 5, difficulty: 1});
+      collection.add(newModel);
+
+      filteredCollection.on("change:blah", function() { changeCount  = changeCount + 1; });
+      filteredCollection.on("change:blubb", function() { changeCount  = changeCount + 1; });
+      newModel.set({"blah": "blah"});
+
+      expect(changeCount).toEqual(1);
+    });
+
+    it("property change events are not fired if it does not fit filter", function() {
+      var collection         = new Backbone.Collection([ {id: 1, difficulty: 1}, {id: 2, difficulty: 2}, {id: 3, difficulty: 1}, {id: 4, difficulty: 3} ]);
+      var filteredCollection = new Backbone.FilteredCollection(null, {collection: collection});
+      filteredCollection.setFilter(function(d) { return (d.get('difficulty') === 1) });
+
+      var changeCount = 0;
+      var newModel = new Backbone.Model({id: 5, difficulty: 1});
+      collection.add(newModel);
+
+      filteredCollection.on("change:difficulty", function() { changeCount  = changeCount + 1; });
+      newModel.set("difficulty", 2);
+
+      expect(changeCount).toEqual(0);
+    });
   });
 
   describe("#resetWith", function() {

data/vendor/assets/javascripts/backbone-filtered-collection.js

@@ -107,6 +107,7 @@ THE SOFTWARE.
       options || (options = {});
 
       var ownIndexOfModel = this.indexOf(model);
+      var self = this;
       if (this.collectionFilter(model)){
         // Model passed filter
         if (ownIndexOfModel < 0){
@@ -117,6 +118,10 @@ THE SOFTWARE.
         // the model passes the filter and is already in the collection
         // therefore we want to indicate that the model has changed
         else {
+          _.each(_.keys(model.changed), function(key) {
+            self.trigger("change:" + key, model, model.changed[key], options);
+          });
+
           this.trigger("change", model, this);
         }
       } else {

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: backbone-filtered-collection
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - Dmitriy Likhten
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-10 00:00:00.000000000 Z
+date: 2014-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -48,16 +48,16 @@ dependencies:
   name: jasmine
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - <
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - <
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.0'
 description: A filtered collection for backbone.js
 email:
 - dlikhten@gmail.com
@@ -66,7 +66,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
-- .rvmrc
+- .ruby-gemset
+- .ruby-version
 - .travis.yml
 - Gemfile
 - LICENSE
@@ -104,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.6
+rubygems_version: 2.1.11
 signing_key: 
 specification_version: 4
 summary: Allowing implementation of a chain-of-responsibility pattern in backbone's

data/.rvmrc

@@ -1 +0,0 @@
-rvm use ruby-2.0.0-p247@filtered-collection --create