baby-braspag 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,15 @@
 ---
-SHA1:
-  metadata.gz: 13c6e3ecf69bd5dd355b5767532c41532065075d
-  data.tar.gz: 615fc83e05cad85f928e30d082982c51c0777fd9
+!binary "U0hBMQ==":
+  metadata.gz: !binary |-
+    YjBlNWI2NWMxYWE1MjI1ZjEwODgwMzc2NDZhM2Y4ZGY4YTIyNWI1Nw==
+  data.tar.gz: !binary |-
+    YjVmMWVhMTBlMzc4MjY3YzdhMTM5NzhjMTdjMmYyNWFkMjQ4OGI3Yg==
 SHA512:
-  metadata.gz: 026127dec38a942f4cb32121e83153d5d74f74ad5454a9cdce55f8b5d387fcfc4776f15b453e52df4bb6d2f4169dd1467e5c90252b6b2567cbe76de35e7521ba
-  data.tar.gz: b756eaf6c931641a8e083fab99f673a3b66300cd962a9bc3d25d1c7ca5c0fb77838c621f5d9206634a5e2c3af9a3d1ec40faba8f9036f109515068b7c6216edb
+  metadata.gz: !binary |-
+    YWY0MzM5Y2MzNWQ2MjYxYzYxYTU2ZmRlZTFhZDZmOTM3NjE5M2Q2MzlmOTJm
+    ZjJjMmIzYmRlOTg3ODYwNmU1YWI5YjQzMDk2ODc0MjRhZTZmNzVmNjg2Y2Vh
+    ZWMwNTM0MzhmZjY0MTkzZGU1ZjJlNTMwODQzMTIwMTZjODQwNTQ=
+  data.tar.gz: !binary |-
+    YTIyMjJkY2U0MzYxZTkxOTgzN2EyNWI4MGU4Nzc3YzEzZWNhYzBjOGM0ODgy
+    YzZlZDEwMjFjYTQzNTU4YTE1YjFjYmQyOWVjMTY4MjczNjJlY2UxYjY4ZGJl
+    ZGQwOGQyOTVjZTBkOGY5MjIyMGEwYzc0MmRiZjU2NWZmMjBkMWE=

data/RELEASES.md

@@ -1,5 +1,9 @@
 # RELEASES
 
+## 0.4.1 - 07/07/2015
+
+5d754a Corrigindo consulta de cartão protegido.
+
 ## 0.2.1 - 11/08/2014
 
 Log das operações `SaveCreditCard` e `JustClickShop` do serviço `CartaoProtegido`.

data/lib/baby-braspag/protected_credit_card.rb

@@ -23,9 +23,7 @@ module Braspag
       :security_code => "SecurityCode"
     }
 
-    SAVE_PROTECTED_CARD_URI = "/CartaoProtegido.asmx?wsdl"
-    GET_PROTECTED_CARD_URI = "/CartaoProtegido.asmx/GetCreditCard"
-    JUST_CLICK_SHOP_URI = "/CartaoProtegido.asmx?wsdl"
+    PROTECTED_CARD_URI = "/CartaoProtegido.asmx?wsdl"
 
     # saves credit card in Braspag PCI Compliant
     def self.save(params = {})
@@ -45,7 +43,7 @@ module Braspag
 
       Braspag.logger.info("[Braspag] #save_credit_card, data: #{data_for_logging}") if Braspag.logger
 
-      client = savon_client(self.save_protected_card_url)
+      client = savon_client(self.protected_card_url)
       response = client.call(:save_credit_card, :message => data)
 
       # We do not want to let any sensitive data exposed on log files.
@@ -62,16 +60,18 @@ module Braspag
 
       raise InvalidJustClickKey unless valid_just_click_key?(just_click_key)
 
-      data = { 'getCreditCardRequestWS' => {:loja => connection.merchant_id, :justClickKey => just_click_key} }
+      request_data = { 'MerchantKey' => connection.merchant_id, 'JustClickKey' => just_click_key }
+      data = { 'getCreditCardRequestWS' => request_data }
 
-      response = Braspag::Poster.new(self.get_protected_card_url).do_post(:get_protected_card, data)
+      client = savon_client(self.protected_card_url)
+      response = client.call(:get_credit_card, message: data)
 
-      response = Utils::convert_to_map(response.body, {
-          :holder => "CardHolder",
-          :card_number => "CardNumber",
-          :expiration => "CardExpiration",
-          :masked_card_number => "MaskedCardNumber"
-        })
+      response = Utils::convert_to_map(response.to_s, {
+          :holder => 'CardHolder',
+          :card_number => 'CardNumber',
+          :expiration => 'CardExpiration',
+          :masked_card_number => 'MaskedCardNumber'
+      })
 
       raise UnknownError if response[:card_number].nil?
       response
@@ -105,7 +105,7 @@ module Braspag
 
       Braspag.logger.info("[Braspag] #just_click_shop, data: #{data_for_logging}") if Braspag.logger
 
-      client = savon_client(self.just_click_shop_url)
+      client = savon_client(self.protected_card_url)
       response = client.call(:just_click_shop, :message => data)
 
       Braspag.logger.info("[Braspag] #just_click_shop returns: #{response}") if Braspag.logger
@@ -150,16 +150,8 @@ module Braspag
       (just_click_key.is_a?(String) && just_click_key.size == 36)
     end
 
-    def self.save_protected_card_url
-      Braspag::Connection.instance.protected_card_url + SAVE_PROTECTED_CARD_URI
-    end
-
-    def self.get_protected_card_url
-      Braspag::Connection.instance.protected_card_url + GET_PROTECTED_CARD_URI
-    end
-
-    def self.just_click_shop_url
-      Braspag::Connection.instance.protected_card_url + JUST_CLICK_SHOP_URI
+    def self.protected_card_url
+      Braspag::Connection.instance.protected_card_url + PROTECTED_CARD_URI
     end
 
     def self.savon_client(url)

data/lib/baby-braspag/utils.rb

@@ -6,6 +6,7 @@ module Braspag
 
     def self.convert_to_map(document, map = {})
       document = Nokogiri::XML(document)
+      document.remove_namespaces!
 
       map.each do |key, value|
         if value.is_a?(String) || value.nil?

data/lib/baby-braspag/version.rb

@@ -1,3 +1,3 @@
 module Braspag
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

data/spec/protected_credit_card_spec.rb

@@ -69,7 +69,7 @@ describe Braspag::ProtectedCreditCard do
       end
 
       before do
-        Braspag::ProtectedCreditCard.should_receive(:save_protected_card_url)
+        Braspag::ProtectedCreditCard.should_receive(:protected_card_url)
         Braspag::ProtectedCreditCard.should_receive(:check_protected_card_params)
                            .and_return(true)
         @connection.should_receive(:savon_client).and_return(savon_double)
@@ -158,7 +158,7 @@ describe Braspag::ProtectedCreditCard do
       before do
         Braspag::ProtectedCreditCard.should_receive(:check_protected_card_params)
                             .and_return(true)
-        Braspag::ProtectedCreditCard.should_receive(:save_protected_card_url)
+        Braspag::ProtectedCreditCard.should_receive(:protected_card_url)
                             .and_return(save_protected_card_url)
         @connection.should_receive(:savon_client).and_return(savon_double)
         savon_double.should_receive(:call).and_return(response)
@@ -176,36 +176,71 @@ describe Braspag::ProtectedCreditCard do
     end
   end
 
+  class SavonClientTest
+    attr_accessor :response
+    attr_reader :method
+
+    def call(method, options, &block)
+      @method  = method
+      @options = options
+
+      @response
+    end
+
+    def options
+      OpenStruct.new(@options || {})
+    end
+  end
+
   describe ".get" do
     let(:get_protected_card_url) { "http://braspag/bla" }
 
     let(:invalid_xml) do
       <<-EOXML
-      <CartaoProtegidoReturn xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-                   xmlns:xsd="http://www.w3.org/2001/XMLSchema"
-                   xmlns="http://www.pagador.com.br/">
-        <CardHolder>Joao Maria Souza</CardHolder>
-        <CardNumber></CardNumber>
-        <CardExpiration>10/12</CardExpiration>
-        <MaskedCardNumber>******9999</MaskedCardNumber>
-      </CartaoProtegidoReturn>
+      <?xml version="1.0" encoding="utf-8"?>
+      <soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+        <soap:Body>
+          <GetCreditCardResponse xmlns="http://www.cartaoprotegido.com.br/WebService/">
+            <GetCreditCardResult>
+              <Success>false</Success>
+              <CorrelationId xsi:nil="true"/>
+              <ErrorReportCollection>
+                <ErrorReport>
+                  <ErrorCode>720</ErrorCode>
+                  <ErrorMessage>Merchant JustClick not found</ErrorMessage>
+                </ErrorReport>
+              </ErrorReportCollection>
+            </GetCreditCardResult>
+          </GetCreditCardResponse>
+        </soap:Body>
+      </soap:Envelope>
       EOXML
     end
 
     let(:valid_xml) do
       <<-EOXML
-      <CartaoProtegidoReturn xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-                   xmlns:xsd="http://www.w3.org/2001/XMLSchema"
-                   xmlns="http://www.pagador.com.br/">
-        <CardHolder>Joao Maria Souza</CardHolder>
-        <CardNumber>9999999999</CardNumber>
-        <CardExpiration>10/12</CardExpiration>
-        <MaskedCardNumber>******9999</MaskedCardNumber>
-      </CartaoProtegidoReturn>
+      <?xml version="1.0" encoding="utf-8"?>
+      <soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+        <soap:Body>
+          <GetCreditCardResponse xmlns="http://www.cartaoprotegido.com.br/WebService/">
+            <GetCreditCardResult>
+              <Success>true</Success>
+              <CorrelationId xsi:nil="true"/>
+              <ErrorReportCollection/>
+              <CardHolder>TESTE HOLDER</CardHolder>
+              <CardNumber>0000000000000001</CardNumber>
+              <CardExpiration>12/2021</CardExpiration>
+              <MaskedCardNumber>000000******0001</MaskedCardNumber>
+            </GetCreditCardResult>
+          </GetCreditCardResponse>
+        </soap:Body>
+      </soap:Envelope>
       EOXML
     end
 
     let(:logger) { mock(:info => nil) }
+    let(:savon_client) { SavonClientTest.new }
+
     before { Braspag.logger = logger }
 
     it "should raise an error when just click key is not valid" do
@@ -219,10 +254,8 @@ describe Braspag::ProtectedCreditCard do
     end
 
     it "should raise an error when Braspag returned an invalid xml as response" do
-      FakeWeb.register_uri(:post, get_protected_card_url, :body => invalid_xml)
-
-      Braspag::ProtectedCreditCard.should_receive(:get_protected_card_url)
-                         .and_return(get_protected_card_url)
+      Braspag::ProtectedCreditCard.should_receive(:savon_client)
+        .and_return(savon_client)
 
       expect {
         Braspag::ProtectedCreditCard.get("b0b0b0b0-bbbb-4d4d-bd27-f1f1f1ededed")
@@ -230,20 +263,26 @@ describe Braspag::ProtectedCreditCard do
     end
 
     it "should return a Hash when Braspag returned a valid xml as response" do
-      FakeWeb.register_uri(:post, get_protected_card_url, :body => valid_xml)
-
-      Braspag::ProtectedCreditCard.should_receive(:get_protected_card_url)
+      Braspag::ProtectedCreditCard.should_receive(:protected_card_url)
                          .and_return(get_protected_card_url)
 
+      savon_client.response = valid_xml
+
+      Braspag::ProtectedCreditCard.should_receive(:savon_client)
+        .and_return(savon_client)
+
       response = Braspag::ProtectedCreditCard.get("b0b0b0b0-bbbb-4d4d-bd27-f1f1f1ededed")
-      response.should be_kind_of Hash
 
-      response.should == {
-        :holder => "Joao Maria Souza",
-        :expiration => "10/12",
-        :card_number => "9" * 10,
-        :masked_card_number => "*" * 6 + "9" * 4
+      expect(response).to be_kind_of Hash
+
+      expected = {
+        :holder => "TESTE HOLDER",
+        :expiration => "12/2021",
+        :card_number => "0000000000000001",
+        :masked_card_number =>  "000000******0001"
       }
+
+      expect(response).to eq(expected)
     end
 
   end
@@ -264,22 +303,6 @@ describe Braspag::ProtectedCreditCard do
 
       let(:logger) { mock(:info => nil) }
 
-      class SavonClientTest
-        attr_accessor :response
-        attr_reader :method
-
-        def call(method, options, &block)
-          @method  = method
-          @options = options
-
-          @response
-        end
-
-        def options
-          OpenStruct.new(@options || {})
-        end
-      end
-
       before do
         Braspag.stub(:logger => logger)
         @savon_client_test = SavonClientTest.new
@@ -360,11 +383,10 @@ describe Braspag::ProtectedCreditCard do
       end
     end
 
-    it ".save_protected_card_url .get_protected_card_url" do
+    it ".protected_card_url" do
       @connection.stub(:protected_card_url => braspag_homologation_protected_card_url)
 
-      Braspag::ProtectedCreditCard.save_protected_card_url.should == "#{braspag_homologation_protected_card_url}/CartaoProtegido.asmx?wsdl"
-      Braspag::ProtectedCreditCard.get_protected_card_url.should == "#{braspag_homologation_protected_card_url}/CartaoProtegido.asmx/GetCreditCard"
+      expect(Braspag::ProtectedCreditCard.protected_card_url).to eq("#{braspag_homologation_protected_card_url}/CartaoProtegido.asmx?wsdl")
     end
 
   end

data/spec/utils_spec.rb

@@ -24,23 +24,64 @@ describe Braspag::Utils do
       XML
     end
 
+    let(:namespaced_document) do
+      <<-XML
+      <?xml version="1.0" encoding="utf-8"?>
+      <soap:Envelope xmlns:soap="http://www.w3.org/2003/05/soap-envelope" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
+        <soap:Body>
+          <GetCreditCardResponse xmlns="http://www.cartaoprotegido.com.br/WebService/">
+            <GetCreditCardResult>
+              <Success>true</Success>
+              <CorrelationId xsi:nil="true"/>
+              <ErrorReportCollection/>
+              <CardHolder>TESTE HOLDER</CardHolder>
+              <CardNumber>0000000000000001</CardNumber>
+              <CardExpiration>12/2021</CardExpiration>
+              <MaskedCardNumber>000000******0001</MaskedCardNumber>
+            </GetCreditCardResult>
+          </GetCreditCardResponse>
+        </soap:Body>
+      </soap:Envelope>
+      XML
+    end
+
     context "basic document and keys" do
-      it "should return a Hash" do
+      it "returns a Hash" do
         keys = { :foo => nil, :meu_elemento => "bar", :outro_elemento => "baz" }
         expected = { :foo => "blabla", :meu_elemento => "bleble", :outro_elemento => nil }
 
-        Braspag::Utils::convert_to_map(document, keys).should == expected
+        expect(Braspag::Utils::convert_to_map(document, keys)).to eq(expected)
       end
     end
 
     context "keys with a Proc" do
-      it "should return a Hash" do
+      it "returns a Hash" do
         proc = Proc.new { "value returned by Proc" }
 
         keys = { :foo => proc, :meu_elemento => "bar", :outro_elemento => "baz" }
         expected = { :foo => "value returned by Proc", :meu_elemento => "bleble", :outro_elemento => nil }
 
-        Braspag::Utils::convert_to_map(document, keys).should == expected
+        expect(Braspag::Utils::convert_to_map(document, keys)).to eq(expected)
+      end
+    end
+
+    context "when document contains namespaces" do
+      it "finds the correct Hash values" do
+        keys = {
+          holder: "CardHolder",
+          card_number: "CardNumber",
+          expiration: "CardExpiration",
+          masked_card_number: "MaskedCardNumber"
+        }
+
+        expected = {
+          :holder => "TESTE HOLDER",
+          :expiration => "12/2021",
+          :card_number => "0000000000000001",
+          :masked_card_number =>  "000000******0001"
+        }
+
+        expect(Braspag::Utils.convert_to_map(namespaced_document, keys)).to eq(expected)
       end
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: baby-braspag
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - baby dev
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-19 00:00:00.000000000 Z
+date: 2015-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httpi
@@ -28,14 +28,14 @@ dependencies:
   name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: 1.6.1
 - !ruby/object:Gem::Dependency
@@ -70,14 +70,14 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
@@ -98,75 +98,75 @@ dependencies:
   name: fakeweb
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: shoulda-matchers
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: debugger
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: baby braspag gem to use Braspag gateway
 email:
-- '"dev-team@baby.com.br"'
+- ! '"dev-team@baby.com.br"'
 executables: []
 extensions: []
 extra_rdoc_files: []
@@ -216,17 +216,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: baby-braspag
-rubygems_version: 2.4.6
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: baby braspag gem to use Braspag gateway