ba_spree_bank_transfer 1.0.0

data/spec/controllers/spree/payments_controller_spec.rb

@@ -0,0 +1,98 @@
+require 'spec_helper'
+
+describe Spree::PaymentsController, type: :controller do
+  before do
+    allow(controller).to receive(:authenticate_spree_user!).and_return(true)
+    @user = mock_model(Spree::User, :generate_spree_api_key! => false, last_incomplete_spree_order: nil)
+    allow(controller).to receive(:spree_current_user).and_return(@user)
+
+    @payment = mock_model(Spree::Payment)
+    @current_user_payments = double("current_user_payments", find_by: @payment)
+    allow(@user).to receive(:payments).and_return(@current_user_payments)
+    request.env["HTTP_REFERER"] = "http://localhost"
+  end
+
+  shared_examples_for "request which finds payment" do
+
+    it "finds payment" do
+      expect(@current_user_payments).to receive(:find_by).with(number: 'payment_id')
+      send_request
+    end
+
+    it "assigns @payment" do
+      send_request
+      expect(assigns(:payment)).to eq(@payment)
+    end
+
+    context 'when payment not found' do
+      before do
+        allow(@current_user_payments).to receive(:find_by).and_return(nil)
+      end
+
+      it "sets flash message" do
+        send_request
+        expect(flash[:error]).to eq("Payment not found")
+      end
+
+      it "redirects to back" do
+        send_request
+        expect(response).to redirect_to(:back)
+      end
+    end
+  end
+
+  describe "PATCH update" do
+    before do
+      @payment_details = double('payment_details', save: true)
+      allow(PaymentDetails).to receive(:new).and_return(@payment_details)
+    end
+
+    def send_request
+      patch :update, id: 'payment_id', payment: { bank_name: 'bank_name', account_no: "account_no", transaction_reference_no: "transaction_reference_no" }
+    end
+
+    it_behaves_like "request which finds payment"
+
+
+    it "creates new payment details" do
+      expect(PaymentDetails).to receive(:new).with(@payment, { 'bank_name' => 'bank_name', 'account_no' => "account_no", 'transaction_reference_no' => "transaction_reference_no" })
+      send_request
+    end
+
+    it "saves payment_details" do
+      expect(@payment_details).to receive(:save)
+      send_request
+    end
+
+    context 'when payment details saved successfully' do
+      it 'sets flash message' do
+        send_request
+        expect(flash[:notice]).to eq("Payment successfully updated")
+      end
+    end
+
+    context 'when payment details not saved' do
+      before do
+        allow(@payment_details).to receive(:save).and_return(false)
+        allow(@payment_details).to receive(:errors).and_return(["some error occurred"])
+      end
+
+      it 'sets flash error' do
+        send_request
+        expect(flash[:error]).to eq("some error occurred")
+      end
+    end
+
+    it "redirects to back" do
+      send_request
+      expect(response).to redirect_to(:back)
+    end
+  end
+
+  describe "#payment_params" do
+    it "permits only bank_name, account_no, transaction_reference_no, deposited_on" do
+      controller.params = { payment: { bank_name: 'Bank Name', account_no: 'Account number', transaction_reference_no: "transaction reference number", order_id: 'order_id', deposited_on: 'deposited_on' } }
+      expect(controller.send(:payment_params)).to eq({ "bank_name" => "Bank Name", "account_no" => "Account number", "transaction_reference_no" => "transaction reference number", 'deposited_on' => 'deposited_on' })
+    end
+  end
+end

data/spec/lib/payment_details_spec.rb

@@ -0,0 +1,84 @@
+require 'spec_helper'
+
+describe PaymentDetails do
+  before do
+    @payment = mock_model(Spree::Payment, update_attributes: true, :validate_bank_details= => nil)
+    @params = { 'bank_name' => 'bank_name', 'account_no' => "account_no", 'transaction_reference_no' => "transaction_reference_no" }
+    @payment_details = PaymentDetails.new(@payment, @params)
+  end
+
+  describe "#initialize" do
+    it "sets payment" do
+      expect(@payment_details.payment).to eq(@payment)
+    end
+
+    it "sets params" do
+      expect(@payment_details.params).to eq(@params)
+    end
+
+    it "initializes errors" do
+      expect(@payment_details.errors).to eq([])
+    end
+  end
+
+  describe "#save" do
+    context 'when payment details submitted' do
+      before do
+        allow(@payment).to receive(:details_submitted?).and_return(true)
+      end
+
+      it "sets errors" do
+        @payment_details.save
+        expect(@payment_details.errors).to eq(["Payment Details can be submitted only once."])
+      end
+
+      it "does not update payment" do
+        expect(@payment).not_to receive(:update_attributes)
+        @payment_details.save
+      end
+
+      it "returns false" do
+        expect(@payment_details.save).to be false
+      end
+
+    end
+
+    context 'when payment details not submitted' do
+      before do
+        allow(@payment).to receive(:details_submitted?).and_return(false)
+      end
+
+      it 'sets validates_bank_details to true' do
+        expect(@payment).to receive(:validate_bank_details=).with(true)
+        @payment_details.save
+      end
+
+      it "updates payment attributes" do
+        expect(@payment).to receive(:update_attributes)
+        @payment_details.save
+      end
+
+      context 'when payment attributes not updated successfully' do
+        before do
+          allow(@payment).to receive(:update_attributes).and_return(false)
+          allow(@payment).to receive_message_chain(:errors, :full_messages).and_return(["some error occurred"])
+        end
+
+        it 'sets errors' do
+          @payment_details.save
+          expect(@payment_details.errors).to eq(["some error occurred"])
+        end
+
+        it 'returns false' do
+          expect(@payment_details.save).to be false
+        end
+      end
+
+      context 'when payment attributes updated successfully' do
+        it 'returns true' do
+          expect(@payment_details.save).to be true
+        end
+      end
+    end
+  end
+end

data/spec/models/spree/bank_spec.rb

@@ -0,0 +1,19 @@
+require 'spec_helper'
+
+describe Spree::Bank, type: :model do
+  it { is_expected.to validate_presence_of :name }
+  it { is_expected.to validate_presence_of :account_no }
+  it { is_expected.to validate_uniqueness_of(:account_no).scoped_to(:name) }
+
+  describe ".active" do
+    before(:each) do
+      @active_bank1 = Spree::Bank.create! name: 'bank1', :account_no => '98765'
+      @active_bank2 = Spree::Bank.create! name: 'bank2', :account_no => '98765'
+      @bank3 = Spree::Bank.create! name: 'bank3', :account_no => '98765', active: false
+    end
+
+    it "returns active banks" do
+      expect(Spree::Bank.active).to match([@active_bank1, @active_bank2])
+    end
+  end
+end

data/spec/models/spree/payment_method/bank_transfer_spec.rb

@@ -0,0 +1,114 @@
+require 'spec_helper'
+
+describe Spree::PaymentMethod::BankTransfer do
+  before(:each) do
+    @order = Spree::Order.new
+    @payment_method = Spree::PaymentMethod::BankTransfer.create! name: "Bank Transfer", active: true
+    @payment = Spree::Payment.new amount: 0.0
+    @payment.order = @order
+    @payment.payment_method = @payment_method
+    @payment.save!
+  end
+
+  describe "#actions" do
+    it "returns actions" do
+      expect(@payment_method.actions).to eq(["capture", "void"])
+    end
+  end
+
+  describe "#can_capture?" do
+    context "when payment state is pending or checkout" do
+      before(:each) do
+        @payment.state = 'checkout'
+        @payment.save!
+      end
+
+      it "returns true" do
+        expect(@payment_method.can_capture?(@payment)).to be true
+      end
+    end
+
+    context "when payment state is pending" do
+      before(:each) do
+        @payment.state = 'pending'
+        @payment.save!
+      end
+
+      it "returns true" do
+        expect(@payment_method.can_capture?(@payment)).to be true
+      end
+
+    end
+
+    context "when payment state is not pending or checkout" do
+      before(:each) do
+        @payment.state = 'void'
+        @payment.save!
+      end
+
+      it "returns false" do
+        expect(@payment_method.can_capture?(@payment)).to be false
+      end
+    end
+  end
+
+  describe "#can_void?" do
+    context "when payment state is not void" do
+      before(:each) do
+        @payment.state = 'pending'
+        @payment.save!
+      end
+
+      it "returns true" do
+        expect(@payment_method.can_void?(@payment)).to be true
+      end
+    end
+
+    context "when payment state is void" do
+      before(:each) do
+        @payment.update_column(:state, 'void')
+      end
+
+      it "returns false" do
+        expect(@payment_method.can_void?(@payment)).to be false
+      end
+    end
+  end
+
+  describe "#capture" do
+    it "creates a new active merchant billing response" do
+      expect(ActiveMerchant::Billing::Response).to receive(:new).with(true, "", {}, {})
+      @payment_method.capture
+    end
+    it "returns active merchant billing response" do
+      expect(@payment_method.capture).to be_a(ActiveMerchant::Billing::Response)
+    end
+  end
+
+  describe "#void" do
+    it "creates a new active merchant billing response" do
+      expect(ActiveMerchant::Billing::Response).to receive(:new).with(true, "", {}, {})
+      @payment_method.void
+    end
+    it "returns active merchant billing response" do
+      expect(@payment_method.void).to be_a(ActiveMerchant::Billing::Response)
+    end
+  end
+
+  describe "#source_required?" do
+    it "returns false" do
+      expect(@payment_method.source_required?).to be false
+    end
+  end
+
+  describe "#credit" do
+    it "creates a new active merchant billing response" do
+      expect(ActiveMerchant::Billing::Response).to receive(:new).with(true, "", {}, {})
+      @payment_method.credit
+    end
+    it "returns active merchant billing response" do
+      expect(@payment_method.credit).to be_a(ActiveMerchant::Billing::Response)
+    end
+  end
+
+end

data/spec/models/spree/payment_spec.rb

@@ -0,0 +1,81 @@
+require 'spec_helper'
+
+describe Spree::Payment, type: :model do
+  context 'when validate_bank_details' do
+    before do
+      subject.validate_bank_details = true
+    end
+
+    it { is_expected.to validate_presence_of(:bank_name) }
+    it { is_expected.to validate_presence_of(:account_no) }
+    it { is_expected.to validate_presence_of(:transaction_reference_no) }
+    it { is_expected.to validate_presence_of(:deposited_on) }
+  end
+
+  context 'when validate_bank_details not true' do
+    it { is_expected.not_to validate_presence_of(:bank_name) }
+    it { is_expected.not_to validate_presence_of(:account_no) }
+    it { is_expected.not_to validate_presence_of(:transaction_reference_no) }
+  end
+
+  describe ".from_bank_transfer" do
+    before do
+      check_payment_method = Spree::PaymentMethod::Check.new
+      check_payment_method.name = "Check Payment Method"
+      check_payment_method.save!
+
+      bank_transfer_payment_method = Spree::PaymentMethod::BankTransfer.new
+      bank_transfer_payment_method.name = "Bank Transfer"
+      bank_transfer_payment_method.save!
+
+      @order = Spree::Order.new
+      @order.save!
+
+      @payment1 = Spree::Payment.new
+      @payment1.order_id = @order.id
+      @payment1.payment_method_id = check_payment_method.id
+      @payment1.save!
+
+      @payment2 = Spree::Payment.new
+      @payment2.order_id = @order.id
+      @payment2.payment_method_id = check_payment_method.id
+      @payment2.save!
+
+      @bank_transfer_payment1 = Spree::Payment.new
+      @bank_transfer_payment1.order_id = @order.id
+      @bank_transfer_payment1.payment_method_id = bank_transfer_payment_method.id
+      @bank_transfer_payment1.save!
+
+      @bank_transfer_payment2 = Spree::Payment.new
+      @bank_transfer_payment2.order_id = @order.id
+      @bank_transfer_payment2.payment_method_id = bank_transfer_payment_method.id
+      @bank_transfer_payment2.save!
+    end
+
+    it "returns payments with payment method as bank_transfer" do
+      expect(Spree::Payment.from_bank_transfer).to match_array([@bank_transfer_payment1, @bank_transfer_payment2])
+    end
+  end
+
+  describe "#details_submitted?" do
+    before do
+      @payment = Spree::Payment.new
+    end
+
+    context 'when transaction_reference_no present' do
+      before do
+        @payment.transaction_reference_no = 'transaction_reference_no'
+      end
+
+      it 'is true' do
+        expect(@payment.details_submitted?).to be true
+      end
+    end
+
+    context 'when transaction_reference_no not present' do
+      it 'is false' do
+        expect(@payment.details_submitted?).to be false
+      end
+    end
+  end
+end

data/spec/models/spree/user_spec.rb

@@ -0,0 +1,5 @@
+require 'spec_helper'
+
+describe Spree::User, type: :model do
+  it { is_expected.to have_many(:payments).through(:orders) }
+end

data/spec/spec_helper.rb

@@ -0,0 +1,98 @@
+# Run Coverage report
+require 'simplecov'
+SimpleCov.start do
+  add_group 'Controllers', 'app/controllers'
+  add_group 'Helpers', 'app/helpers'
+  add_group 'Mailers', 'app/mailers'
+  add_group 'Models', 'app/models'
+  add_group 'Views', 'app/views'
+  add_group 'Libraries', 'lib'
+end
+
+# Configure Rails Environment
+ENV['RAILS_ENV'] = 'test'
+
+begin
+  require File.expand_path('../dummy/config/environment', __FILE__)
+rescue LoadError
+  puts 'Could not load dummy application. Please ensure you have run `bundle exec rake test_app`'
+  exit
+end
+
+require 'rspec/rails'
+require 'shoulda/matchers'
+require 'database_cleaner'
+require 'ffaker'
+
+# Requires supporting ruby files with custom matchers and macros, etc,
+# in spec/support/ and its subdirectories.
+Dir[File.join(File.dirname(__FILE__), 'support/**/*.rb')].each { |f| require f }
+
+# Requires factories defined in spree_core
+# require 'spree/testing_support/factories'
+require 'spree/testing_support/controller_requests'
+require 'spree/testing_support/authorization_helpers'
+require 'spree/testing_support/url_helpers'
+
+# Requires factories defined in lib/spree_favorite_products/factories.rb
+# require 'spree_favorite_products/factories'
+
+Shoulda::Matchers.configure do |config|
+  config.integrate do |with|
+    with.test_framework :rspec
+    with.library :rails
+  end
+end
+
+RSpec.configure do |config|
+  # config.include FactoryGirl::Syntax::Methods
+
+  # == URL Helpers
+  #
+  # Allows access to Spree's routes in specs:
+  #
+  # visit spree.admin_path
+  # current_path.should eql(spree.products_path)
+  config.include Spree::TestingSupport::UrlHelpers
+
+  # == Mock Framework
+  #
+  # If you prefer to use mocha, flexmock or RR, uncomment the appropriate line:
+  #
+  # config.mock_with :mocha
+  # config.mock_with :flexmock
+  # config.mock_with :rr
+  config.mock_with :rspec
+  config.color = true
+
+  # Remove this line if you're not using ActiveRecord or ActiveRecord fixtures
+  config.fixture_path = "#{::Rails.root}/spec/fixtures"
+
+  # Capybara javascript drivers require transactional fixtures set to false, and we use DatabaseCleaner
+  # to cleanup after each test instead.  Without transactional fixtures set to false the records created
+  # to setup a test will be unavailable to the browser, which runs under a seperate server instance.
+  config.use_transactional_fixtures = false
+
+  # Ensure Suite is set to use transactions for speed.
+  config.before :suite do
+    DatabaseCleaner.strategy = :transaction
+    DatabaseCleaner.clean_with :truncation
+  end
+
+  # Before each spec check if it is a Javascript test and switch between using database transactions or not where necessary.
+  config.before :each do |example|
+    DatabaseCleaner.strategy = example.metadata[:js] ? :truncation : :transaction
+    DatabaseCleaner.start
+  end
+
+  # After each spec clean the database.
+  config.after :each do
+    DatabaseCleaner.clean
+  end
+
+  config.fail_fast = ENV['FAIL_FAST'] || false
+
+  config.include Spree::TestingSupport::ControllerRequests, type: :controller
+
+  config.infer_spec_type_from_file_location!
+end