ba 0.0.8 → 0.0.9

data/ba.gemspec

@@ -6,8 +6,8 @@ require 'ba/version'
 Gem::Specification.new do |spec|
   spec.name          = "ba"
   spec.version       = Ba::VERSION
-  spec.authors       = ["Li Ellis Gallardo"]
-  spec.email         = ["lellisga@gmail.com"]
+  spec.authors       = ["Li Ellis Gallardo", "Jean Pierre Guarin"]
+  spec.email         = ["lellisga@gmail.com", "escribimepues@gmail.com"]
   spec.description   = %q{BankBalance Gem is used to check your bank account balance}
   spec.summary       = %q{Checking your bank account is now much faster}
   spec.homepage      = ""

data/lib/ba/banks/bancolombia.rb

@@ -1,38 +1,30 @@
+require 'ba/helpers/bancolombia_helper'
+
 module Ba::Banks
   class Bancolombia < Thor
+    include Ba::Helpers::BancolombiaHelper
 
     desc "balance optional: [username] [password]", "Returns the Bancolombia account balance"
     def balance(username = nil , password = nil)
       go_to_root
       process_username_authentication(username)
       process_password_authentication(password)
-      page = go_to_authentication_path
-      process_questions(page) if need_to_answer_banks_questions?(page)
-      balancePage = agent.get("/olb/BeginInitializeActionFromCM?from=pageTabs")
-      balance = balancePage.search(".contentTotalNegrita").last.children.text
-      puts "Your actual balance is: $#{balance}"
+      process_questions if need_to_answer_banks_questions?
+      puts "Your actual balance is: $#{get_balance}"
     end
 
     private
 
-    def go_to_authentication_path
-      agent.get("https://bancolombia.olb.todo1.com/olb/Authentication")
-    end
-
-    def need_to_answer_banks_questions?(page)
-      !get_question_form(page).nil?
-    end
-
-    def get_question_form(page)
-      @question_form ||= page.form_with(name: "checkChallQuestForm")
+    def get_balance
+      get_balance_page.search(".contentTotalNegrita").last.children.text
     end
 
     def process_password_authentication(password)
-      passwordPageHtml = get_password_path.body
+      passwordPageHtml = password_path_body
       ##Insert \r for correct regex on password scripts
       passwordPageHtml.gsub!(/document.getElementById/, "\r\n\t document.getElementById")
       enc_password = ""
-      password = password || ask("Password: ")
+      password = password || get_password
       password.to_s.split('').each do |n|
         passwordPageHtml.match(/\'td_#{n}\'\)\.addEventListener\(\'click\'\,\sfunction\(\)\{\S*\(\"(.*)\"\)\;\}/)
         enc_password << $1
@@ -53,47 +45,20 @@ module Ba::Banks
     end
 
     def process_username_authentication(username)
-      form = get_login_path.form_with(name: "authenticationForm") do |f|
-        f.userId = username || ask("Username: ")
-      end
-
+      form = login_path_form(username)
       form.click_button
     end
- 
-    def go_to_root
-      agent.get "https://bancolombia.olb.todo1.com/olb/Init"
-    end
 
-    def get_login_path
-      agent.get "https://bancolombia.olb.todo1.com/olb/Login"
-    end
-
-    def get_password_path
-      @password_path ||= agent.get("https://bancolombia.olb.todo1.com/olb/GetUserProfile")
-    end
-  
-    def process_questions(page)
+    def process_questions
       puts "The answer for the following questions will not be saved"
-      first_question = first_question(page)
-      second_question = second_question(page)
+      first_question = first_question
+      second_question = second_question
 
-      form = get_question_form(page) do |f|
+      form = get_question_form do |f|
         f.userAnswer1 = first_question
         f.userAnswer2 = secound_question
       end
       agent.submit(form)
     end
-
-    def first_question(page)
-      ask(page.search("#luserAnswer1").text.strip)
-    end
-
-    def second_question(page)
-      ask(page.search("#luserAnswer2").text.strip)
-    end
-
-    def agent
-      @agent ||= Mechanize.new
-    end
   end
 end

data/lib/ba/helpers/bancolombia_helper.rb

@@ -0,0 +1,64 @@
+module Ba
+  module Helpers
+    module BancolombiaHelper
+      private
+      def go_to_authentication_path
+        @auth_path ||= agent.get("https://bancolombia.olb.todo1.com/olb/Authentication")
+      end
+
+      def need_to_answer_banks_questions?
+        !get_question_form.nil?
+      end
+
+      def get_question_form
+        @question_form ||= go_to_authentication_path.form_with(name: "checkChallQuestForm")
+      end
+
+      def go_to_root
+        agent.get "https://bancolombia.olb.todo1.com/olb/Init"
+      end
+
+      def login_path
+        agent.get "https://bancolombia.olb.todo1.com/olb/Login"
+      end
+
+      def login_path_form(username)
+        login_path.form_with(name: "authenticationForm") do |f|
+          f.userId = username || get_username
+        end
+      end
+
+      def get_password_path
+        @password_path ||= agent.get("https://bancolombia.olb.todo1.com/olb/GetUserProfile")
+      end
+
+      def password_path_body
+        get_password_path.body
+      end
+
+      def get_username
+        ask("Username: ")
+      end
+
+      def get_password
+        ask("Password: ") { |q| q.echo = false }
+      end
+
+      def first_question
+        ask(go_to_authentication_path.search("#luserAnswer1").text.strip)
+      end
+
+      def second_question(page)
+        ask(go_to_authentication_path.search("#luserAnswer2").text.strip)
+      end
+
+      def get_balance_page
+        balancePage = agent.get("/olb/BeginInitializeActionFromCM?from=pageTabs")
+      end
+
+      def agent
+        @agent ||= Mechanize.new
+      end
+    end
+  end
+end

data/lib/ba/version.rb

@@ -1,3 +1,3 @@
 module Ba
-  VERSION = "0.0.8"
+  VERSION = "0.0.9"
 end

data/spec/lib/ba/cli_spec.rb

@@ -17,7 +17,7 @@ describe Ba::CLI do
 
   describe "#version" do
     it "returns the current application version" do
-      STDOUT.should_receive(:puts).with ("0.0.8")
+      STDOUT.should_receive(:puts).with ("0.0.9")
       subject.version
     end
   end

metadata

@@ -1,15 +1,16 @@
 --- !ruby/object:Gem::Specification
 name: ba
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
   prerelease: 
 platform: ruby
 authors:
 - Li Ellis Gallardo
+- Jean Pierre Guarin
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-03-30 00:00:00.000000000 Z
+date: 2013-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -142,6 +143,7 @@ dependencies:
 description: BankBalance Gem is used to check your bank account balance
 email:
 - lellisga@gmail.com
+- escribimepues@gmail.com
 executables:
 - ba
 extensions: []
@@ -162,6 +164,7 @@ files:
 - lib/ba/banks/bank.sample.rb
 - lib/ba/banks/payoneer.rb
 - lib/ba/cli.rb
+- lib/ba/helpers/bancolombia_helper.rb
 - lib/ba/version.rb
 - spec/lib/ba/cli_spec.rb
 - spec/lib/ba/version_spec.rb