azure-core 0.1.13 → 0.1.14

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 28eb15120a2cc99f76064d85594a4126e014ff83be784b7ee8b6c7bc1dcaed0c
-  data.tar.gz: 6ae6620c660aa76e47841fb01d3a7089c044fd404feebc187568c6bfc1d0980d
+  metadata.gz: 0ecaa67ebbb25aea7d1135114553af7386b637bd9cca5a45ef43e23620abb56f
+  data.tar.gz: c502f5b8da53214842f6eee44afbb230b7b4ce142c96f9d81ec68a9e49deb495
 SHA512:
-  metadata.gz: d182d7cb1c220bfb20dac275166c1d948b25ef6ca5a914c7b450829dc04ca2d90a7b2dec7814bd458d5eed76408ac3b659a919e8653058ce5076f8674caa73c2
-  data.tar.gz: 7e3f948e02cf99a942e1bb5199a1020b5b09c821a7683dd58da2221f46dadec6f9acd627ab212b6c140e2c9b020fd6a17d820ec7375277183f920638e8028ac2
+  metadata.gz: 0e3e38ca1dcca9e79a8e0f1ef2a80606941434370c5a9604b72221ba53f9ca4e6d697b26faea3ddb83caef25031b985f3b273eced299c4f6499cf0d7820549d1
+  data.tar.gz: 1737a87e679bcd1a7351e0e0c9c67fc0e22258fb9bb77f678d7974ff7701aeef3cc5c2b7e399c264d8584215e9b5744de175550f36a45a8a46be7b8052c2fb91

data/ChangeLog.md

@@ -1,3 +1,8 @@
+# 2017.12.28 - azure-core gem @version 0.1.14
+* Added `reason_phrase` as an alternative for HTTP error description if no error details is found in response body 
+* Fixed a bug of re-throwing previously stored response error when it retries. [#51](https://github.com/Azure/azure-ruby-asm-core/issues/51)
+* Fixed a bug that retries exceed the limit after many requests fail. [#57](https://github.com/Azure/azure-ruby-asm-core/issues/57)
+
 # 2017.11.10 - azure-core gem @version 0.1.13
 * Added the call options in the retry data.
 * Added the support for retrying a request with a different URL.

data/lib/azure/core/http/http_error.rb

@@ -72,6 +72,8 @@ module Azure
           @uri = http_response.uri
           @status_code = http_response.status_code
           parse_response
+          # Use reason phrase as the description if description is empty
+          @description = http_response.reason_phrase if (@description.nil? || @description.empty?) && http_response.reason_phrase
           super("#{type} (#{status_code}): #{description}")
         end
 

data/lib/azure/core/http/http_response.rb

@@ -19,7 +19,6 @@ module Azure
     module Http
       # A small proxy to clean up the API of Net::HTTPResponse.
       class HttpResponse
-
         # Public: Initialize a new response.
         #
         # http_response - A Net::HTTPResponse.
@@ -44,6 +43,13 @@ module Azure
           @http_response.status
         end
 
+        # Public: Get the response reason phrase.
+        #
+        # Returns a String.
+        def reason_phrase
+          @http_response.reason_phrase
+        end
+
         # Public: Check if this response was successful. A request is considered
         # successful if the response is in the 200 - 399 range.
         #

data/lib/azure/core/http/retry_policy.rb

@@ -37,21 +37,25 @@ module Azure
         # _next - HttpFilter. The next filter in the pipeline
         def call(req, _next)
           response = nil
+          retry_data = @retry_data.dup
           begin
             # URI could change in the retry, e.g. secondary endpoint
-            unless @retry_data[:uri].nil?
-              req.uri = @retry_data[:uri]
+            unless retry_data[:uri].nil?
+              req.uri = retry_data[:uri]
             end
+
+            retry_data[:error] = nil
             response = _next.call
           rescue
-            @retry_data[:error] = $!
-          end while should_retry?(response, @retry_data)
+            retry_data[:error] = $!
+          end while should_retry?(response, retry_data)
+          
           # Assign the error when HTTP error is not thrown from the previous filter
-          @retry_data[:error] = response.error if response && !response.success?
-          if @retry_data.has_key?(:error)
-            raise @retry_data[:error]
-          else
+          retry_data[:error] = response.error if response && !response.success?
+          if retry_data[:error].nil?
             response
+          else
+            raise retry_data[:error]
           end
         end
 
@@ -77,4 +81,4 @@ module Azure
       end
     end
   end
-end
+end

data/lib/azure/core/version.rb

@@ -18,7 +18,7 @@ module Azure
     class Version
       MAJOR = 0 unless defined? MAJOR
       MINOR = 1 unless defined? MINOR
-      UPDATE = 13 unless defined? UPDATE
+      UPDATE = 14 unless defined? UPDATE
       PRE = nil unless defined? PRE
 
       class << self

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: azure-core
 version: !ruby/object:Gem::Version
-  version: 0.1.13
+  version: 0.1.14
 platform: ruby
 authors:
 - Microsoft Corporation
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-14 00:00:00.000000000 Z
+date: 2017-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -209,7 +209,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.2
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: Core library to be consumed by Ruby SDK gems